Commit graph

406 commits

Author SHA1 Message Date
phpnut
3c5c99423d merging changes from source:whiteboard/sandbox/phpnut/pre_0.9.2 in revisions [343] and [344]
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@345 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-10 07:49:30 +00:00
phpnut
6460f6e83f Merging changes from revisions [337] [338] [339] [340] [341]
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@342 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-10 05:08:19 +00:00
phpnut
7791b8dcfe Added validation check to areaTag() with patch from Ticket #54 submitted by bgmccollum.
Note this will not work with the current Blog tutorial.
https://trac.cakephp.org/wiki/Cake/Tutorials/BlogPosts
We will update the tutorial with this change in next release.
Closes #54
Thanks bgmccollum

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@335 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-06 03:03:54 +00:00
phpnut
24c9c0478f Fixed broken method in the HtmlHelper.
HtmlHelper::inputTag() had the $size param removed.
HtmlHelper::inputTag() had variable with underscore in name still.
param in method was camelCased


git-svn-id: https://svn.cakephp.org/repo/trunk/cake@328 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 21:00:43 +00:00
phpnut
8a2592ba3c fixed mime type setting on file
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@327 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 11:47:03 +00:00
brego
4f1a6b89f8 Modified some docblocks - please, somebody make a better solution than using modelName/fieldName as param. See you in 20 days.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@326 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 11:21:45 +00:00
phpnut
b2ad3739b5 more cleanup for API docs to be generated without errors
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@324 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 04:30:45 +00:00
phpnut
6ca443861d more cleanup for API docs to be generated without errors
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@323 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 04:16:20 +00:00
phpnut
3500ca272c more cleanup for API docs to be generated without errors
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@322 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 02:59:39 +00:00
phpnut
c9d9cb8287 cleaning up the file headers so API docs can be created properly
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@320 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 02:07:21 +00:00
phpnut
c89c757806 fixed typo in cake url
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@319 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:52:07 +00:00
phpnut
e3146e2e79 removed duplicate NeatArray class in file
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@318 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:49:09 +00:00
phpnut
e1a8b0335d renaming nstring.php neat_string.php
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@317 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:46:23 +00:00
phpnut
ff7bc90df9 renaming Nstring to NeatString
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@316 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:45:26 +00:00
phpnut
e48bc34562 renaming narray.php back to neat_array.php
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@315 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:40:33 +00:00
phpnut
1b30f48607 renaming narray back to NeatArray
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@314 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:39:06 +00:00
phpnut
0dd8b55d82 remove debug code left in before commit
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@313 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:30:52 +00:00
phpnut
9c84f9c981 check added for models being set
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@312 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:26:50 +00:00
phpnut
3b3a47e3f0 going thru trunk and cleaning up the file headers so API docs can be created properly
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@311 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:24:13 +00:00
brego
ec53963d40 Some PHP5 notices.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@310 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:23:27 +00:00
phpnut
8a806d7fc5 going thru trunk and cleaning up the file headers so API docs can be created properly
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@309 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 01:07:14 +00:00
brego
a6e5922d71 Changes in the description of the default page.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@308 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 00:53:17 +00:00
phpnut
e1f48bf379 going thru trunk and cleaning up the file headers so API docs can be created properly
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@307 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-04 00:48:04 +00:00
phpnut
a558a1e922 Form validation working now.
Be sure to review the changes made to the blog tutorial.
Some specific changes to note we pass model names in inputTag().
was: $html->inputTag('title', 40)
now: $html->inputTag('post/title', 40)

Also in the tagErrorMsg() we pass the model name.
was: $html->tagErrorMsg('body', 'Body is required.')
now: $html->tagErrorMsg('post/body', 'Body is required.') 
https://trac.cakephp.org/wiki/Cake/Tutorials/BlogPosts


git-svn-id: https://svn.cakephp.org/repo/trunk/cake@306 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-03 23:54:50 +00:00
phpnut
1178a63db4 Added flash method back to the controller for now
Will work on moving this out again at a later time


git-svn-id: https://svn.cakephp.org/repo/trunk/cake@305 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-03 19:09:39 +00:00
phpnut
301731fb1a Corrected the use of View class instance.
It looks like the way you where coding it was to be used as a Singleton.
In Controller::render() I am setting all View() attributed by pass reference.
I do not think it will effect other parts of the system.

You can see why I did this by uncommenting the print_r function in View::render().
Reload url in browser.
Then in Controller::render() remove the & from:
$view->autoRender =& $this->autoRender;
This is the only one that seems to cause array to print.

This may also caused in the Router::connect().
Look at this if you get time.
I noticed that each setting in the conf/routes.php file calls outer::connect();
Tee profiler show this happening 6 times on current install from trunk
Router::parse() is called 2 times.


We really need to get some good unit test in place.

Also speeded things up a little.

Profiler test:

Before changes on default install from trunk

Between:
Total Request Time: 13013.4 Milliseconds
Total Request Time: 13065.84 Milliseconds
28 files

After changes
Between:
Total Request Time: 10230.99 Milliseconds
Total Request Time: 10511.59 Milliseconds
27 files



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@304 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-03 07:07:47 +00:00
phpnut
cad49da852 fixed mime type setting on file
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@303 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-03 00:15:26 +00:00
phpnut
5db836ec59 merging css changes from Kamil's sandbox that I forgot
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@302 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-02 23:20:03 +00:00
phpnut
75cce3f107 Merging changes from Kamil's sandbox.
Beginning refactoring to bring current trunk to a usable release.


git-svn-id: https://svn.cakephp.org/repo/trunk/cake@301 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-02 22:49:04 +00:00
phpnut
4089572c5f testing new server and maillist 4th
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@299 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-02 04:44:46 +00:00
phpnut
cbe816dc10 testing new server and maillist 3
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@298 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-02 04:39:29 +00:00
phpnut
108db1fbcd testing new server and maillist
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@297 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-02 04:36:18 +00:00
phpnut
8f4ac9bfd9 testing new server and maillist
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@296 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-02 03:53:01 +00:00
phpnut
63f20284dc testing new server
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@295 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-07-02 03:46:57 +00:00
phpnut
fe6c343771 setting proper mime-type on files in the trunk
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@294 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-30 02:32:36 +00:00
phpnut
01c846dc19 setting proper mime-type on files in the trunk
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@293 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-30 02:11:23 +00:00
phpnut
55da45ec77 setting proper mime-type on files in the trunk
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@292 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-30 02:09:47 +00:00
phpnut
217e177abf Put check in index.php if $_GET['url'] is favicon.ico do nothing.
This will stop errors of a AppController? trying to be created 

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@291 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-26 17:54:49 +00:00
brego
975e0b3755 Changed error methods, and a typo in one error file.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@277 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-23 20:45:22 +00:00
brego
d9a7885d0f DboFactory comes back, no more global variables. To get actual instance of db, call DboFactory::getInstance(). You can also change the running object with DboFactory::setConfig('configname').
Data validation is still dead, gonna spend a night on that one.



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@276 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-23 20:41:10 +00:00
brego
63fe9906cc Tests are passing now, but DboFactory needs to get out at some point.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@275 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-23 14:13:50 +00:00
brego
ba139f10bb Database should work now. I have introduced some semi-singelton magic in dbo. DboFactory is no longer needed. This is not tested properly, and tests will most likely fail! Follow up soon.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@274 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-23 13:59:02 +00:00
brego
9206b074d3 I do not want any uppercase letters in filenames. I want CamelCase actions that link to under_scored files.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@273 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-23 08:32:04 +00:00
phpnut
77d259860c used unset to remove $this->db from the printed object
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@272 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-23 00:27:37 +00:00
pies
27d16ff9b9 I'm sorry, I've reversed two changes. I've changed the error views names to underscored, and I've changed the default DEBUG to 1.
The first one is for consistency (no UppperCase filenames, please), the second is because while I'm no enemy of application security, the application has to be safe _after_ it's written, not before. And to easily write an application, the developer should have the DEBUG mode set to 1 or 2.

Other than that, I think it's a very good idea to put the tag generators in helpers :)

git-svn-id: https://svn.cakephp.org/repo/trunk/cake@271 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-22 23:16:26 +00:00
brego
0535607f5a Now we use DEBUG=0 as default... Also potential security hole - error pages showing database info - are only show when DEBUG>1.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@270 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-22 18:52:34 +00:00
brego
dd5f22418e Tests run properly now - need to add more of them into /libs/helpers/html.php!
Data validation should work - not tested (will do it tomorrow).



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@265 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-22 01:20:19 +00:00
brego
38ddea527e Ok, this one is very big. Firstly, I've outsourced (:]) helper methods like linkTo etc into separate files, located in /libs/helpers/*.
I am not finished with copying methods out of template.php, but it will come - also data validation would not be a problem helpers inclusion happens in the Template::_render().

Also, there was a bug with error functions (as Controller::missingView) - on linux, calling $this->render('../errors/missingController'); rsulted in an error - beacouse apparently is_file() cannot work with '..'. I added a simple fix in Template::_getViewFn.

I've also made some cleanups. Will continue to work tonight.



git-svn-id: https://svn.cakephp.org/repo/trunk/cake@264 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-21 23:44:49 +00:00
brego
63052f1d64 Checked with http://sqlite.org/lang_select.html
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@263 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-21 17:09:42 +00:00
brego
5f0e5a1c59 Some SQLite cleanups.
git-svn-id: https://svn.cakephp.org/repo/trunk/cake@262 3807eeeb-6ff5-0310-8944-8be069107fe0
2005-06-21 17:06:54 +00:00