Commit graph

202 commits

Author SHA1 Message Date
nate
b2b46c3fa4 Implementing $safe mode for RequestHandlerComponent::getClientIP(), which ignores HTTP_X_FORWARDED_FOR, fixes #5842
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7957 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:02:36 +00:00
nate
61850b1be1 Cleaning up test code formatting, adding fix for POST hash validation of checkbox lists, fixes #5903, test cases added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7951 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-23 08:13:00 +00:00
mark_story
a12fd86c54 Applied patch from 'jperras' fixes error in Auth.test.php. Fixes #5899
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7943 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 21:04:05 +00:00
nate
2c64c449bc Correcting Flash detection in RequestHandler, adding tests. Fixes #5838.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7914 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-10 13:55:58 +00:00
mariano.iglesias
f9557c7611 Fixing issue where radio elements would produce wrong hash when Security component enabled in FormHelper, fixes #5791
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7891 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 16:32:54 +00:00
AD7six
b43128c809 Ensuring that the auth component never redirects to an external link.
Tests updated to match code changes and tests added for external referer examples


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7874 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-14 09:07:22 +00:00
TommyO
5f0858e1ad Fixed errors in usage of SimpleTest for EmailComponent tests.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7865 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-11 19:52:41 +00:00
mariano.iglesias
dde4906195 Adding patch by dardosordi. Making all calls to header in SecurityComponent go through Controller. Fixing issue where invalid basic auth credentials would not trigger another login request. Added tests, fixes #5732
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7858 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-10 17:18:00 +00:00
renan.saddam
111b886570 Removed trailing whitespaces from tests.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7848 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 02:58:37 +00:00
AD7six
3f2fa6929b changing tabs for spaces in comment block indentation
Removing address and replacing with cakefoundation url


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7805 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 17:30:26 +00:00
nate
318c2b4952 Correcting SecurityComponent form hash generation when handling arrays, fixes #5588. Fixing code formatting in FormHelper test.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7794 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-29 06:55:42 +00:00
AD7six
ce0a71aef7 fixes #5603 Duplicate first parameter from the paginator with existing url args
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7777 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 22:20:03 +00:00
nate
16e2579f01 Correcting Security component to treat POST data arrays as a single field for validation purposes, fixes #5588
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7774 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 03:18:08 +00:00
renan.saddam
24949e30e0 Added tests to PagesController and removed twice call to count().
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7756 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-16 23:52:54 +00:00
phpnut
4311ba8000 Close #5534, Rename pages_controller.php to pages_controller.test.php
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7755 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-16 06:51:10 +00:00
nate
19975a2cf6 Fixing issue where startup() / shutdown() etc. were being called on components not directly attached to the controller. Only initialize() should be called on sub-components.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7745 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-15 13:07:46 +00:00
nate
1b9357f5e8 Correcting behavior of layering allow/deny calls in AuthComponent, fixes #5595, formatting fixes for RequestHandler
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7743 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-15 02:52:19 +00:00
gwoo
62d1f367db adding test cases to show #5553 is invalid, $uses is not merged when == null.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7718 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-09 17:03:44 +00:00
mark_story
136f9c4b6d Removing getAco(), getAro(), setAco(), and getAco() from AclComponent. These methods were deprecated and not removed. Refs #5561
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7716 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-09 03:35:17 +00:00
mark_story
17e2b4c054 Applying patch from 'Pixelation' fixes cross platform issues in cookie test. Closes #5559
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7715 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-09 02:35:33 +00:00
nate
300dbc5e91 Correcting how parameters and default values are merged in Controller::paginate(), fixes #5503
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7688 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-02 00:46:26 +00:00
mark_story
915a1e119d Adding test to Auth.test to cover logged in user being denied on an action when there is no HTTP_REFERER set. Refs #5507.
Fixed tests that break when Routing.admin is not set.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7687 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-02 00:18:47 +00:00
TommyO
3da0451907 Added basic mb_encode_mimeheader() to Multibyte class.
Modified EmailComponent to take advantage of multibyte support. fixes #5448
Modified EmailComponent to fix newline issues in long subject lines when using mail send method. fixes #5049

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7685 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-01 18:36:38 +00:00
nate
4b8acf4647 Adding 'type' key to both sets of query calls in Controller::paginate(), fixes #5441
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7680 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-29 21:19:37 +00:00
mark_story
b6f9e1e537 Correcting scaffold view file implementation. Was incorrectly using separate add and edit templates. Changes bring scaffold templates more inline with bake templates.
Tests added to cover use with both primary app and plugins. Refs #4862 and closes #5484 

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7671 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-27 03:48:23 +00:00
renan.saddam
a628dfa028 Added test to prove #5482 (Trying to get property of non-object).
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7665 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-26 01:37:17 +00:00
nate
eb7fb6d7e3 Re-implementing form hashing security to using string-based keying. Fixes #5262, fixes #5300
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7658 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-24 23:02:14 +00:00
mark_story
fafb01b09d Fixing modelClass when using plugin models.
Added TestPluginPost to test_app/test_plugin
Test case added.
Closes #5459

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7641 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-22 04:10:49 +00:00
nate
fc5b128d68 Refactoring Auth test, adding coverage, and enabling custom Ajax layouts (as specified by RequestHandler), fixes #5446
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7637 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-20 20:18:16 +00:00
nate
91838d6d5d Fixing bug in RequestHandler::prefers() not respecting accept order for single items, test case updated
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7634 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 19:48:22 +00:00
renan.saddam
4f5a51d79d Proving bad condition structure when Session.checkAgent equal to false. Refs #5450
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7631 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 02:57:58 +00:00
renan.saddam
f080163e8a Added test to disprove multiple calls to session start. Closes #5328
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7628 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 00:55:42 +00:00
mark_story
768e25c4fd Updating Controller::paginate(). Custom paginate() and paginateCount() methods now receive $extra params similar to find('all') and find('count') do. Allows the use of things like 'contain' with custom paginate() methods.
Test case added. Closes #5433 refs #5123.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7627 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 00:46:20 +00:00
nate
14b17fed39 Changing private methods in Security component to protected
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7611 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-16 01:39:20 +00:00
phpnut
cb487bd6e6 More optimization refactoring.
Fix cache but causing  object_map to be created and deleted on each request.
Replacing function and method calls with better performing code.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7596 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-12 05:11:34 +00:00
mark_story
c58e58a491 Adding tests for secured forms. Fixes the issues related to checkboxes in multi row forms.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7533 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-29 03:11:35 +00:00
gwoo
7fe1a03fda fixes #5331, model alias no longer overwritten
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7515 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-27 01:30:09 +00:00
gwoo
e35a215883 fixes #5307, model name being overridden by class registry for no reason, thanks to vizjerai for the helpful ticket.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7501 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-25 22:33:36 +00:00
mark_story
9895f6d39b Added check in AuthComponent::hashPasswords() to ensure that data is an array. Tests Added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7492 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-24 15:18:37 +00:00
mark_story
a59f4d0170 Adding conditional check for constant. Removes notice when running all_tests group. Closes #5281
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7478 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-19 01:34:44 +00:00
gwoo
074ede4639 adding additional case for Router::normalize() and Controller::referer() to show #5157 is invalid
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7463 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-13 18:07:52 +00:00
mark_story
3a06f840c3 Adding patch from 'dardosordi' fixes RequestHandler type detection with character set. Closes #5223
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7448 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-09 18:32:59 +00:00
TommyO
48f55a0f56 Greatly modified the way newLine characters are handled.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7437 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-05 17:02:22 +00:00
TommyO
570145d568 Added test to show (deprecated?) support of string status codes in redirect().
Fixed fail on string status codes in redirect().

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7410 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-01 11:27:53 +00:00
gwoo
b0d2451a97 removing optional instantiation of Set class. Adding toArray() to xml class and calling it from Set::reverse(); updated test cases.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7398 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-31 23:50:32 +00:00
gwoo
4a5282bcd7 closes #5172, AuthComponent login with with UUID
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7396 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-31 19:00:12 +00:00
TommyO
5dc4388fa0 Added tests for template and layout rendering. Currently fail as component doesn't wordwrap properly. May also explain #4498
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7361 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-24 13:54:39 +00:00
mark_story
cc098629a6 Added direction check to Controller::paginate(). paginate() now forces 'asc' when wrong. Added tests. Closes #5120
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7357 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-24 02:46:39 +00:00
mark_story
0b23ec64ff Modified all remaining tests to use CakeTestCase. Switched all uses() calls to App::import().
Added tests to configure.test to test importing from plugins.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7348 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-21 02:40:58 +00:00
mark_story
b2d74c8be1 Added tests to cover model validation setting errors, controller render passing error and form helper field error display. Closes #5077.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7338 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-15 02:13:14 +00:00