Commit graph

19546 commits

Author SHA1 Message Date
Mark Story
73de35c119
Merge pull request #12906 from akeiper/2.x
resolving ini_set error in php 7.2

Fixes #12678
2019-01-16 21:57:13 -05:00
mark_story
a13abcf97b Fix tests. 2019-01-16 21:53:42 -05:00
andrew.keiper
38074f72e9 adding support for PHP 5.3 by adding function_exists for session_status 2019-01-16 15:28:35 -05:00
andrew.keiper
06269b3fba resolving session issues for php 7.2 2019-01-16 10:43:04 -05:00
kicaj
bcbe5fdcf0
Fix #12885 2019-01-11 13:20:09 +01:00
ADmad
108313d74c
Merge pull request #12890 from tenkoma/2.x-enable-php-memcached-on-ci
[2.x]Enable php-memcached on TravisCI
2019-01-11 13:26:08 +05:30
Mark Story
29d49214c4
Merge pull request #12852 from bancer/2.x-code-style
Improve documentation
2018-12-28 08:52:05 -08:00
bancer
71ea302336 Improve documentation 2018-12-28 14:19:26 +01:00
Koji Tanaka
734835402b Enable php-memcached on TravisCI 2018-12-23 19:11:26 +09:00
Joseph Zidell
6ed88922a5 Fixes docblock for View::set() (#12837)
* Fixes docblock for View::set()
2018-12-23 00:09:44 +04:00
mark_story
1dc3219f22 Update version number to 2.10.14 2018-12-19 20:45:32 -05:00
Mark Story
0471d7a9ca
Merge pull request #12808 from bancer/2.x-issue-12804-generate-shell-enum
Improve support of enum data type
2018-12-16 19:30:21 -08:00
Mark Story
2efca21d0e
Merge pull request #12811 from josephzidell/patch-3
Fixes docblock for Folder constructor
2018-12-12 21:45:07 -08:00
Joseph Zidell
44f4fe27bf
Fixes docblock for Folder constructor 2018-12-12 22:45:41 -05:00
bancer
7788c60f58 Adjust enum related unit tests 2018-12-12 14:31:55 +01:00
bancer
cf6c8d511f Improve support of enum data type 2018-12-12 12:40:20 +01:00
Mark Story
acb0436cb6
Merge pull request #12736 from bancer/2.x-documentation
Improve documentation and code style
2018-12-11 12:59:19 -08:00
Val Bancer
0f2bbf505d
Adjust the check according to review comments 2018-12-11 16:36:32 +01:00
Yaser Naderi
3d224639d9 Add the functionality to accept enum MySQL datatype storing the Integer values as String (#12715)
Fix a bug in enum MySQL datatype storing Integers when enum contains
integer string values. Now strings will always be used for enum values.
2018-11-30 21:27:58 -05:00
Mark Story
fea343d67c
Merge pull request #12776 from martinstuecklschwaiger/patch-1
Fix @return value
2018-11-29 15:39:15 -05:00
Martin Stücklschwaiger
a9e20c39be
Fix @return value 2018-11-29 20:37:03 +01:00
Val Bancer
addd538526 Fix invalid condition 2018-11-18 22:48:34 +01:00
Val Bancer
c00579153b Cast var to int for comparison 2018-11-18 18:22:19 +01:00
Val Bancer
cb1d80fda1 Improve documentation 2018-11-18 17:13:11 +01:00
Val Bancer
92e9277d20 Improve code style 2018-11-18 16:24:25 +01:00
Val Bancer
509accc421 Improve code style 2018-11-17 20:55:42 +01:00
Val Bancer
261a99c0e3 Improve documentation and code style 2018-11-17 20:27:05 +01:00
Val Bancer
320cdf98ee Add undocumented properties (#12717)
See https://book.cakephp.org/2.0/en/controllers/request-response.html#accessing-request-parameters and https://api.cakephp.org/2.10/source-class-UpgradeShell.html#345-403

* Initialize $params to null
* Document more magic properties, trigger deprecated notices
* Use $controller->request->params instead $controller->params
* Remove unused variable
* Improve documentation, add type checks.
* It seems like $this->uses can also be of type false; however, parameter
$array of array_unshift() does only seem to accept array.
* Declare undeclared property
* Add extra type checks
* Adjust type check
* Improve documentation, initiate uninitialized variables.
* Improve documentation, reset variable
2018-11-15 20:41:57 -05:00
Mark Story
8573c15575
Merge pull request #12718 from bancer/php-7.3
Fix some PHP 7.3 errors
2018-11-12 21:22:51 -05:00
Val Bancer
22b0386fd5 Move failing assertion to a new test method 2018-11-11 17:53:28 +01:00
Val Bancer
d9655c94c5 Remove memcached in PHP 7.3 tests 2018-11-11 17:49:11 +01:00
Val Bancer
2f5467e8e8 Move failing assertion to a new test method 2018-11-11 17:36:10 +01:00
Val Bancer
0f0cedec14 Move failing assertion to a new test method 2018-11-11 17:18:18 +01:00
Val Bancer
d5ac7aa0b2 Simplify assertions in tests 2018-11-11 17:00:55 +01:00
Val Bancer
90ddb43632 Fix some PHP 7.3 errors 2018-11-11 16:15:55 +01:00
Mark Story
dd9601d73f
Merge pull request #12707 from tenkoma/2.x-build-php73
[2.x]PHP7.3 added to the build setting.
2018-11-06 08:28:30 -05:00
Koji Tanaka
e43db36d4e PHP7.3 added to the build setting. 2018-11-06 10:36:51 +09:00
Mark Story
b1a93df604
Merge pull request #12692 from bancer/model-exists-without-id
Add model id to all `exists()` method calls
2018-11-01 21:21:27 -04:00
bancer
58ebf6a303 Remove id property from bake template 2018-10-31 09:46:01 +01:00
Mark Story
89005c4440
Merge pull request #12680 from bancer/issue-12636-tests-constants
Replace hard coded test directory paths with constants, fixes #12636
2018-10-30 14:28:49 -04:00
bancer
d8d65027ac Adjust unit tests with id parameter for exists() method 2018-10-30 11:02:42 +01:00
bancer
3ea39d96b4 Add model id to all exists() method calls,
Related issue - https://github.com/dereuromark/cakephp-shim/issues/25
2018-10-30 10:39:16 +01:00
mark_story
33ac2b2537 Update version number to 2.10.13 2018-10-27 22:01:42 -04:00
Mark Story
a8521aa25a
Merge pull request #12679 from bancer/patch-4
Improve documentation
2018-10-26 18:48:52 +00:00
bancer
ee1b1a10df Defines TESTS also after app bootstrap.php is loaded, #12636 2018-10-26 15:52:39 +02:00
bancer
85cc215293 Improve documentation 2018-10-26 14:23:30 +02:00
bancer
53e3df20d0 Replace hard coded test directory paths with constants, fixes #12636
The `TESTS` constant definition is moved from bootstrap.php in order
to make it possible to set the constant in test.php or in the project's
bootstrap file so that CakePHP would detect tests in a different folder.
2018-10-26 13:49:53 +02:00
Val Bancer
3c9d46864e
Improve documentation
The parameter description is copied from `CakeLog::write` method.
2018-10-26 09:54:23 +02:00
Mark Story
2acad7e94d
Merge pull request #12667 from bancer/patch-3
Improve documentation
2018-10-22 21:06:32 -04:00
Val Bancer
527b9fe640
Improve documentation 2018-10-22 10:11:01 +02:00