mark_story
efc5054b65
Updating CookieComponent Test case to new Component api.
2010-08-10 23:18:40 -04:00
mark_story
a4e2f7c55f
Updating intialiize() callbacks. Moving $this->_set() int Component::__construct as all the core components did it. Updating constructors and including parent calls.
2010-08-10 23:18:40 -04:00
mark_story
052c81774c
Removing some code duplication.
2010-08-10 23:18:40 -04:00
mark_story
22fbc24560
Adding 'collectReturn' option to ObjectCollection::trigger. lets a callback collect the return of each object and return that.
...
Adding tests.
2010-08-10 23:18:40 -04:00
mark_story
54132cba79
Adding return checks, and changing mock creation.
2010-08-10 23:18:40 -04:00
mark_story
fac97738ce
Making Controller use ComponentCollection.
2010-08-10 23:18:39 -04:00
mark_story
256532b8e4
Updating Components to use Component as the parent class.
2010-08-10 23:18:39 -04:00
mark_story
bf75ab5737
Starting to update Component into a base class instead of a loader class.
2010-08-10 23:18:39 -04:00
mark_story
3666643b84
Adding ComponentCollection and a test case.
2010-08-10 23:18:39 -04:00
mark_story
337ab19145
Updating ObjectCollection::trigger() so it doesn't call __get().
...
Updating HelperCollection test which was passing by coincidence.
2010-08-10 23:18:39 -04:00
mark_story
62019888ba
Changing file headers to reflect accurate licences and versions created.
2010-08-10 23:18:39 -04:00
mark_story
c44c276fa3
Removing ModelBehavior::dispatchMethod(), replacing with call_user_func_array() as its faster and the php4 workaround is no longer needed.
2010-08-10 23:18:39 -04:00
mark_story
409b12954b
Simplifying logic and data structures used to store enabled-ness of objects in an object collection.
2010-08-10 23:18:39 -04:00
mark_story
b2250852e4
Moving BehaviorCollection into its own file.
...
Changing how behaviors are stored in the collection object. Makes it work the same as HelperCollection.
2010-08-10 23:18:39 -04:00
mark_story
fcbfb556c5
Moving loaded helpers into a protected array.
...
Adding magic methods to access the object array.
2010-08-10 23:18:39 -04:00
mark_story
c78e869be6
Removing PHP4 workarounds in BehaviorCollection.
...
Making BehaviorCollection throw exceptions instead of use cakeError.
2010-08-10 23:18:39 -04:00
mark_story
d048813af8
Adding in property copying until this branch gets merged with 2.0-request.
2010-08-10 23:18:39 -04:00
mark_story
d6362f1857
Converting spaces to tabs.
2010-08-10 23:18:38 -04:00
mark_story
6a88452072
Updating TextHelper to not use create_function(). The create_function calls leaked memory and didn't work with the new helper constructors.
2010-08-10 23:18:38 -04:00
mark_story
2d791e1ed0
TextHelper test case constructor issues fixed. There are still fails caused by create_function in the helper.
2010-08-10 23:18:38 -04:00
mark_story
3379e53be0
Updating test case to use correct methods.
...
Updating test case to run in CLI.
2010-08-10 23:18:38 -04:00
mark_story
ba8058500f
Adding test for attachedness of Helper helpers.
2010-08-10 23:18:38 -04:00
mark_story
4672cee5d3
Removing dispatchMethod from JsHelper, its not really that useful, and is good at hiding bugs in mock tests.
...
Updating test cases.
2010-08-10 23:18:38 -04:00
mark_story
0e933e8893
Updating most helper test cases to use View in their constructors.
2010-08-10 23:18:38 -04:00
mark_story
68ff2e5ce5
Adding additional tests for Helper lazy loading.
2010-08-10 23:18:38 -04:00
mark_story
fc3379767d
Moving methods around. ObjectCollection now normalizes helpers arrays. Plugin helpers now lazy load.
...
Tests updated.
2010-08-10 23:18:38 -04:00
mark_story
98982a6f7a
First attempt at lazy loading helpers done. Plugin support not complete.
2010-08-10 23:18:38 -04:00
mark_story
ab815a53ba
Helper test case is passing again.
2010-08-10 23:18:37 -04:00
mark_story
087ccabffe
Starting to modify Helper constructors.
2010-08-10 23:18:37 -04:00
mark_story
1d983e1cd4
Making MissingView and MissingLayout cake errors into exceptions.
2010-08-10 23:18:37 -04:00
mark_story
a23207791a
Modifying View to accept HelperCollection. Removing methods that are no longer needed.
2010-08-10 23:18:37 -04:00
mark_story
f8ecb10407
Adding stub callbacks so errors aren't generated.
2010-08-10 23:18:37 -04:00
mark_story
1c1c4bef80
Fixing errors that would occur when call_user_func_array() triggered failures.
2010-08-10 23:18:37 -04:00
mark_story
c15d228515
Initial integration of HelperCollection into View.
2010-08-10 23:18:37 -04:00
mark_story
16d5b2655c
Adding a way to load helpers in a disabled state. Updating tests and subclasses.
2010-08-10 23:18:37 -04:00
mark_story
d0de468ce0
Removing options that were not used in the generic application.
2010-08-10 23:18:37 -04:00
mark_story
aa61a251dc
Deprecating BehaviorCollection::attach() and BehaviorCollection::detach(). load() and unload() are more generic and make sense in other contexts.
...
Adding base trigger implementation.
Adding tests for helper triggering.
2010-08-10 23:18:37 -04:00
mark_story
9fd881cb00
Moving methods down and adding some tests.
2010-08-10 23:18:36 -04:00
mark_story
6db3dbc680
Starting to create HelperCollection which will be responsible for loading and constructing helpers.
...
Making an abstract class that will be the base of all object collections.
Adding test cases.
2010-08-10 23:18:36 -04:00
mark_story
d1028a7434
Applying patch from 'Mark Mitchell' to make cake.bat return the exit code of the called cake shell. Fixes #992
2010-08-10 23:12:55 -04:00
mark_story
da9c0da626
Changing sql_dump element so it only shows if there is no $logs variable set in the view. Overwriting it could adversely effect helper references. Fixes #998
2010-08-10 23:09:27 -04:00
mark_story
1371cefc3d
Applying patch from 'thatcode' to fix an issue where FormHelper::datetime() would not use 'default' or 'value' keys like other inputs would. This corrects an unintentional inconsistency in the methods. Test cases added. Fixes #988
2010-08-09 23:49:18 -04:00
mark_story
29ddffa2d3
Fixing regression in DboMysqlBase where describe() was no longer pulling out fieldParameters. A test case has been added to catch any future regressions. Fixes #991
2010-08-09 23:25:32 -04:00
mark_story
ccfb1d179a
Expanding test and fixing issue where the return of Folder::create() would be incorrect even though the directory was properly created. Fixes #996
2010-08-09 22:56:41 -04:00
mark_story
d6e3c318cd
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-08-04 23:59:17 -04:00
mark_story
c28ecff862
Adding a test to ensure that $here contains the correct value when supplying additionalParams (like through a requestAction). Changing how Dispatcher::__extractParams converts url params into a string, so the result is the same as a string url.
...
Removing the call to _stop() as it halts the script when a requestAction hits a cached file. Fixes #977
2010-08-04 23:44:48 -04:00
mark_story
a04fe5f81d
Making Router::reverse() strip out additional framework internal parameters that are specific to requestAction. Refs #977
2010-08-04 23:35:49 -04:00
mark_story
8119f77659
Reformatting long lines.
2010-08-04 23:18:33 -04:00
mark_story
43bf1c539a
Separating the various requestAction tests into separate test methods.
2010-08-04 23:16:26 -04:00
mark_story
22673a5348
Adding a test case for CacheHelper correctly generating filenames when $this->here includes all the named and passed args. Refs #977
2010-08-04 23:08:43 -04:00
Juan Basso
72bb229a9c
Added tests to ticket #959
2010-08-04 22:10:44 -03:00
xbuzz
f2f2987743
Fixed 'convertEntities' to links in RSS. Fixes #959
2010-08-04 22:03:44 -03:00
Dirk Brünsicke
712ca6d5b5
Fixing bug in String::insert that produces unexpected results with
...
multiple keys that start with the same substring. Fixes #984
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-03 22:38:45 -04:00
José Lorenzo Rodríguez
4a8e44b419
Adding test case for CakeResponse::mapType()
2010-08-02 19:33:09 -04:30
José Lorenzo Rodríguez
7e1426e743
Fixing doc block
2010-08-02 19:25:04 -04:30
José Lorenzo Rodríguez
e7c7008781
Changing behavior of RequestHandlerComponent::responseType(), it will return the current content type set int the response object
...
It will not return null as default as it did prior 2.0
2010-08-02 19:21:52 -04:30
José Lorenzo Rodríguez
1acbf15c00
Removing RequestHandlerComponent::_header() method
2010-08-02 19:17:43 -04:30
José Lorenzo Rodríguez
8968204cb5
Adding test method for CakeResponse::download()
2010-08-02 19:16:19 -04:30
José Lorenzo Rodríguez
cb63cd171c
Fixing typo
2010-08-02 19:12:58 -04:30
José Lorenzo Rodríguez
bbbb81e10a
Adding CakeResponse::download() method
2010-08-02 19:10:38 -04:30
José Lorenzo Rodríguez
5fb320f31d
Refactoring RequestHandler methods to use the response object
2010-08-02 19:10:01 -04:30
José Lorenzo Rodríguez
4fd032bc10
Refactoring RequestHandlerComponent::mapType() and added response object property to the component
2010-08-02 19:07:26 -04:30
José Lorenzo Rodríguez
040740c05d
Changing the order for comparisson checking on some types, when looking for a mime type
2010-08-02 19:04:53 -04:30
Juan Basso
ae2fa908c5
Dont use private attributes as tables in CakeSchema. Fixes #7
2010-08-02 00:22:46 -03:00
mark_story
3099a15f17
Removing old check for view == 'Theme'. This allows Scaffold to work well with Themed controllers. Test case added. Fixes #255
2010-08-01 22:25:29 -04:00
José Lorenzo Rodríguez
87eb1ec697
Adding the ability to add custom content types to CakeResponse
2010-08-01 14:22:02 -04:30
José Lorenzo Rodríguez
077f71aaa1
Refactoring controller rendering to use the CakeResponse object
2010-08-01 01:38:45 -04:30
Juan Basso
7e7a2c57e2
Fixing changes made in commit 522446e
to works with PHP 5.2-. Refs #974
2010-08-01 02:55:30 -03:00
José Lorenzo Rodríguez
0824348db1
Removing Controller::output property and refactoring methods to not use it. CakeResponse::body() should be used instead
2010-08-01 01:13:41 -04:30
José Lorenzo Rodríguez
1b5808420f
Removing Dispatcher::header() as it is now longer used
2010-08-01 00:49:16 -04:30
José Lorenzo Rodríguez
f9c97383e9
Refactored Controller::disableCache() to use the CakeResponse object, method was also deprecated
2010-08-01 00:16:50 -04:30
José Lorenzo Rodríguez
60f504a470
Refactored Controller::header() to use the CakeResponse object, deprecated Controller::header() and Controller::httpCodes()
2010-08-01 00:13:00 -04:30
José Lorenzo Rodríguez
9d104fee73
Refactoring Controller::redirect() to use the CakeResponse object
2010-08-01 00:10:46 -04:30
José Lorenzo Rodríguez
3ab4e09e11
Moving Controller::httpCodes() to CakeResponse
2010-08-01 00:09:09 -04:30
José Lorenzo Rodríguez
754c0776f8
Skipping response compression test when running in web tester
2010-07-31 20:59:04 -04:30
José Lorenzo Rodríguez
95bc6a7bba
Refactoring Dispatcher to use the response class when delivering assets
2010-07-31 20:50:57 -04:30
José Lorenzo Rodríguez
abafdb037b
Implementing the CakeResponse::compress() method
2010-07-31 19:30:25 -04:30
José Lorenzo Rodríguez
8780f0b33d
Implementing CakeResponse::cache()
2010-07-31 18:31:50 -04:30
José Lorenzo Rodríguez
5ba0e43aa3
Implementing CakeResponse::disableCache()
2010-07-31 17:40:49 -04:30
José Lorenzo Rodríguez
20d1e483cc
Implementing and tesing CakeResponse::send()
2010-07-31 16:58:13 -04:30
José Lorenzo Rodríguez
d1808db0df
Changing the encoding method for "charset"
2010-07-31 14:40:58 -04:30
José Lorenzo Rodríguez
2a4b30dba9
Implementing CakeResponse::header() method
2010-07-31 14:13:21 -04:30
mark_story
509a9e14e2
Fixing condition missing a model name in the TreeBehavior. Fixes #961
2010-07-31 14:29:00 -04:00
José Lorenzo Rodríguez
a2eac24ec0
Removing second parameter from CakeResponse, the response should not be magical
2010-07-31 13:10:37 -04:30
José Lorenzo Rodríguez
159ac2038e
Testing remaining implemented methods
2010-07-31 13:04:53 -04:30
mark_story
9f718de0b6
Reverting changes made in [ 60ab9800e2
]. Restoring use of isset() and $_SESSION = null. Fixes #971
2010-07-31 13:09:40 -04:00
mark_story
522446e0c2
Fixing issues where route elements could not have '-' in the parameter name because of limitations in pcre named capturing subpatterns. Tests added. Fixes #974
2010-07-31 13:03:45 -04:00
José Lorenzo Rodríguez
2c7b21b977
Completinng mime types array
2010-07-31 12:33:39 -04:30
José Lorenzo Rodríguez
f432de830c
Implementing some function in the response object, adding test case
2010-07-31 12:33:02 -04:30
mark_story
86cae09d79
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-07-31 11:59:21 -04:00
ADmad
d04b327469
Fixing test case as it was error prone. Assuming the first value of $plugins array to be 'plugin_js' was incorrect.
2010-07-31 21:08:10 +05:30
mark_story
5efddf9a41
Adding a test case for route params with hyphens. Refs #974
2010-07-31 11:23:02 -04:00
mark_story
373bebb128
Updating test suite to properly handle parent_id situations. Fixes #881
2010-07-29 22:26:30 -04:00
mark_story
ac9721d582
Wrapping long lines.
2010-07-29 22:07:45 -04:00
mark_story
2b1efafe65
Applying optimization from 'michaelc' to reduce number of strtolower() calls in AclBehavior. Fixes #972
2010-07-29 22:04:22 -04:00
mark_story
3bda2ce100
Adding tests for database imports causing duplicated db prefix. Adding a workaround for the duplicated prefix name.
...
Fixes #962
2010-07-29 22:01:12 -04:00
José Lorenzo Rodríguez Urdaneta
ffd7066fa4
Adding the CakeREquest object with initial function signatures and parameters
2010-07-29 00:54:16 -04:30
mark_story
a9bb4eefae
Fixing failing test caused by registry pollution.
...
Adding a test case to prove that unqualified column names work with postgresql. Closes #930
2010-07-29 00:06:11 -04:00
mark_story
596c751ea3
Converting spaces to tabs.
2010-07-28 23:42:36 -04:00
ADmad
6527e9269a
Fixing detection and automatic appending of extension '.js' to urls in call to HtmlHelper::script(). Closes #965
2010-07-29 02:11:00 +05:30
José Lorenzo Rodríguez Urdaneta
69ee014a60
Merge branch '2.0' into 2.0-session
2010-07-27 22:27:17 -04:30
José Lorenzo Rodríguez Urdaneta
1c8ad1d1cc
Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
2010-07-27 22:26:06 -04:30
José Lorenzo Rodríguez Urdaneta
4c71dd845e
Merge remote branch 'origin/2.0' into 2.0-request
...
Conflicts:
cake/libs/controller/components/auth.php
cake/tests/cases/libs/controller/components/auth.test.php
2010-07-27 22:02:08 -04:30
mark_story
272b327dc3
Fixing issue where $error would be set to an array.
2010-07-27 22:27:44 -04:00
mark_story
19d8c9e6bb
Removing a call to __setError() that isn't an error.
2010-07-27 22:27:44 -04:00
mark_story
8db0a19585
Refactoring duplicated logic into a method.
2010-07-27 22:27:44 -04:00
mark_story
ef586d9917
Updating test case to use autoRegenerate.
2010-07-27 22:27:43 -04:00
mark_story
f5bf4c5552
Changing config value name to more accurately represent what it does.
2010-07-27 22:27:43 -04:00
mark_story
6ff7ad68c9
Fixing some infinite loop issues in the test cases for CakeSession.
2010-07-27 22:27:43 -04:00
mark_story
b3febb483e
Fixing incorrect use of Cache::gc(). It has no parameters for now.
2010-07-27 22:27:43 -04:00
mark_story
2f1aa0a97f
Making CakeHtmlReporter dump a stack trace when an exception is caught.
2010-07-27 22:27:43 -04:00
mark_story
81f6f43193
Moving a few things around to better replicate how CakeSession behaved in 1.3. Also fixes the countdown & session id regeneration feature. Still need to write a test case for it though.
2010-07-27 22:27:43 -04:00
mark_story
d2097c514f
Fixing issue where infinite loops would occur when a session was first created.
2010-07-27 22:27:43 -04:00
mark_story
977ffa96be
Removing dead properties and methods from SessionComponent.
...
Sessions should be started as soon as the component is constructed. So there is no reason to have an active()/activate() method.
2010-07-27 22:27:43 -04:00
mark_story
574bfe6b67
Changing clear of $_SESSION to null instead of array(), makes checks later easier. Removing _checkValid call from destroy and making it run in start(), as destroy() calls start().
2010-07-27 22:27:43 -04:00
mark_story
a857e4505c
Adding files from previous commit.
2010-07-27 22:27:43 -04:00
mark_story
db5c44e386
Adding support + test cases for plugin and app/libs session handlers.
2010-07-27 22:27:42 -04:00
mark_story
5673ceb816
Updating core.php files with new session configuration.
2010-07-27 22:27:42 -04:00
mark_story
18b6668a34
Moving tests from SessionComponent to CakeSession, as that is where the features actually are. Removing Security.level/Security::inactiveMins() calculations.
2010-07-27 22:27:42 -04:00
mark_story
eb30c12560
Adding a test case for DatabaseSession::gc();
2010-07-27 22:27:13 -04:00
mark_story
28b9ed7264
Adding test cases for DatabaseSession and fixing a test case in CacheSession.
2010-07-27 22:27:13 -04:00
mark_story
7d2d2aaa4d
Adding test case stub for DatabaseSession and test case for CacheSession.
2010-07-27 22:27:13 -04:00
mark_story
951eeae817
Extracting handler location into a method.
...
Moving DatabaseSession and CacheSession into separate files. Tests to come soon.
2010-07-27 22:27:13 -04:00
mark_story
736d33647e
Adding tests for using a custom session config with CacheSession.
2010-07-27 22:27:13 -04:00
mark_story
49397c74af
Making cache config used for cache session storage configurable.
2010-07-27 22:27:13 -04:00
mark_story
f5d81e53fc
Refactoring Cache and Database session handlers into a separate class, and adding an interface for custom session handlers. Tests updated.
2010-07-27 22:27:13 -04:00
mark_story
a8b05c2fbc
Adding a check for '' and failure. When trying to Cache '', FileEngine will return false. This shouldn't trigger an error inside Cache.
2010-07-27 22:27:12 -04:00
mark_story
339fa29502
Updating CakeSession test case and fixing a few issues in the default settings.
2010-07-27 22:27:12 -04:00
mark_story
b247559e9e
Starting to implement new session configuration setup. Test case updated.
2010-07-27 22:27:12 -04:00
predominant
f05a13a451
Added test for empty key write on CakeSession
2010-07-27 22:27:12 -04:00
predominant
7501fcf46d
Add test for empty read() calls on CakeSession
2010-07-27 22:27:12 -04:00
predominant
623998f550
Added test for empty session check.
2010-07-27 22:27:12 -04:00
predominant
ca65689dd9
Change _setHost() on CakeSession to accept parameter to ease testing, add test cases for host setting, and port stripping.
2010-07-27 22:27:12 -04:00
predominant
a63474a54d
Add test for path containing question, and fix assignment of CakeSession::path
2010-07-27 22:27:12 -04:00
predominant
f5565895e9
Removing __regenerateId method, and moving code to renew().
2010-07-27 22:27:11 -04:00
predominant
afede663c0
Reducing redundant code for CakeSession.
2010-07-27 22:27:11 -04:00
predominant
725bfc3e12
Create _setPath() and _setHost to simplify startup.
2010-07-27 22:27:11 -04:00
mark_story
4b65ebd64f
Making SessionComponent mostly a wrapper for CakeSession.
...
Adding CakeSession::begin() to replace SessionComponent::__start().
Tests updated. Tests related to autoStart were removed/skipped as that feature isn't really around right now.
2010-07-27 22:27:11 -04:00
mark_story
e660416545
Making CakeSession::write() able to write hashes of data.
2010-07-27 22:26:03 -04:00
mark_story
59ea917c23
Fixing a few failing tests, and splitting a big test into two smaller ones.
2010-07-27 22:26:03 -04:00
predominant
4e9d76e806
Fixing session write use issue.
2010-07-27 22:26:03 -04:00
predominant
dd3e0facd2
Trim down CakeSession::started()
2010-07-27 22:26:03 -04:00
predominant
db97df31cd
Adding static to regen
2010-07-27 22:26:03 -04:00
predominant
1dd02b77b2
Adding static to destroy()
2010-07-27 22:26:03 -04:00
mark_story
f47ee0d29a
Making CakeSession destory() make started() not return true. Fixing tests that tried to modify session config while a session was active.
2010-07-27 22:26:03 -04:00
mark_story
daab018777
Removing code for PHP < 5.1 which is not supported by 2.0
2010-07-27 22:26:03 -04:00
mark_story
1938e57cbc
Making userAgent check test pass.
...
Reformatting code inside valid().
2010-07-27 22:26:02 -04:00
predominant
b60b077056
Fix __startSession being called after method rename to _startSession.
2010-07-27 22:26:02 -04:00
predominant
34a6808d5d
Move CakeSession database configuration to separate method, cutting down init().
2010-07-27 22:26:02 -04:00
predominant
632d1f13ae
Minor refactor for CakeSession.
2010-07-27 22:26:02 -04:00