Commit graph

1189 commits

Author SHA1 Message Date
mark_story
5270721ade Remove bonus intval()
It caused issues when getting numeric keys that
exceeded PHP_INT_MAX.

Fixes #2897
2012-05-22 22:33:46 -04:00
Ceeram
7dbd6bc3a2 make sure model data is moved to alias, even when first key in data is assoc model
add extra tests for saveAll and validate first
ensure db values dont get reset to default values
2012-05-19 14:41:16 -04:30
mark_story
c6258fa68c HTML escape context variables.
When creating HTML or js errors the context should be
escaped, as it is very possible that the context vars will contain
HTML.

Clean up some internals in Debugger::outputError().  There were
a few duplicate data structures, and $$ variables.

Fixes #2884
2012-05-16 21:07:45 -04:00
mark_story
0faaedfff5 Split up tests.
Fix API usage in tests.
2012-05-14 21:32:31 -04:00
Rachman Chavik
15a74722b3 use LOGS constant 2012-05-11 08:33:53 +07:00
Rachman Chavik
73c66e2df4 fixing method signature in test models 2012-05-10 19:47:10 +07:00
Rachman Chavik
2598d17670 check extension before passing to addTestFile() 2012-05-10 19:06:04 +07:00
Rachman Chavik
5b67534acc fix incorrect __construct params for mock object 2012-05-10 13:35:01 +07:00
Jose Lorenzo Rodriguez
0fb025f6dc Fixing error with validateMany and validateAssociated not saving values altered in beforeValidate callbacks 2012-05-09 23:51:27 -04:30
Mark Story
a4bbfc0cea Merge pull request #638 from jellehenkens/2.1-router-querystring-bugfix
Router::queryString() order inconsistency and bug with appending to a string instead of array
2012-05-09 17:11:19 -07:00
Jelle Henkens
07735069fa Adding support for a trailing & or & in the existing queryString 2012-05-09 22:32:57 +01:00
mark_story
597913aa5b Fix test cases with postgres.
Setting id values confuses postgres' sequences.
2012-05-07 22:10:17 -04:00
mark_story
fbba3621b5 Fix additional issues with saveAll().
Fixes #2857
2012-05-07 21:36:28 -04:00
Jelle Henkens
45a96ae588 Fixing order inconsistency in queryString and bug with string based existing querystring 2012-05-07 21:48:58 +01:00
mark_story
a1e06b9c8b Fix error in Sqlite tests. 2012-05-06 23:39:02 -04:00
mark_story
6c5255ac73 Fix saving translate records with saveAll()
Also fixes issues saving translated data with validation
disabled.  By enabling data backup in beforeSave() and beforeValidate()
the existing behavior is preserved, and the current issue is fixed.

Fixes #2857
2012-05-06 22:48:15 -04:00
Frank de Graaf
7bb56e7fc3 Fixed HTTP status codes for non-redirects which were breaking AuthComponent. 2012-05-04 16:58:51 +02:00
mark_story
4ab6d37abb Update assertions.
Use assertXmlStringEqualsXmlString() it gives
better error reporting.  Also update string concat
into heredocs.
2012-05-03 21:00:52 -04:00
mark_story
73b0345ff4 Fix issue with non-sequential array keys.
Xml::fromArray() should not cause errors with non-sequential
numeric array keys.

Fixes #2580
2012-05-03 20:35:01 -04:00
mark_story
004bc5b6e7 Fix overwriting of GET/POST
ControllerTestCase was overwriting GET and POST and not
restoring them at the end of testAction.

Fixes #2841
2012-04-30 20:36:19 -04:00
mark_story
f6b33db02c Add test for accept header.
Refs #2828
2012-04-29 14:48:45 -04:00
José Lorenzo Rodríguez
d80b1ef7f6 Merge pull request #630 from shama/patch-typos
Typos in Test Cases
2012-04-27 07:42:40 -07:00
Kyle Robinson Young
eb059d3fa6 Fix typos in test cases 2012-04-26 20:14:52 -07:00
Kyle Robinson Young
b8488b8dfe Update 1.x @link in docblocks 2012-04-26 19:49:18 -07:00
mark_story
6bb8b22cdb Fix space indented code. 2012-04-26 22:27:34 -04:00
mark_story
eefb2e81fa Fix issue where prefixes mid action would be truncated.
If a prefix occured mid action name it would be removed,
corrupting the action name.

Fixes #2831
2012-04-24 20:48:23 -04:00
Rachman Chavik
2f87992d15 File::create() does not need to change umask
umask(0) causes all files to be created with 666 permission.
After input from jrbasso and AD7six, this was found to be an
additional code to support caching using file engine.

FileEngine has since moved to SplFile since 2.x and thus umask
juggling is not required anymore.

Refs: f9f1c4df5
Cherrypicked from 2.2 branch.
2012-04-24 23:35:32 +07:00
mark_story
9e3fe633bb Remove double encoding on addresses in EmailComponent.
CakeEmail should be handling all the encoding now, duplicating it is
silly.

Fixes #2797
2012-04-23 21:41:31 -04:00
mark_story
13468937cc Fix singularization of databases.
Fixes #2822
2012-04-23 21:01:03 -04:00
Till Claassen
3f7e2f536f CakeTestSuite::addTestDirectory() ignore non-php
CakeTestSuite::addTestDirectory() and addTestDirectoryRecursive()
now ignore any files that do not end in .php

This avoids any stray non-php files being parsed, especially
tilde-style backup files that end in .php~

Improves #2031

Signed-off-by: mark_story <mark@mark-story.com>
2012-04-23 12:15:29 -04:00
mark_story
7846254c63 Remove more copy + paste in tests. 2012-04-21 21:31:24 -04:00
mark_story
88465cbb47 Remove copy + paste in tests. 2012-04-21 21:17:28 -04:00
Ceeram
f0bd7386e2 created, modified and updated fields now use static timestamp in testcases 2012-04-21 17:38:49 +02:00
mark_story
c15259f49c Remove useless backups.
PHPUnit does this for us.
Fix formatting and whitespace.
2012-04-17 21:57:07 -04:00
mark_story
ca2c122c62 Make flaky tests less flaky.
Off by one second errors are common here.
2012-04-17 20:51:52 -04:00
mark_story
94e83fa81c Fix invisible buttons.
Fixes #2802
2012-04-17 20:46:19 -04:00
Cauan Cabral
18aa5a040f Include test to .0 and .00 decimals 2012-04-17 20:22:32 -04:00
Cauan Cabral
28bd6880df Make Validation::decimal accept integers
Fix #2800
Force locale of ValidationTests with en_US to ensure decimal dot separator
2012-04-17 20:22:22 -04:00
Ceeram
388b20dd9d fix error in previous commit 2012-04-17 00:22:13 +02:00
Ceeram
a84597784d avoid warning when saveAll() data has empty hasMany data, fixes #2792 2012-04-16 22:46:58 +02:00
mark_story
f818caf47c Remove duplicate code / skipped tests. 2012-04-14 12:20:05 -04:00
Mark Story
6167529d4d Merge pull request #605 from shama/patch-datasource-test
Add checks for startQuote & endQuote.

Fixes #2769
2012-04-14 08:08:05 -07:00
mark_story
5bb8c3a942 Fix code standards. 2012-04-14 10:49:25 -04:00
mark_story
0f2100767b Add failing test for #2661 2012-04-14 10:24:20 -04:00
Renan Gonçalves
b0b36e8fba Defining default values for CakeRequest, those params are present anywhere except when there isn't a Route match. 2012-04-13 15:58:45 +02:00
Kyle Robinson Young
6cf73c763c Tests for a generic custom datasource
Default startQuote and endQuote to avoid error with non-database datasources
2012-04-11 10:08:45 -07:00
Kyle Robinson Young
8bbe250bec Correct method descriptions and remove unused property 2012-04-11 07:50:54 -07:00
mark_story
45e3414d49 Add test for query string encoding.
Closes #2768
2012-04-10 20:08:12 -04:00
mark_story
81208d1fa7 Fix failing test. 2012-04-09 21:46:38 -04:00
mark_story
67743c8079 Fix missing Html escaping on string urls for assets.
Add HTML escaping for asset paths provided as strings.
Split existing tests up.

Fixes #2766
2012-04-09 21:20:11 -04:00