mark_story
15ca2400bc
Fixing issue in DboSource::name() where special characters in column names would not be correctly quoted.
...
Tests added.
Fixes #1264
2010-11-25 06:52:23 -05:00
mark_story
7d158e8d1f
Fixing Set::sort() for arrays with out of sequence, or missing keys.
...
Tests added.
Fixes #1312
2010-11-25 06:39:08 -05:00
mark_story
4214242efd
Adding test for correct merge order for $uses.
...
Fixing incorrect merge ordering for $uses, so it matches historical behaviour.
Fixes #1309
2010-11-24 22:44:12 -05:00
mark_story
0e29567f8d
Adding an array cast to fix issues where users could modify cookie
...
values causing iteration errors. Fixes #1309
2010-11-24 22:09:08 -05:00
mark_story
d5fb0b25cb
Fixing issue where Date header would be missing from Emails sent by
...
EmailComponent.
Adding user configurable field for date.
Test cases added. Fixes #1304
2010-11-22 22:08:46 -05:00
mark_story
79aafda698
Removing use of serialize() for locked fields. This removes any
...
possible exploit related to serialize()/unserialize(). Instead values
are passed as | delimited.
2010-11-21 00:09:45 -05:00
mark_story
ae7855692d
Removing unserialize() as its dangerous. Instead using | delimited fields for locked fields. This totally avoids issues with serialize(). Removing str_rot13, as its only child proof.
...
Tests updated.
2010-11-20 23:42:54 -05:00
mark_story
ef3cb0e50c
Adding tests for Set::normalize()
2010-11-20 22:46:55 -05:00
mark_story
6d9b000aee
Changing how mergeVars are handled, so the difference of app/current is used as a base.
...
Also fixing issues where passing settings to helpers in AppController could result in them not being correctly merged.
Thanks to hashmich for the partial patch.
Fixes #1183
2010-11-20 22:34:24 -05:00
mark_story
e0a8ffe8a3
Applying patch from 'jmccaffrey' to fix issues on windows where virtual
...
machine paths would not be correctly handled. Fixes #1254
2010-11-20 13:26:30 -05:00
mark_story
76a80c262e
Fixing failing test caused by name() being able to quote things better now.
2010-11-13 12:04:22 -05:00
Mariano Iglesias
a1467822fb
Fixing wrong assertion in test for CakeTestCase::testAction. Fixing testAction issue that would always include layout
2010-11-10 23:03:38 -04:30
mark_story
e431e86aa4
Fixing issue found by Felix Wilhelm(flxm) where users could send potentially dangerous or corrupted serialized objects to SecurityComponent, potentially allowing manipulation of file map caches. Test case added.
2010-11-07 20:53:04 -05:00
ADmad
eb76ab95f2
Fixed issue where Model::saveAll() would incorrectly commit a transaction which was not started in that function call itself.
2010-11-06 09:33:50 +05:30
mark_story
d56b812181
Fixing issue where an array to string conversion error could occur if you had multiple values for a model's primary key and you created a matching form. Tests added.
...
Fixes #1257
2010-11-04 21:08:40 -04:00
ADmad
81ce6f40b9
Added test cases showing usage of 'full_base' key for url generation. Refs #1256
2010-11-04 17:59:23 +05:30
mark_story
d1403b0da8
Changing NumberHelper::currency() to format < 1euro based on the suggestions from 'Joel Haasnoot'. Instead of 99c you will get €0,99.
...
Test cases updated. Fixes #1253
2010-11-02 21:56:24 -04:00
mark_story
f29bb562cb
Adding a test for saving blank fields on a model. Closes #1243 .
2010-10-29 00:13:09 -04:00
mark_story
f5fd069583
Applying patch from 'Justas Butkus' to fix CakeSchema::compare()
...
Fixes issues with comparing null == '' and adds a new protected method to handle null aware array difference generation.
Tests added.
Fixes #1206
2010-10-27 23:03:31 -04:00
mark_story
3639f52117
Adding a test for containable modifying return. Refs #1219
2010-10-26 21:39:48 -04:00
SKAhack
9f2d33aa88
meta characters don't match on regex string
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-24 21:42:11 -04:00
mark_story
4496a0a0bb
Reformatting code to use tabs.
...
Fixing issue with float comparison.
Fixes #219
2010-10-24 19:43:41 -04:00
C. James Callaway
b8f0dda964
Updating to match ticket, using radians() SQL function.
2010-10-24 19:39:18 -04:00
C. James Callaway
a429287c19
Adding testcase for ticket #219
2010-10-24 19:38:23 -04:00
Graham Weldon
d3e0ddbb0e
Update copyright years.
2010-10-25 07:58:22 +11:00
mark_story
54854c493b
Changing output buffering, as ajaxtest was making output and breaking tests in group contexts.
2010-10-24 00:39:46 -04:00
mark_story
155bfe6293
Fixing failing test caused by setting an expiry value outside of the PECL extensions limits.
2010-10-24 00:05:27 -04:00
mark_story
7c296211ef
Making generating schema for connections with prefixes work correctly. The prefix needs to be removed so that when tables are created or updated they do not get the prefix added twice.
...
Moving tests around. Fixes #1180
2010-10-20 23:17:04 -04:00
mark_story
498417203b
Making DboSource::fields() use cacheMethod() so it respects $cacheMethods.
...
Test added.
Fixes #1211
2010-10-20 22:28:31 -04:00
mark_story
077d1c5ad5
Applying patch from 'hashmich' to fix issues with slideUp and slideDown effects in prototype engine.
...
Tests updated.
Fixes #1213
2010-10-20 22:07:53 -04:00
mark_story
1c25e627ad
Applying patch from 'Mark Mitchell' fixes issues with sending Email via smtp. Which were incorrect based on previous patches given for ticket #1100 .
...
Fixes #1205 , Fixes #1204
2010-10-18 22:06:12 -04:00
mark_story
c35ef7dbab
Making class attribute bubble down into FormHelper::__selectOption().
...
Fixes issue where you couldn't change the classname of checkbox options.
Fixes #1202
2010-10-16 13:32:04 -04:00
mark_story
67874bd906
Fixing issue where defining a pattern for :action would create an optional route parameter that wouldn't respect its pattern.
...
Added the default action value only when a pattern isn't defined.
Added tests to CakeRoute and Router to cover this case.
Fixes #1197
2010-10-14 21:54:44 -04:00
mark_story
6529e0e2b4
Making optiongroup elements follow the escape parameter.
...
Tests added.
Fixes #1191
2010-10-13 21:59:53 -04:00
mark_story
3f2109f3c3
Applying patch from 'dragonfly' to fix issue where FormHelper would always append an argument even if one was supplied.
...
Test Added
Fixes #1155
2010-10-13 21:36:05 -04:00
mark_story
a0a84d1a8d
Changing pattern used to read digest auth data. Allows emails to be used as usernames.
...
This also adds the realm to the return value of SecurityComponent::parseDigestAuth(). Fixes #1181
2010-10-11 22:35:47 -04:00
ADmad
62161203f2
Fixed issue where FormHelper::radio() and FormHelper::select() with option "multiple"=>"checkbox" would generate tag with invalid "id" attribute if a value was non alphanumeric
2010-10-10 23:16:48 +05:30
Phally
0d86302404
Fixed issue with Set::extract() where conditions containing a space and a slash would fail. Fixes #1185
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-08 23:28:23 -04:00
Phally
0e5613f63d
Fixed Set::extract() where single numeric keys (everything not 0) were skipped. Fixes #1175
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-07 20:33:31 -04:00
teknoid
503b7cf5d7
Adding slug option to avoid auto-slug of tags. Test included. Addresses #284
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-02 19:16:07 -04:00
mark_story
5c27abd35f
Applying patch from 'hashmich' to make jQueryEngine not override the success callback. This allows you to provide a success callback and still get the html insertion when used with the update key.
...
Tests updated.
Fixes #1158
2010-10-01 22:43:46 -04:00
mark_story
5e26d282a1
Fixing connection specific schema generation
...
Fixing missing table errors when reading schema for specific connections.
Tests updated to check that tables not on a connection are never touched. Fixes #1106
2010-09-30 23:22:57 -04:00
mark_story
c573fd0432
Fixing issue where a beforeDelete() could trigger a table truncation.
...
Moving the exists check below beforeDelete() and behavior->beforeDelete() so any records deleted in the callbacks will not exist when db->delete() is called. Test updated. Fixes #250
2010-09-29 23:31:41 -04:00
evilbloodydemon
38e128b597
test for #250
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-09-29 23:06:47 -04:00
mark_story
b08aba8e86
Adding a missing rollback when validation on an associated record fails, and validate = first. Fixes #1147
2010-09-28 23:37:28 -04:00
mark_story
0761edecfb
Making the cake:nocache stripping more relaxed so that if either condition to enable caching is on, tags will be stripped. Tests added. Fixes #1148
2010-09-28 23:03:56 -04:00
mark_story
9992cff96c
Adding another test for #250 .
2010-09-28 22:26:54 -04:00
mark_story
06ed3a96a7
Moving the plugin import tests to a separate method.
...
Adding tests for importing a pluginAppHelper.
Closes #1111
2010-09-26 12:30:12 -04:00
mark_story
0990728385
Adding tests for non latin domains to MemcacheEngine. Closes #1143
2010-09-26 12:04:06 -04:00
mark_story
995a14c140
Making MemcacheEngine understand IPv6 addresses. Fixes #1143
2010-09-26 01:11:19 -04:00
mark_story
6d7f2d37ab
Fixing issue where fields with the exact same name as the model would result in incorrect name attributes. Tests added. Fixes #1123
2010-09-26 00:46:51 -04:00
mark_story
7e4f9c4953
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-09-21 21:14:23 -04:00
mark_story
ce1115b0b4
Adding I18n::clear() to remove most of the private variable access from the i18n test case.
...
Changing casing of classname in test case.
2010-09-21 21:13:45 -04:00
0x20h
2eac24c31a
removed destructor, caching is done on file loading (fixes and improves #1085 )
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-09-21 21:03:36 -04:00
0x20h
ba8280423d
* changed indexing order of the i18n __domains array to allow caching by domain+language ( fixes #1085 )
...
* adapted testcase
Signed-off-by: mark_story <mark@mark-story.com>
2010-09-21 21:03:29 -04:00
mark_story
729a45703b
Fixing issue where table names with spaces would not be quoted by name(). Fixes #1121
2010-09-21 20:34:27 -04:00
ADmad
b9a7b27ba1
Fixing regression cased by commit d5ffdc288d
causing ajax layout to be not auto set for ajax request for html pages. Refs #1099
2010-09-21 00:25:17 +05:30
mark_story
c3d5c3fd00
Fixing issue in Cache where duration = 0 would not read/write from cache. This prevented the creation of non expiring cache entries in APC and memcache.
...
Adding a return false to FileEngine as it was omitted in the past.
Fixes #1120
2010-09-19 12:20:07 -04:00
mark_story
e91fa68f8e
Making the set() functions use + instead of array_merge() so that numeric indices are properly preserved across multiple method calls. Fixes #1105
2010-09-18 00:13:03 -04:00
mark_story
d113d7d612
Removing dead code from DboSource::fields()
...
Updating fields() to use implode, so complex virtual fields are better handled. Fixes #1079
2010-09-18 00:04:36 -04:00
mark_story
738d92cc3e
Fixing failing tests caused by fixture data changes.
2010-09-18 00:03:22 -04:00
mark_story
5a8648cca0
Fixing issue in DboSource::_matchRecords() where unqualified conditions would result in 1=1 conditions. Fixing incorrect test case. Fixes #930
2010-09-16 00:17:09 -04:00
mark_story
d7bb7699e2
Applying patch from '0x20h' to fix issue where domain translation files would be mixed together causing duplicate data in the various cache files. There should now be one cache per domain + language. Fixes #1085
2010-09-13 22:17:05 -04:00
mark_story
85ccd1f096
Fixing skipIf calls so email test runs in a reasonable time frame when there is no local smtp server.
2010-09-12 13:06:49 -04:00
mark_story
e9d194822d
Adding more tests for SMTP address formatting. Fixes #1100
2010-09-12 11:48:09 -04:00
mark_story
55ecfe0292
Fixing stupid typo.
2010-09-11 15:48:48 -04:00
mark_story
7c79583caa
Updating expiry time to be within tolerances of memcached.
2010-09-11 15:44:52 -04:00
mark_story
d5bde3fe7a
Adding a call to session_destroy() to remove the session data. This fixes the issue where data would not be totally destroyed. Fixes #1089
2010-09-08 22:05:53 -04:00
Mark Story
aad72871a0
Adding more tests for virtualFields and complex expressions. Closes #1079
2010-09-07 00:32:44 -04:00
Mark Story
e15069769d
Adding tests for #1079 and fixing some formatting.
2010-09-07 00:09:06 -04:00
Mark Story
c60edfae6d
Fixing issue where errors containing code = 500, were not actually converted to error500 when debug = 0. Making missingConnection, and missingTable into error500 errors.
2010-09-06 16:46:41 -04:00
Mark Story
82fffe6914
Fixing issue where FormHelper::select() with multiple = checkbox and a custom name attribute would not work correctly. Fixes #1078
2010-09-05 01:28:13 -04:00
Mark Story
dbdd17f51a
Adding test cases from 'euromark' and updating how email addresses are parsed so they are slightly more conformant to RFC 5322. Fixes #1066
2010-09-02 11:16:10 -04:00
mark_story
08d6c19ab6
Adding test for themes in app/webroot dir. Closes #1061
2010-08-31 21:21:05 -04:00
mark_story
b02e213958
Adding test case from '0x20h'. Fixing issue where atomic = false, validate = first and saveAll() saving many rows could return an incorrect value. Fixes #1050
2010-08-26 22:21:39 -04:00
mark_story
123873b4d8
Updating DboSource test to account for formatting of floats done in mysql/postgresql.
2010-08-26 21:20:13 -04:00
dogmatic69
95168cee6e
casting the find as an array to avoid errors with array_values() fixes #1041 and 4 failing tests (3 previous)
...
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-26 20:32:48 -04:00
mark_story
465c24f903
Adding a test case for TextHelper::toList(). Closes #1043
2010-08-26 20:30:30 -04:00
mark_story
903b260638
Changing spaces to tabs.
2010-08-26 20:29:03 -04:00
mark_story
ece055eefe
Adding object type check to prevent fatal errors caused by view being used like a model object. Tests added. Fixes #1039
2010-08-23 21:39:23 -04:00
mark_story
5446a062ee
Fixing issue where whitelist would not be used for validation. Test case added. Fixes #1037
2010-08-21 22:48:59 -04:00
mark_story
eb96d8acfb
Adding tests to dbo_postgres for localized floats. Refs #1029
2010-08-21 00:39:45 -04:00
mark_story
afc05c1e05
Adding test cases for using localized floats with mysql. Also added a generic model test case. Refs #1029
2010-08-21 00:19:30 -04:00
mark_story
2abf34d93e
Fixing issue where an app that was in a directory that had the same name
...
as a controller would end up failing to find view cache files.
Adding test for app name in controller name failure to create cache
Fixes #1025
Conflicts:
cake/libs/view/helpers/cache.php
2010-08-16 22:11:25 -04:00
mark_story
686b9c2c8b
Fixing issues in alterSchema in DboMysql and DboPostgres, where fields would be appended to each table being altered.
...
Also fixed an issue in DboPostgres where the generated alter statements would contain too many ;.
Test cases added. Fixes #1023
2010-08-15 22:17:02 -04:00
mark_story
1b41a987fa
Adding test cases and fixing inflection issues with bases. Tests added. Fixes #1012
2010-08-12 20:26:11 -04:00
mark_story
1371cefc3d
Applying patch from 'thatcode' to fix an issue where FormHelper::datetime() would not use 'default' or 'value' keys like other inputs would. This corrects an unintentional inconsistency in the methods. Test cases added. Fixes #988
2010-08-09 23:49:18 -04:00
mark_story
29ddffa2d3
Fixing regression in DboMysqlBase where describe() was no longer pulling out fieldParameters. A test case has been added to catch any future regressions. Fixes #991
2010-08-09 23:25:32 -04:00
mark_story
ccfb1d179a
Expanding test and fixing issue where the return of Folder::create() would be incorrect even though the directory was properly created. Fixes #996
2010-08-09 22:56:41 -04:00
mark_story
d6e3c318cd
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-08-04 23:59:17 -04:00
mark_story
a04fe5f81d
Making Router::reverse() strip out additional framework internal parameters that are specific to requestAction. Refs #977
2010-08-04 23:35:49 -04:00
mark_story
8119f77659
Reformatting long lines.
2010-08-04 23:18:33 -04:00
mark_story
43bf1c539a
Separating the various requestAction tests into separate test methods.
2010-08-04 23:16:26 -04:00
mark_story
22673a5348
Adding a test case for CacheHelper correctly generating filenames when $this->here includes all the named and passed args. Refs #977
2010-08-04 23:08:43 -04:00
Juan Basso
72bb229a9c
Added tests to ticket #959
2010-08-04 22:10:44 -03:00
Dirk Brünsicke
712ca6d5b5
Fixing bug in String::insert that produces unexpected results with
...
multiple keys that start with the same substring. Fixes #984
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-03 22:38:45 -04:00
mark_story
3099a15f17
Removing old check for view == 'Theme'. This allows Scaffold to work well with Themed controllers. Test case added. Fixes #255
2010-08-01 22:25:29 -04:00
mark_story
522446e0c2
Fixing issues where route elements could not have '-' in the parameter name because of limitations in pcre named capturing subpatterns. Tests added. Fixes #974
2010-07-31 13:03:45 -04:00
mark_story
86cae09d79
Merge branch '1.3' of github.com:cakephp/cakephp into 1.3
2010-07-31 11:59:21 -04:00
ADmad
d04b327469
Fixing test case as it was error prone. Assuming the first value of $plugins array to be 'plugin_js' was incorrect.
2010-07-31 21:08:10 +05:30