Commit graph

8970 commits

Author SHA1 Message Date
Marko Marković
c55a57927c Typos in documentation: reguired -> required 2010-12-01 08:12:25 +11:00
José Lorenzo Rodríguez
2e9283abd9 Fixing fixture loading for sqlite 2010-11-29 20:52:54 -04:30
José Lorenzo Rodríguez
0d93520e0a Fixing test case for sqlite 2010-11-29 20:52:32 -04:30
Juan Basso
ffaec10a7c Fixing the result of App::import() when name of class have slash. 2010-11-29 22:37:08 -02:00
José Lorenzo Rodríguez
a791687784 Adding try catch for pdo exception on DboSource::_execute 2010-11-28 23:50:18 -04:30
José Lorenzo Rodríguez
130fe603a7 Skipping test incompatiblw with mysql 2010-11-28 23:34:20 -04:30
José Lorenzo Rodríguez
592dda92de Fixing test to make it pass using DboSqlite 2010-11-28 22:48:34 -04:30
José Lorenzo Rodríguez
372123f15a Moving common method put from DboMysl into DboSource, this makes more sqlite tests pass 2010-11-28 22:45:56 -04:30
Mark Story
40585a34e8 Adding support for userPath in IniAcl.
Test case added.
Fixes #1291
2010-11-28 21:22:10 -05:00
Mark Story
2495b3cd4c Trimming whitespace and adding a file header. 2010-11-28 21:11:18 -05:00
Mark Story
3ddff879b1 Converting IniAcl to use IniFile, this removes one of the classes responsibilities. 2010-11-28 21:06:22 -05:00
Mark Story
35611d50c3 Fleshing out IniFile a bit more. 2010-11-28 21:05:32 -05:00
Mark Story
071cd9b477 Adding very naive implementation of an ini file parser. 2010-11-28 21:05:32 -05:00
mark_story
9d3b3a72ce Starting to extract Ini file parsing out of IniAcl as it breaks single responsibility, and ini file parsing should be generic enough to be reused.
Adding a test case.
2010-11-28 21:05:32 -05:00
mark_story
cc18c15e61 Fixing coding standards. 2010-11-28 21:05:32 -05:00
Mark Story
43c184b2d2 Fixing issues with CLI test runner where the error handler would continue to be cakephp's instead of PHPUnit's. 2010-11-28 21:05:12 -05:00
Mark Story
1f72e504d5 Fixing incorrect imports that caused test case to fail in CLI when run by itself. 2010-11-28 20:49:42 -05:00
Mark Story
91b5a5265e Making ConsoleErrorHandler be invoked with the correct error reporting level. 2010-11-28 20:44:28 -05:00
mark_story
284a8db3f4 Moving error handling classes into a separate directory.
Moving error handling test cases into a directory that matches the one in libs.
Updating imports.
2010-11-28 12:27:51 -05:00
mark_story
e40ee2576b Minor optimization in h()
Minor optimizations in FormHelper, as calls to ArrayAccess methods are avoided now.
2010-11-28 00:33:01 -05:00
mark_story
7bfdbff377 Adding more documentation to core.php. 2010-11-27 19:39:55 -05:00
mark_story
da98791e14 Adding some more documentation about precedence of configuration. 2010-11-27 19:37:25 -05:00
Jeremy Harris
1411e9495e Fixed failing test due to missing CakeRequest class 2010-11-27 12:47:19 -08:00
Jeremy Harris
8492f2055b Added tests for object collection 2010-11-27 12:09:43 -08:00
mark_story
f08fa52a60 Syncing skel/config/core.php 2010-11-27 14:36:34 -05:00
mark_story
345779772d Fixing issue where an AppController::appError would cause errors as $method was not a real method. 2010-11-27 14:35:36 -05:00
mark_story
d3f0d25c03 Removing error masking in ErrorHandler, instead correctly calling set_error_handler() works better. 2010-11-27 14:32:43 -05:00
José Lorenzo Rodríguez
492bcea85f mproving decribing process of tables in sqlite 2010-11-27 00:37:13 -04:30
José Lorenzo Rodríguez
0ff01330c4 Making dates deconstruction in model more consistent for different datasources 2010-11-27 00:13:04 -04:30
José Lorenzo Rodríguez
41ee035d28 Starting to bring sqlite dbo up to date 2010-11-26 23:46:34 -04:30
José Lorenzo Rodríguez
b6731dd9ad Merge remote branch 'origin/2.0' into feature/2.0/pdo
Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysqli.test.php
2010-11-26 20:26:41 -04:30
ADmad
1186bc56f1 Adding EmailCompnent::lineFeed property toallow overriding the default line feed string when using mail() function to send mail. Closes #1320 2010-11-27 02:11:43 +05:30
ADmad
70ae66edf7 Fixing test cases for EmailComponent 2010-11-27 01:21:19 +05:30
mark_story
c717ff2e72 Adding logging of errors when debug = 0 for console applications. Fixes #1311 2010-11-25 23:16:27 -05:00
mark_story
0d5ed014d1 Removing constants and configuration settings that don't are repeated or deprecated/not used. 2010-11-25 23:16:03 -05:00
mark_story
9b4f7a1a15 More documentation. 2010-11-25 22:51:31 -05:00
mark_story
f3feb1575c Removing support for AppError. It doesn't make sense to have hardcoded class references when there is better configuration available.
Updating doc blocks for exceptions.
Updating core.php file.
2010-11-25 22:51:30 -05:00
mark_story
1cffea379f More documentation. 2010-11-25 22:51:30 -05:00
mark_story
04d3feb6c0 Unknown errors cannot be mapped as they generate another error. Having a default case doesn't make much sense here.
Adding additional coverage to ErrorHandler.
2010-11-25 22:51:30 -05:00
mark_story
845edf38e1 Removing core classes using App::import() with an array(). This usage incurs an additional call to App::import().
Removing Set from core class imports, as Set is required as part of the framework bootstrapping.
2010-11-25 22:51:30 -05:00
mark_story
e88cdc8a01 Adding more documentation. 2010-11-25 22:51:30 -05:00
mark_story
55623ace92 Adding deprecated error level to the map switch. 2010-11-25 22:51:30 -05:00
mark_story
f2f3f13c75 Adding exception logging configuration setting. Allows uncaught exceptions to be logged.
Implementing logging, and adding a test case.
2010-11-25 22:51:30 -05:00
mark_story
af4447d55d Removing Configure::write('log'). This feature is now part of Error configuration.
Removing log check from Debugger::showError().  This method only show's errors, it shouldn't be logging them as well.
2010-11-25 22:51:30 -05:00
mark_story
14a6368b39 Adding missed isset() check
Making ConsoleErrorHandler handle both errors, and exceptions in CLI.
2010-11-25 22:51:30 -05:00
mark_story
74bf455c49 Updating ConsoleErrorHandler to match ErrorHandler.
Updating test cases for ConsoleErrorHandler.
2010-11-25 22:51:30 -05:00
mark_story
3bc708ba19 Adding the new group to AllTests.
Removing ErrorHandler test from AllLibs.
2010-11-25 22:51:30 -05:00
mark_story
fac222e2cd Removing classes that were not used in the ErrorHandler test case. Adding a new test suite for error classes. 2010-11-25 22:51:29 -05:00
mark_story
e2c8e20afa Pulling exception page rendering out into a separate class, ErrorHandler felt very large and confusing, as it had a few too many jobs. 2010-11-25 22:51:29 -05:00
mark_story
8a35b76cc2 Fixing error caused by removed method. 2010-11-25 22:51:29 -05:00
mark_story
722b1a02ba Adding Debugger output to ErrorHandler::handleError, and adding tracing for log writes.
Renaming Debugger::_output() -> Debugger::outputError() and making it public instead of protected.
2010-11-25 22:51:29 -05:00
mark_story
f373fc19d1 Removing logError from CakeLog, it will be moved into ErrorHandler::handleError() 2010-11-25 22:51:29 -05:00
mark_story
6c2c4f91df Removing dead tests and updating ones to reflect changes in how Configure works. 2010-11-25 22:51:29 -05:00
mark_story
a621ac1ba3 Adding level to the core.php file, this lets you choose which error levels you are interested in for your application.
Removing hardcoded error_reporting levels in Configure.
2010-11-25 22:51:29 -05:00
mark_story
a8ba73da62 Removing wrapper method that didn't contribute anything.
Adding doc blocks for the sequence bootstrapping takes.
2010-11-25 22:51:29 -05:00
mark_story
b371de8cf4 Moving error handler configuration setting after application bootstrap is done, this will allow classes to be imported using the cache. 2010-11-25 22:51:29 -05:00
mark_story
e68a1a094e Moving error and exception handler configuration into Configure, as settings. You can use Error.handler and Exception.handler to define the error and exception handlers for your application. 2010-11-25 22:51:28 -05:00
mark_story
4960b6e7bf Changing method names on CakeLog and Debugger to better reflect what they do. Updating test cases. 2010-11-25 22:51:28 -05:00
mark_story
da3bf1c747 Adding ErrorHandler::handleError for consolidating core error handling out of CakeLog and Debugger. 2010-11-25 22:51:28 -05:00
mark_story
6d5cf96d1c Making instance method use the instance, and not call itself statically. 2010-11-25 22:51:28 -05:00
mark_story
15ca2400bc Fixing issue in DboSource::name() where special characters in column names would not be correctly quoted.
Tests added.
Fixes #1264
2010-11-25 06:52:23 -05:00
mark_story
7d158e8d1f Fixing Set::sort() for arrays with out of sequence, or missing keys.
Tests added.
Fixes #1312
2010-11-25 06:39:08 -05:00
mark_story
4214242efd Adding test for correct merge order for $uses.
Fixing incorrect merge ordering for $uses, so it matches historical behaviour.
Fixes #1309
2010-11-24 22:44:12 -05:00
mark_story
0e29567f8d Adding an array cast to fix issues where users could modify cookie
values causing iteration errors.  Fixes #1309
2010-11-24 22:09:08 -05:00
ADmad
b567de977e Fixed bug where Dispatcher::getUrl() returned incorrect URL if $base appeared in a $uri besides at start of $uri. 2010-11-24 02:15:44 +05:30
mark_story
d5fb0b25cb Fixing issue where Date header would be missing from Emails sent by
EmailComponent.
Adding user configurable field for date.
Test cases added.  Fixes #1304
2010-11-22 22:08:46 -05:00
mark_story
d9484c109f Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-11-22 21:29:33 -05:00
mark_story
d0d16a7eda Fixing i18n extraction errors in Scaffold. Fixes #1305 2010-11-22 21:29:11 -05:00
mark_story
bf10723f89 Applying patch from 'michealc' to fix duplicated comments. Fixes #1306 2010-11-22 21:21:55 -05:00
mark_story
f48811a2ff Moving include up so its not buried deep inside the class. 2010-11-22 21:15:02 -05:00
mark_story
7013a8f1e0 Fixing typo. Should be AppShell, not AppModel. 2010-11-22 21:07:21 -05:00
mark_story
244de1df85 Adding a comment about the messageId property and shells. Refs #1303 2010-11-22 13:01:14 -05:00
mark_story
2d21e9c331 Removing cache hits, as App::core() is almost always called before Cache is initialized, as Cache uses App::core to load the first configured engine. This Cache::read call can never succeed so it should be removed. 2010-11-21 23:02:39 -05:00
mark_story
fdcfd03340 Fixing typo that prevented html coverage reports from being generated. 2010-11-21 23:02:28 -05:00
mark_story
4c0e69b8fc Removing constant checks, they aren't used anymore. 2010-11-21 15:13:33 -05:00
mark_story
8e1f7cc7b9 Removing extra line. 2010-11-21 15:12:44 -05:00
mark_story
8aabf3689e Making BehaviorCollection more consistent with other object collections.
Fixing failing tests caused by not being updated when behavior changed.
2010-11-21 14:42:13 -05:00
mark_story
cb657b158b Fixing failing test and adding skip for test that will fail in a non-isolated case. 2010-11-21 14:39:07 -05:00
mark_story
a729d29cfd Updating ModelTask test to have fewer skips and collisions with the rest of the testsuite. 2010-11-21 13:39:18 -05:00
mark_story
d7b1f70680 Adding some additional output to bake tasks to make them more consistent. Adding flags for Quiet output so the shells give minimal output. 2010-11-21 12:55:01 -05:00
mark_story
d373dde2ef Fixing notice errors in bake all.
Moving some message printing around.
2010-11-21 12:22:44 -05:00
mark_story
8a129ec3a0 Adding a normalize parameter to Object::_mergeVars(). This allows existing behavior to be maintained.
Updating Controller and Shell usage to match new parameters.
2010-11-21 00:47:42 -05:00
mark_story
8821bec049 Moving _mergeVars() into Object as its common to Controller, Model and Shell. 2010-11-21 00:14:29 -05:00
mark_story
8f82156a51 Adding _mergeVars to Controller (this duplicated method will be re-factored away).
Updating tests in ControllerMergeVarsTest to use PHPUnit assertions.
2010-11-21 00:14:29 -05:00
mark_story
e2aeae3825 Adding _mergeVars() into Model.
Refactoring how Model does its property merging.
Eventually _mergeVars() could be moved into Object.
2010-11-21 00:12:07 -05:00
mark_story
b80535573e Adding _mergeVars to Shell. This allows $tasks and $uses to work much
like $uses in Controllers, and provides consistency in the framework.
Adding tests for merging vars.
2010-11-21 00:12:07 -05:00
mark_story
a8554df077 Fixing call to a help method that doesn't exist. 2010-11-21 00:12:07 -05:00
mark_story
cbd88ede37 Adding support for AppShell into App. When you import a Shell class, App will automatically load Shell and AppShell. 2010-11-21 00:12:07 -05:00
mark_story
a2bc369935 Fixing missing include in HelpFormatter. 2010-11-21 00:12:06 -05:00
mark_story
4f6891705b Moving Shell test to the same path as the shell class. 2010-11-21 00:12:06 -05:00
mark_story
66c9b79c2e Removing App::__overload() it does nothing anymore. 2010-11-21 00:12:06 -05:00
mark_story
0d7ecea6cb Adding AppShell to the ignored shell list in CommandListShell. 2010-11-21 00:12:06 -05:00
mark_story
b914709f32 Moving AppShell to where the other shells live. 2010-11-21 00:12:06 -05:00
mark_story
b0ddfa0755 Added the placeholder class for an 'AppShell'.
Conflicts:

	cake/console/cake.php
2010-11-21 00:12:06 -05:00
mark_story
79aafda698 Removing use of serialize() for locked fields. This removes any
possible exploit related to serialize()/unserialize().  Instead values
are passed as | delimited.
2010-11-21 00:09:45 -05:00
mark_story
ae7855692d Removing unserialize() as its dangerous. Instead using | delimited fields for locked fields. This totally avoids issues with serialize(). Removing str_rot13, as its only child proof.
Tests updated.
2010-11-20 23:42:54 -05:00
mark_story
3237402fb8 Merge branch '1.3' into merger
Conflicts:
	cake/libs/configure.php
2010-11-20 23:14:33 -05:00
mark_story
ef3cb0e50c Adding tests for Set::normalize() 2010-11-20 22:46:55 -05:00
mark_story
6d9b000aee Changing how mergeVars are handled, so the difference of app/current is used as a base.
Also fixing issues where passing settings to helpers in AppController could result in them not being correctly merged.
Thanks to hashmich for the partial patch.
Fixes #1183
2010-11-20 22:34:24 -05:00
mark_story
e0a8ffe8a3 Applying patch from 'jmccaffrey' to fix issues on windows where virtual
machine paths would not be correctly handled.  Fixes #1254
2010-11-20 13:26:30 -05:00
PhpNut
82d46067ab Corrected doc comment. 2010-11-17 15:00:27 -06:00
PhpNut
bed7767258 Removing __cache property that can be altered outside of the class definition.
Adding __resetCache() as a replacement for checking if cache should be reset and written.
2010-11-17 14:02:35 -06:00
José Lorenzo Rodríguez
40418de218 Freeing up some memory in dbos after the result set has been completly fetched.
Adding dbo_mysql and dbo_postgres to the AllDAtabase testsuite
2010-11-16 23:59:24 -04:30
mark_story
ba10003ef2 Fixing failing tests when HtmlHelper test was run by itself. 2010-11-16 22:52:49 -05:00
José Lorenzo Rodríguez
c0f10437ea Adding a few transactions to speed up a little tests involving fixtures 2010-11-16 23:14:48 -04:30
José Lorenzo Rodríguez
1326707c9d Implementing transaction nesting, this will allow to open multiple transactions that will only be commited if all transactions succesfully calls commit() 2010-11-16 22:56:23 -04:30
mark_story
47f6a29998 Small optimizations in env() and Helper::_parseAttributes(). 2010-11-16 22:24:54 -05:00
mark_story
d89581dcca Changing object construction and method call to use file_put_contents. 2010-11-16 21:54:05 -05:00
mark_story
d12c232d8a Merge branch '1.3' into merger
Conflicts:
	app/config/core.php
	cake/console/templates/skel/config/core.php
	cake/dispatcher.php
	cake/libs/controller/components/auth.php
	cake/libs/view/helpers/form.php
	cake/tests/cases/libs/cake_test_case.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/model/models.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helpers/paginator.test.php
	cake/tests/lib/cake_test_case.php
2010-11-16 21:48:13 -05:00
José Lorenzo Rodríguez
f2b707ac0b Merge remote branch 'origin/2.0' into feature/2.0/pdo
Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysqli.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
2010-11-16 21:54:42 -04:30
mark_story
5349257bbd Changing empty() to !isset() to avoid additional cache hits when po files are missing or empty. 2010-11-16 07:32:14 -05:00
José Lorenzo Rodríguez
a335891eba mapping lastNumRows to lastAffectedRows as it is not possible to do the first one using PDO 2010-11-16 02:02:08 -04:30
José Lorenzo Rodríguez
5a881c461e Fixing acl testcase so it runs smoothly on postgres 2010-11-16 01:22:29 -04:30
mark_story
f0ac462775 Updating test cases with failing tests. 2010-11-15 22:53:49 -05:00
mark_story
66e6ec763e Merge branch 'dispatcher-request' into 2.0
Conflicts:
	cake/libs/configure.php
	cake/tests/cases/libs/all_routing.test.php
	cake/tests/cases/libs/controller/controller.test.php
2010-11-15 22:42:54 -05:00
mark_story
293ef95f33 Adding more documentation, and adding some return early changes. 2010-11-14 18:43:46 -05:00
mark_story
db3f74dfa0 Moving a method around. 2010-11-14 18:38:10 -05:00
mark_story
070066be18 Expanding doc blocks for Dispatcher.
Extracting _isPrivateAction() so subclasses could change the behavior.
2010-11-14 18:37:27 -05:00
mark_story
1631f31460 Adding doc comments to Configure and App. 2010-11-14 18:26:54 -05:00
mark_story
b91566d35f Removing ini_set() in project root.
Fixing notice errors that would happen when mod_rewrite wasn't enabled.
2010-11-14 14:45:09 -05:00
mark_story
27287e4b9f Moving AppTest into a separate file.
Updating test suite.
2010-11-14 13:06:25 -05:00
mark_story
1b89547c58 Pulling App out into its own file. Trying to stick with one class per file conventions.
Removing class_exists check, as Set is loaded during the framework
bootstrap.
2010-11-14 13:02:30 -05:00
mark_story
8e29595b63 Updating test.php to bootstrap like index.php
Updating skel file to match app one.
2010-11-14 12:50:28 -05:00
mark_story
afd2683602 Adding a check for loaded routes. This prevents routes being loaded on each dispatched action, such as when requestAction is called. 2010-11-14 01:12:39 -05:00
mark_story
f27566336c Renaming private method to protected.
Removing return by reference operator.
2010-11-14 01:08:13 -05:00
mark_story
f36f38e7f6 Adding doc blocks and adding type hints for _invoke(). 2010-11-14 01:05:42 -05:00
mark_story
f02e0483ee Reworking parameter munging specific to requestAction into requestAction. Updating tests cases for Object. As request->data is an array() not null. And leading / is trimmed off of [url][url]. 2010-11-14 01:01:11 -05:00
mark_story
55cc3296ab Making the Debugger tests pass when you have debug = 0 in your config file. Tests are runnable while debug = 0 from CLI. 2010-11-14 00:59:45 -05:00
mark_story
557d797297 Making Dispatcher test cases pass when Dispatcher expects a CakeRequest instead of a string. 2010-11-14 00:29:56 -05:00
mark_story
ea80a6dbbb Removing instance variables that were no longer needed, as they weren't actually being used for much. 2010-11-14 00:16:07 -05:00
mark_story
1fe84c00dd Starting to try and simplify the bootstrap process, and give a choice
over which GET param is used for cake's url.
2010-11-14 00:06:01 -05:00
mark_story
dad7963ea4 Moving Dispatcher inside libs directory, as it is part of CakePHP's libs. 2010-11-14 00:00:23 -05:00
mark_story
6073ac5dfa Fixing errors caused by accessing things that don't exist. 2010-11-13 23:57:01 -05:00
mark_story
c7fed2ecba Removing duplicate calls to Inflector. 2010-11-13 21:08:26 -05:00
mark_story
9b08b725fe Merge branch '2.0' into 2.0-view
Conflicts:
	cake/libs/controller/controller.php
	cake/libs/view/helpers/cache.php
2010-11-13 21:03:54 -05:00
mark_story
4c3337598e Updating version numbers for 1.3.6 2010-11-13 20:01:20 -05:00
mark_story
76a80c262e Fixing failing test caused by name() being able to quote things better now. 2010-11-13 12:04:22 -05:00
mark_story
6c8c7ca4a5 Turning __get() back into methods. There were so few properties being accessed that it didn't make sense to have __get(), over a handful of methods.
Tests updated.
2010-11-12 23:57:55 -05:00
mark_story
f9b7cbcb96 Making ConsoleOptionParser allow subclasses of the option, argument and subcommand classes to be supplied as arguments to the builder methods. Adding tests. 2010-11-12 23:52:33 -05:00
mark_story
8e1dd9e892 Adding __get() to access protected properties of ConsoleOptionParser components for upcoming changes. 2010-11-12 23:34:52 -05:00
mark_story
e63f81c12a Fixing test case that was missing request access. 2010-11-12 23:23:08 -05:00
mark_story
faa23e8d51 Updating tests to reflect changes in bake templates. 2010-11-12 23:22:48 -05:00
mark_story
01894b315f Fixing issues caused by not accessing the request object correctly. 2010-11-12 23:14:34 -05:00
mark_story
18bb5f6b8b Removing =& operators for construction of objects. 2010-11-12 23:05:44 -05:00
mark_story
47fa4713b1 Pulling ScaffoldView into a separate file. 2010-11-12 22:54:28 -05:00
mark_story
85e072a64b Removing reference operators in view class constructors. 2010-11-12 22:51:53 -05:00
mark_story
d044cdd02f Fixing test case that was missing request access. 2010-11-12 22:50:15 -05:00
José Lorenzo Rodríguez
91e2d88900 Moving method back to DboSourceTest, as it was very difficult to adapt it to use mock objects 2010-11-11 00:22:08 -04:30
mark_story
ec2884f17c Making routing suite include RedirectRoute. 2010-11-10 23:50:01 -05:00
mark_story
4e3b62e466 Removing vestigial method in App.
Fixing E_STRICT error in Router.
2010-11-10 23:43:48 -05:00