Commit graph

8458 commits

Author SHA1 Message Date
Mark Story
474ace09c1 Adding CakeResponse to the list of included files for Controller. 2010-09-06 01:11:26 -04:00
Mark Story
d62ae2900a Fixing issue where ConnectionManager wasn't triggering session close, causing issues with database sessions. 2010-09-06 01:10:45 -04:00
Mark Story
27ae7f1f44 Making session storage classes not static, there was no real reason they were static before, and removing the static methods allows them to have constructors. This will allow moving database specific features from CakeSession to DatabaseSession. 2010-09-06 00:43:58 -04:00
ADmad
bfaaa6b8ba Fixing unnecessary extra calls to 'afterFind' callback of 'hasMany' associated models. Closes #995 2010-09-05 23:53:24 +05:30
Mark Story
01eb0bf07d Making messages optional for HTTP exceptions. 2010-09-05 11:32:35 -04:00
Mark Story
8bd0f18a53 Adding a new line to the ConsoleErrorHandler
Refactoring ConsoleErrorHandler test to use dynamic mocks.
2010-09-05 11:22:39 -04:00
Mark Story
9fee81cda0 Updating ConsoleErrorHandler to use new exception names and method renames. 2010-09-05 11:10:48 -04:00
Mark Story
e5b4dd94d7 Renaming exceptions to not use Error400, Error500. Instead HTTP status words are used.
Adding more common HTTP status errors.
Updating tests for ErrorHandler.
2010-09-05 02:05:31 -04:00
Mark Story
b7791dd94f Removing variable that wasn't provided by the exception. 2010-09-05 02:04:08 -04:00
Mark Story
82fffe6914 Fixing issue where FormHelper::select() with multiple = checkbox and a custom name attribute would not work correctly. Fixes #1078 2010-09-05 01:28:13 -04:00
Mark Story
cc17e1a85a Adding more doc blocks to error classes. 2010-09-04 19:18:14 -04:00
Mark Story
954676c9f6 Adding doc blocks to the new exception classes. 2010-09-04 19:16:06 -04:00
Mark Story
d198230e61 Fixing issue where errors that did not have a 500+ code would use the incorrect status code. 2010-09-04 19:06:10 -04:00
Mark Story
4d863618f5 Refactoring exception handling so codes are much more flexible and easy to change.
Made error404 and error500 more generic.
Removed error() as it didn't really make that much sense.
2010-09-04 15:38:10 -04:00
Mark Story
dbd34c75c7 Removing newlines and trailing space. 2010-09-04 15:36:57 -04:00
Mark Story
4980f42dc5 Renaming file. 2010-09-04 15:35:01 -04:00
Mark Story
42d998ca3b Fixing up the include for the console error handler, and adding a test for stderr handle. 2010-09-04 10:46:04 -04:00
Mark Story
fa7549dc4c Fixing comments and removing cakeError(). Instead you should be throwing exceptions. 2010-09-04 01:34:45 -04:00
Mark Story
af87e5d5bc Adding a skip when AppError is present, as its behaviour is unknown. 2010-09-03 15:35:11 -04:00
Mark Story
8c428ff8a8 Moving where AppError is used, as infinite recursion is no fun. 2010-09-03 15:03:33 -04:00
Mark Story
5c0fe1b16e Applying patch from 'majna'. Adding plugin to the list of template variables exposed in the controller task. Test added Fixes #1077 2010-09-03 12:33:59 -04:00
Mark Story
f2db19767d Adding in support for AppError. 2010-09-03 10:30:35 -04:00
Mark Story
2c7ef67e97 Fixing stupid output buffering error. 2010-09-03 10:22:58 -04:00
Mark Story
29ade860b1 Adding cases for Error404 and Error500 exceptions. 2010-09-02 18:04:50 -04:00
Mark Story
a1e01e414b Adding a tests for CakeExceptions and non CakeExceptions 2010-09-02 18:02:58 -04:00
Mark Story
a44b35311d Integrating the ConsoleErrorHandler into the console environment. 2010-09-02 17:49:43 -04:00
Mark Story
60e44660c3 Moving ErrorHandler to ConsoleErrorHandler so it doesn't have classname conflicts.
Making the console use a subclass of ErrorHandler.
2010-09-02 17:49:00 -04:00
Mark Story
034aaa7462 Creating optional boot variable that informs Configure if it should bootstrap the app. Changing how ShellDispatcher checks for app existence it sets the $boot var now and reuses the framework bootstrap file instead of a second custom one. 2010-09-02 17:16:57 -04:00
Mark Story
81e6ca2249 Moving dispatcher include so that cake/bootstrap.php is only bootstrapping the framework. This should allow reusing the bootstrap file for console and web once console error handler is fixed. 2010-09-02 17:00:52 -04:00
Mark Story
d6b43c0e29 Removing TIME_START global, use $_SERVER['REQUEST_TIME'] instead. 2010-09-02 16:55:42 -04:00
Mark Story
ffa8b959e4 Changing classname and importing base class. 2010-09-02 16:47:06 -04:00
Mark Story
3940b059a3 Adding a big docblock to explain how to setup application exception handling. 2010-09-02 16:39:09 -04:00
Mark Story
2e8a60f932 Removing some mentions of cakeError as its been removed. Also adding information about exceptions that can be raised. 2010-09-02 16:38:19 -04:00
Mark Story
dbdd17f51a Adding test cases from 'euromark' and updating how email addresses are parsed so they are slightly more conformant to RFC 5322. Fixes #1066 2010-09-02 11:16:10 -04:00
Mark Story
3e5e52d52e Fixing doc block for Form::create(). Fixes #1058 2010-09-02 00:29:04 -04:00
Mark Story
063fcf557d Moving error handler inclusion to before Configure::bootstrap() so app error handlers can be created.
Fixing issue where unknown exception types would not be handled spewing out errors.  Unknown exception types are interpreted as 500 errors.
2010-09-01 20:29:55 -04:00
mark_story
08d6c19ab6 Adding test for themes in app/webroot dir. Closes #1061 2010-08-31 21:21:05 -04:00
mark_story
a8d4015f47 Updating bootstrap process in CLI to match the one in web.
Updating all_libs to use new file.
Updating error_handler test to run in cli.
Updating Controller so it imports required classes.
2010-08-30 22:59:10 -04:00
mark_story
1f30c06695 Fixing method coercion in error404 so it only coerces CakeExceptions.
Test Added.
2010-08-29 23:39:28 -04:00
mark_story
534f6006f8 Adding omitted parent call. 2010-08-29 23:38:46 -04:00
mark_story
612c52bb8b Adding a beforeRender() that automatically escapes all the content sent to errors handled by CakeErrorController. 2010-08-29 23:31:20 -04:00
mark_story
78ac5bd20f Removing sprintf() placeholders that don't work. 2010-08-29 23:28:54 -04:00
mark_story
efaa2e1177 Refactoring test case to use a dataprovider for the uniform/copy paste test cases. 2010-08-29 21:53:44 -04:00
mark_story
f1164c93d6 Updating the various CakeExceptions to take arrays in their constructors. This allows for the existing templates to continue working, as well as generalize the way in which errors are handled. This change also makes the messages coming out of exceptions more readable and removes string hackery. 2010-08-29 21:37:25 -04:00
mark_story
741f2972f9 Removing non required attribute from missing controller error page. 2010-08-29 15:12:50 -04:00
mark_story
99cde14432 No more skipped tests for ErrorHandler.
Removing missing_model as it was never called.
2010-08-29 13:49:10 -04:00
predominant
465b15c64e Removing reference assignments. 2010-08-29 23:09:33 +10:00
mark_story
7fb62e9b7e Updating more error messages to use exceptions. 2010-08-29 01:26:21 -04:00
mark_story
041aeecce4 Renaming test case file to match class file.
Updating tests and methods for missing_action, missing_view, private_action.
2010-08-29 01:01:36 -04:00
mark_story
88c66c057d Renaming error.php to error_handler.php to better match its class name. 2010-08-29 01:00:36 -04:00