Commit graph

6480 commits

Author SHA1 Message Date
Mark Story
f1a0690415 Fixing issues in JsHelper with PHP4 compatibility. Seems passing arrays by reference doesn't work very well. 2010-01-15 00:02:24 -05:00
Mark Story
b97ac84a34 Fixing method_exists use in Validation for php4 compatibility. 2010-01-14 23:41:35 -05:00
Mark Story
276d183bdd Adding conditional to php5 only function use. 2010-01-14 23:40:18 -05:00
Mark Story
741f507c23 Fixing reference errors in php4. 2010-01-14 23:38:39 -05:00
Mark Story
371ac3971a Fixing php4 compatibility in model_read test. 2010-01-14 23:38:24 -05:00
Mark Story
3a38e0869f Fixing php4 issues in ErrorHandler and ErrorHandler testcase. 2010-01-14 23:17:24 -05:00
Mark Story
547aa76c92 Fixing method_exists() use for php4, as method_exists cannot be used with class/method names in php4. 2010-01-14 23:07:48 -05:00
Mark Story
036d7e6e13 Updating helper syntax. 2010-01-14 23:07:15 -05:00
Mark Story
d4d9ed7bfe Fixing test cases and php4 compatibility in Debugger. 2010-01-14 23:06:48 -05:00
Mark Story
f2dc2078c2 Making PagesController include SessionHelper. 2010-01-14 22:56:34 -05:00
Mark Story
96c56d7446 Fixing failing tests in php4 caused by missing & operators. 2010-01-14 22:54:17 -05:00
Mark Story
5212406ea7 Making xml data test php5 only as Xml::compare() is non-functional in php4 2010-01-14 22:48:19 -05:00
Mark Story
5d280ea977 Making CodeCoverageManager and CakeSession tests run in php4. Removing test case for removed method. 2010-01-14 22:47:49 -05:00
Mark Story
2093f05ce7 Fixing php4 compatibility issues in CakeLog. 2010-01-14 22:33:14 -05:00
Mark Story
af4e9ba76e Fixing php4 reference issues in CakeSchema. 2010-01-14 22:18:26 -05:00
Mark Story
f2cc41bb3a Fixing php4 issues for AclShell test case. 2010-01-14 22:15:14 -05:00
Joël Perras
259b59cae1 Adding optional $reset parameter to Inflector::rules(). Fixes #91.
Inflector::rules() now has an optional 3rd parameter, $reset, which can
be set to true if you desire to remove the default inflections defined
in Inflector.

Note that the reset will only affect those inflection types which you
have explicitly re-defined in the $rules parameter.
2010-01-14 18:18:55 -05:00
Joël Perras
eb7e10db50 Updating Inflector::slug() handling of $map argument. Fixes #18.
When passing a $map to Inflector::slug(), the $map values will now
overwrite any default mappings that Inflector::slug defines.

Modified pre-existing test-case for Inflector::slug() when using a $map.
2010-01-14 17:51:14 -05:00
Joël Perras
adb0c809a0 Refactoring Model::exists() to be independent of Model::$useTable. Fixes #199.
Model::exists() now makes no check whatsoever on the value of
Model::$useTable. This means that, as with a database-backed dbo,
Model::exists() will call Model::find('count') (which in turn calls
DataSource::read()) to determine if the record identified by Model::$id
already exists in the datasource.
2010-01-14 16:47:08 -05:00
Joël Perras
199a14f3be Updating Model::exists() to be more side-effect free.
Model::exists() no longer monkeys with the internal state of
Model::$__exists. The optional $reset parameter has also been removed,
as it is no longer needed.
2010-01-14 16:47:08 -05:00
Joël Perras
137704e397 Optimization to Model::save(). 2010-01-14 16:47:08 -05:00
José Lorenzo Rodríguez
c196c2cbdf More whitespace fixes 2010-01-14 15:57:58 -04:30
José Lorenzo Rodríguez
5395397c95 Updating doc blocks 2010-01-14 15:50:27 -04:30
José Lorenzo Rodríguez
543f40c91e Simplifying returns 2010-01-14 15:42:30 -04:30
José Lorenzo Rodríguez
09b466f8aa Fixing whitespace and removig calls to Helper::output() introduced by error 2010-01-14 15:38:48 -04:30
José Lorenzo Rodríguez
0b3758dc91 Bug fix in I18n
Changing calls from date to strftime in TimeHelper
Implementing TimeHelper::converSpecifiers() to conver format strings to be windows safe and I18n friendly
Implementing TimeHelper::i18nFormat() to format dates with preferred locale date format
Changing TimeHelper::format() to handle inversion of first two parameters, while being backwards compatible. If called with the first parameter as a time string it will call TimeHelper::i18nFormat()
2010-01-14 14:11:57 -04:30
José Lorenzo Rodríguez
a980f72364 Refactoring I18n::translate() to return time format string or arrays when category is LC_TIME
Tests added
2010-01-14 09:54:45 -04:30
José Lorenzo Rodríguez
589972d581 Merge branch '1.3' into github-i18n
* 1.3: (137 commits)
  Updating tests to reflect SessionHelper's loss of magic inclusion.
  Removing SessionHelper's magical inclusion into the helpers array.  Use of SessionHelper must now be explicitly done. Tests updated.
  Fixing merge var test case for non magic session component.
  Fixing Pagescontroller test and removal of pageTitle from controller.
  Fixing component and controller test cases to work with less magical session component.
  Removing the magical addition of SessionComponent to components array.  This makes components more declarative, and removes magic that cannot be undone by the end developer.
  Fixing failing tests due to deleted assets.
  Removing use of subclass method 'fullTableName()' in Datasource superclass. Fixes #100.
  Updating CakeTestSuiteDispatcher parsing of .
  Adding missing </p> to Html test reporter template.
  Updating css file in skel dir.
  Fixing alignment issues in tables.
  Removing orphaned method.
  Adding 'id' attribute to hidden field generated for multiple select and multiple checkboxes. Fixes issue where invalid markup was generated in case to multiple checkboxes
  Adding php5 check to avoid errors when using __get() or __isset() methods in models
  Fixing include in test of CodeCoverageManager. Fixes #196
  Fixing var name when not have SimpleTest or XDebug installed.
  Moving skel/config/sql to skel/config/schema
  Fixing output of 'Actions' in bake templates.  Now outputs a __() call.
  Updating scaffolds to match new bake design.
  ...
2010-01-14 08:34:03 -04:30
Mark Story
1980a46b46 Updating tests to reflect SessionHelper's loss of magic inclusion. 2010-01-14 00:09:14 -05:00
Mark Story
a56bc5585c Removing SessionHelper's magical inclusion into the helpers array. Use of SessionHelper must now be explicitly done. Tests updated. 2010-01-13 23:55:09 -05:00
Mark Story
a85da63956 Fixing merge var test case for non magic session component. 2010-01-13 23:49:11 -05:00
Mark Story
32832f4810 Fixing Pagescontroller test and removal of pageTitle from controller. 2010-01-13 23:49:11 -05:00
Mark Story
540e81b1b0 Fixing component and controller test cases to work with less magical session component. 2010-01-13 23:49:11 -05:00
Mark Story
ebf99de965 Removing the magical addition of SessionComponent to components array. This makes components more declarative, and removes magic that cannot be undone by the end developer. 2010-01-13 23:49:10 -05:00
Mark Story
eb2c34afa0 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-01-13 23:47:59 -05:00
Mark Story
67b69b3106 Fixing failing tests due to deleted assets. 2010-01-13 23:47:31 -05:00
Joël Perras
4d1f6b82e8 Removing use of subclass method 'fullTableName()' in Datasource superclass. Fixes #100. 2010-01-13 23:19:10 -05:00
Joël Perras
88a09cfbb4 Updating CakeTestSuiteDispatcher parsing of .
Better handling of cases where dirname() of PHP_SELF returns only '/'.
2010-01-13 23:19:10 -05:00
Joël Perras
ff3aefe93a Adding missing </p> to Html test reporter template. 2010-01-13 23:19:09 -05:00
Mark Story
8243afa383 Updating css file in skel dir. 2010-01-13 23:03:02 -05:00
Mark Story
e60243c464 Merge branch '1.3' into scaffold-design 2010-01-13 22:16:47 -05:00
Mark Story
25a8a1b1c9 Merge branch '1.3' of github.com:cakephp/cakephp1x into 1.3 2010-01-13 21:56:24 -05:00
Mark Story
619f9210f3 Removing orphaned method. 2010-01-13 21:55:32 -05:00
ADmad
848dc518ab Adding 'id' attribute to hidden field generated for multiple select and multiple checkboxes. Fixes issue where invalid markup was generated in case to multiple checkboxes 2010-01-14 04:13:39 +05:30
José Lorenzo Rodríguez
8496055059 Adding php5 check to avoid errors when using __get() or __isset() methods in models 2010-01-13 12:57:41 -04:30
Juan Basso
d8257518de Fixing include in test of CodeCoverageManager. Fixes #196
Signed-off-by: Mark Story <mark@mark-story.com>
2010-01-13 09:38:26 -05:00
Juan Basso
1c542b6ea5 Fixing var name when not have SimpleTest or XDebug installed.
Signed-off-by: Mark Story <mark@mark-story.com>
2010-01-13 09:35:58 -05:00
Mark Story
f93094b6ea Moving skel/config/sql to skel/config/schema
Updating index.php and test.php in skel dir.
2010-01-13 00:17:15 -05:00
Mark Story
53f0771a48 Fixing output of 'Actions' in bake templates. Now outputs a __() call. 2010-01-13 00:14:57 -05:00
Mark Story
2de9639091 Updating scaffolds to match new bake design. 2010-01-13 00:12:45 -05:00
Mark Story
ee8ebce837 Merge branch '1.3' into scaffold-design 2010-01-12 23:33:52 -05:00
Mark Story
84840c7b04 Fixing issues with magic input() type detection and adding/updating tests. 2010-01-12 23:27:17 -05:00
Mark Story
dc00cfe539 Adding &nbsp; to baked index files to fix rendering issues in IE. 2010-01-12 18:28:16 -05:00
Mark Story
d8e7aa929c Merge branch '1.3-misc' into 1.3 2010-01-12 17:18:14 -05:00
Mark Story
8e22e8cbea Merge branch '1.3-test-suite' into 1.3-misc 2010-01-12 09:31:07 -05:00
Mark Story
a0c3c4b803 Updating AuthComponent::startup() so that being redirected to loginAction with no Auth.redirect value in the session and a non empty loginRedirect defined, the Auth.redirect value is not overwritten. This prevents redirection to already accessible pages. Test cases updated.
Fixes #173
2010-01-11 23:54:06 -05:00
Mark Story
4a96f52be9 Refactoring testsuite shell and consolidating duplicated filename generation logic. 2010-01-11 18:04:38 -05:00
Mark Story
0803e2a5a6 Moving CLI code coverage generation into the CliReporter. 2010-01-11 18:04:08 -05:00
Mark Story
07b43be125 Making CLI case code coverage reports include text. 2010-01-11 18:00:45 -05:00
José Lorenzo Rodríguez
04562982b2 Fixing doc block 2010-01-11 15:34:16 -04:30
José Lorenzo Rodríguez
7e9fc9f705 Test case for date format definition using a LC_TIME locale file 2010-01-11 15:19:57 -04:30
José Lorenzo Rodríguez
50f58da60d Continuing work on locale definition file parser 2010-01-11 15:12:24 -04:30
José Lorenzo Rodríguez
8bc4f0336e Beginings of a parser of locale definition file 2010-01-11 15:09:42 -04:30
José Lorenzo Rodríguez
aa9258cbd1 Adding test for DboSource::group() and virtual fields
Closes #184
2010-01-11 12:22:59 -04:30
José Lorenzo Rodríguez
3fe4b46614 Fixing DboSource::group() to test for virtual fields when first parameter is not an array 2010-01-11 12:06:27 -04:30
José Lorenzo Rodríguez
cecfd72f28 Fixing parse error in php 4 2010-01-11 11:51:55 -04:30
Phally
bbb105fc8c Added virtual field support for GROUP BY. 2010-01-11 11:46:59 -04:30
Mark Story
dda2414b5b Fixing compatibility in ConnectionManager with php4. Fixes #187 2010-01-11 09:48:53 -05:00
Mark Story
4ada5b7eea Fixing notice errors caused by incorrect datatyping in php4. 2010-01-11 09:44:51 -05:00
Mark Story
896414e632 Fixing parse error in PHP4 caused by optional arguments with default
values being passed by reference. Fixes #180
2010-01-11 09:40:56 -05:00
Mark Story
84e70c1db1 Adding linebreak for text/cli output situations. 2010-01-10 15:56:51 -05:00
Mark Story
489958ea48 CakeTextReporter now outputs code coverage. 2010-01-10 15:56:24 -05:00
Mark Story
9989327b5b Fixing constructor of CakeCliReporter to match CakeBaseReporter. 2010-01-10 15:55:49 -05:00
Mark Story
980a85cec4 Updating testsuite shell to use new CodeCoverage methods. 2010-01-10 15:55:09 -05:00
Mark Story
02dbbcdfc6 Fixing CliReporter class name as well as making cli/text output the default if the reporter is unknown. 2010-01-10 15:45:41 -05:00
Mark Story
e7e1a9b15c Further refactoring of code coverage manager. 2010-01-10 15:42:30 -05:00
Mark Story
5a88aaf909 Refactoring loops in CodeCoverageManager 2010-01-10 15:28:29 -05:00
Mark Story
645807211b Adding clear to CodeCoverageManager. 2010-01-10 13:39:41 -05:00
Mark Story
d7164c416e Adding code coverage toggling to CakeBaseReporter.
Updating CodeCoverageManager method use in CakeTestSuiteDispatcher.
2010-01-10 13:24:41 -05:00
Mark Story
da26124add Renaming CodeCoverageManager::start() to init().
Adding a start(), stop(), and clear() methods to CodeCoverageManager.
Making CakeBaseReporter toggle code coverage on and off as needed.
Updating test case for CodeCoverageManager.
2010-01-10 13:23:37 -05:00
Mark Story
b83f3d37c8 Removing unused method. 2010-01-10 13:06:11 -05:00
Mark Story
3dad64c9c0 Moving buffer start in CakeHtmlReporter to fix errors when displaying menus.
Adding paintDocumentStart() to CakeTextReporter::paintHeader() to fix issues with test results not being text/plain.
2010-01-10 13:05:35 -05:00
Mark Story
a41678e51f Merge branch '1.3-misc' into 1.3-test-suite 2010-01-10 12:53:00 -05:00
Mark Story
6147de7725 Fixing notice errors in test case. 2010-01-10 12:52:06 -05:00
Mark Story
836c7de7cb Updating CodeCoverageManager test case and CodeCoverageManager 2010-01-10 12:48:40 -05:00
Mark Story
cf5c48ecc5 Making CakeBaseReporter constructor take null for charset, so its easier to type. 2010-01-10 12:48:11 -05:00
Mark Story
e304246e8f Updating test manager test cases to reflect changes in API. 2010-01-10 12:39:21 -05:00
Mark Story
a0aca7ee62 Adding output buffering to htmlreporter fixing issues with tests that send headers like Dispatcher test. 2010-01-10 12:34:55 -05:00
Mark Story
285ff5eb3b Merge branch '1.3-misc' into 1.3-test-suite 2010-01-10 12:28:09 -05:00
predominant
0959de6031 Adding more tests to check cache paths and stupid values. 2010-01-10 20:54:20 +11:00
predominant
3bd8bd2e0e Adding Inflector::underscore tests 2010-01-10 20:52:49 +11:00
Mark Story
f4bda62ea3 Adding doc blocks and correcting constructor of CakeCliReporter
Fixing TestSuite console code coverage output.
2010-01-09 23:00:03 -05:00
Mark Story
bcd7d34023 Refactoring breadcrumb and time generation in the CLI reporter. 2010-01-09 22:51:17 -05:00
Mark Story
d79bacd1ed Making CodeCoverageManager get its settings from the reporter. This
makes code coverage much less reliant on GET parameters.
2010-01-09 22:42:00 -05:00
Mark Story
03da53bb92 Correcting classname used in CodeCoverageManager
Moving CodeCoverageManager::report() to be inside the html document.
2010-01-09 22:35:29 -05:00
Mark Story
f52900f818 Adding time and memory use to CakeCliReporter 2010-01-09 22:04:28 -05:00
Mark Story
7b5addec3e Making CakeCliReporter a subclass of CakeBaseReporter.
Removing duplicated output from reporter message.
Adjusting formatting of output to be more readable.
2010-01-09 22:02:35 -05:00
Mark Story
081509a09c Fixing typos.
Removing useless constant.
Fixing constructor
2010-01-09 21:30:46 -05:00
Mark Story
a8f289349e Letting TestManager::getExtension accept either test or case as a test case type. 2010-01-09 21:29:57 -05:00
Mark Story
696af91aa0 Refactoring testsuite shell features, and adding i18n text. 2010-01-09 21:25:05 -05:00