Commit graph

9594 commits

Author SHA1 Message Date
Juan Basso
8c7b0f48d8 Checking if has item before fetch virtual fields, avoiding call a function with result (can be large). It save a good time. 2011-02-25 19:55:34 -03:00
Juan Basso
d095f5fe8d Optimizations in filterResults. 2011-02-25 19:15:40 -03:00
Juan Basso
fea2b5798c Minor optimizations in DboMysql. 2011-02-25 17:22:15 -03:00
Juan Basso
73b3b65a53 Changed to filterResults be protected instead of private. 2011-02-25 13:26:14 -03:00
Juan Basso
728d9b2a26 Removed the unused var. 2011-02-25 13:05:08 -03:00
Juan Basso
9baeaf8338 Some code optimizations. 2011-02-25 13:01:32 -03:00
Juan Basso
765c094cf1 Extra protection. 2011-02-25 12:54:58 -03:00
Juan Basso
a091302c92 Removed the isInterfaceSupported method. It not make sense in PHP5. 2011-02-25 12:54:57 -03:00
Juan Basso
05fc10e717 Removed the Datasource::sources method that is used to PHP4. Changed the isInterfaceSupported to be case sensitive (PHP4 restriction). 2011-02-25 12:54:55 -03:00
Juan Basso
6f5be8ff95 Minor changes. 2011-02-25 12:54:53 -03:00
Juan Basso
7f58d2628f Removing return from constructor. 2011-02-25 12:54:51 -03:00
Juan Basso
9e8fc96bf8 Trimming whitespaces. 2011-02-25 12:54:50 -03:00
Juan Basso
5ab5197090 Less one var. 2011-02-25 12:54:48 -03:00
Juan Basso
6e14fa8949 Moving attributes from Datasource to DboDataSource. 2011-02-25 12:54:46 -03:00
Juan Basso
f15544018f Minor optimizations in find. 2011-02-25 12:54:44 -03:00
Juan Basso
5bfa0867ef Removed the support to notation of 1.2. 2011-02-25 12:54:43 -03:00
Juan Basso
31679c3efa Changed the scope of methods in Model. 2011-02-25 12:54:41 -03:00
mark_story
e05c6cd83f Fixing issue where actions starting with a prefix but not followed by an _ would get mangled when going through router::url().
Fixes #1556
2011-02-24 16:43:13 -05:00
José Lorenzo Rodríguez
19bcec599b Merge branch '2.0' of github.com:cakephp/cakephp into 2.0
Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
2011-02-24 01:38:11 -04:30
José Lorenzo Rodríguez
69b70249da Fixing more issues with database prefixes 2011-02-24 01:31:03 -04:30
José Lorenzo Rodríguez
ea7f0bf900 Fixing some tests to make them run with table prefixes 2011-02-23 23:44:48 -04:30
mark_story
139d6b3133 Changing the checks surrounding dataExpression to use empty() instead of isset() so unexpected things don't happen if you ever use dataExpression = false. Fixes #1521 2011-02-23 21:15:39 -05:00
mark_story
9367a10522 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2011-02-23 21:07:10 -05:00
mark_story
98df3e331f Fixing DboMysql not quoting database names in listSources.
Updated tests.
Fixes #1552
2011-02-23 11:36:41 -05:00
mark_story
30c7b954ec Fixing greedy regexp in project task. 2011-02-23 11:26:43 -05:00
José Lorenzo Rodríguez
00f3aaf615 Fixing some issues in ACL related classes when using database prefixes 2011-02-23 01:22:23 -04:30
José Lorenzo Rodríguez
8f62d01701 Fixing lazy loading of database conenction when using prefixes and performing delete operations 2011-02-23 00:51:48 -04:30
José Lorenzo Rodríguez
fc060b5e9c Starting to lazy load database conenctions again, model read tests fixed 2011-02-23 00:43:56 -04:30
José Lorenzo Rodríguez
a79877d11a Revert "Making Model::setSource() eager again to fix issues where joined models"
This reverts commit d20f68c44e.
2011-02-22 23:49:02 -04:30
Juan Basso
52163b4b05 Allowing strings in cc and bcc. Fixes #1553. 2011-02-22 21:23:15 -03:00
mark_story
d4cdc118d2 Fixing notice error that happens when you run tests for plugins. 2011-02-22 08:41:36 -05:00
mark_story
6426b7ec04 Fixing issues with / routes, as PATH_INFO doesn't exist.
Changing foreach loop for if elseif blocks, and removing use of env().  The values we want will never be anywhere else by _SERVER, so don't incur extra overhead looking places it won't be.
Added tests.
2011-02-21 22:30:01 -05:00
José Lorenzo Rodríguez
4cebe55a9b Merge remote-tracking branch 'origin/2.0' into 2.0-class-loading
Conflicts:
	app/webroot/index.php
	lib/Cake/Controller/Component/AuthComponent.php
	lib/Cake/Network/CakeRequest.php
	lib/Cake/tests/cases/libs/controller/components/auth.test.php
2011-02-21 22:28:30 -04:30
Juan Basso
21a9904a71 Adding a protection to cake console be executed in driver root (windows). Fixes #1408. 2011-02-21 17:55:15 -03:00
Juan Basso
c5f291958b Adding extra protection to cake console be executed in driver root (windows). 2011-02-21 17:36:32 -03:00
ADmad
1f2afd8d3f Removing deprecated function TimeHelper::relativeTime() which was simply an alias for TimeHelper::timeAgoInWords() 2011-02-22 01:27:46 +05:30
ADmad
709ed7675b Fixing typo in PHPUnit include file path 2011-02-22 01:21:26 +05:30
mark_story
0b75906649 Adding docs about the ability to set settings in the helper as well. 2011-02-21 14:08:29 -05:00
mark_story
c64dd9d352 Adding the ability to pass additional information into the rendering of flash messages. Allows you to keep keep code DRY by moving repeated settings into the view.
Added tests.
Fixes #792
2011-02-21 14:08:29 -05:00
Juan Basso
e1b3703c20 Adding a protection to cake console be executed in driver root (windows). Fixes #1408. 2011-02-21 15:46:55 -03:00
mark_story
6338299e77 Merge branch 'clean-get' into 2.0 2011-02-21 12:47:41 -05:00
mark_story
1f9bbbce53 Pulling windows specific tests into a separate test method. 2011-02-21 10:48:34 -05:00
Victor Widell
d0b7d3355d $this->data[$habtmKey] could be a string, meaning $this->data[$habtmKey][$habtmKey] would be the first character of that string. Probably not what you want.
Fixes #1549

Signed-off-by: mark_story <mark@mark-story.com>
2011-02-21 10:39:55 -05:00
mark_story
440a89051d Fixing test that didn't fail as expected. 2011-02-20 22:33:10 -05:00
mark_story
d1821b3f9d Removing $request->query[url]. This simulated value is also available at $request->url, and having it in the query array confuses things, as GET[url] no longer exists.
Fixing failing tests elsewhere in the framework.
2011-02-20 21:52:20 -05:00
mark_story
2190596764 Fixing htaccess file to not use GET params anymore. 2011-02-20 13:57:38 -05:00
mark_story
23bacfc0c7 Adding new checks, so missing favicons don't flood the error logs. 2011-02-20 13:29:19 -05:00
mark_story
8991095045 Removing references to GET['url'] & favicon, as there is no more GET[url]. 2011-02-20 13:12:04 -05:00
mark_story
24935afff4 Removing remaining references to $_GET['url']. 2011-02-19 22:27:38 -05:00
mark_story
ea52f880fd Removing useless property. 2011-02-19 22:26:44 -05:00
mark_story
630d0a9887 Removing redundant method. 2011-02-19 22:26:12 -05:00
mark_story
8cbd9fc361 Fixing viewClass name on Scaffold. 2011-02-19 22:21:58 -05:00
mark_story
633fcba4e8 Fixing viewClass name on Scaffold. 2011-02-19 22:21:38 -05:00
mark_story
24369cf04a Removing GET param, and making CakeRequest use PATH_INFO and SCRIPT_NAME to determine base paths and request urls.
Updated tests.  Removed test for base path injection, as PHP_SELF is no longer used to compute the base path, and users cannot influence SCRIPT_NAME.
2011-02-19 22:20:55 -05:00
mark_story
db00915dea Removing complicated logic that does a reasonable amount of unnecessary work. Favouring $_SERVER['PATH_INFO'] over more complicated, logic. This may cause issues with IIS 5.x, but its a very old release now.
Updating tests to match values that come out of IIS7.
2011-02-19 18:20:54 -05:00
mark_story
52467a7e18 Moving assignment of base into _base(). 2011-02-19 13:17:05 -05:00
mark_story
79ec16364a Refactoring tests to use a generator. 2011-02-19 12:36:27 -05:00
mark_story
1ee6c1ee45 Removing some no longer required method calls. 2011-02-19 11:30:09 -05:00
mark_story
c15d0132f3 Adding more environment detection tests. 2011-02-19 10:00:34 -05:00
mark_story
63f07d3f0f Making Authorize and Authenticate objects have constructors like other components.
Adding ComponentCollection as a argument for the constructor, this unifies the two types of objects and makes them consistent with other components.  It also allows authenticate/authorize objects to access other components, thanks to hiromichan for the idea. Tests updated.
2011-02-17 23:17:07 -05:00
mark_story
0cb5394d0b Adding static variable to allow changing which get param cake uses. Refs #1483 2011-02-17 22:15:16 -05:00
mark_story
5c4854b897 Adding omitted return that would prevent users from reaching the login page after being redirected to it. Tests added. Fixes #1542 2011-02-17 07:44:41 -05:00
0x20h
0e7f2efdb1 Fixing notice errors caused by accessing headers in po files that
don't exist. Fixes #1515

Signed-off-by: mark_story <mark@mark-story.com>
2011-02-16 22:13:51 -05:00
mark_story
ca3e606ec8 Fixing failing tests caused by me forgetting to run tests in [7032729651] 2011-02-16 22:08:20 -05:00
mark_story
a95d4acf09 Removing unused code, and adding a realpath() to document_root, so symlinks work a bit better. 2011-02-16 21:14:32 -05:00
mark_story
c638443b4d Merge branch '2.0-auth' into 2.0 2011-02-14 22:45:39 -05:00
José Lorenzo Rodríguez
c1e81a20cd Moving more files to the new folder 2011-02-13 23:20:49 -04:30
José Lorenzo Rodríguez
dfc0a28d7f Merge remote branch 'origin/2.0' into 2.0-class-loading 2011-02-13 23:11:38 -04:30
José Lorenzo Rodríguez
6e4f4efb79 Merge remote branch 'origin/2.0' into 2.0-class-loading
Conflicts:
	cake/bootstrap.php
	lib/Cake/Console/Command/TestSuiteShell.php
	lib/Cake/Console/TaskCollection.php
	lib/Cake/Controller/ComponentCollection.php
	lib/Cake/Controller/Controller.php
	lib/Cake/Core/App.php
	lib/Cake/Model/BehaviorCollection.php
	lib/Cake/Network/CakeRequest.php
	lib/Cake/TestSuite/CakeTestSuiteDispatcher.php
	lib/Cake/TestSuite/CakeWebTestCase.php
	lib/Cake/TestSuite/TestManager.php
	lib/Cake/TestSuite/TestRunner.php
	lib/Cake/View/HelperCollection.php
	lib/Cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
	lib/Cake/tests/cases/libs/test_manager.test.php
2011-02-13 23:10:19 -04:30
mark_story
e60376bef9 Removing a bunch of code that can be reached through inheritance.
Adding a doc block.
2011-02-13 22:19:49 -05:00
mark_story
51dcb18742 Adding support for AppFixtureManager as well as option flag selection. 2011-02-13 19:01:53 -05:00
mark_story
d20f68c44e Making Model::setSource() eager again to fix issues where joined models
would not have the table prefixes correctly configured.  Fixes #1507
2011-02-13 18:42:04 -05:00
mark_story
7f8c98d9de Fixing typo and exposing fixture manager parameter to webrunner. 2011-02-13 15:15:01 -05:00
mark_story
844c6315c1 Fixing issue where a non CakeException would break things.
Test added.
2011-02-13 15:14:29 -05:00
mark_story
451b3fd18d Going back to using the old time and memory calculations/output. 2011-02-13 15:01:00 -05:00
mark_story
912927db18 Removing duplicate tag. 2011-02-13 14:56:35 -05:00
mark_story
f6e9b5b254 Removing TestManager from the group tests.
Fixing a failing case on the testsuite shell.
Fixing Debugger from stealing the error handler from PHPUnit.
2011-02-13 14:56:35 -05:00
mark_story
1c9808fdca Creating a factory method for the runner creation. 2011-02-13 14:56:35 -05:00
mark_story
78dd89027d Removing comments left in on previous commit. 2011-02-13 14:56:35 -05:00
mark_story
9f4597effd reformatting code. 2011-02-13 14:56:35 -05:00
mark_story
39e05bce4a Using PHPUnit internals for more things.
Removing code that is also present in PHPUnit.
Updating testsuite shell to use loader class.
2011-02-13 14:56:35 -05:00
mark_story
e5c898a4d2 Moving methods into the loader class.
Getting rid of lame functions and using Spl more effectively.
2011-02-13 14:56:35 -05:00
mark_story
0c09d08585 Removing duplicate methods. 2011-02-13 14:56:35 -05:00
mark_story
4f65d0dbed Fixing issue where document start would be sent multiple times. 2011-02-13 14:56:35 -05:00
mark_story
846a0587fc Getting rid of TestManager. 2011-02-13 14:56:34 -05:00
mark_story
00c56facdd Removing CakeWebTestCase it doesn't work anymore. 2011-02-13 14:56:34 -05:00
mark_story
f84046c802 Moving a require.
Adding some doc blocks, and making the loader not double append test case suffixes.
2011-02-13 14:56:34 -05:00
mark_story
08fba9b280 Making coverage reports work from the webrunner. 2011-02-13 14:56:34 -05:00
mark_story
16481d7b7e Running individual tests from the web runner now works.
Adding some more hooks, so webrunner can swap out result printers like it did before.
2011-02-13 14:56:34 -05:00
mark_story
8ebbccbd76 Fixing tab/spaces. 2011-02-13 14:56:34 -05:00
mark_story
8c2e0815ec Adding Fixture manager overriding.
Refs #1511
2011-02-13 14:56:34 -05:00
mark_story
0a2822335c Removing a bunch of code not needed any more. 2011-02-13 14:56:34 -05:00
mark_story
f586ed0394 Initial ugly re-factor of where fixtures are done. 2011-02-13 14:56:33 -05:00
mark_story
5a631a6c74 Renaming the runner.
Making the runner extend PHPUnit_TextUi_TestRunner so we can customize the TestSuite classes it uses.
Adding CakeTestSuiteCommand so we can customize the TextUI_Command output.
2011-02-13 14:56:33 -05:00
mark_story
60590de6bc Starting to banish TestManager, and replace it with a more normal PHPUnit test loader. 2011-02-13 14:56:33 -05:00
mark_story
63caf566fb Adding some tests around invalidFields() and fieldList options.
Closes #1534
2011-02-13 12:22:29 -05:00
ADmad
681b9997b0 Renamed Controller::view to Controller::viewClass and Controller::view, View::view can now be used to change the view rendered by default. Parameters of Controller::render() and View::render() changed to eliminate redundancy. Closes #1520 2011-02-13 02:24:39 +05:30
mark
e16d21eaa3 Add displayField and primaryKey to controller bake. Fixes #1192
Signed-off-by: mark_story <mark@mark-story.com>
2011-02-12 11:47:38 -05:00
mark_story
d0c2b9c9d1 Fixing failing test caused by boolean type changes. 2011-02-12 06:21:19 -05:00
mark_story
08509cc6d3 Fixing issue where static variable would be shared inconsistently across multiple instances. Fixes #1504 2011-02-11 22:39:09 -05:00
mark_story
26c5f78a14 Fixing notice error caused when looking for info on tables that don't exist. 2011-02-11 22:37:56 -05:00
mark_story
e0420937a7 Fixing notice error that could occur if csrfTokens ended up being null/not an array. 2011-02-11 22:30:51 -05:00
mark_story
42c2f3011b Applying fix from 'Mark Mitchell' to expose PeriodicalExecuter in the callback. Fixes #1529 2011-02-11 21:49:00 -05:00
mark_story
71f76080a2 Fixing issue where creating cookies in the beforeFilter would result in
cookies with the wrong expiry time. Thanks 'RabidFire' for the patch. Fixes #1523
2011-02-09 21:19:15 -05:00
mark_story
33390070d3 Removing HTTP authentication from SecurityComponent. There are new
Authentication objects to fill this hole now.
2011-02-08 22:09:57 -05:00
mark_story
a5fb2cf8a7 Fixing issue where fixtures without field definitions would drop tables,
even though they had no way to re-create them. Fixes #1519
2011-02-08 21:53:12 -05:00
mark_story
9a940709ab Removing unsupported options from PrototypeEngine. Fixes #1516 2011-02-07 20:59:01 -05:00
mark_story
584116524b Fixing range option for prototype engine. Fixes #1509 2011-02-07 19:19:50 -05:00
mark_story
fbd798da6c Reordering parameters to make it easier to remember the order. 2011-02-06 16:59:47 -05:00
mark_story
47cdaedc94 Fixing $this -> self. 2011-02-06 15:25:36 -05:00
Juan Basso
f2a4b1e959 Supporting %e in windows. Fixes #1510. 2011-02-06 15:51:28 -02:00
mark_story
e32f419d0a Fixing comments. 2011-02-06 00:01:52 -05:00
mark_story
3629925a40 Refactoring authentication objects so basic and digest authentication can work without cookies. This makes non browser clients able to use Basic and Digest auth.
Updating test cases.
2011-02-05 18:41:00 -05:00
mark_story
7388d900b4 Fixing IIS test cases to match what should actually happen. 2011-02-05 16:12:50 -05:00
mark_story
11d20f80d0 Fixing failing tests imported with the merge. 2011-02-05 15:24:53 -05:00
mark_story
e149c411fb Merge branch '1.3' into merger
Conflicts:
	cake/VERSION.txt
	cake/config/config.php
	cake/console/shells/tasks/template.php
	cake/dispatcher.php
	cake/libs/controller/component.php
	cake/libs/controller/components/email.php
	cake/libs/controller/scaffold.php
	cake/libs/model/datasources/dbo/dbo_mysqli.php
	cake/libs/view/helpers/cache.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
	cake/tests/fixtures/datatype_fixture.php
2011-02-05 12:20:09 -05:00
mark_story
8d5e68d582 Fixing issue where habtm tables would not have the connection prefix removed when generating schema. Fixes #1180 2011-02-05 11:19:05 -05:00
mark_story
ca22624b2b Tiny tweak to remove a duplicated line. 2011-02-05 10:43:30 -05:00
mark_story
79bbd227e3 Cache::configured() and in_array() are faster than calling Cache::config() 6 times. 2011-02-05 10:30:28 -05:00
mark_story
cf50cbdd9d Fixing issue in FormHelper where CURRENT_TIMESTAMP or other invalid data could cause a notice error. Fixes #1508 2011-02-05 06:43:00 -05:00
mark_story
0a266fa1fc Fixing typo. 2011-02-05 05:54:38 -05:00
mark_story
f58f3763eb Updating tests to account for attribute whitespace change. 2011-02-05 05:52:18 -05:00
mark_story
8f66fe6ed4 Removing additional spaces in tags. 2011-02-05 01:48:52 -05:00
mark_story
f5383a2243 Fixing some failing tests. 2011-02-05 01:40:14 -05:00
mark_story
8d7df1721c Removing duplicate import. 2011-02-05 01:29:35 -05:00
mark_story
304f12d0ed Removing a pointless import in CakeRequest.
Moving inclusion of ObjectCollection to bootstrap.  This avoids repetitive calls to import()
2011-02-05 01:28:41 -05:00
mark_story
8e267f7be2 Fixing bake's unit test detection so it checks for PHPUnit properly.
Fixes #1505
2011-02-04 21:56:24 -05:00
Mark Story
7b34d879dc Making exception class names visible in the WebTest runner. Fixes #1506 2011-02-04 17:11:49 -05:00
mark_story
3875d0ef54 Removing a method that is duplicated in AuthComponent. 2011-02-03 23:00:41 -05:00
mark_story
9854947d0f Fixing reversed args. 2011-02-03 22:46:31 -05:00
mark_story
5834225cc3 Making AuthComponent::password() static, as it might be needed in places where an instance of AuthComponent is not handy. 2011-02-03 22:46:31 -05:00
mark_story
a5d9a64e1a Removing loginError, its not used anymore. 2011-02-03 22:46:31 -05:00
mark_story
59dac2255e Expanding test coverage. 2011-02-03 22:46:31 -05:00
mark_story
060360c787 Switching Controller->Session => Auth->Session. 2011-02-03 22:46:31 -05:00
mark_story
dc7565ad47 Removing crufty methods
Removing additiona ->Controller all over the place
2011-02-03 22:46:31 -05:00
mark_story
af934e3443 Removing more dead code in the Auth test. 2011-02-03 22:46:31 -05:00
mark_story
ffb6c29e79 Removing dead fixtures, dead properties and dead models. 2011-02-03 22:46:31 -05:00
mark_story
2f917674d1 Fixing docblock to reflect change from '*' to 'all'. Adding note about constant. 2011-02-03 22:46:31 -05:00
mark_story
82851895ef Shifting includes around. 2011-02-03 22:46:31 -05:00
mark_story
91a3fc4aee Fixing tests so they run in the webrunner. 2011-02-03 22:46:30 -05:00
mark_story
0e7f490489 Fixing failing test. 2011-02-03 22:46:30 -05:00
mark_story
669672a1a0 Adding doc blocks. 2011-02-03 22:46:30 -05:00
mark_story
d5f5ae3271 Fixing typo where realm would be wrong if not specified. 2011-02-03 22:46:30 -05:00
mark_story
705b3288e1 Basics of DigestAuth are working. 2011-02-03 22:46:30 -05:00
mark_story
945e49ad09 Starting Digest auth, using Basic auth as a starting base. 2011-02-03 22:46:30 -05:00
mark_story
bcd8dcd0f7 Extracting common logic into the base class. 2011-02-03 22:46:30 -05:00
mark_story
4610a0bf3c Adding some more tests for basic auth challenge headers. 2011-02-03 22:46:30 -05:00
mark_story
e8bf6ed176 Basic tests for BasicAuthenticate are passing. 2011-02-03 22:46:30 -05:00
mark_story
67c4c9a693 Fix failing test and removing tests for settings that no longer exist. 2011-02-03 22:46:30 -05:00
mark_story
ba02483ae8 Adding a response parameter to authenticate() both basic and digest auth need to set response headers. 2011-02-03 22:46:30 -05:00