mark_story
61b70f1b44
Removing parameters from RouterRoute::_writeRoute().
2009-12-02 00:26:43 -05:00
mark_story
494875cca2
Renaming RouterRouter::$params to $options.
2009-12-02 00:20:51 -05:00
mark_story
728613a34d
Removing use of Set::filter() as its slowish.
2009-12-01 23:05:04 -05:00
mark_story
67ccac1f57
Adding omitted reference operator.
2009-12-01 22:31:18 -05:00
mark_story
63cd1a3326
Renaming method and removing Set::filter() call.
2009-12-01 22:21:33 -05:00
mark_story
78773020d1
Moving route failure handling to a separate method.
2009-12-01 21:56:03 -05:00
mark_story
4c175cc0bc
Removing code.
2009-12-01 21:43:36 -05:00
mark_story
02ed766874
All tests passing in RouterTest.
2009-12-01 21:37:39 -05:00
mark_story
e741e0e4cb
Adding test for previously broken reverse routing feature, where parameters that only partially passed the pattern would be accepted.
2009-12-01 15:04:53 -05:00
mark_story
e36631091d
Fixing a failing test.
2009-12-01 14:58:36 -05:00
mark_story
21dd7fd4ca
Fixing connection of plugin routes, the were being connected in the wrong spot.
...
Moving admin route + plugin tests to correct place.
Fixing order of methods in tests. parse() should only be called after routes are connected otherwise the default routes will precede the custom routes.
2009-12-01 14:39:23 -05:00
mark_story
a5a02925d8
Adding test for previous commit.
2009-12-01 13:38:32 -05:00
mark_story
a8f79f9fe5
Removing defaults that are also keys this makes the actions with the default index key work much better. Also things can't be both a variable and a constant routing parameter.
2009-12-01 13:37:03 -05:00
mark_story
6046528744
Moving XmlNode::__killParent() to a protected method so Xml can access it. Adding _killParent(true) call to Xml::__destruct. Forces destruction of circular references held in child objects when an xml object is garbage collected. Fixes #369
2009-12-01 10:01:36 -05:00
mark_story
547ed839d9
Correcting constructor of MediaView to fix issues with viewVars not being set.
...
Correcting use of MediaView in Dispatcher. Fixes #366
2009-12-01 09:50:27 -05:00
mark_story
0293a840c5
Adding test to disprove #368 . FormHelper::year() is working correctly and includes model name in the input name attribute.
2009-11-30 13:43:26 -05:00
mark_story
393038816c
More tests passing in RouterTest now.
2009-11-30 10:15:39 -05:00
mark_story
cd46f4db2e
Fixing function signature of ThemeView constructor. Fixes issues where ThemeView would always be registered causing issues with EmailComponent and themed views. Fixes #370
2009-11-30 09:19:25 -05:00
mark_story
fccfe14e8d
Expanding doc block for ClassRegistry.
2009-11-30 09:18:24 -05:00
mark_story
11dd7898c4
Fixing tests + adding tests for passed args order preservation when passed args are part of default route parameters.
2009-11-30 00:23:41 -05:00
mark_story
e41c408378
Adding parameter pattern matching back into RouterRoute::match(), fixes failing tests in RouterRoute test case.
2009-11-29 23:46:02 -05:00
mark_story
5999264f10
Most of RouterRoute::match() working now. Failing tests for params with patterns included.
2009-11-29 22:57:10 -05:00
mark_story
de0b90db4a
Moving addition of plugin and controller keys to Router instead of RouterRoute.
2009-11-29 16:21:33 -05:00
mark_story
9e9559b350
Working on RouterRoute::match(). Adding tests for RouterRoute::match() and removing defaults from routes that don't need defaults.
2009-11-29 16:09:45 -05:00
mark_story
0834cb47ab
Removing code from RouterRoute::__mapRoute. All tests passing.
2009-11-29 12:10:09 -05:00
mark_story
b242dc9531
Moving parameter persist to RouterRoute.
...
Tests updated.
2009-11-29 10:59:38 -05:00
mark_story
f59b8daf2e
Expanding tests for passed arguments in route defaults working correctly. Refactoring passed arguments in route default handling.
2009-11-29 09:49:19 -05:00
mark_story
889e367510
Expanding and correcting doc block for router::connect.
2009-11-28 23:37:40 -05:00
mark_story
7216925394
Updating doc blocks.
2009-11-28 23:12:44 -05:00
mark_story
a86e414adc
Removing Router::stripEscape() and all uses of it.
...
Router::stripEscape() removed escape patterns supported in DboSource. Since those escape patterns no longer exist, neither does the need for the escaping of those patterns.
2009-11-28 23:08:52 -05:00
mark_story
d70689ecda
Merge branch '1.3-misc' into write-route
2009-11-28 23:04:22 -05:00
mark_story
02f9275e20
Removing automagic -! sql no-escape string handling. Removing use of Router::stripEscape() from Dispatcher, as this method removed -! from url + post data.
2009-11-28 23:02:59 -05:00
mark_story
5cbe3dbd39
Removing unused variables. Making loop easier to read.
2009-11-28 21:58:02 -05:00
mark_story
5b4d15dc3b
Removing support for mid route * elements. Mid-route lazy * behaved in a sometimes erratic fashion making routes employing mid-route lazy * hard to depend on.
2009-11-28 21:54:33 -05:00
mark_story
33c67f7c47
More tests passing and more code moved from Router to RouterRoute. Switching RouterRoute to used named capture groups. This simplifies the route processing internals as there are fewer loops used to merge array sets together.
2009-11-28 09:40:15 -05:00
mark_story
4cb055ff0a
Removing tests for features no longer supported. Path elements containing only regular expressions are no longer supported. They did not effectively reverse route. And they provided an inconsistent behavior when combined with the full gamut of regular expressions and routing parameters.
2009-11-27 17:12:35 -05:00
mark_story
26aa3731e0
Fixing _name_ elements being inserted into serialized xml from Xml lib. Test case added. Fixes #367
2009-11-27 14:27:32 -05:00
phpnut
8bc84948f0
Adding more tests for theme assets
2009-11-27 10:27:15 -06:00
mark_story
49c6cd3f9f
Fixing issues with optional parameters. Allows route params to be made optional by setting a pattern definition.
2009-11-27 09:58:51 -05:00
phpnut
7b78e475ca
Merge branch '1.3' of code.cakephp.org:cakephp into 1.3
2009-11-27 00:55:45 -06:00
phpnut
43fdde2dad
Removing unneeded code in Dispatcher::cached();
...
Fixing path search for themes
2009-11-27 00:49:20 -06:00
mark_story
fd98bc5d76
Expanding tests on Router and RouterRoute.
2009-11-26 23:46:42 -05:00
mark_story
feb0dec970
Starting tests for RouterRouter::parse()
2009-11-26 23:01:54 -05:00
mark_story
89d0ed8f3b
Route compilation tests passing again.
2009-11-26 21:42:33 -05:00
mark_story
8315b48e77
Removing String::getInstance() as it was causing fatal errors when eAccelerator was enabled, and is a deprecated method.
2009-11-26 18:24:14 -05:00
mark_story
18e0537869
Adding variable initialization
2009-11-26 17:50:33 -05:00
phpnut
21d2226f75
Merge branch '1.3' of code.cakephp.org:cakephp into 1.3
2009-11-26 14:53:06 -06:00
phpnut
903a1fd95a
Adding new Configure::$App['www_root']
...
Helper::webroot(); will now check for theme assets in APP/webroot/theme/<theme_name>/
Adding ico key to Media::$mimeType;
Fixed bug in previous commits that would not use views/themed/<theme_name>/layouts/ from a plugin
Adding test cases for Helper::webroot();
Adding more tests for ThemeView.
2009-11-26 14:52:38 -06:00
renan.saddam
f9204ebe7c
Adding $pos = 0; to avoid php notice.
2009-11-26 17:52:14 -02:00
ADmad
ad20e43730
Removing unneeded code for minor optimization
...
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-26 09:54:25 -05:00
