Commit graph

1596 commits

Author SHA1 Message Date
jperras
8bb11e49d7 Fixing counterCache behavior when updating an existing record's counterScope value. Thanks for the patch, mattcurry. Fixes #6270.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8155 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-25 01:17:21 +00:00
jperras
97abf84770 EmailComponent:: now is set to null after calling EmailComponent::reset(). Test cases added; fixes #6314.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8153 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-25 00:01:57 +00:00
jperras
650d1e7c78 Removing hard coded HELO hostname of 'cake' in EmailComponent; better compliance with RFC-821 3.5. Test cases added. Fixes #6264.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8152 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-24 18:20:51 +00:00
mark_story
82cb895f50 Correcting test case simulation. Closes #6211
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8151 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-23 17:26:56 +00:00
gwoo
fd0c39fcc6 fixes #6293, Deleting non-existing record causes save() to fail. Thanks to msadouni for the patch and test!
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8150 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-22 16:47:34 +00:00
mark_story
6e91ee7ad4 Adding tests to disprove #6306
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8148 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-20 07:36:26 +00:00
davidpersson
bbfee7ba17 Updating Xml class to always use #document as the very root node and to create a node below it if the root option is set.
Adding test. 
Fixes #6294

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8147 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-17 13:26:07 +00:00
renan.saddam
bd7bd5d891 Fixing issue when generating textarea with null value.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8146 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-16 18:12:01 +00:00
mark_story
8db4fe682b Allowing name attribute to pass on to hidden field in FormHelper::radio().
Fixes inconsistency with checkbox().  Test case added.
Fixes #6260

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8145 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-15 17:18:01 +00:00
mark_story
377108f930 Adding tests to show correct usage of form::create() with querystring params. Closes #6278
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8144 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-15 02:29:50 +00:00
mark_story
32107f5fba Fixing test broken in [8136]. Adding Configure::write() to prevent fails when running helpers as a group.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8143 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-15 02:14:04 +00:00
mark_story
97652231a0 Fixing RequestHandlerComponent::prefers() with array input. Test case updated. Fixes #6290
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8141 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-14 13:16:25 +00:00
jperras
066629d566 Removing hard-coded 'id' field from Model::_prepareUpdateFields. Fixes #6274.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8139 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-13 14:15:58 +00:00
the_undefined
bf2829a896 Fixed bug related to the order in which some replacement take place
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8138 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-09 13:15:43 +00:00
mark_story
9491e4632d Applying patch from 'SkieDr' to fix custom find type pagination. Removes parameters from exiting paginate(). Test case added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8137 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-07 14:56:30 +00:00
mark_story
5f4cdf91ac Fixing AjaxHelper::dragOptions to match scriptaculous docs.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8136 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-06 00:57:46 +00:00
mark_story
5c4f838f5a Adding buffer flush to ajax helper test. Test suite menus now properly display.
Fixing Drag options.  Adding test coverage. Fixes #6266

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8135 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-06 00:45:53 +00:00
mark_story
d74e2d1a73 Fixing newline escaping for single quote strings, output now matches json_encode().
Test added, and old test fixed.
Fixing buffering issues, causing test suite menu to disappear when running JavascriptHelper Test case.
Fixes #6167

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8134 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-04 02:42:46 +00:00
davidpersson
392a6b195d Adding tests for Folder::copy and ::move showing that
skipping existing subdirectories is the intended behavior.
Disproves #6529.  Refs #6529.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8133 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-01 17:54:25 +00:00
mark_story
6551e2a45d Adding test for file input creation on hasOne relationship. Refs #6223
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8132 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-28 02:46:23 +00:00
davidpersson
5d23f46118 Adding tests to disprove #6236. Closes #6236.
Removing return from testWriteEmptyValues method to enable the test.
Updating CacheTest to revert settings changed in the tests.



git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8131 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-26 20:40:45 +00:00
renan.saddam
9f0cbb00ce Adding tests to Session Save Handler callbacks. Refs #6229.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8130 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-26 14:25:47 +00:00
mark_story
0516fb2090 Enabling disabled attribute to be passed to hidden input when making checkboxes.
Test case added. 
Fixes #6226

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8128 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-25 16:58:29 +00:00
jperras
4439bc4f70 Fixing regression in PaginatorHelper. Adding tests for PaginatorHelper::sortDir, as well as fixing incorrect test for sorting with Model.field dot notation. Fixes #6218.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8125 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-22 18:59:53 +00:00
mariano.iglesias
364fe18208 Adding test to disprove issue. Closes #4693
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8124 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-22 13:09:50 +00:00
davidpersson
fd7d6718a1 Updating tests to not affect other ones when run from a group
Adding NoCrossContamination group
Shortening group class names
Renaming lib_controller group
Updating test imports to include the core AppController by default
Some cosmetics




git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8123 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-21 23:55:39 +00:00
jperras
641a48342b Adding test for Auth login redirect to url with query string parameters. Disproves #6211.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8118 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-19 18:37:54 +00:00
gwoo
5c53fcfcb9 fixes #6209, persistModel and undefined $Behaviors
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8117 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-19 18:27:49 +00:00
davidpersson
3c3b852099 Changing package of tests from "cake.tests" to "cake".
Moving tearDown et al. to the top of each test class.
Adding short descriptions to docblocks.
Adding missing docblocks.
Removing unnecessary blank lines and whitespaces.
Updating labels of test groups.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8116 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-18 17:55:58 +00:00
renan.saddam
76e0f17dbc Updating documentation to improve code completion
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8114 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-17 21:10:28 +00:00
gwoo
de5907326e fixes #6203, Model::invalidFields respecting Model::whitelist
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8113 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-17 18:19:12 +00:00
davidpersson
0ead89639a Adding tests for Controller::redirect.
Proves #6200 is invalid. 
Making original tests more strict.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8110 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-16 14:07:26 +00:00
mariano.iglesias
a9062e2e02 Adding new email validation
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8109 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-16 12:54:25 +00:00
gwoo
056402efa7 moving checks for Set::extract() so that null will be returned when empty data is passed and classicExtract is expected.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8105 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-15 19:39:35 +00:00
phpnut
e3b027288b Removing unused setting in Session configuration.
Fixed bug in CakeSession::watch(); that allowed setting multiple vars to watch and CakeSession::ignore(); would only unset the first one found.
Fixed errors being thrown when testing database sessions and the database was dropped before script process ended.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8103 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-15 00:27:25 +00:00
davidpersson
70f18af78d Adding Folder tests, fixes cases where ordered directory entries were expected
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8100 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-15 00:10:53 +00:00
mariano.iglesias
f1d25bcc20 Removing need to explicitly set IDs for Containable test, added in r6989
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8098 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-14 22:24:42 +00:00
gwoo
198548092b cleaning up some Set::extract, adding tests for empty data and results. Removing some checks from Cache engine.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8097 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-14 19:56:28 +00:00
nate
36d3540c19 Adding native-type-generation fixes for JavascriptHelper::object()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8095 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-13 14:49:00 +00:00
gwoo
de6541f658 fixes #6189, paginator sort direction for associated fields of the same name
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8092 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-12 17:11:08 +00:00
mariano.iglesias
fdbf102228 Fixing issue where disallowing plugin was not possible in PaginatorHelper, fixes #6159
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8090 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-11 19:24:06 +00:00
nate
92cc331341 Updating docblocks and code formatting in XML classes, adding test change to previous commit.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8089 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-11 04:09:35 +00:00
nate
4466c9f7b7 Reverting changes to Behavior so that all models use the same behavior instance, fixes #6038, refs #4408.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8087 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-11 00:06:41 +00:00
the_undefined
55e72bb749 Better support for regex matching, fixes #6184
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8086 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-10 20:20:32 +00:00
nate
cb95f13608 Correcting issue in String::insert() where 0 offsets were handled incorrectly, affecting issue where values were not properly quoted and inserted into conditions strings. Fixes #6163.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8085 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-09 20:03:02 +00:00
nate
eea46e7cc8 Fixing issue where calculated columns were getting quoted incorrectly. Test included. Reformatting code to be 100 characters or less.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8084 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-09 18:36:32 +00:00
mark_story
c164be8c03 Enabling Asset.timestamp for HtmlHelper::image() making it consistent with Javascript::link().
Tests added.
Fixes #6170

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8078 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-06 04:40:50 +00:00
mark_story
18a7115385 Adding test to show proper escaping of escaped strings in Javscript::object() closes #6167.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8076 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-06 03:53:31 +00:00
jperras
79cba70758 Updating number helper to allow output of main currency symbol in the 'after' slot. Also added some basic i18n for NumberHelper::toReadableSize Fixes #6150.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8069 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-03 15:32:12 +00:00
mark_story
d9cbb85488 Adding test case for RequestHandler::beforeRedirect() when request is an ajax request. Ensures that requestAction() is properly triggered.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8068 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-01 06:11:03 +00:00