adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 11:28:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
16393 commits 7 branches 0 tags 44 MiB
Commit graph

16393 commits

This branch
This branch
All branches
Author SHA1 Message Date
mark_story
d7d8fc00d1 Check data with isset() before accessing it. 
Don't blindly access data that may not exist.

Fixes #2712
 2014-01-25 22:15:47 -05:00
mark_story
cf16ae055f Remove pointless code. 
After the changes in #2709 this code just heats the earth.
 2014-01-25 22:13:42 -05:00
Mark Story
82aa048acc Merge pull request #2709 from MelvinRoss/url-fix 
Fix double url decoding bug
 2014-01-25 19:10:44 -08:00
Melvin.Ross@gmail.com
7f496fad94 _Trailing_ and $this->keys also do not need to be urldecoded. Both _trailing_ and $this->keys gets set in _writeRoute, which also makes the regex that used to create the array $route. 
Any keys in $route that match [_trailing_] or any values in $this->keys are put there through the exection of preg_match. The URL is decoded before being passed to preg_match, which means the values
inside of [_trailing_]etc. have already been decoded.
 2014-01-24 17:44:31 -06:00
Melvin.Ross@gmail.com
83f37e48a9 Fix typo that removed '$' from '$key' 2014-01-24 16:33:59 -06:00
Melvin.Ross@gmail.com
8d6814e63f Remove rawurldecode from the _parseArgs function in CakeRoute since urldecode is already called on the URL string in CakeRoute::parse() when creating the $route array that is passed to _parseArgs. 
The result of the double urldecodes is parameters with meaningful '%' signs being stripped away on accident, and the web server reporting that the requested address doesn't exist.
 2014-01-24 16:14:58 -06:00
José Lorenzo Rodríguez
ddf046a246 Merge pull request #2694 from bar/patch-3 
Correctly remove routing url from query string.
 2014-01-22 05:15:03 -08:00
mark_story
61dd1c3f9d Fix trailing whitespace. 2014-01-21 20:23:12 -05:00
Ber Clausen
5b4121f643 Update tests. 2014-01-21 16:56:37 -03:00
ber clausen
d241a06a65 Correctly remove routing url from query string. 
It mostly happens when in nxing setups, because of location defined like:

try_files $uri $uri/ /app/webroot/index.php?$uri&$args;
 2014-01-21 16:57:46 -02:00
mark_story
b4e56c9989 Merge branch 'issue-2667' 
Fixes #2667
 2014-01-18 21:54:31 -05:00
mark_story
55e1619c59 Fix issue with find(count) and TranslateBehavior. 
Fixes #2667
 2014-01-18 21:54:09 -05:00
Rob McVey
7a27650297 Test case that demonstrates issue with count and Translate 2014-01-18 21:49:07 -05:00
mark_story
46eda802e5 Fix mising connection parameter to schema objects. 
When calling create/update the created schema object should be passed
the current connection.

Fixes #2668
 2014-01-16 17:19:22 -05:00
mark_story
f25e84f4fb Don't select year 0 when there are all 0's. 
Year 0 is almost never a 'good' selection value and causes odd behavior
when paired with MySQL.

Fixes #2658
 2014-01-15 10:23:45 -05:00
Christian Winther
ace586e367 Merge pull request #2656 from makusu/fix-debugger-templates-array 
fix multiple log array key definition on templates property in Debugger
 2014-01-14 23:29:05 -08:00
Max Meiden Dasuki
9cc7c465d1 fix multiple log array key definition on templates property in Debugger 2014-01-15 15:14:00 +08:00
Mark
db1e7c13fb Merge pull request #2635 from bcrowe/hotfix-timeDocBlock 
Simple docblock updates to CakeTime
 2014-01-08 18:40:57 -08:00
Bryan Crowe
cd27012405 Simple docblock updates to CakeTime 2014-01-08 21:38:45 -05:00
Mark Story
9bf7513ba9 Merge pull request #2628 from pummra/patch-1 
Add message to let user know that no controllers were generated.
 2014-01-08 06:43:12 -08:00
mark_story
b20ca3f4e0 Fix errors with postgres tests. 2014-01-08 09:42:13 -05:00
pummra
5605ff48ab Update ControllerTask.php 
Removed $admin from message in regards to no controllers being baked in all() function
 2014-01-08 12:23:03 +00:00
pummra
a981c7fa8c Removed trailing whitespace. 2014-01-08 10:16:06 +00:00
pummra
0214ac403e Update ControllerTask.php 
Updated if statement for clarity and also fixed spelling mistake.
 2014-01-08 10:10:40 +00:00
pummra
d41bb0b1b3 Update ControllerTask.php 
Added an output message if no controllers are baked using the all() function.
 2014-01-08 09:52:05 +00:00
mark_story
caf350c01f Exclude lib/Cake/Test when building pear packages. 
The core tests include a number of files that cause grief when the
cakephp pear package is installed via composer. Excluding the core tests
solves all of these problems and makes a smaller package which is nice.

Fixes #2620
 2014-01-07 10:06:50 -05:00
mark_story
312b2c3cd1 Merge branch 'translate-patch' 2014-01-06 21:21:25 -05:00
mark_story
3763350667 Add test for issue #2595 
Fold conditions that did the same thing and add a test case.

Closes #2595
 2014-01-06 21:21:13 -05:00
Mark Story
53c8b4ff05 Merge pull request #2612 from dereuromark/master-fixture 
Clearer error message when fixture insertion fails.
 2014-01-06 18:13:37 -08:00
euromark
ecfd64c082 adding test 2014-01-06 21:07:00 +01:00
euromark
865ca7acd6 wording 2014-01-06 20:43:30 +01:00
euromark
1201887ad1 Clearer error message 2014-01-06 20:42:17 +01:00
Raffaele
a4f138813b Return value if value are 0 
Save correctly if the value is 0, but after the find is returned as an empty string.
 2014-01-03 15:46:09 +01:00
ADmad
cfa104577f Merge pull request #2593 from dereuromark/master-hotfix 
Correct casing.
 2014-01-03 03:41:11 -08:00
euromark
3d51bfee3b Correct casing. 2014-01-03 04:09:19 +01:00
Mark Story
4ae1feaf2d Merge pull request #2571 from cuppett/patch-1 
Must double quote the schema name in query
 2013-12-30 08:18:22 -08:00
ADmad
f37eb9ad4b Merge pull request #2572 from bcrowe/hotfix-controllerBlocks 
Update some grammar in Controller
 2013-12-29 21:30:01 -08:00
Bryan Crowe
49bb441cef Update some grammar in Controller 2013-12-30 00:13:26 -05:00
mark_story
85d72443b6 Remove ext-mbstring dependency. 
mbstring is not a hard dependency for 2.x. The Multibyte class can shim
up the missing extension.

Refs #2564
 2013-12-29 23:49:17 -05:00
Mark Story
107f883223 Merge pull request #2570 from dereuromark/master-pkpass 
Add missing pkpass mimetype
 2013-12-29 20:36:08 -08:00
Stephen Cuppett
ed749fdc97 Must double quote the schema name in query 
Schema names with reserved words such as "create" will fail this query without double quotes. 

Attempted prepared statement with ? placeholder. This failed with the following CakePHP error:

Error: A Database connection using "Postgres" was missing or unable to connect.	
The database server returned this error: SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near "$1" LINE 1: SET search_path TO $1 ^
 2013-12-29 21:43:56 -05:00
euromark
2f02d0c755 Add missing pkpass mimetype 2013-12-30 01:19:09 +01:00
Mark Story
b728bced73 Merge pull request #2564 from josegonzalez/master 
Added composer.json for CakePHP 2.x
 2013-12-28 16:08:03 -08:00
Jose Diaz-Gonzalez
c86f9ab3e5 Added composer.json for CakePHP 2.x 2013-12-28 18:24:22 -05:00
Mark Story
b682732c1e Merge pull request #2557 from rchavik/2.4-save-tree-invalid-scope 
2.4 save tree invalid scope
 2013-12-27 07:17:52 -08:00
Rachman Chavik
c4f8289b53 Fix test by checking against an empty array instead of false 2013-12-27 12:37:39 +07:00
Rachman Chavik
c48afae2dc Add test to prove issue when saving invalid tree data 2013-12-27 12:35:28 +07:00
mark_story
1daa27c0d7 Add tests for uncovered case of :0 replacements. 
There were previously no tests for the :0, :1 style replacement markers
in DboSource. In fact I didn't even know it was a 'feature'.
 2013-12-24 13:13:05 -05:00
Mark Story
1cb7e4f0ff Merge pull request #1635 from dereuromark/master-dom-ids 
Fix duplicate ID generation of for multiple checkboxes.
 2013-12-24 07:02:38 -08:00
euromark
b392254c92 fix cs 2013-12-24 15:20:32 +01:00