Commit graph

11354 commits

Author SHA1 Message Date
José Lorenzo Rodríguez
9fac0b92c6 Extracting JsBaseEngineHelper to its own file, fixing some JsHelper related test cases 2010-12-21 22:01:38 -04:30
José Lorenzo Rodríguez
43401c271a Fixing App::uses usage un CakeRouteTest 2010-12-21 21:46:12 -04:30
mark_story
04929ae1df Applying patch from 'Thorsten Buss'.
Fixes issues in DboSource, where mismatching types on join columns could result in incorrect query generation.
Fixes #708
2010-12-21 20:40:19 -05:00
mark_story
6f62c22cbc Fixing fencepost errors.
Splitting tests up into smaller groups.
2010-12-20 20:27:27 -05:00
mark_story
abc6a28eca Increasing code coverage. 2010-12-20 14:02:12 -05:00
mark_story
0b90195a52 Adding tests for creating next/prev links with querystrings.
Removing code that doesn't seem to do anything, no tests fail when its removed.
2010-12-20 13:59:09 -05:00
mark_story
d7e411650f Moving some tests around so its easier to figure out what's being tested.
Adding a querystring test.
2010-12-20 13:39:22 -05:00
José Lorenzo Rodríguez
3fff5d144a Making SessionHelper tests pass again 2010-12-19 23:58:47 -04:30
José Lorenzo Rodríguez
2cb2609a43 Making ThemeView test pass 2010-12-19 23:49:20 -04:30
mark_story
e5588f746c Reversing changes that required a : sigil for named parameters. Also removing ?foo style parameters for querystring args. Having two ways to create querystring args was not sitting well with me.
Tests updated.
2010-12-19 23:11:02 -05:00
José Lorenzo Rodríguez
b2ad8fe113 Removing constant TEST_CAKE_CORE_INCLUDE_PATH 2010-12-19 23:33:37 -04:30
José Lorenzo Rodríguez
5fa028839e Fixing paths location in cake.php files 2010-12-19 23:17:53 -04:30
José Lorenzo Rodríguez
827a74b734 Merge remote branch 'origin/2.0' into 2.0-class-loading 2010-12-19 23:12:37 -04:30
mark_story
b49b49a5ef Removing named parameter sigils. 2010-12-19 22:17:57 -05:00
mark_story
d3fc29c8e8 Adding more documentation to connectNamed().
Changing argSeparator -> separator, as it is less typing and easier to remember.
2010-12-19 21:49:17 -05:00
mark_story
025ba23886 Removing whitespace and adding some more documentation. 2010-12-19 20:05:57 -05:00
mark_story
4c3736a68a Making more tests pass with the named parameter changes. 2010-12-19 17:38:21 -05:00
mark_story
51e2b16d46 Removing pagination test from Containable test case, it doesn't make sense there. 2010-12-19 17:24:38 -05:00
mark_story
5df2678ba9 Fixing named params that were missing the : and fixing Router::reverse() so it adds in the : 2010-12-19 17:09:34 -05:00
mark_story
c83a4703a3 Implementing ability to change pagination params to use querystring variables.
Tests added.
2010-12-19 16:47:22 -05:00
mark_story
da46ad494b Deleting duplicate tests.
Moving a test out into a separate method.
2010-12-19 13:53:11 -05:00
mark_story
cc2d8e2fec Moving limit from the options to the normal paging params. This fixes a few notice errors. 2010-12-19 13:15:04 -05:00
mark_story
176d5520f6 Making paging params match those that would be generated by PaginatorComponent. 2010-12-19 13:09:52 -05:00
mark_story
8c3ceff50d Making paging.options only contain options that are not in the defaults. This replaces the many diffs that were calculated on each url generation between paging.options and paging.defaults. 2010-12-19 12:58:07 -05:00
mark_story
833bdbcc0b Reformatting paging params.
Removing defaults from the paging params as they are no longer being used.
2010-12-19 12:43:29 -05:00
mark_story
ef84d86cf5 Reformatting code, and removing merging of defaults key in the helper. It no longer exists. 2010-12-19 12:26:28 -05:00
mark_story
f54479e566 Adding some docblock info about pagination. 2010-12-19 12:20:12 -05:00
mark_story
e9d3fcf5cf Moving limit checking into a separate method, and adding tests.
Removing $scope from being passed down to the options, it previously only allowed additional conditions to be set.
Updated tests.
2010-12-19 11:58:35 -05:00
evilbloodydemon
78a376ebc4 upgrade shell - 'configure' subcommand 2010-12-19 17:06:45 +03:00
mark_story
1e741de84b Removing show alias, it was undocumented and untested. 2010-12-19 02:14:37 -05:00
mark_story
108a6611a8 Moving validation of sorting to a separate method. This makes it easier to test, extends and read.
Tests added.
2010-12-19 02:12:39 -05:00
mark_story
7b11eeb6e0 Updating tests to not use the deprecated Controller::$passedArgs.
Removing messy and hard to understand defaults + whitelisting from paginate() now that it has a separate method.
2010-12-19 01:57:51 -05:00
mark_story
6b3db0a3eb Pulling out parameter merging logic into a method, this allows specific typing of parameter merging (named, querystring, route). Also simplifies whitelisting of request parameters.
Tests added for merging and whitelisting.
2010-12-19 01:42:23 -05:00
mark_story
7585b2941e Adding paramType to the test cases. 2010-12-19 00:38:20 -05:00
José Lorenzo Rodríguez
5605bf2d9e Fixing failing test for HelperCollection 2010-12-18 22:32:20 -04:30
José Lorenzo Rodríguez
5f7ca8d2b6 Removing some internal chenck for the "driver" key in database configs 2010-12-18 22:27:55 -04:30
José Lorenzo Rodríguez
e8c73170ba Ficing a couple of notices when using a mocked CakeRequest 2010-12-18 22:27:28 -04:30
José Lorenzo Rodríguez
633f1dc1e5 Fixing warning in ConnectionManager 2010-12-18 22:27:02 -04:30
José Lorenzo Rodríguez
5e1b49918b Fixing App::core('cake') 2010-12-18 22:26:23 -04:30
José Lorenzo Rodríguez
151a4bdb33 Fixing view files finding and making tests pass 2010-12-18 22:09:08 -04:30
José Lorenzo Rodríguez
ad78f1dc74 Adding support for plugin classes back,
Allowing the user to override core classes in app/libs
Adding some backward compatibility for App::path() and App::build()
2010-12-18 22:07:30 -04:30
José Lorenzo Rodríguez
8bcabdea6a Fixing constants for test suite 2010-12-18 22:02:25 -04:30
José Lorenzo Rodríguez
5efa201b9b Moving recently created files into the new folders 2010-12-18 21:52:03 -04:30
mark_story
54c52d85fb Fixing failing tests in PaginatorComponent. 2010-12-18 17:29:47 -05:00
mark_story
6b9d9f4aea Reapplying changes in [33d2f9a6ed] as they got lost when the paginator component was extracted. 2010-12-18 17:17:43 -05:00
mark_story
a6cca7c036 Extracting a method from paginator component. 2010-12-18 17:09:30 -05:00
mark_story
7c6af5bfec Making a test actually test what its supposed to. 2010-12-18 17:01:26 -05:00
mark_story
319e622151 Added another test for querystring params. Querystring params should not be affected by greedy routes, as they are not really controlled by internal routing. 2010-12-18 16:51:54 -05:00
mark_story
eb9fe07472 Adding query string generation into CakeRoute. This removes one more task from Router. Tests added
Adding constants for the named param and querystring param sigils.
2010-12-18 16:44:21 -05:00
Juan Basso
5d2b4c758d Minor optimization in cache views. 2010-12-18 19:41:57 -02:00