Commit graph

1733 commits

Author SHA1 Message Date
mark_story
ad237ec681 Don't collect code coverage on every request. 2011-11-05 17:29:55 -04:00
mark_story
61d6a720d6 Add test for using autoMock and multiple redirects.
Having multiple redirects and not calling generate() before each test, or
using autoMock results in an exit.  This is related to
[c5ca10ca69] where controller re-use was removed.

Refs #2200
2011-11-05 17:28:13 -04:00
Graham Weldon
812e449680 Created a buffer for CakeResponse testing 2011-11-06 08:21:10 +11:00
mark_story
15753ab641 Apply patch from 'Carlos Gant'
Remove un-necessary loop when deleting without cascade.
Fixes #2050
2011-11-05 16:16:13 -04:00
Majna
3374406bbf Fix View task missing 'app' param when baking custom action. 2011-11-05 19:54:21 +01:00
mark_story
cd81f9c30a Fix comment in I18n
Move construction details to a protected constructor.
Fixes #2222
2011-11-05 08:19:57 -04:00
Marko Marković
4e702b2fae Updated test for debug
It now detects being called from CLI
2011-11-05 10:24:46 +01:00
mark_story
bfd95d0e04 Fixing remaining failing tests in PHPUnit 3.6 2011-11-04 22:54:09 -04:00
mark_story
d68053c4d4 Fix exception expectations.
PHPUnit 3.6 does not allow you to expect the generic Exception
class.
2011-11-04 22:54:08 -04:00
mark_story
13900dc75c Starting to fix issues with PHPUnit 3.6 compatibility. 2011-11-04 22:54:08 -04:00
Majna
1b9b90d2e7 Replacing 'driver' with 'datasource'. 2011-11-04 23:07:31 +01:00
Majna
1455c59e0c Fix notice when baking db config: Undefined variable 'driver'. 2011-11-04 22:49:38 +01:00
Marko Marković
c7363bb042 Updated tests for debug() 2011-11-04 19:43:43 +01:00
Jose Lorenzo Rodriguez
d74b64d475 Merge remote-tracking branch 'origin/2.0' into 2.1 2011-11-04 12:09:31 -04:30
Jose Lorenzo Rodriguez
b983aa9192 Small optimization in DboSource 2011-11-04 10:01:45 -04:30
Marko Marković
73429b357f Fixed inconsistent debug parameters and empty '(line )' 2011-11-04 14:58:06 +01:00
mark_story
0304bb8796 Merge branch '2.0' into 2.1
Conflicts:
	lib/Cake/Config/config.php
	lib/Cake/VERSION.txt
2011-11-03 22:04:00 -04:00
Jose Lorenzo Rodriguez
926ac32549 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-11-03 21:21:38 -04:30
Yosuke Basuke Suzuki
f861cc6e09 Proposal. Adding new package using App::build().
For instance, adding new 'Service' package to app search paths.
2011-11-03 21:47:28 -04:00
Jose Lorenzo Rodriguez
2711178b4b Fixing Content-Length calculation when there is buffered output that will be sent before the response body. fixes #2208 2011-11-03 21:09:30 -04:30
mark_story
a929951038 Fix issue with Controller::setAction()
Calling setAction did not modify which view file was
rendered.  This was a regression with 1.3

Fixes #2212
2011-11-03 20:13:41 -04:00
Majna
51ccbad170 Fixing ignored '--exclude-plugins' option on Windows for Extract task. 2011-11-03 21:34:32 +01:00
Jose Lorenzo Rodriguez
606c30b77f Releasing 2.0.2 2011-11-02 23:44:50 -04:30
mark_story
98a8f44fa7 Make formatting tag removal smarter.
Instead of removing all tags, only known
formatting tags.

Fixes #2203
2011-11-02 21:50:16 -04:00
mark_story
18a34c03a4 Fix issue where unknown exceptions would be squashed.
Fix issue where unknown exceptions with error codes that were not
in HTTP ranges would be ignored.  In development those messages
should display.

Fixes #2205
2011-11-02 21:21:48 -04:00
mark_story
201231cd42 Fix encoding issues with debug().
Fixes #2199
2011-11-02 13:45:34 -04:00
Jose Lorenzo Rodriguez
3fc6d293fc Fixing regression in ControllerTestCase after changes done in RequestHandlerComponent 2011-11-01 13:49:40 -04:30
Marko Marković
385f6f164f Fixed typos in css 2011-11-01 16:59:11 +01:00
Lubos Remplik
985dcad802 MimeType audio/ogg added 2011-11-01 08:17:36 -07:00
mark_story
f531e7f24b Fix UUID issue in SQLite
Only varchar(36) was interpreted as a uuid.  char(36)
should also be treated this way.  Most documentation refers
to this type.  Also char(x) fields should be treated as strings,
not text.

Fixes #2184
2011-10-31 23:10:48 -04:00
mark_story
550076d75e Fix issue in RequestHandlerComponent.
Fixes issues where response and request properties would
not be set as the initialize() callback would have not fired.

Fixes #2190
Fixes #2189
2011-10-31 22:41:43 -04:00
mark_story
6623b7dc9d Update generated cache files.
- Cache files should contain a response object on the controller.
  Without it bad things happen.
- Include the $request and $response contructor arguments for Controller.
- Update import -> uses()

Refs #2190
2011-10-31 22:27:43 -04:00
mark_story
bf43a5ee24 Fix whitespace and add usage to doc block. 2011-10-31 21:56:16 -04:00
Yasushi Ichikawa
4aeb5b461d delete App::uses Multibyte class. It is no longer needed. 2011-10-31 23:47:36 +09:00
Yasushi Ichikawa
f39c683130 check mbstring.func_overload before using strlen() 2011-10-31 23:29:59 +09:00
Yasushi Ichikawa
e53287583e return byte length instead of number of characters in Content-Length 2011-10-31 18:31:08 +09:00
Jose Lorenzo Rodriguez
7141dff5d1 Releasing 2.0.1 2011-10-30 18:28:32 -04:30
Jose Lorenzo Rodriguez
d49096aab9 Fixing DbConfigTask to produce correct configurations 2011-10-30 18:25:43 -04:30
José Lorenzo Rodríguez
f51be0a82c Merge pull request #278 from Danielpk/enhancement_auth_deny
Added enhancement to AuthComponent::deny().
2011-10-30 15:38:21 -07:00
mark_story
92f9a6c1db Fix missing urlencod/urldecode in routing.
Named params and passed args should be urlencoded, as they
may contain non-ascii characters.

Refs GH-214
2011-10-29 20:42:07 -04:00
Juan Basso
fcd96bcc60 Using native methods to query in HttpSocket. 2011-10-29 15:40:41 -04:00
mark_story
bcdf61a9d5 Adding escaping by default for TextHelper::autoLink()
TextHelper::autoLink, autoLinkEmails, and autoLinkUrls now all
escape HTML by default, this can be disabled using the escape => false option.

Fixes #1625
2011-10-29 12:08:43 -04:00
Daniel Pakuschewski
7cde0b654c Removed tests for deny('*') to prevent people get confused with it 2011-10-29 13:57:04 -02:00
Daniel Pakuschewski
09579198a9 Droped support to deny('*'). 2011-10-29 13:54:35 -02:00
Jose Lorenzo Rodriguez
66cf86c154 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-10-28 23:46:13 -04:30
Jose Lorenzo Rodriguez
60e3f02eac Setting a correct Content-Length for plugin assets 2011-10-28 23:45:31 -04:30
mark_story
ce9bb6b632 Fix validation detection in FormHelper
string values for validation means a single validation method.
That implies the field is required.

Fixes #2181
2011-10-28 21:35:43 -04:00
Mark Story
11e2ef6674 Merge pull request #281 from majna/2.0-schema-dump
Added missing 'write' param for schema dump shell. Fixes #2179.
2011-10-28 16:56:40 -07:00
Majna
14efc4daae Added missing 'write' param for schema dump shell. Fixes #2179. 2011-10-29 00:51:40 +02:00
Juan Basso
e682b446e6 Added space back to not break the test case. 2011-10-28 18:48:38 -04:00
Gun.io Whitespace Robot
4742168253 Remove whitespace [Gun.io WhitespaceBot] 2011-10-28 18:25:08 -04:00
AD7six
4fd3bccf78 don't have the version in 2 places 2011-10-28 12:12:28 +02:00
José Lorenzo Rodríguez
8945dcbf57 Adding test case for previous commit 2011-10-27 22:53:20 -05:30
José Lorenzo Rodríguez
29ca42ed7a Not sending a content-length for redirection status codes that are not supposed to have any content 2011-10-27 22:44:42 -05:30
Jose Lorenzo Rodriguez
9866882506 Not sending a content-length for redirection status codes that are not supposed to have any content 2011-10-27 23:18:49 -04:30
Jose Lorenzo Rodriguez
aabfad9a09 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-10-27 22:25:37 -04:30
Jose Lorenzo Rodriguez
4a453cc384 Fixes #2175
Adding automatic Content-Length header to hint browser of the end of the response when using persistent connections
2011-10-27 22:15:37 -04:30
mark_story
adf52235d0 Make h() not puke when objects are passed in.
This can happen in the default Exception rendering,
if an object is in the viewVars.
2011-10-27 21:30:50 -04:00
mark_story
8529d76e6f Removing Xml prolog from default xml layouts.
Both DOMDocument and SimpleXML output the prolog when
saving xml.

Fixes #2171
2011-10-27 20:58:03 -04:00
Jose Lorenzo Rodriguez
95acaba295 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-10-27 10:06:30 -04:30
Renan Gonçalves
53be552370 Fixing use of options['exclude'] in Debugger::trace(), tests added. 2011-10-27 16:01:54 +02:00
Daniel Luiz Pakuschewski
eb6c07f77e Fixed: _passedArgs now is _passedVars 2011-10-27 10:16:38 -02:00
Daniel Luiz Pakuschewski
24bb6663ab Fixed typo 2011-10-27 10:10:57 -02:00
mark_story
24fd87398d Fix issue with 0.Model.field inputs.
These inputs would be incorrectly prefixed with another Model name.
2011-10-26 23:46:15 -04:00
Jose Lorenzo Rodriguez
bc8b522eec Merge remote-tracking branch 'origin/2.0' into 2.0 2011-10-26 22:33:24 -04:30
Jose Lorenzo Rodriguez
ee7f417085 Test to disprove #2123, it is possible to load classes in plugin's Lib directory. App::uses() is intended for classes not procedural files. 2011-10-26 22:33:14 -04:30
mark_story
43df8d34e7 Use String::tokenize() to split up fields.
It is slightly more intelligent than explode()
Solves basic problems in Sqlite with virtualFields.

Fixes #2163
2011-10-26 21:17:20 -04:00
m
010abd9e18 Inheritance fix for CakeTestCase
Fix overriden methods to be static like other methods in
PHPUnit_Framework_Assert.
Fixes #2170

Signed-off-by: mark_story <mark@mark-story.com>
2011-10-26 20:28:42 -04:00
Daniel Luiz Pakuschewski
8738ef3dc2 Added tests to deny() and deny('*') 2011-10-26 22:07:57 -02:00
Daniel Luiz Pakuschewski
5246e7dd1d Allow AuthComponent to deny all actions with single deny() or deny('*') 2011-10-26 22:07:17 -02:00
ADmad
1244656595 Prevent unneeded afterFind callback triggering on associated models. Fixes #2057 2011-10-26 19:36:32 +05:30
ADmad
8473d6a660 Fixed code formatting 2011-10-26 13:00:52 +05:30
mark_story
ad524b25ef Merge branch '2.0' into 2.1 2011-10-25 22:29:03 -04:00
m
5a5a542a71 Missing ini_set of include path for test.php
Fixes #2167

Signed-off-by: mark_story <mark@mark-story.com>
2011-10-25 22:26:59 -04:00
Maggion Emmanuel
3dc9fee5c0 Typo 2011-10-25 22:22:10 -04:00
mark_story
c2c63d373c Fix incorrect field detection for habtm fields.
Fields on habtm models would always be treated as multiselects.
Even when there were additional fields specified.

Fixes #2153
2011-10-25 22:21:27 -04:00
mark_story
5efddd11c8 Add comment for test. 2011-10-25 21:08:56 -04:00
mark_story
477c492e86 Fix issue where named parameters would not be urldecoded.
Fixes #2155
2011-10-25 21:07:27 -04:00
mark_story
7547d2c2d1 Update doc block concerning plugins.
Fixes #2146
2011-10-25 20:33:55 -04:00
mark_story
d92c73d821 Remove reference to XmlHelper.
Refs #2164
2011-10-25 20:16:58 -04:00
mark_story
e80c548887 Update link on home page.
Fixes #2159
2011-10-25 12:36:13 -04:00
m
dcc17f2091 ucfirst object names part two (Folder/File)
Signed-off-by: mark_story <mark@mark-story.com>
2011-10-24 21:36:48 -04:00
mark_story
621cb43e93 Add Opera Mobi to mobile detectors.
This was missed in a merge with 1.3.
Fixes #2087
2011-10-24 21:12:06 -04:00
mark_story
bd87400131 Fix inflection for words ending in media.
Fixes #2149
2011-10-24 21:05:56 -04:00
fiblan
9c4a9bbd06 Fix missing prefix when reading table schema.
When using prefixes, table metadata would be lost.
Fixes #1522

Signed-off-by: mark_story <mark@mark-story.com>

Conflicts:

	lib/Cake/Model/CakeSchema.php
2011-10-24 20:40:47 -04:00
Majna
42042c2a76 Fixing incorrect theme view doc block. 2011-10-24 16:32:19 +02:00
mark_story
d6bf1479c8 Add documentation and test for FormHelper::select()
An alternate syntax was undocumented and untested.  Fix that.
Refs #1794
2011-10-23 22:27:07 -04:00
mark_story
c3f647217d Implement trailing greedy star star.
Trailing args grabs all trailing arguments as a single passed
parameter.  This is useful when you want to have trailing arguments
that contain / in them.
2011-10-23 21:27:28 -04:00
mark_story
d6f7669f54 Merge branch '2.0' into 2.1 2011-10-23 21:07:09 -04:00
mark_story
d62351eb36 Revert the changes done to remove the 'cake' domain
After some discussion, polutting the app POT file
with unchanging Cake strings was incorrect.  Having these
strings in a separate POT file allows reuse of translations across
projects.

Refs #2103
2011-10-23 20:36:31 -04:00
Majna
a9dbde0cbd Fixing incorrect doc blocks regarding error handler. 2011-10-23 21:55:20 +02:00
mark_story
205d75587c Move registration of CakePlugin.
Move the uses() call to Cake/bootstrap.php
CakePlugin is used by App, and should be loaded along with
other core classes like Configure and Cache.

Fixes #2147
2011-10-23 13:54:13 -04:00
mark_story
e457c14dec Fix issues with stateless authentication.
Cookies and sessions are no longer required for stateful authentication.
AuthComponent::user() also works correctly in these situations as well.

Fixes #2134
2011-10-23 12:54:51 -04:00
James Larking
75daff8df9 Camelize type of test being generated.
This fixes use for:

`cake bake model ModelName`

When classTypes and directories should be CamelCase.
This solves issue whereby model tests are written directly to Cases folder rather than into Cases/Model

Signed-off-by: mark_story <mark@mark-story.com>
2011-10-23 11:13:56 -04:00
mark_story
ab77afbaec Adding tests for lowercase type names. 2011-10-23 11:11:07 -04:00
mark_story
72006b9369 Fix options in OptionParser for TestTask
Fix the allowed options for type to allow Camelcase versions as well.
2011-10-23 11:10:52 -04:00
mark_story
30225520ff Update assertEqual to assertEquals. 2011-10-23 10:44:19 -04:00
mark_story
b02155e766 Remove tests, that interact with RedirectRoute.
RedirectRoute now has exit() in it.  This makes hitting those
routes in testing dangerous.
2011-10-22 23:27:04 -04:00
mark_story
6d6aa3cb75 Add _stop() to RedirectRoute.
Moved from CakeResponse to RedirectRoute,
as RedirectRoute is the only place its currently needed.

Refs #2143
2011-10-22 22:56:50 -04:00
mark_story
8e69df9013 Revert "Fix RedirectRoute by stopping execution."
This reverts commit 841e7aa560.

Having _stop() on CakeResponse seemed like the wrong place to stop
execution.  It can make testing with redirects harder.
Instead RedirectRoute should be stopping execution.
2011-10-22 22:44:21 -04:00
mark_story
32b48ecc7c Fix issue with missing base on redirect route.
The request data wasn't set in Router when redirect routes are processed.
This caused the base to become missing. This causes issues with applications
running in a subdirectory.
2011-10-22 18:48:31 -04:00
Majna
841e7aa560 Fix RedirectRoute by stopping execution.
If CakeResponse sends a Location header, it will stop execution.
This fixes issues with where a body would be sent with redirect headers.
Tests updated.

Fixes #2143
2011-10-22 13:22:28 -04:00
mark_story
f0ca6e4a99 Merge branch '2.0' into 2.1 2011-10-22 12:53:27 -04:00
mark_story
7b169ed084 Fix broken tests. 2011-10-22 12:53:10 -04:00
mark_story
ab6aab8a1a Merge branch '2.0' into 2.1 2011-10-22 11:03:42 -04:00
Daniel Pakuschewski
318ea27c8d File::info() return the file size. 2011-10-22 11:01:22 -04:00
mark_story
c5ca10ca69 Remove controller reuse between testAction() calls.
Reusing controllers between various testAction calls would
mean that calls that needed to render views, would break on the
second call to testAction().  Controllers are rebuilt for each testAction()
call now.

Fixes #2142
2011-10-22 10:58:21 -04:00
Graham Weldon
b165acd926 Fixed EmailComponent test 2011-10-23 00:28:47 +11:00
Graham Weldon
212028cda2 Remove comments, and fix debug transport for email. 2011-10-23 00:23:50 +11:00
Graham Weldon
2844f4a477 Fixed sending BCC with DATA for CakeEmail, as well as 7->8bit conversion tests passing 2011-10-23 00:20:37 +11:00
Graham Weldon
f8697ccb55 Added skip if mbstring not available 2011-10-22 17:52:41 +11:00
Graham Weldon
7ed6e041b9 Changed getContentTransferEncoding to protected 2011-10-22 15:24:26 +11:00
Graham Weldon
51dd024a1a Merge remote-tracking branch 'origin/2.0' into 2.0 2011-10-22 14:55:53 +11:00
mark_story
fe9e595913 Fix issue with postgres and virtualFields
If a virtualField was set to a literal value it would be quoted.
Test added.

Fixes #2085
2011-10-21 22:17:48 -04:00
mark_story
7e89442a13 Make App::_loadVendor() static.
Fixes strict warnings.
Fixes #2137
2011-10-21 20:37:24 -04:00
Ceeram
4d795a7383 ensure SmtpTransportTest passes, always use localhost as hostname 2011-10-21 15:02:53 +02:00
Renan Gonçalves
d9e8b3b6a2 Parsing every parameter until there is no more. Good to have alias but with the ability to override the arguments. 2011-10-21 12:20:43 +02:00
mark_story
0bb9f3f99e Fix failing test caused by changes in debug(). 2011-10-20 21:42:14 -04:00
mark_story
7b9acc5c16 Fix failing test caused by addition of TestShell. 2011-10-20 21:39:58 -04:00
mark_story
52010a3e9d Fix double encoding in debug(). 2011-10-20 21:38:31 -04:00
mark_story
0cf389e3ce Fix broken AllTests. 2011-10-20 21:24:54 -04:00
mark_story
eb17653965 Implement $request->is('requested');
Add tests and new detector type for request parameters
Fixes #1995
2011-10-20 21:11:42 -04:00
mark_story
9f80004920 Remove unused parameter. 2011-10-20 20:14:30 -04:00
Ceeram
2890e6659e Fixing execute() $this->_result was not instance of PDOStatement after queries other then SELECT, lastAffected() now returns correct integer 2011-10-20 14:27:48 +02:00
AD7six
53bc963315 Merge branch '2.0' into 2.1 2011-10-20 08:57:49 +02:00
mark_story
a7404e8e83 Remove more incorrect __d() calls. 2011-10-19 23:25:22 -04:00
mark_story
71a55f52f8 Fixing incorrect translation usage. 2011-10-19 23:21:43 -04:00
mark_story
535b45b600 Fix strict warnings on Validation class. 2011-10-19 23:18:46 -04:00
mark_story
25e9aaf6c8 Removing the remaining cake domain translations.
3rd time is a charm.
Fixes #2103
2011-10-19 23:09:21 -04:00
mark_story
7c70b371bf Removing the rest of the 'cake' domain.
These string should all be part of the app POT files.
Fixes #2103
2011-10-19 22:55:50 -04:00
mark_story
bca6492309 Update debug()
debug() now uses Debugger to output content and generate traces.
This improves the readability of its output as null/true/false are better
represented.  Objects are easier to interpret as well.
2011-10-19 22:27:55 -04:00
mark_story
986b7d3eaa Updating other debugger tests. 2011-10-19 22:27:55 -04:00
mark_story
49f687b0c4 New Debugger::exportVar() formatting.
Better resembles var_dump().
Includes types, and is less noisy to read than before.
2011-10-19 22:27:55 -04:00
mark_story
183ffb29d7 Improving the exception stack traces.
Adding Debugger::getType()
2011-10-19 22:27:55 -04:00
mark_story
f5ae9622e6 Add missing argument.
Without this argument calls with two arguments would be
treated as invalid shell commands.
2011-10-19 22:26:51 -04:00
mark_story
edfb0884c8 Adding test for form->submit() and timestamps.
Conflicts:

	lib/Cake/Test/Case/View/Helper/FormHelperTest.php
2011-10-19 21:53:47 -04:00
Johannes N
30504ef32b Enable Asset timestamp for image submit buttons.
Conflicts:

	lib/Cake/View/Helper/FormHelper.php
2011-10-19 21:51:18 -04:00
mark_story
7a4aa401d1 Adding backwards compatible plugin syntax.
Thie got lost during 2.0, and it inflecting only the shell name
is kind of bad.
2011-10-19 21:33:03 -04:00
mark_story
bad819773e Update CommandListShell to give better help.
plugins require plugin prefixes now.  Update the help
to suggest how to run plugin shells.

Fixes #2121
2011-10-19 21:26:31 -04:00
Mark Story
714e2812bc Merge pull request #261 from rchavik/misc
display model and field that is causing schema generate to fail
2011-10-19 17:27:47 -07:00
Rachman Chavik
a02fd82db2 display offending model and column 2011-10-20 07:07:42 +07:00
Jose Lorenzo Rodriguez
3735c7db67 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-10-19 16:47:58 -04:30
Jose Lorenzo Rodriguez
d666d6175a Improving the upgrade shell by adding more renaming rules and making it more robust in case insensitive systems 2011-10-19 16:46:55 -04:30
ADmad
6d51ce54fe Revert "Fixed failing smtp tests when testing on host other then hardcoded 'localhost'."
This change you cause the tests to fail when run through CLI

This reverts commit f361509f10.
2011-10-20 00:49:43 +05:30
Majna
f361509f10 Fixed failing smtp tests when testing on host other then hardcoded 'localhost'. 2011-10-19 20:34:02 +02:00
Norio Suzuki
712822ef83 add some test for ISO-2022-JP charset mails 2011-10-20 00:18:42 +09:00
Renan Gonçalves
fe9762d053 Making the test assert what it is intended to assert. 2011-10-19 16:48:03 +02:00
Renan Gonçalves
d1be66f2e1 Fixing failing test introduced in fb4a003522. 2011-10-19 15:57:46 +02:00
Renan Gonçalves
646b8f1aa0 Fixed issue when using multiple extensions in Router::parseExtensions() could result in undefined index notice by RequestHandlerComponent. 2011-10-19 15:36:00 +02:00
Rachman Chavik
a60d71d19b removing 'empty' files from nonempty directories 2011-10-19 12:19:28 +07:00