adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
19605 commits 7 branches 0 tags 44 MiB
Commit graph

944 commits

Author SHA1 Message Date
Albert Peschar
2121cdc43c Remove String class 2022-03-03 10:27:13 +02:00
Albert Peschar
d9247a0832 Use array_values to avoid named parameters error 2022-01-31 17:02:07 +00:00
Markus Podar
d201312a0e
php-8.0-compat: fix "Error: Unknown named parameter $subject" 
PHP 8 added support for named parameters however will throw an error when
a named parameter, which does not exist, will be called/appears.

In this case the code uses `array_filter(compact('subject))` to conveniently
prepend `$subject` to the callback, if it's non-null.

It's then combined with `$params` but mixing a hash wih a sequential array
and then end result is `['subject' => …, ]` which then triggers this
TypeError in PHP 8.

The solution applies `array_values()` on above array as to remove the keys
and then the error disappears.

With this change, our internal test suite (2k tests) is green on both PHP8
and PHP7.4, aka this change is expecte to be backwards compatible.
 2020-11-12 17:30:04 +01:00
othercorey
01d5d039f3
Use random_int with PHP 7 2020-05-23 11:12:46 -05:00
Richard van den Berg
63c01dfbab Generate truly random uuid() 2020-05-23 15:38:41 +02:00
Markus Podar
459ee900fe
php-7.4-compact: replace deprecated curly brace offset access 
Per https://wiki.php.net/rfc/deprecate_curly_braces_array_access and https://www.php.net/manual/en/migration74.deprecated.php
>  The array and string offset access syntax using curly braces is deprecated. Use $var[$idx] instead of $var{$idx}.
 2020-03-20 21:10:58 +01:00
bancer
7e1fef4066 Improve doc block 2019-05-06 14:21:24 +02:00
bancer
bb20b4f419 Change private method to protected 2019-01-31 09:49:41 +01:00
bancer
e94183c6d8 Give a better name to a new function 2019-01-29 09:16:48 +01:00
bancer
ec5bac5e52 Fix timezone adjustment in CakeTime::nice and CakeTime::niceShort 2019-01-25 13:56:50 +01:00
bancer
c855ef874b Simplify i18nFormat 2019-01-25 12:25:26 +01:00
bancer
009d69b3f7 Fix code style errors 2019-01-25 12:21:34 +01:00
bancer
044e8f24af Fix timezone conversion 2019-01-25 12:05:44 +01:00
bancer
7911bb9052 Remove unnecessary timezone offset manipulation 2019-01-24 15:43:11 +01:00
Joseph Zidell
44f4fe27bf
Fixes docblock for Folder constructor 2018-12-12 22:45:41 -05:00
Val Bancer
90ddb43632 Fix some PHP 7.3 errors 2018-11-11 16:15:55 +01:00
bancer
85cc215293 Improve documentation 2018-10-26 14:23:30 +02:00
Val Bancer
3c9d46864e
Improve documentation 
The parameter description is copied from `CakeLog::write` method.
 2018-10-26 09:54:23 +02:00
Val Bancer
e825823e9a
Improve documentation 2018-10-22 10:02:51 +02:00
Val Bancer
b97530977d
Improve documentation 2018-10-19 16:54:05 +02:00
Val Bancer
8e8fbae78c
Improve documentation 2018-10-19 16:45:21 +02:00
Joseph Zidell
59fe9f55c2
Augment docblock for Hash::combine() 
Adds array as possible types for `Hash::combine()` for `$keyPath` and `$valuePath` params.
 2018-09-20 22:00:03 -04:00
Joe
34bfeba15d Fixes failing tests 2018-09-03 00:45:34 -04:00
Joe
a4e71b3b40 Fixes: 
* Issue with preg_match()
* Undefined variables
 2018-08-21 14:46:58 -04:00
chinpei215
a6b0271560 Remove Security::engine() 
We disscussed and decided to avoid auto selecting which extension to use.
Instead, call Configure::write('Security.useOpenSsl', true) manually.
 2018-02-24 12:17:51 +09:00
chinpei215
fc397bd481 Pass MCRYPT_DEV_URANDOM to mcrypt_create_iv() explicitly 2018-01-20 00:25:35 +09:00
chinpei215
5289aae64e Change Security::randomBytes() to fallback to mcrypt_create_iv() 2018-01-19 23:54:58 +09:00
chinpei215
d7ed0339b1 Make mcrypt optional 
Now Security::encrypt() and Security::decrypt() works with openssl
if the mcrypt extension is unavailable.
Note that Security::rijndael() doesn't work with openssl.
 2018-01-19 23:54:53 +09:00
Milan van As
7de5ae4438 Force email domain lookups to work in fallback case. 2017-10-25 08:45:57 +02:00
Mark Story
fb44035177 Merge pull request #11299 from tenkoma/2.x-fix-cc-number-jcb-pattern 
[2.x]Fix Credit card number pattern(JCB) is wrong
 2017-10-08 10:09:19 -04:00
Koji Tanaka
7d2d902b57 [2.x]Fix Credit card number pattern(JCB) is wrong 2017-10-08 16:15:10 +09:00
chinpei215
deac8f9109 Backport #7080, #8233 and #11060 2017-10-06 22:02:37 +09:00
chinpei215
ccf634e5f3 Docblock update 2017-10-06 21:59:48 +09:00
LustyRain
e1e5a292f2 Fix: revert return 2017-10-05 00:09:51 +09:00
LustyRain
1f09318724 Fix delete space, restored return 2017-10-04 20:40:57 +09:00
LustyRain
8bb07c0fd7 Fix called twice 2017-10-04 11:39:31 +09:00
LustyRain
31b13edf8a Fix: phpdoc miss 
## did
- void unReturn
- miss return void
- add return type
- type miss typing
- add param type and return type
  - string → string|array
- change ClassName
 2017-10-04 00:22:42 +09:00
mark_story
aaa37fa809 Merge branch '2.next' of github.com:cakephp/cakephp into 2.next 2017-06-26 21:51:55 -04:00
mark_story
2032fef772 Merge branch '2.x' into 2.next 2017-06-26 21:51:41 -04:00
Marc Würth
da8414e13b Use HTTPS for the opensource.org MIT license URL 2017-06-11 00:23:22 +02:00
Marc Würth
04efc7ba50 Use HTTPS for the book.cakephp.org URL 2017-06-11 00:15:36 +02:00
Marc Würth
10b89b51a9 Use HTTPS for the cakefoundation.org URL 2017-06-11 00:10:59 +02:00
Marc Würth
17314baa15 Use HTTPS for the cakephp.org URL 2017-06-10 23:40:28 +02:00
Ikuo Degawa
655a5fe0ae Fix broken cookie issue #10724 
This change makes Security::cipher() encoding and decoding same as 2.7 and below.
 2017-06-10 15:20:25 +09:00
mark_story
cf679a3233 Merge branch '2.x' into 2.next 2017-05-27 21:47:22 -04:00
Joe
70ead28a1d Redo commits on 2.next branch 2017-05-12 02:02:36 -04:00
mark_story
9007a7fe58 Fix notBlank() to pass on -0.0 
Copy the implementation from 3.x as it works with -0.0 already.

Refs #10521
 2017-04-16 09:57:36 -04:00
mark_story
e698891d09 Hash::filter() should not exclude 0.0 
Refs #10385
 2017-03-09 21:29:44 -05:00
mark_story
84a15dc9df Fix short-array usage. 2017-02-14 14:12:38 -05:00
mark_story
3f10a0227a Allow false/true to be read as keys in Hash::get(). 
While these are not values within the documented types, there exist use
cases in CakeSession that necessitate these to be supported types.

Refs #10196
 2017-02-13 21:50:51 -05:00