mark_story
db86b0c050
Don't disable the entire select when disabled is array(1)
...
When the disabled attribute is just array(1), then the attribute should
be filtered out of select element attributes. This is kind of a hacky
workaround but changing the underlying attribute handling is going to be
pretty tricky and far more dangerous.
Fixes #3546
2014-05-23 13:26:11 -04:00
mark_story
587f2da09e
Merge branch 'master' into 2.6
...
Conflicts:
lib/Cake/VERSION.txt
2014-05-22 14:29:43 -04:00
mark_story
81875cfeb1
Optimize renew().
...
Don't call session_id() twice when we can use a local variable to store
the current session id.
Fixes #3531
2014-05-22 14:28:56 -04:00
mark_story
c6d02d5779
Merge branch 'secure-form-url-special'
...
Merge pull request #3525 into master. This fixes additional issues with
form tampering prevention by accomodating more URL types.
2014-05-22 14:14:46 -04:00
mark_story
cd68002246
Add additional test case for named parameters.
...
Refs #3525
2014-05-22 14:14:35 -04:00
akiyan
781430c4af
Removed unnecessary conditional branch, fixed test and comment.
2014-05-22 14:08:18 -04:00
akiyan
67f256297d
Fixed secure form hash for special url.
...
No htmlspecialchars encode and without fragment identifer.
2014-05-22 14:08:11 -04:00
Carl Sutton
a657e410b2
Allow getting params the same way data() works
...
I could improve this to do the `hash::insert()` to replace `addParams()` as is done in `data()`
2014-05-22 17:32:19 +01:00
mark_story
270e8774e4
Fix incorrect status line parsing in HttpSocketResponse.
...
Allow for multi-word status reasons.
Closes #3545
2014-05-21 21:53:18 -04:00
Mark Story
b1fe9134c6
Merge pull request #3528 from Marlinc/patch-1
...
Add 'feedback' to uninflected single and plurals
2014-05-19 16:46:16 -04:00
José Lorenzo Rodríguez
1d34793828
Merge pull request #3530 from beporter/feature/bin-cake-cdpath-fix
...
Harden the `cake` script to avoid `CDPATH` breakage.
2014-05-19 21:44:29 +02:00
Marlin Cremers
1977d51a49
Add 'feedback' to uninflected single and plurals
2014-05-19 20:57:11 +02:00
Brian Porter
9452d5e1b6
Harden the bin/cake
script to avoid breakage when local shell environment has a CDPATH
set.
2014-05-19 11:05:28 -05:00
mark_story
0fd12c7a68
Update version number to 2.5.1
2014-05-17 22:39:27 -04:00
mark_story
2e4d6eb009
Merge branch 'master' into 2.6
...
Conflicts:
lib/Cake/VERSION.txt
2014-05-16 21:26:30 -04:00
mark_story
153141a6c7
Make help clearer around how to use UpgradeShell.
...
Closes #3504
2014-05-15 11:32:32 -04:00
Mark Story
6ace6c3fd8
Merge pull request #3498 from dereuromark/master-hotfix-hash
...
Make sure invalid arrays return empty array instead of throwing notices.
2014-05-14 20:50:16 -04:00
euromark
143e8e4c56
Make sure invalid arrays return empty array instead of throwing notices.
2014-05-14 23:53:58 +02:00
Mark Story
ef96724bc8
Merge pull request #3497 from jameswatts/feature/view-wat
...
Removed the little doc that lied
2014-05-14 14:42:56 -04:00
James Watts
992ab5ea11
Removed the little doc that lied
...
View::get() never looked up blocks
2014-05-14 20:06:37 +02:00
mark_story
20ef10aca2
Fix inline attachments being broken when only sending an HTML text body.
...
The rel boundary was closed too early causing inline images to be
incorrectly included in the email message.
Refs #3474
2014-05-14 09:42:25 -04:00
José Lorenzo Rodríguez
5ab02a0ed1
Merge pull request #3493 from Schlaefer/fix-failingModelTaskTest
...
fixes failing test cases in ModelTaskTest if not run in test-suite
2014-05-14 11:47:28 +02:00
Schlaefer
6b80ae35b1
fixes model task test-cases for 'between' validation rule alias
2014-05-14 10:55:24 +02:00
José Lorenzo Rodríguez
73f725e7ff
Merge pull request #3489 from rchavik/2.5-composer
...
Updated the test suite dispatcher to allow use of PHPUnit from Composer
2014-05-14 10:34:21 +02:00
Schlaefer
bf0edd1112
fixes failing test cases in ModelTaskTest if not run in test-suite
...
Tests 'testSkipTablesAndAll' and 'testExecuteIntoAll' didn't took fixture
table 'core.number_tree' into account.
2014-05-14 10:34:09 +02:00
mark_story
66e733f8b1
Fix test I forgot to fix in b8fa7ce134
2014-05-13 22:12:39 -04:00
David Yell
140e0bbbd3
Updated the test suite dispatcher to allow use of PHPUnit from Composer
...
Closes #3479
2014-05-14 09:09:53 +07:00
mark_story
b8fa7ce134
Fix issues where emails would have multipart/mixed when they should not.
...
When sending multi-part emails with no attachments we shouldn't include
the outer multipart/mixed header as it confuses Outlook and causes it to
show the email as having attachments even though there are none.
A bunch of tests need to be adjusted as the empty multipart/mixed
container has been removed.
Fixes #3474
2014-05-13 22:03:06 -04:00
Mark
2d46be6de5
Merge pull request #3471 from coencoppens/issue-2122
...
Issue 2122
2014-05-13 22:56:12 +02:00
Mark Story
2259309580
Merge pull request #3484 from dereuromark/master-hotfix-bake
...
Hotfix for older baked templates regarding postLink()
2014-05-13 16:53:06 -04:00
euromark
8af76a3705
Hotfix for older baked templates regarding postLink()
2014-05-13 20:51:39 +02:00
Mark Story
418c0a7b7c
Merge pull request #3481 from okinaka/master
...
Unset $db in DboSource::read().
2014-05-13 14:01:33 -04:00
mark_story
e9ecfe0936
Remove x bit on files.
...
PHP files should not have executable permission set.
2014-05-13 12:30:14 -04:00
Mark Story
33ebfa65cc
Merge pull request #3483 from dereuromark/master-hotfix-bake
...
Fixes baked postLink()s
2014-05-13 12:16:42 -04:00
Schlaefer
3ac731273e
adds backwards compatible 'between' alias for 'lengthBetween' validation rule
2014-05-13 17:36:23 +02:00
euromark
aefc459907
Fixes baked postLink()s
2014-05-13 17:14:11 +02:00
Mark Story
590e552d31
Merge pull request #3480 from Schlaefer/fix-testDecimalLocaleSet-OSX
...
fixes failing test case ValidationTest::testDecimalLocaleSet() on OS X
2014-05-13 10:02:33 -04:00
Kenshin Okinaka
91cb3ddc27
Unset $db in DboSource::read().
...
After calling $db->queryAssociatin(), it is necessary to unset db.
This reverts commit 52d425737a
.
2014-05-13 21:17:34 +09:00
Schlaefer
e10e8fcb15
fixes failing test case ValidationTest::testDecimalLocaleSet() on OS X
...
thousand separator isn't set in de_DE but in da_DK
2014-05-13 13:25:53 +02:00
Schlaefer
021d765620
fixes falling test case for 'lengthBetween' validator
2014-05-13 10:46:50 +02:00
Schlaefer
815838f150
replaces validator 'between' with 'lengthBetween'
2014-05-13 10:46:25 +02:00
Schlaefer
4848b63189
closes #3303 RFC: Rename Validator::between() into Validator::length()
2014-05-13 09:31:03 +02:00
Jose Lorenzo Rodriguez
3c57300816
CakePHP 2.5.0
...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Darwin)
iQEcBAABAgAGBQJTcYCoAAoJEDwHD15Vs66g4PQH+wZkDgvrGK5AoMBU63tLhM68
txYUfV2g7YCjoWC/q0R5QbEYa7otBAAtREEdPisTU34pWPPGcar4/Q8M+bsztaJv
UfOWOzmVLqNqDGMfvJKL5Y3kWtuKDpUVGupa4SBdt/jQ0RxwsG5SBolwu7QQ15gr
BstQjA6RpTmdBjzbHVfX6WO3a//4utY3Nf0G4+aL5Q/y1FDNzyAmBq4OKahbBY0K
MnaWiANHXN/3YfFFaWxDk+P23gsiWckaqq3Q2ipaGGGQoWq0rMeWFw3OrSc4w4xS
L94poTkNDPqEzEjO7A4GvyvgXW4NhuuDbGkrSXciArfxihVSyB1mziDWSSYanAI=
=y8NE
-----END PGP SIGNATURE-----
CakePHP 2.5.0
2014-05-13 09:14:43 +02:00
mark_story
780132f892
Update version number to 2.5.0
2014-05-12 22:17:12 -04:00
mark_story
5b143fcfd7
Merge branch 'paginate-optimization' into 2.5
...
Fixes #3333
2014-05-12 22:11:27 -04:00
mark_story
a34d5f733d
Fix PaginatorComponent tests.
...
Because count() queries don't happen in many cases now, the lastQueries
index needs to shift up by one because a query isn't happening anymore.
Refs #3333
2014-05-12 22:10:27 -04:00
mark_story
b2207c1ca8
Reverse conditions to make the cheapest condition first.
...
We don't need to do a count() if the page is not 1.
Refs #3333
2014-05-12 22:09:27 -04:00
Toby Cox
823f01601d
enhancement to paginator
...
As pointed out, we need to make sure that we are also on the first page
to make this conditional clause valid
2014-05-12 21:49:08 -04:00
Toby Cox
296ea215b1
Enhancement to paginator
...
No point in finding the count (via model) if the returned result count
is less than our limit. We then know that the count is the count of our
results
2014-05-12 21:49:07 -04:00
mark_story
89cd114e6f
Merge branch 'master' into 2.5
2014-05-12 14:30:02 -04:00