ADmad
738d0e2277
Fixed edge case which allowed login with empty password.
...
Ensure skipping call to FormAuthenticate::_checkFields() does not allow
logging in with empty password. Closes #2441 .
2013-12-07 18:40:08 +05:30
mark_story
85a9132c9b
Append / to the start/end of the mapResources prefix.
...
This makes the method easier to use and less error prone.
Fixes #2431
2013-12-04 21:46:59 -05:00
Mark Story
58317d312c
Merge pull request #2427 from EliuFlorez/patch-3
...
Cast implemented events to an array when detaching listeners.
This makes it much simpler to work with mocks, and avoids warnings caused by developer error.
2013-12-04 11:26:35 -08:00
Eliu Florez
6ee5277c9f
Update CakeEventManager.php
...
Cast resultados de implementedEvents a una matriz.
e6f2c92005
2013-12-04 14:26:02 -04:30
mark_story
e6f2c92005
Cast results of implementedEvents to an array.
...
This makes using mocks much easier with event listeners as they don't
need to provide a returnValue for implementedEvents.
Refs #2333
2013-12-03 22:39:14 -05:00
Mark Story
a57c46ff93
Merge pull request #2421 from ADmad/2.4-bugfix-deleteall
...
Fixed bug where deleteAll tried to delete same id multiple times.
2013-12-03 10:22:16 -08:00
ADmad
f3900e89fd
Fixed bug where deleteAll tried to delete same id multiple times.
...
Ensure find done in deleteAll only returns distinct ids. A wacky
combination of association and conditions can sometimes generate
multiple rows per id.
2013-12-03 22:18:17 +05:30
Mark Story
b8268cd055
Merge pull request #2408 from ADmad/2.4-paginator-exception
...
Moved exception throwing to after paging info it set for request.
Fixes #2402
2013-11-30 14:17:12 -08:00
ADmad
c72def4840
Moved exception throwing to after paging info it set for request.
...
This fixes the regression caused in 2096d3f632
. When catching exception
thrown by PaginatorComponent::paginate() in controller, developer again
has access to paging info in request object.
Closes #2402
2013-11-30 19:00:08 +05:30
mark_story
a9ca1bdc58
Add tests and fix other cases where autoLinkEmail would fail.
...
Refs #2403
2013-11-29 22:57:43 -05:00
mark_story
7c66d0db50
Fix autoLink() when URLs contain email addresses.
...
Add whitespace lookbehind to ensure the email address is preceded by
whitespace, this obviously means that emails starting with word/symbols
are not detected, however those symbols are generally valid in an email
address anyways, and will form the local part.
Fixes #2403
2013-11-29 22:24:03 -05:00
mark_story
bbe4c659aa
Add tests for TextHelper::autoLink()
...
Add tests for email addresses embedded in urls.
Refs #2403
2013-11-29 21:57:08 -05:00
ADmad
155c7585e0
Fixed docblock
2013-11-29 00:14:43 +05:30
mark_story
eb34e011e2
Update version number to 2.4.3
2013-11-24 21:25:25 -05:00
mark_story
eac6d7850f
Remove pointless array cast.
2013-11-23 12:36:15 -05:00
mark_story
5e77183afe
Fix failing tests when Console group was run in isolation.
2013-11-23 12:36:02 -05:00
mark_story
311189a662
Sort tables before returning them.
...
This fixes unsorted table lists in the various bake related tasks.
Fixes #2386
2013-11-23 12:34:16 -05:00
mark_story
d97cf79545
Add coverage for comma in email alias.
...
Closes #2381
2013-11-22 13:14:21 -05:00
mark_story
37e387fed2
Replace non-breaking spaces with Inflector::slug().
...
Fixes #2363
2013-11-22 10:13:10 -05:00
mark_story
a4460ff228
Fix tests even better than before.
...
The current tests work on travis, but fail on jenkins. Fix that up.
2013-11-21 22:57:50 -05:00
mark_story
0e7b0ad111
Fix failing test.
2013-11-21 21:46:03 -05:00
Mark Story
f3ca966623
Merge pull request #2377 from bar/patch-1
...
Always remove verify_host from SSL context.
2013-11-21 11:03:37 -08:00
ber clausen
1b9bf7b0fd
Always remove verify_host from SSL context.
...
It is only used to be able to set ```CN_match```.
2013-11-21 16:23:01 -02:00
Mark Story
7fdf17e43e
Merge pull request #2367 from cakephp/issue-2364
...
Leave db->cacheSources unaltered.
Fixes #2364
2013-11-19 15:37:16 -08:00
mark_story
1be40d5d64
Fix coding standards error.
...
Refs #2364
2013-11-19 18:36:52 -05:00
mark_story
ec38ee1c48
Only enable cacheSources if both the datasource + model agree on it.
...
This prevents models from flipping cacheSources on when the datasource
has it disabled already.
Refs #2364
2013-11-19 17:36:20 -05:00
mark_story
99fd6e40fe
Leave db->cacheSources unaltered.
...
When a model uses cacheSources = false, it should not have side effects
on the datasource.
Fixes #2364
2013-11-19 15:06:55 -05:00
Mark Story
cc94026f7e
Merge pull request #2358 from mathop/2.4-html-meta-icon
...
Fix duplicated webroot path on HtmlHelper::meta('icon').
2013-11-18 18:07:36 -08:00
Matheus Pedroso
4677ddf490
Fix duplicated webroot path on HtmlHelper::meta('icon').
2013-11-18 23:38:01 -02:00
Mark Story
df52e85e0c
Merge pull request #2338 from ravage84/hash-linked
...
Added link to three hash methods
2013-11-16 18:53:45 -08:00
Marc Würth
229bd69903
Added link to three hash methods
2013-11-17 03:40:39 +01:00
mark_story
016c3aed44
Add test for saveAssociated and expression objects.
...
Add a test for #1514 . This issue was fixed during recent refactorings.
Closes #1514
2013-11-16 10:51:14 -05:00
mark_story
cee2801700
Add 'metadata' to the uninflected list.
...
Fixes #2332
2013-11-15 21:49:05 -05:00
Mark Story
17ae40f0ce
Merge pull request #2319 from ravage84/php-5-removal
...
Removed "PHP 5" from file header DocBlocks
2013-11-14 06:41:31 -08:00
Mark Story
d8e9f53bf1
Merge pull request #2320 from ravage84/copyright+license-fixes
...
Fixed some copyright and license statements in the file header DocBlocks
2013-11-13 15:15:09 -08:00
Marc Würth
7018997979
Fixed some copyright and license statements in the file header DocBlocks
2013-11-14 00:07:03 +01:00
Marc Würth
7cfa0116f4
Removed "PHP 5" from file header DocBlocks
...
This statement does not serve a purpose anymore.
In a long forgotten world it indicated the main version number of PHP which the code in the file was compatible to.
http://pear.php.net/manual/en/standards.sample.php
But since PHP 5.1 and later this is only marginally true.
Thus I propose to remove it from CakePHP.
2013-11-13 22:58:39 +01:00
Mark Story
4f0d9b30a9
Merge pull request #2317 from ravage84/replace-ogtsl
...
Replaced all remaining license references to the Open Group Test Suite L...
2013-11-13 10:16:10 -08:00
Marc Würth
ce47890e98
Replaced all remaining license references to the Open Group Test Suite License with the MIT License
2013-11-13 18:52:06 +01:00
Andy Dawson
d94c187adc
Merge pull request #2305 from kimegede/docblock-construct-destruct-return-void
...
Docblock construct destruct remove @return
2013-11-13 01:44:35 -08:00
mark_story
a07608cbb9
Fix incorrect CSRF token fields when using postLink()
...
Creating a postLink after creating a GET form would result in the
incorrect fields being generated.
Fixes #2308
2013-11-11 21:56:55 -05:00
mark_story
1f5d1eee98
Remove duplicated reference for behaviors in ClassRegistry
...
The 2nd key in the registry was to support persistModel which has long
since been removed. With this registry key not being used it can be
removed with reasonable safety.
Fixes #2306
2013-11-11 12:30:00 -05:00
Kim Egede Jakobsen
18e0dc95dd
Remove @return from docblock (for __construct && __destruct methods)
2013-11-11 14:54:48 +01:00
Kim Egede Jakobsen
f0205f53ad
Try to make same comments for constructors.
...
Conflicts:
lib/Cake/I18n/L10n.php
2013-11-11 11:03:57 +01:00
Mark Story
9d18a5da78
Merge pull request #2300 from cusspvz/patch-1
...
Model.php PHPDoc Description: Change afterFilter with afterFind
2013-11-10 10:43:05 -08:00
José Moreira
b1e366c500
Model.php PHPDoc Description: Chang afterFilter with afterFind
2013-11-10 16:59:28 +00:00
mark_story
8d38861a2e
Fix missing HTML encoding on URL's generated by Html->meta().
...
The input URL was not correctly handled as an asset URL and thus was
not correctly HTML or URL escaped. This created invalid HTML when
favicon URLs included query string arguments.
Refs #2233
2013-11-09 14:31:09 -05:00
mark_story
bf2f2e772e
Split existing tests up, and add tests for Router based image URL's
...
Refs #2233
2013-11-09 12:00:56 -05:00
mark_story
ada0ec4c77
Fix formatting of decimal values when there is no fractionSymbol.
...
When a currency format does not include a fractionSymbol it should be
able to format fractional values.
Fixes #2253
2013-11-09 09:36:38 -05:00
mark_story
407c420176
Remove CRLF from To headers in MailTransport.
...
Like other header fields To should not contain CRLF.
Refs #2209
2013-11-08 13:25:51 -05:00