Commit graph

3594 commits

Author SHA1 Message Date
mark_story
6cc1688d4e Fixing issue where DboMysql would perform joins on delete queries even if the conditions did not require joins. Added a more intelligent join detector, that removes joins if all the conditions are simple. This will only be able to optimize array conditions.
Test cases added.  Fixes #1571
2011-03-24 23:25:56 -04:00
mark_story
532555b94b Fixing order condition quoting to allow fields with - in them. Fixes #1599 2011-03-24 22:28:11 -04:00
ADmad
69e5854f0a Applying patch from 'Eärendil' to add option 'hiddenField' for FormHelper::select() for use with 'multiple'=>'checkbox'. Test cases added. Closes #1161 2011-03-21 19:18:53 +05:30
mark_story
e2773242f7 Adding a test case for the issue fixed in #1408.
Fixing issue where -app command did not work as expected.
Fixes #1601
2011-03-20 22:19:22 -04:00
mark_story
dd9ebd8a60 Fixing a failing test caused by changes in fixture schema. 2011-03-20 16:06:44 -04:00
Jamie Mill
cf0e9c0a31 Fixing undefined var and docblock error in CakeCliReporter->paintException(). 2011-03-17 19:15:08 +00:00
ADmad
4e046c8cd0 Fixing a test case for Model::saveAll() 2011-03-16 00:56:31 +05:30
ADmad
0f341c7114 Fixed bug where default class name 'checkbox' was dropped in case of validation error for div wrapping checkbox for multiple checkboxes 2011-03-11 20:20:55 +05:30
mark_story
7853189328 Adding 'style' as a known html attribute. Fixes #1573 2011-03-07 21:58:11 -05:00
mark_story
197c9bf912 Making empty string create empty submit buttons. This applies to both Form->submit() and Form->end(). Tests added. Fixes #1569 2011-03-02 20:27:57 -05:00
mark_story
e05c6cd83f Fixing issue where actions starting with a prefix but not followed by an _ would get mangled when going through router::url().
Fixes #1556
2011-02-24 16:43:13 -05:00
mark_story
9367a10522 Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2011-02-23 21:07:10 -05:00
Juan Basso
52163b4b05 Allowing strings in cc and bcc. Fixes #1553. 2011-02-22 21:23:15 -03:00
mark_story
1f9bbbce53 Pulling windows specific tests into a separate test method. 2011-02-21 10:48:34 -05:00
mark_story
ca3e606ec8 Fixing failing tests caused by me forgetting to run tests in [7032729651] 2011-02-16 22:08:20 -05:00
mark_story
63caf566fb Adding some tests around invalidFields() and fieldList options.
Closes #1534
2011-02-13 12:22:29 -05:00
mark_story
42c2f3011b Applying fix from 'Mark Mitchell' to expose PeriodicalExecuter in the callback. Fixes #1529 2011-02-11 21:49:00 -05:00
mark_story
a5fb2cf8a7 Fixing issue where fixtures without field definitions would drop tables,
even though they had no way to re-create them. Fixes #1519
2011-02-08 21:53:12 -05:00
mark_story
9a940709ab Removing unsupported options from PrototypeEngine. Fixes #1516 2011-02-07 20:59:01 -05:00
mark_story
584116524b Fixing range option for prototype engine. Fixes #1509 2011-02-07 19:19:50 -05:00
Juan Basso
f2a4b1e959 Supporting %e in windows. Fixes #1510. 2011-02-06 15:51:28 -02:00
mark_story
cf50cbdd9d Fixing issue in FormHelper where CURRENT_TIMESTAMP or other invalid data could cause a notice error. Fixes #1508 2011-02-05 06:43:00 -05:00
Phally
9402f0ab79 Added missing skipIf when no SMTP server is running. 2011-01-31 00:06:11 +01:00
Juan Basso
bbf6aedd9c Fixed wrong viewVars store when have objects in view caching. Fixes #1486. 2011-01-28 00:31:18 -02:00
mark_story
5464ed8455 Fixing blackholes caused by using custom name attributes with inputs. Fixes #1489 2011-01-27 21:05:30 -05:00
mark_story
71d8e744f1 Fixing case-sensitivity of AS in fields. Tests added. Fixes #1474 2011-01-26 20:58:16 -05:00
mark_story
7032729651 Fixing how webroot is calculated for installs not using url rewriting. Also fixes using the top level index.php file.
Test cases added for using both index.php files.
Cleaned up existing tests for environment detection.
Fixes #1261, Fixes #1432
2011-01-23 17:08:09 -05:00
mark_story
3747e395f1 Fixing notice errors caused by garbage urls being fed into Dispatcher.
Added a test.
Fixes #1463
2011-01-21 16:02:33 -05:00
mark_story
ed7f8d1906 Fixing issue where DboPostgres used the wrong type for boolean columns with a default of false or true.
Added a test case.
Changing Model::create() so it doesn't wipe out default values === false.
Fixes #1460
2011-01-21 13:31:33 -05:00
mark_story
ab337e2e8a Adding tests for TextHelper::autolinkurl(). Closes #1466 2011-01-18 18:56:35 -05:00
ADmad
d4e4957563 Adding test case for FormHelper::input() for generation multiple checkboxes with space in option values. Refs #1465 2011-01-19 02:25:39 +05:30
mark_story
cfce0e45d3 Fixing issue where empty session id's would cause duplicate key errors. Empty session id sessions are no longer saved. Fixes #1450 2011-01-18 08:14:47 -05:00
mark_story
b0d4951184 Fixing TextHelper::autoLinkEmails() not linking email addresses that contain '.
Test added.
Fixes #1457
2011-01-17 11:11:30 -05:00
mark_story
ca299a097c Fixing issue where get forms created with model = false would create inputs with name = ''. Tests added. Fixes #1455 2011-01-15 14:39:24 -05:00
mark_story
b8780586ec Fixing issue where FormHelper::checkbox() would ignore an explicit checked = false, and use the post data instead. Test case added. Fixes #1437 2011-01-14 21:48:23 -05:00
mark_story
459e2ef1b0 Merge remote branch 'bar/envfix' into 1.3 2011-01-13 20:29:20 -05:00
mark_story
5f612b7833 Making memcache cache adapter, set the expiry time of any value greater than 30 days to never expire. This works around the 30 day limitation of the PHP extension. Test case added. Fixes #1451 2011-01-13 20:27:10 -05:00
mark_story
0f4c90588d Fixing issue where elements did not get .ctp as a fallback extension unlike view and layout files.
Adding a protected method to get extensions, as it would be in 3 places now.
Added tests.
Fixes #1438
2011-01-12 20:43:41 -05:00
mark_story
f893e3b63b Applying patch from 'ryandesign' fixing incorrect datetime formats. Fixes #1441 2011-01-11 20:16:42 -05:00
mark_story
4f94b715ec Revert "Fixing Set::filter() not predictably filtering in a recursive
fashion.  While a minor change in behavior, more predictable and uniform
behavior is worth it." Refs #1431

This reverts commit 6e2ffafe54.
2011-01-09 22:29:10 -05:00
Ber Clausen
8d15ba5037 Fixing env('HTTP_BASE') for site domain names that have the form
xxx.yyy.zzz and use second level TLDs.
2011-01-09 17:43:41 -03:00
mark_story
8754d11aed Adding EmailComponent::_getSocket() so EmailComponent + smtp is easier to test.
Fixing issue where hosts with portnames could cause smtp emails to fail.
Added tests, fixed an existing test to not depend on a local mailserver.
Fixes #1433
2011-01-06 23:10:01 -05:00
mark_story
6e2ffafe54 Fixing Set::filter() not predictably filtering in a recursive fashion. While a minor change in behavior, more predictable and uniform behavior is worth it.
Fixes #1431
2011-01-05 22:48:09 -05:00
mark_story
5768bfe5c7 Fixing failing test caused by missing space. 2010-12-31 16:35:44 -05:00
mark_story
a7061510c1 Applying patch from 'rynop'. Fixing FixtureTask so it includes the datasource if its not the default one.
Updating tests.
Fixes #1419
2010-12-31 13:05:04 -05:00
mark_story
5092013304 Making EmailComponent register and un-register its view object, when rendering email templates. This allows helpers to use the view to do additional processing. Fixes #442 2010-12-27 15:12:27 -05:00
Juan Basso
5d2b4c758d Minor optimization in cache views. 2010-12-18 19:41:57 -02:00
Juan Basso
a7c7436d8e Passing viewVars to cache views, avoiding cake:nocache problems. 2010-12-18 19:31:10 -02:00
mark_story
53a687049c Fixing encoding of address aliases. They are now mime-encoded like other headers. Tests added. Fixes #1360 2010-12-13 23:23:02 -05:00
mark_story
e410509684 Fixing TestTask not being able to find plugin objects when baking test skeletons interactively. Test case added. Fixes #1361 2010-12-13 22:04:55 -05:00
mark_story
d7e62b88bc Adding test cases for using helpers in nested elements from email
templates.  Closes #1355
2010-12-09 22:34:20 -05:00
mark_story
a830632071 Changing View::element() to not overwrite viewVars with helpers that
have the same name.
Test added.
Fixes #1354
2010-12-09 22:06:23 -05:00
mark_story
8681399fc2 Forcing the plugin list to use a fresh directory listing in the web runner. Fixes #1338 2010-12-06 21:29:11 -05:00
mark_story
44b09171ef Adding unicode letters and numbers to url path segment regex.
Test case added.
Fixes #1284
2010-12-01 23:47:30 -05:00
dogmatic69
96b30f0547 adding tests for places that will leave a trailing 0 because of the way phps number_format() method works
Signed-off-by: mark_story <mark@mark-story.com>
2010-12-01 22:08:26 -05:00
ADmad
70ae66edf7 Fixing test cases for EmailComponent 2010-11-27 01:21:19 +05:30
mark_story
15ca2400bc Fixing issue in DboSource::name() where special characters in column names would not be correctly quoted.
Tests added.
Fixes #1264
2010-11-25 06:52:23 -05:00
mark_story
7d158e8d1f Fixing Set::sort() for arrays with out of sequence, or missing keys.
Tests added.
Fixes #1312
2010-11-25 06:39:08 -05:00
mark_story
4214242efd Adding test for correct merge order for $uses.
Fixing incorrect merge ordering for $uses, so it matches historical behaviour.
Fixes #1309
2010-11-24 22:44:12 -05:00
mark_story
0e29567f8d Adding an array cast to fix issues where users could modify cookie
values causing iteration errors.  Fixes #1309
2010-11-24 22:09:08 -05:00
ADmad
b567de977e Fixed bug where Dispatcher::getUrl() returned incorrect URL if $base appeared in a $uri besides at start of $uri. 2010-11-24 02:15:44 +05:30
mark_story
d5fb0b25cb Fixing issue where Date header would be missing from Emails sent by
EmailComponent.
Adding user configurable field for date.
Test cases added.  Fixes #1304
2010-11-22 22:08:46 -05:00
mark_story
79aafda698 Removing use of serialize() for locked fields. This removes any
possible exploit related to serialize()/unserialize().  Instead values
are passed as | delimited.
2010-11-21 00:09:45 -05:00
mark_story
ae7855692d Removing unserialize() as its dangerous. Instead using | delimited fields for locked fields. This totally avoids issues with serialize(). Removing str_rot13, as its only child proof.
Tests updated.
2010-11-20 23:42:54 -05:00
mark_story
ef3cb0e50c Adding tests for Set::normalize() 2010-11-20 22:46:55 -05:00
mark_story
6d9b000aee Changing how mergeVars are handled, so the difference of app/current is used as a base.
Also fixing issues where passing settings to helpers in AppController could result in them not being correctly merged.
Thanks to hashmich for the partial patch.
Fixes #1183
2010-11-20 22:34:24 -05:00
mark_story
e0a8ffe8a3 Applying patch from 'jmccaffrey' to fix issues on windows where virtual
machine paths would not be correctly handled.  Fixes #1254
2010-11-20 13:26:30 -05:00
mark_story
76a80c262e Fixing failing test caused by name() being able to quote things better now. 2010-11-13 12:04:22 -05:00
Mariano Iglesias
a1467822fb Fixing wrong assertion in test for CakeTestCase::testAction. Fixing testAction issue that would always include layout 2010-11-10 23:03:38 -04:30
mark_story
e431e86aa4 Fixing issue found by Felix Wilhelm(flxm) where users could send potentially dangerous or corrupted serialized objects to SecurityComponent, potentially allowing manipulation of file map caches. Test case added. 2010-11-07 20:53:04 -05:00
ADmad
eb76ab95f2 Fixed issue where Model::saveAll() would incorrectly commit a transaction which was not started in that function call itself. 2010-11-06 09:33:50 +05:30
mark_story
d56b812181 Fixing issue where an array to string conversion error could occur if you had multiple values for a model's primary key and you created a matching form. Tests added.
Fixes #1257
2010-11-04 21:08:40 -04:00
ADmad
81ce6f40b9 Added test cases showing usage of 'full_base' key for url generation. Refs #1256 2010-11-04 17:59:23 +05:30
mark_story
d1403b0da8 Changing NumberHelper::currency() to format < 1euro based on the suggestions from 'Joel Haasnoot'. Instead of 99c you will get €0,99.
Test cases updated.  Fixes #1253
2010-11-02 21:56:24 -04:00
mark_story
f29bb562cb Adding a test for saving blank fields on a model. Closes #1243. 2010-10-29 00:13:09 -04:00
mark_story
f5fd069583 Applying patch from 'Justas Butkus' to fix CakeSchema::compare()
Fixes issues with comparing null == '' and adds a new protected method to handle null aware array difference generation.
Tests added.
Fixes #1206
2010-10-27 23:03:31 -04:00
mark_story
3639f52117 Adding a test for containable modifying return. Refs #1219 2010-10-26 21:39:48 -04:00
SKAhack
9f2d33aa88 meta characters don't match on regex string
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-24 21:42:11 -04:00
mark_story
4496a0a0bb Reformatting code to use tabs.
Fixing issue with float comparison.
Fixes #219
2010-10-24 19:43:41 -04:00
C. James Callaway
b8f0dda964 Updating to match ticket, using radians() SQL function. 2010-10-24 19:39:18 -04:00
C. James Callaway
a429287c19 Adding testcase for ticket #219 2010-10-24 19:38:23 -04:00
Graham Weldon
d3e0ddbb0e Update copyright years. 2010-10-25 07:58:22 +11:00
mark_story
54854c493b Changing output buffering, as ajaxtest was making output and breaking tests in group contexts. 2010-10-24 00:39:46 -04:00
mark_story
155bfe6293 Fixing failing test caused by setting an expiry value outside of the PECL extensions limits. 2010-10-24 00:05:27 -04:00
Juan Basso
deb20d4cf2 Fixed the PHPDoc. 2010-10-21 14:56:05 -02:00
Toni Uebernickel
b04f87f62d fixed E_NOTICE undefined variable in CakeCliReporter::paintException 2010-10-21 14:56:04 -02:00
mark_story
7c296211ef Making generating schema for connections with prefixes work correctly. The prefix needs to be removed so that when tables are created or updated they do not get the prefix added twice.
Moving tests around. Fixes #1180
2010-10-20 23:17:04 -04:00
mark_story
498417203b Making DboSource::fields() use cacheMethod() so it respects $cacheMethods.
Test added.
Fixes #1211
2010-10-20 22:28:31 -04:00
mark_story
077d1c5ad5 Applying patch from 'hashmich' to fix issues with slideUp and slideDown effects in prototype engine.
Tests updated.
Fixes #1213
2010-10-20 22:07:53 -04:00
mark_story
1c25e627ad Applying patch from 'Mark Mitchell' fixes issues with sending Email via smtp. Which were incorrect based on previous patches given for ticket #1100.
Fixes #1205, Fixes #1204
2010-10-18 22:06:12 -04:00
mark_story
c35ef7dbab Making class attribute bubble down into FormHelper::__selectOption().
Fixes issue where you couldn't change the classname of checkbox options.
Fixes #1202
2010-10-16 13:32:04 -04:00
mark_story
67874bd906 Fixing issue where defining a pattern for :action would create an optional route parameter that wouldn't respect its pattern.
Added the default action value only when a pattern isn't defined.
Added tests to CakeRoute and Router to cover this case.
Fixes #1197
2010-10-14 21:54:44 -04:00
mark_story
6529e0e2b4 Making optiongroup elements follow the escape parameter.
Tests added.
Fixes #1191
2010-10-13 21:59:53 -04:00
mark_story
3f2109f3c3 Applying patch from 'dragonfly' to fix issue where FormHelper would always append an argument even if one was supplied.
Test Added
Fixes #1155
2010-10-13 21:36:05 -04:00
mark_story
a0a84d1a8d Changing pattern used to read digest auth data. Allows emails to be used as usernames.
This also adds the realm to the return value of SecurityComponent::parseDigestAuth().  Fixes #1181
2010-10-11 22:35:47 -04:00
ADmad
62161203f2 Fixed issue where FormHelper::radio() and FormHelper::select() with option "multiple"=>"checkbox" would generate tag with invalid "id" attribute if a value was non alphanumeric 2010-10-10 23:16:48 +05:30
Phally
0d86302404 Fixed issue with Set::extract() where conditions containing a space and a slash would fail. Fixes #1185
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-08 23:28:23 -04:00
Phally
0e5613f63d Fixed Set::extract() where single numeric keys (everything not 0) were skipped. Fixes #1175
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-07 20:33:31 -04:00
teknoid
503b7cf5d7 Adding slug option to avoid auto-slug of tags. Test included. Addresses #284
Signed-off-by: mark_story <mark@mark-story.com>
2010-10-02 19:16:07 -04:00
mark_story
5c27abd35f Applying patch from 'hashmich' to make jQueryEngine not override the success callback. This allows you to provide a success callback and still get the html insertion when used with the update key.
Tests updated.
Fixes #1158
2010-10-01 22:43:46 -04:00