Commit graph

1705 commits

Author SHA1 Message Date
mark_story
d192ed32f0 Adding a socket key to DboMysqli::$baseConfig. Fixes notice errors when socket is undefined. Fixes #1482 2011-01-26 20:54:14 -05:00
mark_story
32f0b20a33 Removing wonky and most likely incorrect manipulation of socket and port
setting mangling in DboMysqli.  Fixes #1478
2011-01-24 22:05:16 -05:00
mark_story
ed7f8d1906 Fixing issue where DboPostgres used the wrong type for boolean columns with a default of false or true.
Added a test case.
Changing Model::create() so it doesn't wipe out default values === false.
Fixes #1460
2011-01-21 13:31:33 -05:00
mark_story
dca3fecfed Merge branch '1.3' into merger
Conflicts:
	cake/console/error.php
	cake/libs/cache/memcache.php
	cake/libs/cake_session.php
	cake/libs/controller/components/request_handler.php
	cake/libs/model/cake_schema.php
	cake/libs/router.php
	cake/libs/set.php
	cake/libs/view/helpers/form.php
	cake/libs/view/helpers/text.php
	cake/libs/view/view.php
	cake/tests/cases/libs/set.test.php
2011-01-18 20:04:30 -05:00
mark_story
b94edefb2c Removing the last vestiges of the enable parameter.
Fixing issue where isset() stupidly plods along when doing a string index of a string.
Updating DbAcl to use proper settings array.
Fixes #1467
2011-01-18 19:33:57 -05:00
Jeremy Harris
be563e1220 Merge remote branch 'upstream/2.0' into 2.0 2011-01-17 20:07:22 -08:00
Jeremy Harris
1f0c57c4ee Fixed aliasing so it works with plugins in the 'className' key 2011-01-14 17:44:33 -08:00
Jeremy Harris
39e06b0425 Updated documentation 2011-01-13 18:06:32 -08:00
Jeremy Harris
2b596859cb Reversed alias and actual class to be more consistent with how Model aliases load and to make migration easier 2011-01-13 18:04:06 -08:00
Juan Basso
d15ed329d9 Changed the trigger_error by exceptions in ConnectionManager. 2011-01-12 23:08:34 -02:00
mark_story
f893e3b63b Applying patch from 'ryandesign' fixing incorrect datetime formats. Fixes #1441 2011-01-11 20:16:42 -05:00
Jeremy Harris
24d90c17d6 Allowed behaviors to be aliased by setting the 'alias' key 2011-01-09 18:28:12 -08:00
mark_story
443f6d1c5b Merge branch '1.3' into merger
Conflicts:
	cake/console/shells/tasks/test.php
	cake/libs/cake_log.php
	cake/libs/controller/components/email.php
	cake/libs/set.php
	cake/libs/view/helpers/cache.php
	cake/libs/view/helpers/paginator.php
	cake/libs/view/helpers/time.php
	cake/libs/view/view.php
	cake/tests/cases/console/libs/tasks/fixture.test.php
	cake/tests/cases/console/shells/tasks/test.test.php
	cake/tests/cases/libs/controller/components/email.test.php
	cake/tests/cases/libs/model/db_acl.test.php
	cake/tests/cases/libs/set.test.php
2011-01-08 23:49:19 -05:00
José Lorenzo Rodríguez
2b9c6b8609 optimizing sqlite driver to look for the "From" keyword in reverse order on the sql string 2011-01-04 17:44:33 -04:30
José Lorenzo Rodríguez
4948280ba8 Fixing typo in sqlite driver 2011-01-04 17:25:23 -04:30
José Lorenzo Rodríguez
665e560310 Checking for null values before converting to boolean 2011-01-04 17:00:10 -04:30
mark_story
de6eda964e Removing silent errors in PDO dbo's when a connection exception is created.
Adding the host param for mysql.
Adding a test for mysql missing the host param.
Fixes #1427
2011-01-03 23:34:22 -05:00
José Lorenzo Rodríguez
5a75d1d91a Adding boolean casts for sqlite 2011-01-02 01:26:57 -04:30
José Lorenzo Rodríguez
fe18e31b79 Changes to make sqlite recognize boolean columns declared as "boolean", so they can be casted to native php type 2011-01-01 22:11:28 -04:30
José Lorenzo Rodríguez
1d530db39b Changing a bit how postgres driver treats booleans so it correcty casts them 2011-01-01 22:09:22 -04:30
José Lorenzo Rodríguez
da152e0e82 Changes to make mysql cast boolean vaules to the native php boolean datatype 2011-01-01 22:07:27 -04:30
mark_story
a9a1994a7e Merge branch '2.0-pagination' into 2.0 2010-12-31 12:37:53 -05:00
mark_story
b82ad15c5e Fixing issue in console when baking a new project, from outside the
installation directory you would get an error because database.php could
not be found.  Fixes #1406
2010-12-27 00:19:59 -05:00
mark_story
fd3b4b2cd5 Adding Model::hasMethod() and tests. 2010-12-26 17:35:22 -05:00
mark_story
3022e2d785 Adding documentation. 2010-12-26 17:21:49 -05:00
mark_story
ad5a1ca6b7 Making __methods and __mappedMethods protected instead of private. 2010-12-26 17:10:16 -05:00
mark_story
0c4b665ad0 Adding ability for BehaviorCollection::hasMethod() to return the callback.
Re-factored BehaviorCollection::dispatchMethod to be simpler and faster.
Changing now BehaviorCollection stores callbacks so they look like normal php callback arrays.
2010-12-26 17:09:20 -05:00
mark_story
769da1a7c8 Adding basic BehaviorCollection::hasMethod implementation. Tests added. 2010-12-26 16:44:50 -05:00
mark_story
4009b6b2c7 Fixing more @package tags, and removing duplicate tags in classes. 2010-12-24 14:33:41 -05:00
mark_story
ef77e60cb0 Removing @subpackage tags, moving contents of @subpackage into @package.
Removing duplicate cake.cake in @package tags.
Renaming cake.app -> app
2010-12-24 14:09:57 -05:00
mark_story
a37b3a1598 Adding more documentation to DboSource. 2010-12-22 22:33:17 -05:00
mark_story
98c356a9c5 Adding some more documentation to ModelBehavior as well as basic usage. 2010-12-22 22:27:47 -05:00
mark_story
04929ae1df Applying patch from 'Thorsten Buss'.
Fixes issues in DboSource, where mismatching types on join columns could result in incorrect query generation.
Fixes #708
2010-12-21 20:40:19 -05:00
mark_story
f3445cd941 Making ModelBehavior::beforeFind() return true by default. Since
returning null causes the find to abort, behaviors should return true if
they are not going to return a query array.
2010-12-12 18:04:52 -05:00
mark_story
3c69d9b138 Making ModelBehavior beforeX callbacks default to returning true. Returning null or false from a Behavior::before method will abort the operation. It felt illogical to have null continue, but false stop. 2010-12-12 17:40:13 -05:00
mark_story
48879f8264 Fixing strict errors in translate and acl behaviors.
Removing conditional definition of I18nModel.  There is no reason for it to exist anymore.
Removing duplicate class definition.
2010-12-12 17:38:49 -05:00
mark_story
df21d19c4c Making a bunch of properties public so containable can hack around. Need to refactor and fix visibility issues.
Fixing failing tests in containable.
2010-12-12 15:48:36 -05:00
mark_story
a05baaa76e Removing BehaviorCollection::trigger() so it uses the parent method.
Updating model to use the new behaviorcollection trigger method signature.
2010-12-12 15:03:23 -05:00
mark_story
81e009b816 Fixing additional strict warnings. 2010-12-12 15:02:38 -05:00
mark_story
33b8a35b75 Fixing strict warnings in TreeBehavior and a few other classes. 2010-12-12 14:56:48 -05:00
mark_story
b9f0fc0724 Merge branch '1.3' into merger
Conflicts:
	cake/dispatcher.php
	cake/libs/cake_session.php
	cake/libs/controller/components/cookie.php
	cake/libs/controller/components/email.php
	cake/libs/controller/controller.php
	cake/libs/controller/scaffold.php
	cake/libs/set.php
	cake/libs/validation.php
	cake/libs/view/view.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/validation.test.php
	cake/tests/cases/libs/view/view.test.php
2010-12-10 22:24:31 -05:00
mark_story
c096eea664 Fixing failing tests caused by constants changing. 2010-12-05 23:32:34 -05:00
José Lorenzo Rodríguez
c559b9c22d Merge remote branch 'origin/2.0' into 2.0
Conflicts:
	cake/console/templates/skel/config/database.php.default
	cake/libs/model/datasources/dbo/dbo_sqlite.php
2010-12-05 20:51:37 -04:30
Juan Basso
c52d5320c8 Replaced the *printf with i18n aliases by i18n aliases with params. 2010-12-04 23:37:13 -02:00
mark_story
8031d33d33 Fixing more E_STRICT notices and adding a type check to DboSource::dropSchema(). 2010-12-04 14:37:02 -05:00
mark_story
a6c5065e9c Fixing a few more E_STRICT errors in postgres test/class. 2010-12-04 14:31:11 -05:00
mark_story
7e3c98024e Removing reference operators in ModelBehavior. 2010-12-04 14:19:36 -05:00
mark_story
18fb12c95c Removing & pass by ref operators as they aren't needed any more.
Fixing a bunch of E_STRICT errors.
2010-12-04 14:15:32 -05:00
mark_story
d13759522b Removing strtolower() calls. You must now call model magic findBy and findAllBy using camelcase forms. 2010-12-04 13:45:42 -05:00
mark_story
466137485d Removing a duplicated property.
Changing is_a() to instanceof as it marginally faster.
Adding a comment to getConnection as it was missing it.
Minor optimization to a regular expression.
2010-12-04 13:28:43 -05:00
José Lorenzo Rodríguez
66d0986cd4 Pepending table name to index generation to avoid name clashes
Finally, all tests using a Sqlite database pass
2010-12-03 15:25:26 -04:30
José Lorenzo Rodríguez
e167271568 Making more DboSlite tests pass 2010-12-03 14:41:39 -04:30
José Lorenzo Rodríguez
7c4ab886e6 Merge remote branch 'origin/2.0' into feature/2.0/pdo 2010-12-03 14:08:03 -04:30
José Lorenzo Rodríguez
cdc4cb9e1e Implementing method in DboSqlite to avoid error while running the test suite 2010-12-02 00:20:08 -04:30
José Lorenzo Rodríguez
2e04c5260e Fixing some tests to make them run on sqlite 2010-12-02 00:19:43 -04:30
José Lorenzo Rodríguez
2e9283abd9 Fixing fixture loading for sqlite 2010-11-29 20:52:54 -04:30
José Lorenzo Rodríguez
0d93520e0a Fixing test case for sqlite 2010-11-29 20:52:32 -04:30
José Lorenzo Rodríguez
a791687784 Adding try catch for pdo exception on DboSource::_execute 2010-11-28 23:50:18 -04:30
José Lorenzo Rodríguez
372123f15a Moving common method put from DboMysl into DboSource, this makes more sqlite tests pass 2010-11-28 22:45:56 -04:30
José Lorenzo Rodríguez
492bcea85f mproving decribing process of tables in sqlite 2010-11-27 00:37:13 -04:30
José Lorenzo Rodríguez
0ff01330c4 Making dates deconstruction in model more consistent for different datasources 2010-11-27 00:13:04 -04:30
José Lorenzo Rodríguez
41ee035d28 Starting to bring sqlite dbo up to date 2010-11-26 23:46:34 -04:30
José Lorenzo Rodríguez
b6731dd9ad Merge remote branch 'origin/2.0' into feature/2.0/pdo
Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysqli.test.php
2010-11-26 20:26:41 -04:30
mark_story
845edf38e1 Removing core classes using App::import() with an array(). This usage incurs an additional call to App::import().
Removing Set from core class imports, as Set is required as part of the framework bootstrapping.
2010-11-25 22:51:30 -05:00
mark_story
15ca2400bc Fixing issue in DboSource::name() where special characters in column names would not be correctly quoted.
Tests added.
Fixes #1264
2010-11-25 06:52:23 -05:00
mark_story
bf10723f89 Applying patch from 'michealc' to fix duplicated comments. Fixes #1306 2010-11-22 21:21:55 -05:00
mark_story
8aabf3689e Making BehaviorCollection more consistent with other object collections.
Fixing failing tests caused by not being updated when behavior changed.
2010-11-21 14:42:13 -05:00
mark_story
8821bec049 Moving _mergeVars() into Object as its common to Controller, Model and Shell. 2010-11-21 00:14:29 -05:00
mark_story
e2aeae3825 Adding _mergeVars() into Model.
Refactoring how Model does its property merging.
Eventually _mergeVars() could be moved into Object.
2010-11-21 00:12:07 -05:00
José Lorenzo Rodríguez
40418de218 Freeing up some memory in dbos after the result set has been completly fetched.
Adding dbo_mysql and dbo_postgres to the AllDAtabase testsuite
2010-11-16 23:59:24 -04:30
José Lorenzo Rodríguez
c0f10437ea Adding a few transactions to speed up a little tests involving fixtures 2010-11-16 23:14:48 -04:30
José Lorenzo Rodríguez
1326707c9d Implementing transaction nesting, this will allow to open multiple transactions that will only be commited if all transactions succesfully calls commit() 2010-11-16 22:56:23 -04:30
mark_story
d12c232d8a Merge branch '1.3' into merger
Conflicts:
	app/config/core.php
	cake/console/templates/skel/config/core.php
	cake/dispatcher.php
	cake/libs/controller/components/auth.php
	cake/libs/view/helpers/form.php
	cake/tests/cases/libs/cake_test_case.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/model/models.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helpers/paginator.test.php
	cake/tests/lib/cake_test_case.php
2010-11-16 21:48:13 -05:00
José Lorenzo Rodríguez
f2b707ac0b Merge remote branch 'origin/2.0' into feature/2.0/pdo
Conflicts:
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysqli.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
2010-11-16 21:54:42 -04:30
José Lorenzo Rodríguez
a335891eba mapping lastNumRows to lastAffectedRows as it is not possible to do the first one using PDO 2010-11-16 02:02:08 -04:30
mark_story
9b08b725fe Merge branch '2.0' into 2.0-view
Conflicts:
	cake/libs/controller/controller.php
	cake/libs/view/helpers/cache.php
2010-11-13 21:03:54 -05:00
mark_story
18bb5f6b8b Removing =& operators for construction of objects. 2010-11-12 23:05:44 -05:00
mark_story
6c2b088706 Merge branch '2.0' into 2.0-view 2010-11-10 23:41:44 -05:00
José Lorenzo Rodríguez
00a3eda4d0 Fixing broken test because of change done in previous commit 2010-11-10 23:48:58 -04:30
José Lorenzo Rodríguez
47c6132b24 cleaning up some tests, adding missing parameters in DboSource to match declaration on DataSource 2010-11-09 01:25:05 -04:30
José Lorenzo Rodríguez
9caba98780 Merge branch '2.0' of github.com:cakephp/cakephp into feature/2.0/pdo 2010-11-08 22:40:09 -04:30
José Lorenzo Rodríguez
afa5ee6885 Removing E_STRICT errors from connection manager 2010-11-08 22:37:34 -04:30
mark_story
e8678b38ac Adding specific conditions to model->delete's call to dbo->delete. This
helps fix a race condition where dbo->defaultConditions could cause
additional data loss.  Fixes #250
2010-11-08 21:50:45 -05:00
mark_story
3216c902cd Removing the enable parameter on HelperCollection, BehaviorCollection, and ComponentCollection. They all now support the enabled option that Behaviors have historically supported. This provides a simpler API with fewer arguments, and allows callbacks to be disabled on objects in their declared arrays.
Test cases updated.
2010-11-07 13:23:45 -05:00
mark_story
88c717dbd8 Removing the 3rd param from ObjectCollection::load() and adding a uniform setting of 'callbacks'. This setting is used to disable callbacks on objects by convention. Test cases updated. 2010-11-07 13:23:45 -05:00
ADmad
eb76ab95f2 Fixed issue where Model::saveAll() would incorrectly commit a transaction which was not started in that function call itself. 2010-11-06 09:33:50 +05:30
José Lorenzo Rodríguez
6028705c72 Moving more methods out from DboSourceTest 2010-11-03 19:52:49 -04:30
José Lorenzo Rodríguez
eedd823fd8 Merge remote branch 'origin/2.0' into feature/2.0/pdo 2010-11-03 00:23:18 -04:30
Mark Story
e6aeae8935 Fixing issue where value in difference array was always the string value instead of the original value. 2010-10-31 22:44:45 -04:00
Mark Story
a3da915abd Fixing issue where value in difference array was always the string value instead of the original value. 2010-10-31 22:41:33 -04:00
Mark Story
08e7bcb7ab Merge branch '1.3' into integration
Conflicts:
	app/config/core.php
	cake/console/libs/acl.php
	cake/console/templates/skel/config/core.php
	cake/console/templates/skel/webroot/test.php
	cake/dispatcher.php
	cake/libs/view/errors/missing_action.ctp
	cake/libs/view/helpers/form.php
	cake/tests/cases/libs/cache/memcache.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/log/file_log.test.php
	cake/tests/cases/libs/model/cake_schema.test.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helpers/ajax.test.php
	cake/tests/groups/bake.group.php
	cake/tests/groups/behaviors.group.php
	cake/tests/groups/i18n.group.php
	cake/tests/groups/javascript.group.php
	cake/tests/lib/reporter/cake_cli_reporter.php
2010-10-31 21:56:59 -04:00
mark_story
f5fd069583 Applying patch from 'Justas Butkus' to fix CakeSchema::compare()
Fixes issues with comparing null == '' and adds a new protected method to handle null aware array difference generation.
Tests added.
Fixes #1206
2010-10-27 23:03:31 -04:00
José Lorenzo Rodríguez
b3d8a619a3 Updating test for booleans in postgres 2010-10-26 21:46:29 -04:30
José Lorenzo Rodríguez
ce490b1df2 Fixing issues with translatable field aliasing in TranslateBehavior 2010-10-26 18:22:13 -04:30
José Lorenzo Rodríguez
9f27fa7dfb Fixing parsing of translated data after switching to virtualFields 2010-10-26 17:52:40 -04:30
José Lorenzo Rodríguez
02635696d7 Removing function from created virtual fields in translate behavior as it was not needed 2010-10-26 17:51:29 -04:30
José Lorenzo Rodríguez
90274ef859 restoring commented code to make more tests pass 2010-10-26 17:50:37 -04:30
José Lorenzo Rodríguez
e989f71b99 making a backup of model virtual fields in traslate behavrio to avoid side effects 2010-10-26 17:49:43 -04:30
José Lorenzo Rodríguez
f94f79e146 Initial steps to start using virtual fields in TranslateBehavior, this will ease Dbo abstraction 2010-10-25 23:40:24 -04:30
José Lorenzo Rodríguez
25c213e976 Preventing zero length of fields using prostgres 2010-10-25 20:25:07 -04:30