Commit graph

617 commits

Author SHA1 Message Date
mark_story
aa7448e3ed Fixing incorrect exit codes on console exceptions.
Uncaught exceptions on the console would result in exit code 0.
This is not helpful in *nix scripting.

- Update the ConsoleErrorHandler to not inherit from the web error handler.
- Make ErrorHandler::_mapErrorCode() public as it isn't overly private.
- Make ConsoleErrorHandler methods instance methods so mocking can be done.
- Add a _stop method to correctly exit.
- Update tests.
2011-10-03 22:48:50 -04:00
Jose Lorenzo Rodriguez
0a2553cce5 Making model tests less time dependent 2011-10-03 14:51:07 -04:30
Jose Lorenzo Rodriguez
71c73503c6 Making test case less configuration independent 2011-10-03 12:13:11 -04:30
Jose Lorenzo Rodriguez
d08f916179 Grabbing the first available config defined in connection manager as a default for baking. Fixing a couple of failing test cases 2011-10-03 11:54:40 -04:30
mark_story
84f805419d Fixing issue where DbConfigTask would try to rebuild
database configuration.

This could happen when using commands like `Console/cake bake controller`.
Using ConnectionManager ensures that the database config file will be loaded
if its available.
2011-10-02 22:53:45 -04:00
mark_story
aae2b0c257 Fixing issue baking controller tests.
During interactive controller baking, controller tests
would be generated with the wrong filename.
During interactive baking fixtures would not be detected.
Fixes #2052
2011-10-02 22:53:37 -04:00
mark_story
3907c2bdf3 Fixing build failure in Postgres. 2011-10-01 22:49:57 -04:00
mark_story
c9bd97309f Merge branch '1.3' into merger
Conflicts:
	cake/libs/configure.php
	cake/libs/controller/components/email.php
	cake/libs/model/datasources/dbo/dbo_mysqli.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/controller/components/email.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
	lib/Cake/Config/config.php
	lib/Cake/Console/Command/Task/ViewTask.php
	lib/Cake/Model/Datasource/DboSource.php
	lib/Cake/Model/Model.php
	lib/Cake/Test/Case/Model/ModelReadTest.php
	lib/Cake/Test/Case/Model/ModelValidationTest.php
	lib/Cake/Test/Case/Utility/InflectorTest.php
	lib/Cake/Test/Case/View/Helper/FormHelperTest.php
	lib/Cake/Utility/Inflector.php
	lib/Cake/Utility/Validation.php
	lib/Cake/VERSION.txt
	lib/Cake/View/Helper.php
	lib/Cake/View/Helper/FormHelper.php
2011-10-01 22:38:20 -04:00
Jose Lorenzo Rodriguez
5d19b6ded9 Removing test ins porstgres that wasn't actually testing a thing, and making another postgres test pass 2011-10-01 15:25:17 -04:30
Jose Lorenzo Rodriguez
61be5b1d5c Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-10-01 14:08:56 -04:30
Jose Lorenzo Rodriguez
b8aa000589 Re-implementing Mysql::listDetailedSources() to not use prepared statements, using php <= 5.3.5 + mysqlnd internal driver causes segmentation faults when using a similar query from this method several times. 2011-10-01 14:06:41 -04:30
mark_story
d9db8c8124 Fixing failing test on postgres build. 2011-10-01 09:08:18 -04:00
mark_story
df82aa09e4 Removing test that causes problems in AllTests. 2011-09-30 22:47:47 -04:00
mark_story
0fc6d7a98d Making test more generic so it passes on Jenkins. 2011-09-30 22:44:04 -04:00
mark_story
4810518c7d Fix issue where abstract or interface controllers
would be constructed by Dispatcher.
Tests added.
Fixes #2048
2011-09-30 22:40:30 -04:00
mark_story
115c656dcc Update expectation to account for umask()
Updating a number of simple assertEqual -> assertEquals.
Fixes #2045
2011-09-30 22:10:16 -04:00
mark_story
af4b0c9c1b Make DboSource::lastError() fallback to the connection.
If there is no argument the connection error should be checked
for an error.
Add a test for most of lastError().  Mocking PDO is a pain.
Fixes #2046
2011-09-30 21:56:39 -04:00
mark_story
a3f25ee5e3 Fixing issue with integer columns and NULL values.
Fixes #2037
2011-09-29 20:28:52 -04:00
Jose Lorenzo Rodriguez
8acd980895 Converting more pattern assertions into simple string contains 2011-09-29 00:42:24 -04:30
Jose Lorenzo Rodriguez
fbdb058441 Converting regular expression assertions to simple string contains, those perform faster and consume less memory 2011-09-29 00:05:15 -04:30
Jose Lorenzo Rodriguez
27ab12dd2a Simplifying assertions in FixtureTask test 2011-09-28 23:39:07 -04:30
Jose Lorenzo Rodriguez
7b3ceb5a29 Fixing a few failing test cases and attempting to work around php segmentation fault when running the complete test suite 2011-09-28 22:57:50 -04:30
mark_story
08b974d64b Adding the _x and _y fields to the unlocked fields
for image submits.
Fixes #2032
2011-09-27 21:14:36 -04:00
Majna
8d6fc84135 Fixing failing test for Router. Debugger test fails on windows due to different directory separator. 2011-09-27 23:47:44 +02:00
ADmad
33030a4502 Fixing my previous attempt in ef4826e to make Model::_findCount() behave nicely with 'group' option. Refs #1677, #573 2011-09-28 02:58:48 +05:30
mark_story
7e44836837 Fixing failing test. 2011-09-26 21:46:25 -04:00
mark_story
a5fe702624 Updating CrudAuthorize to work like ActionsAuthorize.
Updating tests.
Fixes #1749
2011-09-26 20:38:38 -04:00
mark_story
79687a2dcf Making locking file caching the default.
Locking files prevents many issues with unserialize() warnings
caused by partially written files.
Fix a locking issue where files would be left locked.
Fixes #1988
2011-09-25 09:26:32 -04:00
mark_story
b1dad6e5bd Adding session renewal upon login/logout.
This helps improve session security, as it reduces the opportunity
of replaying a session id successfully.
Fixes #836
2011-09-24 22:35:21 -04:00
mark_story
50a0a51f53 Renaming method to better match what it does. 2011-09-24 21:56:37 -04:00
Yosuke Basuke Suzuki
5612d411f3 Added unittest for saveAll() validation with the data no id assigned. 2011-09-23 22:23:26 +09:00
mark_story
36928d35f9 Redoing fix done in 155968349f
Adding more test cleanup to try and solve build issues.
2011-09-22 22:05:36 -04:00
Jelle Henkens
957a75c45e Removing PHP4 compatibility code
Signed-off-by: mark_story <mark@mark-story.com>
2011-09-20 21:10:32 -04:00
Jose Lorenzo Rodriguez
8ccf90437a Typo in last commit. Making flexible the range for memory usage in theme view after changing internal templates 2011-09-18 16:43:00 -04:30
Jose Lorenzo Rodriguez
a2daa39a98 Making theme test more flexible so it passes after recent changes in templates 2011-09-18 16:37:17 -04:30
mark_story
8d43764801 Fix issue with duplicate associations when using string form.
Fixes #2002
2011-09-18 12:26:59 -04:00
mark_story
6a4e7558fc Merge branch '1.3' into merger
Conflicts:
	cake/basics.php
	cake/console/libs/tasks/extract.php
	cake/libs/view/helpers/js.php
	cake/tests/cases/console/libs/tasks/extract.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
	cake/tests/test_app/views/pages/extract.ctp
	lib/Cake/Cache/Engine/MemcacheEngine.php
	lib/Cake/Model/Behavior/ContainableBehavior.php
	lib/Cake/Model/Datasource/Database/Mysql.php
	lib/Cake/Model/Datasource/DboSource.php
	lib/Cake/Model/Model.php
	lib/Cake/Test/Case/Model/Behavior/ContainableBehaviorTest.php
	lib/Cake/Test/Case/Model/CakeSchemaTest.php
	lib/Cake/Test/Case/Model/Datasource/Database/PostgresTest.php
	lib/Cake/Test/Case/View/Helper/FormHelperTest.php
	lib/Cake/Test/Case/View/Helper/TimeHelperTest.php
2011-09-18 12:09:04 -04:00
ADmad
08026e5828 The 'default' config for Configure class is now auto created on first use if not already created. 2011-09-18 00:06:37 +05:30
mark_story
0e5797d69d Make full page caching + Themes work.
Dispatcher now uses ThemeView for rendering cache files.
This enables nocache blocks to reference theme elements.
Fixes #1858
2011-09-17 13:19:43 -04:00
mark_story
85b86cb282 Fix entity names for associated model date fields.
Fixes #1993
2011-09-17 12:29:21 -04:00
mark_story
09e7f1d491 Splitting apart the Scaffold and ScaffoldView tests.
Fixes #1985
2011-09-16 22:08:19 -04:00
Renan Gonçalves
4378bb6dc4 Fixed bug in CakeSchema where it determines the field position.
- Respective tests were added.
- Schema files will now have 'after' => 'previous_field' on it.
2011-09-16 15:28:28 +02:00
mark_story
42dccac8da Splitting AclTest into multiple test case files.
Fixes #1985
2011-09-13 21:25:50 -04:00
mark_story
4fda085928 Trying to fix occasional error during FixtureTaskTest. 2011-09-13 20:45:45 -04:00
Jelle Henkens
7ba2f90b2a Refactoring expectError() calls to PHPUnit annotations 2011-09-13 19:56:37 +01:00
mark_story
8272705fee Fixing failing test from previous commit. 2011-09-12 23:25:13 -04:00
mark_story
59e306526f Adding 'vendors' alias to App
- Vendor is the new directory name, and a legacy mapping should exist.
  This makes App::path() match App::import() and all other packages.
- Add an alias for plugins -> Plugin.  It also was missing the alias,
  that matches the new style package names.

Fixes #1972
2011-09-12 23:20:29 -04:00
mark_story
d74f442608 Making test case class names match file names.
Refs #1985
2011-09-12 23:01:04 -04:00
Mark Story
0e9b3dd613 Merge pull request #198 from jellehenkens/2.0-rss-helper-tests
Added tests for the RssHelper for code that was not covered
2011-09-12 19:59:09 -07:00
ADmad
97a975c6c4 Refactoring Model::invalidFields() a bit. 2011-09-12 05:10:34 +05:30
Jelle Henkens
236200ca56 Improved error handling for writing the test file to disk 2011-09-10 17:02:22 +01:00
AD7six
61f8de440d Merge branch '2.0-simpler-test' of github.com:cakephp/cakephp into feature/2.0-simpler-tests
Conflicts:
	lib/Cake/Console/Command/TestShell.php
2011-09-10 17:08:00 +02:00
Jelle Henkens
38196bda3f Adding missing test scenarios in the rss helper 2011-09-10 11:49:49 +01:00
Jelle Henkens
653163c891 Adding missing test scenarios in the paginator helper 2011-09-09 21:47:26 -04:00
mark_story
608e5ee04b Refactoring test.
Removing expectError() replacing it with PHPUnit annotation.
2011-09-09 21:43:57 -04:00
Jelle Henkens
aa4545217e Fixing test by splitting them up, testing the expected error ignored the next asserts 2011-09-09 21:40:05 -04:00
mark_story
3cb3424b4f Add App::uses to baked controllers.
Controllers should load their dependencies.
Bake should help with the best practice.
Fixes #1971
2011-09-09 20:43:04 -04:00
mark_story
7c08c966b0 Adding App::uses() call to model baking.
Models should always include their parent classes to be safe.
Bake should reflect the best practice.
Refs #1971
2011-09-09 20:43:04 -04:00
mark_story
1743eaa776 Fix issue with HABTM fields
habtm fields were not being correctly being detected.
2011-09-08 22:18:44 -04:00
mark_story
fa8bdfd0dd Add fix and test for CamelBack input names.
Refs #1974
2011-09-08 20:34:41 -04:00
Mark Story
8880e0c668 Merge pull request #192 from jellehenkens/2.0-html-helper-tests
Added tests for the HtmlHelper for code that was not covered
2011-09-07 18:03:02 -07:00
mark_story
6ab59a447c Fix create() and onsubmit option.
Removing support for onSubmit variant.  Additional
choices are not necessary. Fixing onsubmit option
not correctly working.
Fixes #1977
2011-09-07 20:59:04 -04:00
Jelle Henkens
3c8c2936b3 Added tests to test ajax settings 2011-09-07 20:59:04 -04:00
Jelle Henkens
e6826fea21 Adding tests for HtmlHelper 2011-09-08 00:59:39 +01:00
mark_story
39c270fd84 Attempting to fix build failure in Jenkins. 2011-09-05 21:53:29 -04:00
mark_story
684c154777 Removing more flaky tests. 2011-09-04 10:50:15 +01:00
mark_story
2218923782 Removing a failing test. I think the encoding of the file has changed over time,
and I don't have a typeface with lowercase Georgian text.
2011-09-04 10:22:35 +01:00
Jose Lorenzo Rodriguez
3d0af8b690 Adding a new exception renderer method to show useful error for failed queries 2011-09-04 04:50:19 -04:30
Jose Lorenzo Rodriguez
843f7e3eef Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-03 21:08:50 -04:30
Jose Lorenzo Rodriguez
12c73806f4 Skipping tests on Sqlite that involve creating a duplicate connection/ It is not possible to open multiple connections to it 2011-09-03 21:07:40 -04:30
mark_story
8630f4cdcb Fixing mistake in last commit. 2011-09-04 02:15:45 +01:00
mark_story
8c8dc6cebb Fixing the one failing Multibyte test. 2011-09-04 01:55:26 +01:00
mark_story
dbf801b9d4 Fixing failing test. 2011-09-04 01:06:00 +01:00
Jose Lorenzo Rodriguez
149deba416 Fixing Mysql test case after making the DboSource throw exceptions 2011-09-03 19:12:06 -04:30
Jose Lorenzo Rodriguez
8897335af4 All tests passing on postgres 2011-09-03 18:58:53 -04:30
Jose Lorenzo Rodriguez
74ba030e7c More postgres tests passing again 2011-09-03 18:34:11 -04:30
Jose Lorenzo Rodriguez
93d6cd4ad6 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-03 18:08:16 -04:30
Jose Lorenzo Rodriguez
61ff8d6154 Making DboSource tests more portable 2011-09-03 18:07:26 -04:30
mark_story
d597186274 Fixing a few more failing tests.
Adding some parent calls to tests, removing duplicated junk.
2011-09-03 23:23:24 +01:00
Jose Lorenzo Rodriguez
d06d5f8738 Not checking length on databases that won't return it for floats 2011-09-03 17:21:48 -04:30
Jose Lorenzo Rodriguez
fcf58371fd Fixing a failing postgres test 2011-09-03 17:09:41 -04:30
Jose Lorenzo Rodriguez
7003edeb8f Adding missing expectedException annotations 2011-09-03 17:05:09 -04:30
Jose Lorenzo Rodriguez
0ca8af2c22 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-03 17:01:49 -04:30
Jose Lorenzo Rodriguez
f0ef0aab62 Making postgres tests pass 2011-09-03 17:00:16 -04:30
mark_story
2c21fc90fb Fixing failing tests and issues with Sqlite. 2011-09-03 22:07:45 +01:00
Jose Lorenzo Rodriguez
49b8b24ac2 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-03 13:09:04 -04:30
mark_story
2ceea79862 Fixing errors and failing tests with SQLite.
Seems that MySQL is extremely permissive with NOT NULL fields.
SQLite is more strict it seems.
2011-09-03 18:37:29 +01:00
Jose Lorenzo Rodriguez
36470f4a86 Removing $error property from DboSource, errors in queries will throw exceptions now 2011-09-03 12:17:00 -04:30
Jose Lorenzo Rodriguez
df303f9e09 Fixing remaining failing tests 2011-09-03 09:43:50 -04:30
Jose Lorenzo Rodriguez
2bca1435ab Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-09-03 07:05:48 -04:30
Jose Lorenzo Rodriguez
01f26995b6 Fixing failing test in fixture test case 2011-09-03 07:04:51 -04:30
Jose Lorenzo Rodriguez
89b1e54071 Removing Oracle driver, it will not make it to stable release. Revert this commit to bring it back for next version 2011-09-03 06:50:19 -04:30
mark_story
ca078d9a25 Converging on 4px for border-radius.
Updating debug() to output a tiny bit more HTML so it can be made sexy.
2011-09-03 10:06:01 +01:00
mark_story
f1f4afacbd Fixing duplication of classes. cake-debug was used for debug and error messages. 2011-09-03 10:06:01 +01:00
mark_story
85d9b1af8d Fixing failing tests caused by path/object cache issues. 2011-09-03 01:14:51 +01:00
mark_story
efbeab6199 Merge branch '1.3' into merger
Conflicts:
	cake/libs/controller/components/email.php
	cake/tests/cases/console/libs/tasks/fixture.test.php
	lib/Cake/Console/Command/Task/DbConfigTask.php
2011-09-03 00:48:09 +01:00
Renan Gonçalves
7ae89c3679 Checking if short options exist, fixed an warning caused by not checking it. 2011-09-01 22:10:42 +02:00
Mark Story mark@mark-story.com
957a8d5c00 Fixing log files to directories a webserver doesn't always have write access too. 2011-09-01 20:24:39 +01:00
Mark Story mark@mark-story.com
41b22c5521 Fixing Router::mapResources() so it works with plugins.
Fixes #1956
2011-09-01 18:49:01 +01:00
Mark Story mark@mark-story.com
4d1f41dddc Fixing failing tests cased by App::object() cache being warm.
Removing code duplicated in CakeTestCase methods.
Adding missing parent calls.
2011-09-01 00:38:08 +01:00
Mark Story mark@mark-story.com
572412ec6b Removing bad integration test that wasn't required anymore. 2011-09-01 00:23:59 +01:00
Mark Story mark@mark-story.com
bb3a1d546b Fixing RequesHandler::prefers(). It was previously entirely wrong.
It took the ordered list of accept types, and blindly assumed
the first in the list was the most preferred.  This is an incorrect
assumption to make, as all types with the same q value are equal.

- Using CakeRequest::parseAccept() to access only the most preferred
content types.
- Using in_array() to check for the desired type.
- Updating tests for RequestHandler.
2011-09-01 00:20:54 +01:00
Mark Story mark@mark-story.com
e2f48b4a95 Refactoring how q values are parsed, as content types were
reversed for similar q value types.  This causes issues in
RequestHandlerComponent.
2011-09-01 00:20:54 +01:00
Jose Lorenzo Rodriguez
b9b7516945 Merge remote-tracking branch 'ceeram/2.0-email' into 2.0
Conflicts:
	lib/Cake/Network/Email/AbstractTransport.php
	lib/Cake/Network/Email/CakeEmail.php
	lib/Cake/Network/Email/DebugTransport.php
	lib/Cake/Network/Email/MailTransport.php
	lib/Cake/Network/Email/SmtpTransport.php
2011-08-31 17:39:41 -04:30
Juan Basso
840d27bbb9 Fixed the allow method to parameters not be required. 2011-08-30 21:12:57 -04:00
Jose Lorenzo Rodriguez
6612cb3421 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-08-30 00:08:54 -04:30
Jose Lorenzo Rodriguez
a8b38beb9d Fixing bug in SchemaShell where it would always force a read on all tables 2011-08-30 00:07:57 -04:30
Mark Story mark@mark-story.com
3a8b344208 Fixing issue where CakeTestCase would erase custom bootstrapped paths in tearDown().
Adding App::paths() to simplify getting all the paths App knows about.
Fixes #1934
2011-08-29 22:14:18 -04:00
Jose Lorenzo Rodriguez
0e85170f28 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-08-29 16:55:27 -04:30
Jose Lorenzo Rodriguez
40ba4005bd Affecting the REQUEST_METHOD env variable in order to ease controller testing with different http verbs 2011-08-29 16:54:22 -04:30
Ceeram
0b00fb4fe0 fixing bug in deliver(), and adding more tests 2011-08-29 17:13:41 +02:00
Ceeram
4b093a858c adding more testcases for CakeEmail 2011-08-29 16:02:00 +02:00
Ceeram
c5d0955cd0 adding back blank line 2011-08-29 11:39:08 +02:00
Ceeram
87ffd92c2b Fixing transport test, as transport class now returns as stated in RFC 2822 2011-08-29 11:38:01 +02:00
Ceeram
3be9a8a5e8 debugtransport now also returns in correct format as stated in RFC 2822 2.3, updated tests 2011-08-29 11:21:46 +02:00
Mark Story
59c6b419e5 Merge branch '1.3' into merger
Conflicts:
	cake/console/libs/bake.php
	cake/libs/configure.php
	cake/libs/controller/components/request_handler.php
	cake/tests/cases/console/libs/tasks/fixture.test.php
	cake/tests/cases/libs/controller/components/request_handler.test.php
	lib/Cake/Cache/Engine/FileEngine.php
	lib/Cake/Test/Case/Controller/ScaffoldTest.php
	lib/Cake/Utility/Validation.php
2011-08-28 22:08:49 -04:00
Ceeram
2efa3b0377 optmizing CakeEmail, and improving tests, transport class config() now returns configs array if no array is passed 2011-08-29 03:11:30 +02:00
mark_story
9ff922cbc7 App::objects() should skip directories and files starting with
`.`.  These generally contain version control or OS metadata, and
not code CakePHP can use.
Fixes #1933
2011-08-28 15:36:19 -04:00
mark_story
1a872e6544 Fixing CakeRequest::accepts() where ;q values on Accept header
were not respected.
Fixes #1940
2011-08-27 11:39:22 -04:00
mark_story
5df12a287e Fixing failing tests caused by moving params[ext]. 2011-08-27 10:36:11 -04:00
mark_story
02a6883b22 Using Folder class in CakeTestSuite, this fixes issues where
hidden directories from VCS would be added as test cases.
Fixes #1933
2011-08-27 10:34:08 -04:00
Jose Lorenzo Rodriguez
f94394f582 Removing routing url from query string in CakeRequest. This happens mostly with nginx setups 2011-08-27 01:29:50 -04:30
Juan Basso
7d0250ff47 Merge branch '2.0-api-doc' into 2.0 2011-08-26 20:22:26 -04:00
mark_story
5955cc6ed7 Adding trimming of Accept headers to CakeRequest.
Fixes #1684
2011-08-25 22:28:02 -04:00
Ceeram
9e0ff5ad88 add Cakelog to send(), transport classes now all return in same format, fixing some typos 2011-08-26 02:31:18 +02:00
Ceeram
4cc5295400 more refactoring of CakeEmail 2011-08-25 16:03:39 +02:00
Juan Basso
c60abb1802 Fixed tests affected by the visibility changes. 2011-08-24 23:10:51 -04:00
mark_story
6acf024a2b Fixing incorrect keying for ext routing parameter. It was
nested under params[url][ext].  This makes it unlike
all other routing parameters.  Having the nested value
also makes reversing requests harder, and generating urls more
difficult.
Adding a test for Router::reverse() and extensions.
Fixes #1923, fixes #1928
2011-08-22 22:26:02 -04:00
Mark Story
68b2d67b0a Adding support for callback style error formatters.
This will allow other classes to inject custom error formatting
code into debugger.  Hopefully making it possible to remove the getInstance() workarounds.
2011-08-22 20:44:33 -04:00
Mark Story
48c6b78660 Adding tests for Debugger::addFormat() 2011-08-22 20:44:32 -04:00
Mark Story
73f4b8c8bf Adding additional test cases for assertTags. 2011-08-22 20:44:32 -04:00
Mark Story
daf1251473 Adding tests for Debugger::outputAs()
Adding exceptions for invalid state checking.
2011-08-22 20:44:32 -04:00
Juan Basso
dbb87a0196 Changed protected callbacks of scaffold to public in Controller. 2011-08-21 23:18:55 -04:00
Juan Basso
e9390985ca Changed mergeAssociation scrubQueryData to be protected. 2011-08-21 21:27:35 -04:00
Juan Basso
689c7ffd45 Fixed some problems caused by the visibility changes. 2011-08-21 01:04:55 -04:00
Mark Story
7276f3357d Fixing issues where ControllerTestCase couldn't properly hit plugin
controllers.
Fixing some formatting.
Fixes #1918
2011-08-20 09:58:35 -04:00
Mark Story
70f47378f9 Fixing options[data] always writing its data into $_POST['data'].
It now just overwrites $_POST.
Fixes #1917
2011-08-20 09:46:01 -04:00
Mark Story
0091fac5b9 Adding prefix based cache clearning to Wincache.
This matches APC and Memcache.
Fixes #1911
2011-08-20 09:27:33 -04:00
Mark Story
ef921fa56f Making ApcEngine::clear() only clear keys with a matching
prefix. Refs #1911
2011-08-20 09:27:33 -04:00
Juan Basso
a1a049c700 Merge remote-tracking branch 'origin/2.0' into 2.0-api-doc
Conflicts:
	lib/Cake/Model/Model.php
	lib/Cake/View/Helper/CacheHelper.php
2011-08-20 01:47:27 -04:00
Juan Basso
61833294f0 Changed the visibility to methods that not affect others classes. 2011-08-20 01:39:30 -04:00
Juan Basso
3dd86ebfd4 Fixed the Memcache::clear() to not flush all the server, just the variables associated with the prefix. Refs #1911 2011-08-19 22:12:37 -04:00
Mark Story
46c07add3f Fixing issues with HTML5 number inputs and float columns.
For float columns, the default step value is 'any'
Fixes #1907
2011-08-18 22:31:00 -04:00
ADmad
c3884f407f Implemented feature to allow multiple counter caches per associated model. 2011-08-17 18:10:32 +05:30
Mark Story
54e1de9070 Adding visibility keywords to code that came from
a 1.3 merge.
2011-08-16 22:40:38 -04:00
Juan Basso
620a65b2fc Merge branch '2.0' into 2.0-api-doc
Conflicts:
	lib/Cake/Test/Case/View/Helper/CacheHelperTest.php
	lib/Cake/Utility/Debugger.php
2011-08-14 21:12:05 -04:00
mark_story
182b13fdbd Fixing failing test. In 2.0, absolute paths are not altered. 2011-08-14 14:49:56 -04:00
mark_story
d93c8cb200 Merge branch '1.3' into merger
Conflicts:
	cake/libs/controller/components/security.php
	cake/libs/view/pages/home.ctp
	cake/libs/view/view.php
	lib/Cake/Cache/Engine/FileEngine.php
	lib/Cake/Config/config.php
	lib/Cake/Model/Datasource/Database/Postgres.php
	lib/Cake/Test/Case/Utility/SanitizeTest.php
	lib/Cake/Test/Case/Utility/SetTest.php
	lib/Cake/Test/Case/View/Helper/CacheHelperTest.php
	lib/Cake/Test/Case/View/Helper/FormHelperTest.php
	lib/Cake/VERSION.txt
	lib/Cake/View/Helper/CacheHelper.php
2011-08-14 14:39:49 -04:00
ADmad
ef4826eb70 Making Model::find('count') behave nicely when 'group' key is specified in options. Closes #1677 2011-08-14 07:37:23 +05:30
ADmad
5d79299362 For paging links the 'class' attribute is now always applied to the wrapping tag for consistency. Closes #1759 2011-08-14 05:09:57 +05:30
ADmad
b781762903 Fixing regression in Set::extract(). Refs #1895, #1816, #1692. 2011-08-14 03:11:55 +05:30
ADmad
7983b4109b Data returned by Model::save() not contains primary key too when new record is created. Closes #1869 2011-08-14 02:56:08 +05:30
mark_story
fdacc9de16 Fixing issues with request stack not being used correctly
when there are requestAction requests being performed.
Adding Router::popRequest() to allow manipulation of request stack
so nested requestAction or serial requestAction calls work correctly.
Fixes #1906
2011-08-12 21:21:05 -04:00
mark_story
3014d3fb84 Fixing issues with CSRF token failure and requestAction.
Fixes #1900
2011-08-12 20:38:24 -04:00
Jose Lorenzo Rodriguez
1726bad396 Adding ability to Set class to iterate on ArrayObjects, or any object implementing ArrayAccess and Traversable 2011-08-11 13:26:06 -04:30
Mark Story
6026aa4019 Adding tests for FormHelper::postButton() and SecurityComponent. 2011-08-10 22:00:02 -04:00
Mark Story
2ce2d06de2 Fixing issue where postLink() would fail when used with SecurityComponent. 2011-08-10 21:53:33 -04:00
Mark Story
e9382d0897 Fixing failing tests. 2011-08-10 21:40:53 -04:00
Maggion Emmanuel
27734507e4 Adding test case 2011-08-09 20:47:25 +03:00
Mark Story
5d3c470871 Fixing issues where option values started with '-'. 2011-08-06 15:43:41 -04:00
Mark Story
b7391274fb Adding an exception when a short option is longer than one
character. Having long short options breaks parsing, and
doesn't make sense with how short options are used.
2011-08-06 15:21:42 -04:00
Mark Story
fb756c5aee Fixing incorrectly inflected shell names in help. 2011-08-06 09:52:07 -04:00
Mark Story
5f84b4846c Making long options & arguments replaced with short forms.
Fixes #1882
2011-08-06 09:50:41 -04:00
Mark Story
b362afee06 Changing assertPattern to assertRegExp. 2011-08-03 20:06:47 -04:00
Mark Story
cdcabc79b6 Doing some refactoring in the project task.
Adding tests for constants staying commented out when CakePHP is on the include_path.
2011-08-03 20:06:47 -04:00
Mark Story
4da671c952 Merge pull request #157 from ProLoser/patch-2
Added `'integer' => 'number'` for HTML5
2011-08-01 18:07:40 -07:00
Juan Basso
d84531d29c Using @property to autocomplete components and helpers in some IDEs. Also added @property to bake of controller and model. Fixes #103. 2011-07-31 20:28:35 -04:00
ADmad
9577fb0ca2 Fixed TreeBehavior::childCount(). Closes #1833 2011-07-31 12:39:52 +05:30
Jose Lorenzo Rodriguez
eaa01634b1 Making ControllerTestCase abstract, that way PHP won't complain about empty test cases, closes #1868 2011-07-30 22:05:17 -04:30
ADmad
b15c77ecc3 Enhancing validation messages to have placeholders. Closes #1855 2011-07-31 06:33:56 +05:30
Juan Basso
9bc3e567c1 Removed the @access and @static. 2011-07-30 20:56:48 -04:00
mark_story
f9373ff504 Fixing double output issues with Scaffold. 2011-07-28 18:09:19 -04:00
Majna
29e4cad99e Fix for lowercased schema folder when baking plugin skel 2011-07-28 18:57:10 +02:00
Dean Sofer
804e88b092 Added test for HTML5 FormHelper::input() integer to number in $map 2011-07-26 02:19:41 -07:00
Jose Lorenzo Rodriguez
cfd2d9e00b Updating all @package annotations in doc blocks 2011-07-26 01:46:14 -04:30
Jose Lorenzo Rodriguez
21ff9caac7 Solving scope problem after clearing up variables in the default routes file 2011-07-25 23:58:08 -04:30
Jose Lorenzo Rodriguez
959a9689b3 Merge remote-tracking branch 'origin/2.0-paginator-count' into 2.0 2011-07-25 23:29:04 -04:30
Jose Lorenzo Rodriguez
165dcf11b1 Merge remote-tracking branch 'origin/2.0-saveall' into 2.0 2011-07-25 19:22:17 -04:30
Jose Lorenzo Rodriguez
febf28f34b Merge remote-tracking branch 'origin/1.3' into 2.0
Conflicts:
	cake/console/templates/default/views/home.ctp
	cake/libs/controller/controller.php
	cake/libs/model/datasources/dbo/dbo_mysqli.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/view/media.test.php
	cake/tests/lib/cake_test_case.php
	cake/tests/lib/code_coverage_manager.php
	cake/tests/test_app/views/pages/home.ctp
	lib/Cake/Cache/Engine/ApcEngine.php
	lib/Cake/Model/Datasource/Database/Mysql.php
	lib/Cake/View/Helper/FormHelper.php
2011-07-25 14:44:23 -04:30
Ceeram
b8daa99cac Splitting saveAll into separate save and validation methods for many rows and associated rows. Closes ticket #1157 2011-07-25 09:39:03 +02:00
Juan Basso
b8c00d5f56 Changed the paginator to do a count after the find. 2011-07-23 21:09:55 -04:00
mark_story
6fb3c72d49 Fixing issue where plugin models in $uses, would create
incorrect forms when create() is called with no arguments.
Fixes #1841
2011-07-23 14:49:39 -04:00
mark_story
3589a17321 Merge branch 'request-response' into 2.0 2011-07-23 14:23:06 -04:00
mark_story
63ea4ef99a Fixing missing fixture causing test failure. 2011-07-22 20:45:33 -04:00
Mark Story
ec3de84c4e Removing getResponse, its not used and it doesn't serve much purpose. 2011-07-22 20:29:45 -04:00
mark_story
c37c641b4a Fixing failing tests because of core routes not being loaded. 2011-07-22 20:29:45 -04:00
mark_story
16073b4e44 Fixing notice errors in Router.
Updating AuthComponent tests for changes in Router behavior.
2011-07-22 20:29:45 -04:00
mark_story
be98e0b962 Updating Folder tests for new file.
Converting assertIdentical to assertSame.
2011-07-22 20:29:45 -04:00
mark_story
f0819d364c Updating Dispatcher tests for changes in Router. 2011-07-22 20:29:45 -04:00
mark_story
cfb3e8a15b Moving default routes into a separate file.
Removing Router::defaults() as its not needed anymore.
Removing default routes from inside router.
Removing properties related to default routes.
Removing dead tests and updating tests.
2011-07-22 20:29:45 -04:00
mark_story
358d591e95 Making ApiShell test, which uses Controller pass. 2011-07-22 20:29:44 -04:00
mark_story
b56931383c Adding tests. 2011-07-22 20:29:44 -04:00
mark_story
61ab769f1c Moving tests for private actions to ControllerTest. 2011-07-22 20:29:44 -04:00
mark_story
c25394278b Returning response objects from controllers wasn't working correctly. 2011-07-22 20:29:44 -04:00
mark_story
177cd39abb Moving private method detection into Controller.
This fixes an issue where potected methods would
not be called, and no exception would be raised.
2011-07-22 20:29:44 -04:00
mark_story
70744f3cb4 Fixing failing tests for Controller.
Adding a string cast for easier testing.
2011-07-22 20:29:44 -04:00
mark_story
173e043eaf Fixing more failing tests caused by requestAction
and changes in Controller::__construct.
2011-07-22 20:29:44 -04:00
mark_story
fc08784c22 Making Controller tests pass. 2011-07-22 20:29:43 -04:00
mark_story
5240edeb82 Refactoring tests to better use PHPUnit's features
Removing non-functional cruft.
2011-07-22 20:29:43 -04:00
mark_story
9641bcc8df Modifying Dispatcher and its test cases to accept a CakeResponse as part of its
arguments.
2011-07-22 20:29:43 -04:00
Jose Lorenzo Rodriguez
420a2f56df Merge branch '2.0-dbo-performance' into 2.0 2011-07-20 22:15:45 -04:30
Ceeram
4ae9058012 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-07-19 10:57:41 +02:00
Ceeram
f94c50dc5d added ModelDeleteTest to AllModelTest 2011-07-19 10:57:31 +02:00
Juan Basso
a2e7c0febe Optimization in FormHelper::postLink(). 2011-07-18 20:33:45 -04:00
Jose Lorenzo Rodriguez
50d4330487 Ensuring uniqueness of method cache keys, all tests passing now 2011-07-17 23:45:22 -04:30
Jose Lorenzo Rodriguez
08be8300ee Merge branch '2.0' into 2.0-dbo-performance 2011-07-17 23:22:58 -04:30
Jose Lorenzo Rodriguez
222df2c315 Removing unneeded assert that fails when run in the all test suite 2011-07-17 23:12:51 -04:30
Jose Lorenzo Rodriguez
4c8f5ce5be Bringing up to date the ModelTask test case after adding the new validation method 2011-07-17 22:46:56 -04:30
Jose Lorenzo Rodriguez
b603232aee Removing redundant call to DboSource::fields(), the fields come already quoted from DboSource::read() 2011-07-17 17:42:47 -04:30
Jose Lorenzo Rodriguez
108505a6a0 Merge branch '2.0-form-helper' into 2.0 2011-07-16 17:32:07 -04:30
Jose Lorenzo Rodriguez
ca0dccb1e7 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-07-15 18:30:55 -04:30
Jose Lorenzo Rodriguez
a02db65fd1 Removing persist object feature, it was problematic an incomplete 2011-07-15 18:30:03 -04:30
Jose Lorenzo Rodriguez
d5ce09cd96 Restoring the validationErrors property in FormHelper, it will be checked first before the validation errors in the model 2011-07-15 18:24:27 -04:30
José Lorenzo Rodríguez
7596fcf45a Merge pull request #153 from ajibarra/e4c1f28d849c6a60c369265a502315260babe80b
Preventing AppModel to be inspected inside CakeSchema
2011-07-15 14:48:01 -07:00
José Lorenzo Rodríguez
57a8c108a6 Merge pull request #147 from burzum/feature/2.0-return-query
Feature/2.0 return query
2011-07-15 14:10:08 -07:00
Alejandro Ibarra
e4c1f28d84 Included validation to skip AppModel on CakeSchema->readSchema because it tries to find 'app_models' table. Added testSchemaReadWithAppModel test 2011-07-15 15:18:38 -04:30
Jose Lorenzo Rodriguez
fb264d9671 Adding a datetime validation method to the Validation class, closes #1021 2011-07-15 01:20:37 -04:30
Jose Lorenzo Rodriguez
8a6d97dfa7 Fixing loading of default options in CakePlugin::loadAll(), fixes #1737 2011-07-15 01:05:53 -04:30
Jose Lorenzo Rodriguez
37231b4ce6 Updating Controller test case 2011-07-14 17:38:02 -04:30
Jose Lorenzo Rodriguez
ac2538b108 REmoving call to deprecated method in PHPUnit 2011-07-14 17:28:53 -04:30
Jose Lorenzo Rodriguez
0c79ad88a3 Cleaning up the code and adding tests for new features 2011-07-14 17:26:55 -04:30
Jose Lorenzo Rodriguez
0228611969 Fixing remaining failing tests on FormHelperTest case 2011-07-14 13:56:31 -04:30
Jose Lorenzo Rodriguez
a5851e9597 Updating test to reflect that models passed as a request parameter are now in an associative array 2011-07-14 13:53:27 -04:30
Jose Lorenzo Rodriguez
4ed46cf330 Updating more tests on FormHelperTest case 2011-07-14 13:53:10 -04:30
Jose Lorenzo Rodriguez
9304f3420b Currently the FormHelper fails if the Model supplied is 'Model', perhaps we need to add a special case for this 2011-07-14 11:05:41 -04:30
Jose Lorenzo Rodriguez
ef5650c034 Fixing ClassRegistry that was incorrectly checking class inheritance
Fixing Model class that was incorrectly sending model names to be instantiated
Fixing more FormHelper tests
2011-07-14 01:30:52 -04:30
Jose Lorenzo Rodriguez
1941be6a76 Updating FormHelper tests 2011-07-14 01:03:29 -04:30
Jose Lorenzo Rodriguez
60b44e074a Cleaning up the ClassRegistry::init() method, removing the use of the second parameter as it always accepted but one value
The second parameter is now $strict, meaning that if the model class is not found it will not try to create an AppModel instance
2011-07-14 00:06:01 -04:30
Jose Lorenzo Rodriguez
d54e8cd82f Starting to update tests after removing the validationErrors property in Helper 2011-07-13 23:51:23 -04:30
Ceeram
a025cb2e01 Adding option to ProjectTask, for setting CAKE_CORE_INCLUDE_PATH. Tests added. 2011-07-13 23:54:24 +02:00
Florian Krämer
adb943b7fd Refactoring the code to build the query array as suggested here https://github.com/cakephp/cakephp/pull/147#issuecomment-1553663 2011-07-12 23:31:07 +02:00
Jose Lorenzo Rodriguez
e45b35cffe Removing the Controller::modelNames property and loading it's contents in the uses variable.
Simplifying code in Controller::render()
Setting all models loaded into the request parameters so it can be used later on the Form helper
2011-07-12 01:19:14 -04:30
Jose Lorenzo Rodriguez
f8ab1d3c73 Adding App::location() method to be able to obtain the defined path for a class 2011-07-12 00:38:50 -04:30
Florian Krämer
9d7c97c296 Adding the "returnQuery" key to the 2nd argument of the find() method to be able to get the query array back from the before state of findMethod() calls. This was required in the past for some more complex queries and is in 2.0 no longer possible because the find methods became protected. 2011-07-12 01:04:22 +02:00
Majna
cde13daed4 Refactored DatabaseSession to use only 'Session.handler.model' config. Fixed static call on non-static method DatabaseSession::gc(). Fix for SessionFixture -primary key too long (MySQL Error: 1071) 2011-07-11 00:16:41 +02:00
José Lorenzo Rodríguez
a69fccabf6 Merge pull request #144 from majna/2.0
Fix for exception messages and typos
2011-07-07 11:26:32 -07:00
ADmad
1bccc7713d Fixing singularization of "curves" 2011-07-07 23:08:03 +05:30
Majna
742130b540 Fix for wrong Exception messages and typos. Added missing ExceptionRenderer tests for Datasource 2011-07-07 19:36:21 +02:00
Jose Lorenzo Rodriguez
eaa80bbced Completing support for extracting model validation messages from application plugins 2011-07-07 02:11:48 -04:30
Jose Lorenzo Rodriguez
d2519ae0ae Adding support to the extract task to operate on a single plugin, thus removing the hassle of declaring the plugin path in command line 2011-07-07 01:57:55 -04:30
Jose Lorenzo Rodriguez
765164f33b Merge branch '2.0-extract-model-validation' into 2.0 2011-07-07 01:05:39 -04:30
mark_story
1d0d3f80fb Fixing Helper::value() when models exist in ClassRegistry
and field values are empty.
Fixes #1817
2011-07-06 21:26:07 -04:00
mark_story
71933f5cf5 Adding a logout callback to authenticate objects.
Adding tests for the callback.
Adding doc blocks for the new callback.
Fixes #1758
2011-07-03 12:53:21 -04:00
mark_story
c2a96267b2 Merge branch 'form-helper' into 2.0 2011-07-02 12:13:41 -04:00
Majna
71ed244f14 Fix for render element - allow under_scored plugin name. Fixes #1814 2011-07-02 02:17:44 +02:00
mark_story
bef2e75bdf Fixing failing debugger test.
Adding doc blocks for helper properties.
2011-07-01 07:56:48 -04:00
mark_story
c9acb6b587 Moving FormHelper specifics into that class. 2011-07-01 07:39:03 -04:00
Mark Story
89258327c6 Moving entity() and its related attributes to Helper
Removing entity() and its attributes from View.
Having that information on View allowed for unwanted side effects,
and seemed like a break of encapsulation.
2011-06-25 20:02:34 -04:00
Mark Story
e4d701021e Fixing failing tests caused by merge with 1.3 2011-06-25 20:00:39 -04:00
Mark Story
4073584eef Fixing more failing tests.
Fixing use of properties that are going away.
2011-06-25 19:31:20 -04:00