Commit graph

19482 commits

Author SHA1 Message Date
bancer
7788c60f58 Adjust enum related unit tests 2018-12-12 14:31:55 +01:00
bancer
cf6c8d511f Improve support of enum data type 2018-12-12 12:40:20 +01:00
Mark Story
acb0436cb6
Merge pull request #12736 from bancer/2.x-documentation
Improve documentation and code style
2018-12-11 12:59:19 -08:00
Val Bancer
0f2bbf505d
Adjust the check according to review comments 2018-12-11 16:36:32 +01:00
Yaser Naderi
3d224639d9 Add the functionality to accept enum MySQL datatype storing the Integer values as String (#12715)
Fix a bug in enum MySQL datatype storing Integers when enum contains
integer string values. Now strings will always be used for enum values.
2018-11-30 21:27:58 -05:00
Mark Story
fea343d67c
Merge pull request #12776 from martinstuecklschwaiger/patch-1
Fix @return value
2018-11-29 15:39:15 -05:00
Martin Stücklschwaiger
a9e20c39be
Fix @return value 2018-11-29 20:37:03 +01:00
Val Bancer
addd538526 Fix invalid condition 2018-11-18 22:48:34 +01:00
Val Bancer
c00579153b Cast var to int for comparison 2018-11-18 18:22:19 +01:00
Val Bancer
cb1d80fda1 Improve documentation 2018-11-18 17:13:11 +01:00
Val Bancer
92e9277d20 Improve code style 2018-11-18 16:24:25 +01:00
Val Bancer
509accc421 Improve code style 2018-11-17 20:55:42 +01:00
Val Bancer
261a99c0e3 Improve documentation and code style 2018-11-17 20:27:05 +01:00
Val Bancer
320cdf98ee Add undocumented properties (#12717)
See https://book.cakephp.org/2.0/en/controllers/request-response.html#accessing-request-parameters and https://api.cakephp.org/2.10/source-class-UpgradeShell.html#345-403

* Initialize $params to null
* Document more magic properties, trigger deprecated notices
* Use $controller->request->params instead $controller->params
* Remove unused variable
* Improve documentation, add type checks.
* It seems like $this->uses can also be of type false; however, parameter
$array of array_unshift() does only seem to accept array.
* Declare undeclared property
* Add extra type checks
* Adjust type check
* Improve documentation, initiate uninitialized variables.
* Improve documentation, reset variable
2018-11-15 20:41:57 -05:00
Mark Story
8573c15575
Merge pull request #12718 from bancer/php-7.3
Fix some PHP 7.3 errors
2018-11-12 21:22:51 -05:00
Val Bancer
22b0386fd5 Move failing assertion to a new test method 2018-11-11 17:53:28 +01:00
Val Bancer
d9655c94c5 Remove memcached in PHP 7.3 tests 2018-11-11 17:49:11 +01:00
Val Bancer
2f5467e8e8 Move failing assertion to a new test method 2018-11-11 17:36:10 +01:00
Val Bancer
0f0cedec14 Move failing assertion to a new test method 2018-11-11 17:18:18 +01:00
Val Bancer
d5ac7aa0b2 Simplify assertions in tests 2018-11-11 17:00:55 +01:00
Val Bancer
90ddb43632 Fix some PHP 7.3 errors 2018-11-11 16:15:55 +01:00
Mark Story
dd9601d73f
Merge pull request #12707 from tenkoma/2.x-build-php73
[2.x]PHP7.3 added to the build setting.
2018-11-06 08:28:30 -05:00
Koji Tanaka
e43db36d4e PHP7.3 added to the build setting. 2018-11-06 10:36:51 +09:00
Mark Story
b1a93df604
Merge pull request #12692 from bancer/model-exists-without-id
Add model id to all `exists()` method calls
2018-11-01 21:21:27 -04:00
bancer
58ebf6a303 Remove id property from bake template 2018-10-31 09:46:01 +01:00
Mark Story
89005c4440
Merge pull request #12680 from bancer/issue-12636-tests-constants
Replace hard coded test directory paths with constants, fixes #12636
2018-10-30 14:28:49 -04:00
bancer
d8d65027ac Adjust unit tests with id parameter for exists() method 2018-10-30 11:02:42 +01:00
bancer
3ea39d96b4 Add model id to all exists() method calls,
Related issue - https://github.com/dereuromark/cakephp-shim/issues/25
2018-10-30 10:39:16 +01:00
mark_story
33ac2b2537 Update version number to 2.10.13 2018-10-27 22:01:42 -04:00
Mark Story
a8521aa25a
Merge pull request #12679 from bancer/patch-4
Improve documentation
2018-10-26 18:48:52 +00:00
bancer
ee1b1a10df Defines TESTS also after app bootstrap.php is loaded, #12636 2018-10-26 15:52:39 +02:00
bancer
85cc215293 Improve documentation 2018-10-26 14:23:30 +02:00
bancer
53e3df20d0 Replace hard coded test directory paths with constants, fixes #12636
The `TESTS` constant definition is moved from bootstrap.php in order
to make it possible to set the constant in test.php or in the project's
bootstrap file so that CakePHP would detect tests in a different folder.
2018-10-26 13:49:53 +02:00
Val Bancer
3c9d46864e
Improve documentation
The parameter description is copied from `CakeLog::write` method.
2018-10-26 09:54:23 +02:00
Mark Story
2acad7e94d
Merge pull request #12667 from bancer/patch-3
Improve documentation
2018-10-22 21:06:32 -04:00
Val Bancer
527b9fe640
Improve documentation 2018-10-22 10:11:01 +02:00
Val Bancer
e825823e9a
Improve documentation 2018-10-22 10:02:51 +02:00
Mark Story
2bdc04e53c
Merge pull request #12653 from begnini/fix_describe_pgsql_function
limiting the regex to consume only words in default value in pgsql
2018-10-21 02:30:44 +00:00
Mark Story
001adaa8cd
Merge pull request #12660 from cakephp/issue-12657-2x
2.x - Don't break UNC file paths
2018-10-21 01:55:01 +00:00
mark_story
ffde7ee32a Don't break UNC file paths
Blindly replacing // causes network paths and paths with protocols to
break. Relying on correct input allows the user to get what they want
without the framework interfering.

Refs #12657
2018-10-19 22:08:39 -04:00
Mark Story
240ae93b68
Merge pull request #12656 from bancer/patch-2
Improve documentation
2018-10-19 20:42:21 +00:00
Val Bancer
b97530977d
Improve documentation 2018-10-19 16:54:05 +02:00
Val Bancer
8e8fbae78c
Improve documentation 2018-10-19 16:45:21 +02:00
Humberto Pereira
23e38aeaf0 limiting the regex to consume only words in default value in PostgreSQL after ::
added tests showing the old behavior was broken.
2018-10-18 17:16:29 -04:00
Mark Story
5b57a1e926
Merge pull request #12579 from josephzidell/patch-1
Augment docblock for `Hash::combine()`
2018-09-21 12:01:13 -04:00
Joseph Zidell
59fe9f55c2
Augment docblock for Hash::combine()
Adds array as possible types for `Hash::combine()` for `$keyPath` and `$valuePath` params.
2018-09-20 22:00:03 -04:00
Mark Story
2273428dca
Merge pull request #12554 from bancer/patch-1
Improve handling of CURRENT_TIMESTAMP default value
2018-09-13 09:34:17 -04:00
Val Bancer
d7b5cda0ea Fix PHP 5.3 syntax 2018-09-12 18:14:24 +02:00
Val Bancer
a7a49c5f8e Fix syntax 2018-09-12 17:32:00 +02:00
Val Bancer
1a62c147fe
Improve handling of CURRENT_TIMESTAMP default value
Resolves https://github.com/cakephp/cakephp/issues/12553.
2018-09-12 16:45:01 +02:00