Commit graph

106 commits

Author SHA1 Message Date
Mark Story
d54c901f5d Moving _setupDatabase() into the Database session class, as that's the only place its used. 2010-09-06 01:12:23 -04:00
Mark Story
27ae7f1f44 Making session storage classes not static, there was no real reason they were static before, and removing the static methods allows them to have constructors. This will allow moving database specific features from CakeSession to DatabaseSession. 2010-09-06 00:43:58 -04:00
mark_story
272b327dc3 Fixing issue where $error would be set to an array. 2010-07-27 22:27:44 -04:00
mark_story
19d8c9e6bb Removing a call to __setError() that isn't an error. 2010-07-27 22:27:44 -04:00
mark_story
8db0a19585 Refactoring duplicated logic into a method. 2010-07-27 22:27:44 -04:00
mark_story
ef586d9917 Updating test case to use autoRegenerate. 2010-07-27 22:27:43 -04:00
mark_story
6ff7ad68c9 Fixing some infinite loop issues in the test cases for CakeSession. 2010-07-27 22:27:43 -04:00
mark_story
81f6f43193 Moving a few things around to better replicate how CakeSession behaved in 1.3. Also fixes the countdown & session id regeneration feature. Still need to write a test case for it though. 2010-07-27 22:27:43 -04:00
mark_story
d2097c514f Fixing issue where infinite loops would occur when a session was first created. 2010-07-27 22:27:43 -04:00
mark_story
574bfe6b67 Changing clear of $_SESSION to null instead of array(), makes checks later easier. Removing _checkValid call from destroy and making it run in start(), as destroy() calls start(). 2010-07-27 22:27:43 -04:00
mark_story
db5c44e386 Adding support + test cases for plugin and app/libs session handlers. 2010-07-27 22:27:42 -04:00
mark_story
18b6668a34 Moving tests from SessionComponent to CakeSession, as that is where the features actually are. Removing Security.level/Security::inactiveMins() calculations. 2010-07-27 22:27:42 -04:00
mark_story
951eeae817 Extracting handler location into a method.
Moving DatabaseSession and CacheSession into separate files.  Tests to come soon.
2010-07-27 22:27:13 -04:00
mark_story
49397c74af Making cache config used for cache session storage configurable. 2010-07-27 22:27:13 -04:00
mark_story
f5d81e53fc Refactoring Cache and Database session handlers into a separate class, and adding an interface for custom session handlers. Tests updated. 2010-07-27 22:27:13 -04:00
mark_story
339fa29502 Updating CakeSession test case and fixing a few issues in the default settings. 2010-07-27 22:27:12 -04:00
mark_story
b247559e9e Starting to implement new session configuration setup. Test case updated. 2010-07-27 22:27:12 -04:00
predominant
7501fcf46d Add test for empty read() calls on CakeSession 2010-07-27 22:27:12 -04:00
predominant
ca65689dd9 Change _setHost() on CakeSession to accept parameter to ease testing, add test cases for host setting, and port stripping. 2010-07-27 22:27:12 -04:00
predominant
a63474a54d Add test for path containing question, and fix assignment of CakeSession::path 2010-07-27 22:27:12 -04:00
predominant
f5565895e9 Removing __regenerateId method, and moving code to renew(). 2010-07-27 22:27:11 -04:00
predominant
afede663c0 Reducing redundant code for CakeSession. 2010-07-27 22:27:11 -04:00
predominant
725bfc3e12 Create _setPath() and _setHost to simplify startup. 2010-07-27 22:27:11 -04:00
mark_story
4b65ebd64f Making SessionComponent mostly a wrapper for CakeSession.
Adding CakeSession::begin() to replace SessionComponent::__start().
Tests updated.  Tests related to autoStart were removed/skipped as that feature isn't really around right now.
2010-07-27 22:27:11 -04:00
mark_story
e660416545 Making CakeSession::write() able to write hashes of data. 2010-07-27 22:26:03 -04:00
predominant
4e9d76e806 Fixing session write use issue. 2010-07-27 22:26:03 -04:00
predominant
dd3e0facd2 Trim down CakeSession::started() 2010-07-27 22:26:03 -04:00
predominant
db97df31cd Adding static to regen 2010-07-27 22:26:03 -04:00
predominant
1dd02b77b2 Adding static to destroy() 2010-07-27 22:26:03 -04:00
mark_story
f47ee0d29a Making CakeSession destory() make started() not return true. Fixing tests that tried to modify session config while a session was active. 2010-07-27 22:26:03 -04:00
mark_story
daab018777 Removing code for PHP < 5.1 which is not supported by 2.0 2010-07-27 22:26:03 -04:00
mark_story
1938e57cbc Making userAgent check test pass.
Reformatting code inside valid().
2010-07-27 22:26:02 -04:00
predominant
b60b077056 Fix __startSession being called after method rename to _startSession. 2010-07-27 22:26:02 -04:00
predominant
34a6808d5d Move CakeSession database configuration to separate method, cutting down init(). 2010-07-27 22:26:02 -04:00
predominant
632d1f13ae Minor refactor for CakeSession. 2010-07-27 22:26:02 -04:00
predominant
9bddd9a861 Minor refactor of if()'s 2010-07-27 22:26:02 -04:00
predominant
06f9d748e2 Fix session path/base for init() 2010-07-27 22:25:37 -04:00
predominant
16f4899821 Fix destroy() calling old constructor on CakeSession 2010-07-27 22:25:37 -04:00
predominant
ea7d45cb11 Remove unset() 2010-07-27 22:25:37 -04:00
predominant
b0e4a09d38 Rename constructor to init() and add init() call at bottom of CakeSession. 2010-07-27 22:25:37 -04:00
predominant
86a7263ab5 Fix cookielifetime variable declaration for CakeSession. 2010-07-27 22:25:37 -04:00
predominant
04b67e59fc Fix tests to remove checking of session ID directly on Session Helper. 2010-07-27 22:25:37 -04:00
predominant
17688a6002 Chaned CakeSessn o use static approache. 2010-07-27 22:25:37 -04:00
predominant
0a72de6438 Removing @access doc block lines from CakeSession. 2010-07-27 22:25:05 -04:00
predominant
58c94b8578 Add access to started() on CakeSession. 2010-07-27 22:25:05 -04:00
predominant
390274f807 Remove function exists check on session_write_close() 2010-07-27 22:25:05 -04:00
mark_story
d38857095a Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/model/model.php
	cake/libs/validation.php
	cake/libs/view/helpers/ajax.php
	cake/tests/cases/libs/controller/components/session.test.php
2010-07-24 22:34:42 -04:00
Scott Reeves
037a7628c4 Fixing typo in parameter description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:14:43 -04:00
mark_story
60ab9800e2 Fixes issue where CakeSession::destroy() would fail to properly restart the session. Tests added. Fixes #787 2010-07-03 18:34:02 -04:00
mark_story
2020675078 Merge branch '1.3' into 2.0
Conflicts:
	cake/dispatcher.php
	cake/tests/cases/libs/controller/components/request_handler.test.php
2010-06-30 22:47:27 -04:00