Commit graph

970 commits

Author SHA1 Message Date
jperras
4dbdf1e0c6 Converting EmailComponent private methods to protected. 2009-08-09 17:13:06 -04:00
gwoo
6775e0997e Merge branch '1.2' into 1.3 2009-08-03 13:13:18 -07:00
jperras
d41a28c975 Fixing PHP4 compatibility issues for SecurityComponent.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8282 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-08-03 19:40:02 +00:00
mark_story
401796e1a9 Adding missing reference operators in Controller::paginate().
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8277 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-08-03 17:55:16 +00:00
mark_story
29dd4ddf03 Fixing issues in Scaffold Test case with PHP4.
Cleaning up code formatting in Scaffold.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8276 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-08-03 17:38:40 +00:00
AD7six
a4bc755cc7 whitespace normalization 2009-08-02 16:10:24 -07:00
gwoo
15ed658a27 Revert "Merge branch '1.3-newlines' into 1.3"
This reverts commit c088131cd8e9f53396852e8a320e2b0396807d20, reversing
changes made to 9341a2bb5eda1db208019aa8a9171224fb76fc6b.
2009-08-02 15:59:54 -07:00
gwoo
bf2b8a60e6 Merge branch '1.3-misc' into 1.3 2009-08-02 12:20:07 -07:00
gwoo
d118c6a764 Merge branch '1.3-newlines' into 1.3 2009-08-02 12:08:55 -07:00
gwoo
1423b0067b Merge branch '1.2' into 1.3 2009-07-30 11:34:33 -07:00
DarkAngelBGE
f88cc56cfe Coding standards fixes
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8260 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-28 20:01:42 +00:00
AD7six
fd0aaefb39 whitespace normalization 2009-07-26 12:46:07 +02:00
gwoo
062f471b7f updating App::import usage. ran each test and everything seems ok. 2009-07-25 18:27:02 -07:00
AD7six
b2142df2bc adding a newline before all comment blocks 2009-07-24 21:18:37 +02:00
jperras
e40428801e Removing all uses of uses() global method & replacing with require or App::import. 2009-07-24 13:41:08 -04:00
gwoo
a9d98e73c3 Merge branch '1.2' into 1.3 2009-07-22 09:27:31 -07:00
DarkAngelBGE
3e14d281df fixes #6397, removing unneeded line feed in email component headers, adding tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8248 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-22 16:04:53 +00:00
DarkAngelBGE
caeac73562 Applying patch from ' matsinet', fixes #6475, EmailComponent ignoring sendAs when attachments present, adding tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8242 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-21 21:54:05 +00:00
gwoo
a2f0ab8b27 Merge branch '1.2' into 1.3 2009-07-20 09:31:56 -07:00
mark_story
02ed77ab20 Adding tests for calling RequestHandlerComponent::renderAs() twice.
Fixing issue where viewPath was not updated.
Fixes #6466

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8230 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-14 03:52:06 +00:00
jperras
4f44a15470 EmailComponent::reset now empties out attachments array. Fixes #6498.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8226 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-10 00:07:51 +00:00
gwoo
f1a4352620 Merge branch '1.2' into 1.3 2009-07-03 08:24:42 -07:00
mark_story
f79a68b2a6 Minor refactor of variable names.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8215 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-03 00:20:54 +00:00
gwoo
2ba8e8777c Merge branch '1.2' into 1.3 2009-07-02 16:12:50 -07:00
gwoo
bc359259a2 Merge branch '1.2' into 1.3 2009-07-02 09:27:00 -07:00
jperras
a6d3193a6d Updated EmailComponent::__strip regex for mailto: links. Fixes #6464.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8211 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-02 02:58:43 +00:00
mark_story
ff5d9ed6e0 Fixing issues created in [8205] where allowedActions check was done incorrectly. Fixes #6482
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8208 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-01 03:56:16 +00:00
mark_story
8c7883fe3e Fixing camel cased methods in checks for allowedActions in AuthComponent under PHP5. Normalizes to lowercase method name. Fixes #6142
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8205 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-06-30 00:25:09 +00:00
gwoo
13550a140a fixing require cake_session in session component 2009-06-24 15:05:08 -07:00
mark_story
16eb51e91c Adding ControllerMergeVarsTestCase to more extensively test merging of vars in Controller::__mergeVars.
Fixing issue where components declared in AppController would get doubled settings if no components were declared in subclasses.
Fixes #6459

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8201 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-06-24 18:09:14 +00:00
jperras
d335fefbee Adding a 'client' option to EmailComponent:: for specifying the host to be used in the SMTP HELO request; defaults to env('HTTP_HOST'). Fixes #6264.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8194 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-06-11 03:07:38 +00:00
gwoo
6f21c18366 Merge branch '1.3-lib_renames' into 1.3 2009-06-02 10:17:02 -07:00
gwoo
fdd63d4e8e Merge branch 'master' into 1.3 2009-06-02 10:12:14 -07:00
mark_story
9aa64ef564 Ensuring that 'ext' param added by RequestHandler does not end up as a queryString parameter in Auth.redirect.
Adding test case.
Fixes #6211

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8182 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-06-01 00:01:58 +00:00
mark_story
8c243ee731 Applying patch from 'mete0r', adding tests for Scaffold variable setting. Fixes #6361
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8172 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-05-13 01:00:38 +00:00
gwoo
15518b8c9a merging 1.3-misc into master 2009-05-01 14:05:46 -07:00
gwoo
db71202aac Merge branch '1.2' into 1.3 2009-05-01 08:26:02 -07:00
mark_story
c8cf1a2c5b Updating __mergeVars to correctly merge parent and child component configurations.
Applied patch from 'neilcrookes'. 
Test case added. Fixes #6325

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8157 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-28 01:32:20 +00:00
mark_story
b68c78fc0f Fixing lost querystring params when user request without a session is performed. Test case updated. Fixes #6211
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8156 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-25 02:16:05 +00:00
jperras
97abf84770 EmailComponent:: now is set to null after calling EmailComponent::reset(). Test cases added; fixes #6314.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8153 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-25 00:01:57 +00:00
jperras
650d1e7c78 Removing hard coded HELO hostname of 'cake' in EmailComponent; better compliance with RFC-821 3.5. Test cases added. Fixes #6264.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8152 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-24 18:20:51 +00:00
gwoo
ec18aac4ab Merge branch 1.2 into 1.3 2009-04-15 15:16:01 -07:00
mark_story
97652231a0 Fixing RequestHandlerComponent::prefers() with array input. Test case updated. Fixes #6290
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8141 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-14 13:16:25 +00:00
mark_story
9491e4632d Applying patch from 'SkieDr' to fix custom find type pagination. Removes parameters from exiting paginate(). Test case added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8137 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-07 14:56:30 +00:00
gwoo
643651fe56 Merge master in 1.3 2009-03-19 14:10:13 -07:00
renan.saddam
76e0f17dbc Updating documentation to improve code completion
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8114 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-17 21:10:28 +00:00
mark_story
eba2e78d06 Fixing typo in last commit.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8108 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-16 03:06:28 +00:00
mark_story
4dceb5be31 Adding doc blocks for properties that previously had no documentation. Closes #6199
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8107 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-16 03:01:51 +00:00
jperras
b22ddc11f9 Renaming socket.php to cake_socket.php . Changing associated App::import calls. 2009-03-15 16:52:27 -04:00
gwoo
6cb8b3d286 Merge branch 'master' into 1.3.x.x 2009-03-14 13:57:18 -07:00
jperras
ba78e04be9 Fixing doc block for parameter of Controller::flash. Thanks 'ADmad'.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8083 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-09 01:11:38 +00:00
mariano.iglesias
591b9f0582 Fixing wrong usage of array_shift added in r7013
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8072 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-03 23:58:55 +00:00
mark_story
811eb90d87 Updating doc blocks on RequestHandler to improve parsing in API.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8064 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-27 01:33:38 +00:00
mark_story
af021cb4b2 Adding Html entity conversion to all urls generated by helpers, fixing potential for merged passedArgs to create xss vectors.
Adding integer cast in paginate() to page param. 
Tests added/updated.
Fixes #6134

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8061 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-25 19:51:41 +00:00
gwoo
43ad3d76e5 updating code from [8024] [8025]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8031 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-15 20:13:14 +00:00
gwoo
712fea65ab updating code from [8024]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8025 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-13 01:11:00 +00:00
mark_story
e045e6826a Fixing Session from being added to components array twice.
Fixing greedy mergeVars with AppController.
Tests Added
Fixes #6091

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8024 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-12 13:36:20 +00:00
gwoo
f0d03a91cf Merge branch 'master' into 1.3.x.x 2009-02-09 12:01:06 -08:00
gwoo
f7dd0800d1 fixes #6062, AuthComponent and Controller::scaffold
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8018 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-06 23:23:12 +00:00
mark_story
4b00c29eef Updating doc blocks to improve readability in API.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8015 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-04 05:00:59 +00:00
the_undefined
27065d7aab Fixed bug in AuthComponent that allowed uppercase actions to pass checks
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8011 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-26 18:50:09 +00:00
nate
c7d133fc0f Removing variable name inflection from Controller::set() 2009-01-20 14:36:39 -05:00
mark_story
ba42eb05c1 Fixing broken tests refs #5687
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7986 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 20:37:31 +00:00
gwoo
e496fc9434 updating auth component and test with additional checks for missing data
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7979 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 05:21:26 +00:00
mark_story
6c258c0f93 Fixing Auth's handling of params when loginAction is an array. Tests updated. Fixes #5961
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7972 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-06 03:20:11 +00:00
gwoo
0751251181 updating email tests to match previous change.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7970 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-02 22:50:28 +00:00
gwoo
4f0256f9cd fixes #5904, changing email component to use initialize instead of startup, so it can be used in other components more easily
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7969 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-02 22:47:38 +00:00
nate
b2b46c3fa4 Implementing $safe mode for RequestHandlerComponent::getClientIP(), which ignores HTTP_X_FORWARDED_FOR, fixes #5842
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7957 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:02:36 +00:00
nate
d5b157ed94 Fixing undefined variable in first if block branch, fixes #5921
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7954 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-24 05:40:05 +00:00
mark_story
ac87db981a Fixing typos in doc blocks. Fixes #5898
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7941 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 14:31:53 +00:00
nate
3129d5411f Correcting return value for Auth::redirect(), fixes #5893
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7930 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 07:30:55 +00:00
nate
2c64c449bc Correcting Flash detection in RequestHandler, adding tests. Fixes #5838.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7914 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-10 13:55:58 +00:00
AD7six
d80e527e5b fixes #5776
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7882 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-20 16:53:45 +00:00
AD7six
b43128c809 Ensuring that the auth component never redirects to an external link.
Tests updated to match code changes and tests added for external referer examples


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7874 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-14 09:07:22 +00:00
TommyO
11f0817341 Improved strip method for performance and clarity.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7866 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-11 19:54:15 +00:00
gwoo
a99ca57762 fixes #5687, adding Controller::methods to hold available methods for called controller, refactored auth and dispatcher to use this property
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7864 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-11 16:34:05 +00:00
mariano.iglesias
dde4906195 Adding patch by dardosordi. Making all calls to header in SecurityComponent go through Controller. Fixing issue where invalid basic auth credentials would not trigger another login request. Added tests, fixes #5732
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7858 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-10 17:18:00 +00:00
john
44781d2ef9 Updating Component docblocks with @link and editing docblock text.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7809 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 19:39:18 +00:00
john
863adabe12 Updating Controller docblocks with @link and updating docblock content and grammar.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7808 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 19:30:17 +00:00
AD7six
3f2fa6929b changing tabs for spaces in comment block indentation
Removing address and replacing with cakefoundation url


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7805 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 17:30:26 +00:00
nate
318c2b4952 Correcting SecurityComponent form hash generation when handling arrays, fixes #5588. Fixing code formatting in FormHelper test.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7794 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-29 06:55:42 +00:00
AD7six
ce0a71aef7 fixes #5603 Duplicate first parameter from the paginator with existing url args
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7777 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 22:20:03 +00:00
nate
16e2579f01 Correcting Security component to treat POST data arrays as a single field for validation purposes, fixes #5588
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7774 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 03:18:08 +00:00
mark_story
1b456f2cf1 Applying patch from 'davidpersson' fixing code spacing. Closes #5643
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7772 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 00:10:44 +00:00
TommyO
f5a8ce4612 Fixed bug where bcc was visible to all recipients when using smtp
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7766 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-20 17:09:42 +00:00
renan.saddam
24949e30e0 Added tests to PagesController and removed twice call to count().
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7756 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-16 23:52:54 +00:00
gwoo
0a8274332a fixing issue with plugins in primary components introduced in [7745]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7749 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-15 17:37:19 +00:00
nate
19975a2cf6 Fixing issue where startup() / shutdown() etc. were being called on components not directly attached to the controller. Only initialize() should be called on sub-components.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7745 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-15 13:07:46 +00:00
nate
1b9357f5e8 Correcting behavior of layering allow/deny calls in AuthComponent, fixes #5595, formatting fixes for RequestHandler
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7743 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-15 02:52:19 +00:00
mark_story
c128505a2c Adding read() into CookieComponent::del() so that values will always be populated. Reversing change from [7725]. Fixes #5563
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7729 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-10 17:24:10 +00:00
mark_story
aa217716b9 Applying patch from 'halogenandtoast' Fixes issues with deleting cookie values before read() is used. Closes #5563
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7725 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-10 01:16:04 +00:00
gwoo
9a22018e40 removing some unneeded code from scaffold
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7722 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-09 22:26:33 +00:00
mark_story
136f9c4b6d Removing getAco(), getAro(), setAco(), and getAco() from AclComponent. These methods were deprecated and not removed. Refs #5561
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7716 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-09 03:35:17 +00:00
TommyO
d5dbb7ba32 Fixed problem where already-authorized user was failing.
Added return of respond code found on success, allowing for more fine-grained post-query activity.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7714 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-08 17:53:48 +00:00
gwoo
443491e7fa reverting changes from 7668
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7689 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-02 02:16:09 +00:00
nate
300dbc5e91 Correcting how parameters and default values are merged in Controller::paginate(), fixes #5503
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7688 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-02 00:46:26 +00:00
TommyO
3da0451907 Added basic mb_encode_mimeheader() to Multibyte class.
Modified EmailComponent to take advantage of multibyte support. fixes #5448
Modified EmailComponent to fix newline issues in long subject lines when using mail send method. fixes #5049

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7685 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-01 18:36:38 +00:00
nate
4b8acf4647 Adding 'type' key to both sets of query calls in Controller::paginate(), fixes #5441
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7680 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-29 21:19:37 +00:00
mark_story
b6f9e1e537 Correcting scaffold view file implementation. Was incorrectly using separate add and edit templates. Changes bring scaffold templates more inline with bake templates.
Tests added to cover use with both primary app and plugins. Refs #4862 and closes #5484 

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7671 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-27 03:48:23 +00:00
gwoo
f8f4bcc16c fixes #5482, playing with model that uses alias
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7668 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-26 15:27:36 +00:00
gwoo
e6b994bcb1 updating handling of required classes, fixes #5480
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7666 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-26 14:03:16 +00:00
mark_story
62168bfe0f Updating doc blocks to include access and return PHPDOC tags.
Removing use of e() in Debugger.
Fixing code formatting in CookieComponent
Closes #5477

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7662 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-25 16:49:56 +00:00
nate
eb7fb6d7e3 Re-implementing form hashing security to using string-based keying. Fixes #5262, fixes #5300
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7658 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-24 23:02:14 +00:00
DarkAngelBGE
e245d18ed8 fixes #5469
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7648 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-23 12:04:02 +00:00
mark_story
fafb01b09d Fixing modelClass when using plugin models.
Added TestPluginPost to test_app/test_plugin
Test case added.
Closes #5459

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7641 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-22 04:10:49 +00:00
nate
fc5b128d68 Refactoring Auth test, adding coverage, and enabling custom Ajax layouts (as specified by RequestHandler), fixes #5446
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7637 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-20 20:18:16 +00:00
nate
91838d6d5d Fixing bug in RequestHandler::prefers() not respecting accept order for single items, test case updated
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7634 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 19:48:22 +00:00
mark_story
768e25c4fd Updating Controller::paginate(). Custom paginate() and paginateCount() methods now receive $extra params similar to find('all') and find('count') do. Allows the use of things like 'contain' with custom paginate() methods.
Test case added. Closes #5433 refs #5123.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7627 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 00:46:20 +00:00
mark_story
0f9a4e0470 Optimizing in_array() checks to isset().
No more in_array($a, array_keys($b)) patterns exist.
Closes #5161

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7624 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 03:40:28 +00:00
phpnut
8ae5866a1c Additional optimization refactoring
Removed ability to use deprecated / with plugin, helper, etc combinations. The dot notation is only allowed from this point forward.
Corrected tests for the above changes.
Corrected formating in basics.php

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7623 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 03:09:19 +00:00
nate
66240f0c5d Refactoring DboPostgres and adding '.' to sequence name detection, fixes #5424, fixing code formatting
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7620 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 00:23:17 +00:00
nate
e3d7aee9da Adding option to disable POST data validation in Security component, fixes #5412
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7617 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-17 15:27:41 +00:00
nate
14b17fed39 Changing private methods in Security component to protected
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7611 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-16 01:39:20 +00:00
phpnut
5658e26e07 Changing comparison operators to === (identical) which is faster than == (equal)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7604 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-14 17:17:49 +00:00
phpnut
2b95df3abf Additional optimization refactoring
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7597 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-13 18:59:30 +00:00
phpnut
cb487bd6e6 More optimization refactoring.
Fix cache but causing  object_map to be created and deleted on each request.
Replacing function and method calls with better performing code.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7596 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-12 05:11:34 +00:00
nate
c9c18741fb Small security fix for Auth component when invalid Ajax request is triggered with no $ajaxLogin set
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7595 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-12 02:10:55 +00:00
DarkAngelBGE
19d4f3d596 adding a couple 'return home early' refactorings
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7572 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-08 20:33:48 +00:00
DarkAngelBGE
fe82e827f0 Refactoring ScaffoldView::_getViewFileName()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7569 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-08 15:44:32 +00:00
DarkAngelBGE
2deb6f3828 fixing possible notices in SecurityComponent::__validatePost, closes #5232
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7545 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-02 04:04:49 +00:00
mark_story
c58e58a491 Adding tests for secured forms. Fixes the issues related to checkboxes in multi row forms.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7533 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-29 03:11:35 +00:00
mark_story
8a76b86c85 Updating doc block for Controller::flash(). Closes #5333
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7511 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-26 18:35:44 +00:00
mark_story
9895f6d39b Added check in AuthComponent::hashPasswords() to ensure that data is an array. Tests Added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7492 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-24 15:18:37 +00:00
TommyO
fe62d7f70d Allow smtp response to be handled more efficiently by Socket class.
Parse test for smtp response checks more accurately at the beginning of the response.
Fixes #5062.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7461 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-13 16:06:23 +00:00
mark_story
3a06f840c3 Adding patch from 'dardosordi' fixes RequestHandler type detection with character set. Closes #5223
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7448 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-09 18:32:59 +00:00
TommyO
48f55a0f56 Greatly modified the way newLine characters are handled.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7437 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-05 17:02:22 +00:00
TommyO
570145d568 Added test to show (deprecated?) support of string status codes in redirect().
Fixed fail on string status codes in redirect().

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7410 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-01 11:27:53 +00:00
gwoo
4a94397b43 removing deprecated code
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7401 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-01 01:04:03 +00:00
gwoo
b0d2451a97 removing optional instantiation of Set class. Adding toArray() to xml class and calling it from Set::reverse(); updated test cases.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7398 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-31 23:50:32 +00:00
gwoo
4a5282bcd7 closes #5172, AuthComponent login with with UUID
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7396 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-31 19:00:12 +00:00
TommyO
b6e9888753 Replaced all instances of ife() in /cake
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7387 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-30 20:34:01 +00:00
gwoo
460b219810 small refactor to Controller::paginate handling of sort direction
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7369 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-27 15:55:19 +00:00
gwoo
e26b7e7a63 refactor dispatcher, fixes #5033
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7365 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-26 20:09:20 +00:00
TommyO
e235e422ed log fix: Committed in error. No real changes made to file.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7360 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-24 13:52:37 +00:00
mark_story
cc098629a6 Added direction check to Controller::paginate(). paginate() now forces 'asc' when wrong. Added tests. Closes #5120
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7357 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-24 02:46:39 +00:00
phpnut
30a49a39e4 Fixes #5016, Security->disabledFields not working properly. Empty value arrays needed to be unset
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7314 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-05 10:10:19 +00:00
gwoo
5ddd330b11 closes #5019, updating test case to show that security component is operating as expected. fix for newLine in utf subject of email component
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7311 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-04 14:18:01 +00:00
phpnut
815c6fb1f5 Fixes #4997 CookieComponent write multiple values doesn't not obey $encrypt
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7291 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 07:14:55 +00:00
phpnut
022ffa3f4f Adding fixes for pagination on associated models.
Corrected dot notation use in Controller::paginate();

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7286 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 06:25:08 +00:00
gwoo
b8714ede74 fix to paginate sort order for self associated models
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7278 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 03:12:45 +00:00
gwoo
1576a83505 fixing issue with sort in pagination and adding tests, removes previously deprecated controller methods and adds trigger_error to recent ones
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7276 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 00:43:31 +00:00
nate
df75a06756 Fixing coding standards violations in core, and adding misc tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7222 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-20 20:17:23 +00:00
gwoo
2999b7f15d fixes #4902, email smtp headers
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7180 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-13 18:03:47 +00:00
gwoo
e9daddddf3 fixes #4910, aclnode loading
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7179 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-13 16:40:45 +00:00
gwoo
97a57a0f05 fixing bug in error handler when callbacks were moved to construct classes, moved callbacks back to dispatcher for now until we find a better place in the controller, fixed caching for the "home" page by adding check for "/', original test case was incorrect.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7177 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-12 18:36:08 +00:00
gwoo
1e231e9511 some cleanup, wrapping uses() in class exists
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7172 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-11 15:46:31 +00:00
phpnut
6807d4c333 Starting initial refactoring of current code base.
Made changes to test suite to allow running test without headers already sent errors.
Moved Component::initialize(), Controller::beforeFilter(); and Component::startup(); from Dipatcher::start() to Controller::constructClasses();
Removed Dispatcher::start();
Fixing model instances not being created
Adding additional test to CookieComponent to increase coverage to 95%
Optimizing Set::diff();
Fixing SessionComponent test and RequestHandlerComponent test
Fixing CakeSession tests, removed deprecated code from CakeSession

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7162 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-10 22:38:05 +00:00
mark_story
ebe6e31ef3 Changed Scaffold views to allow Type, Alias, Detail, Data, and Field as Model names. Closes #4136, #4859. Updated tests.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7152 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-10 02:12:32 +00:00
phpnut
cbebf3e6b3 Adding fix for new line endings when sending email via php mail();
Fixed typo __headers should have been __header

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7149 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-09 23:35:38 +00:00
gwoo
ebe4b5824f fixes #4870, component now using references on callbacks instead of copies. thanks for the patch
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7148 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-09 23:32:54 +00:00
the_undefined
2d8e63ae7b Refactored and updated postConditions to new operator syntax, fixes #4860
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7145 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-09 08:29:56 +00:00
mark_story
8f59f18877 Added fallback view file for scaffolded admin routes. Closes #4862. Added tests.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7143 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-09 02:56:36 +00:00
gwoo
76acfafa5a fixes #4848, console building paths when config does not exist.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7138 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-07 22:09:40 +00:00
gwoo
bd7b09e629 updating email component, proper fix for [7052]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7134 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-06 18:31:11 +00:00
gwoo
1c21457eef fixes #4858, self referencing components
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7133 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-06 16:18:14 +00:00
gwoo
b3f605c1d8 fixes #4836 components initialize for error pages, also changing Object::stop() to Object::_stop()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7116 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-04 19:04:58 +00:00
mark_story
55bcf1e25e Components can have settings assigned in the components declaration, tests added. Closes #4055
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7112 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-04 02:39:05 +00:00
gwoo
6affb7f70a updating EmailComponent, making lineLength public, deprecating protected _lineLength, default value of 70, updating docblocks,
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7105 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-03 17:26:30 +00:00
gwoo
09fae6203d fixing issue with references from latest component refactor. test case added
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7088 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-02 04:57:06 +00:00
nate
39feb3f7c1 Refactoring DboSource. Model array conditions must now have comparison operators on the left side, fixes misc bugs, updated core to reflect changes
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7075 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-31 12:36:38 +00:00
gwoo
1aa6e5c4f4 changing component checks for callbacks from is_callable to method_exists
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7074 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-31 09:24:42 +00:00
gwoo
c57b5611a0 adding patch for Acl::allow(), fixes #4792, closes #4781
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7072 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-31 04:31:30 +00:00
gwoo
cf896eaa9b refactoring component handling, closes #4795, tests added. deprecated Controller::_initComponents();
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7070 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-31 03:54:22 +00:00
nate
42da5aba81 Moving Cake folder to correct location
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7063 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 11:40:08 +00:00
DarkAngelBGE
e6e0d852a2 deleting cake folder from svn
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7061 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 10:59:16 +00:00
TommyO
67f2255076 Fixed minor bug in connect communications with SMTP server
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7059 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-29 20:43:13 +00:00
TommyO
ecc4347e25 Fixed bug for Authenticating against SMTP server. Added test case.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7058 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-29 17:26:43 +00:00
TommyO
a89feed085 EmailComponent reference twekaed to be more PHP4 friendly
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7055 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-28 15:28:47 +00:00
TommyO
3670598052 Adapted EmailComponent SMTP sends to use CakeSocket for communications
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7053 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-28 15:17:18 +00:00
TommyO
ee113b7a5c Fixes bugs in EmailComponent where multiple sends will duplicate headers and content. Makes debug more consistent with sends.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7052 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-28 14:59:13 +00:00
nate
9eeecc8755 Adding content stripping fix for email component, fixes #4753
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7043 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-25 18:08:55 +00:00
mark_story
dcdfdb3cbe Updated Auth redirect url generation. Now correctly retains passedArgs and namedParams. Added tests for this behavior. Closes #4750
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7040 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-24 22:43:19 +00:00
mariano.iglesias
9c722b6999 Improving field detection in Containable. paginate() now avoids sending recursive to find calls when it is not explicitly set. Adding more tests to Containable to show how to paginate, fixes #4746
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7030 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-23 16:12:14 +00:00
joelmoss
cedb20e612 Replaced all instances of renderElement() with element(). Fixes #4740
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7017 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-22 23:04:36 +00:00
nate
bccfd41291 Adding creation fix for ACL join records, fixes #4478
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7016 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-22 19:16:54 +00:00
mariano.iglesias
62bf371aec Allowing paginate to override the default find type for fetching records.
Set the find type as the first string parameter in your paginate settings:
var $paginate = array('popular', ...);
Check the test case for an example.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7013 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-22 17:07:42 +00:00
gwoo
aaab0306aa removing exit() and replace with $this->stop();
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7012 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-22 16:57:46 +00:00
mariano.iglesias
8f92952d46 Allowing paginate() to send any extra parameters to the find call, and updating it to use new find notation.
Updating test in Containable to reflect how to properly use pagination: just set your 'contain' setting as you do with other pagination parameters, for example:
var $paginate = array('Article' => array('conditions' => ..., 'contain' => array( ... ));
and then do your normal paginate(), without having to set reset to false nor call resetBindings(). Check the test case for an actual example.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7010 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-22 16:25:10 +00:00
nate
6c5f98ddec Fixing ACL interface class names
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6999 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-22 02:00:36 +00:00
DarkAngelBGE
45bccc5215 optimization refs #3415
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6970 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 20:36:39 +00:00
DarkAngelBGE
c3c5898ebc fixes #4452 for better performance
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6962 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 08:08:48 +00:00
the_undefined
8f4eda68fc Fixed issues with Controller::persistModel and behaviors, closes #4647
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6959 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 08:03:00 +00:00
the_undefined
065b8f4281 Made Controller::redirect use Object::stop, fixes #4154
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6947 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 05:21:43 +00:00
the_undefined
abe853a978 Made Auth component find conditions more explicit, closes #4680
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6936 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-18 23:49:51 +00:00
nate
8313fef72d Changing recursive setting in Auth user lookup query, allows $userScope to use joins, fixes #4665
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6919 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-18 04:49:54 +00:00
gwoo
8124d166ff updating auth url for login actions
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6904 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-16 18:17:04 +00:00
gwoo
8a236492a0 adding Object::stop(), updating auth and auth.test to use
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6901 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-16 15:23:00 +00:00
gwoo
1623fa89f8 updating auth, fixes #4417 ajaxLogin rendering
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6893 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-15 19:20:13 +00:00
the_undefined
bf107d1886 Fixed admin routing redirect in AuthComponent
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6886 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-15 07:06:22 +00:00
nate
b489bb1470 Cleaning up PagesController, fixes #4640
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6871 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-14 21:34:26 +00:00
DarkAngelBGE
11ba82430a removing unneeded lines from RequestHandler,
adding error surpression oeprator in front of header() to make the components group pass (RequestHandler class)

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6846 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-13 14:38:01 +00:00
DarkAngelBGE
d04101a95a refactoring Controller::referer
adding Controller::header() for testability
bring Controller up in code coverage

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6844 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-13 14:22:57 +00:00
DarkAngelBGE
4b91712791 bringing security component up to 84% coverage,
internationalizing trigger_error for security lib

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6835 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-13 06:27:43 +00:00
the_undefined
24d8878ab6 Added CAKEPHP_SHELL constant to shell dispatcher making it easy to recognize when in shell mode
Fixed #4599

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6834 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-13 05:23:57 +00:00
the_undefined
451192018a Improved AuthComponent to use an array to match the login action, fixes #4572
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6830 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-13 03:22:34 +00:00
nate
296e8989ba Adding GET/PUT/DELETE method checks to Security component, refactoring adding tests, closes #4231. Thanks joelmoss.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6703 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-19 19:25:49 +00:00
mariano.iglesias
ab3b90503f Fixing issue in Security component with modeless field names, fixes #4454. Thanks vuego for the test and patch!
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6685 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-17 22:51:40 +00:00
mariano.iglesias
5f967487bb Encoding subject without modifying original, fixes #4489
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6683 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-17 22:12:58 +00:00
nate
dc5742d28f Correcting query order in DB_ACL::check(), fixes #4309
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6654 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-11 05:48:39 +00:00
nate
a89beea029 Correcting issue with permissions being incorrectly overwritten in ACL, fixes #4190
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6651 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-10 13:19:10 +00:00
phpnut
1d9a096376 "Fixes #4427, Current protected attribute Email::_newLine renders Email Component unusable for SMTP.
Original change to EmailComponent:_newLine reverted, related bug has been fixed elsewhere in the code."

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6632 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-04 11:46:09 +00:00
phpnut
d14b50fc92 "References #4394, additional fixes to multi record forms.
Added additional test cases"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6629 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-03 06:48:56 +00:00
phpnut
5d59938121 "Correcting code block"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6628 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-03 02:33:41 +00:00
phpnut
f2941a660e "References #4239 Added test from ticket to showing ticket is invalid.
Fixes #4394, fails when the hasMany multi-record form contains hidden fields.
"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6627 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-03 02:29:17 +00:00
phpnut
06d06c85d9 "Fixes #4339, Providing null for variable with underscores leads to camelcased variable in view"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6626 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-02 20:14:06 +00:00
phpnut
358c529e7a "Fixes #4416, Email component uses invalid \"Content-Type\" for attachments.
Added fclose();
Removed unused code"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6623 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-02 18:57:29 +00:00
phpnut
c5f06674fa "Fixes #4394, SecurityComponent::!__validatePost fails on hasMany multi-record form.
"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6618 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-02 06:08:55 +00:00
phpnut
fa787aa82b "Closes #4304, EmailComponent::!__getSmtpResponse not handling multiline messages"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6601 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-26 03:49:30 +00:00
nate
819cd1d667 Re-removing the Auth vulnerability re-introduced in [6593]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6595 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-20 19:18:52 +00:00
phpnut
47eb421091 "Adding fix to Auth::identity(); for errors thrown on invalid input.
Added tests for invalid input.
Debug is turned off in this area of code because of the CakePHP errors handling, messages could cause long delays and exception noticed when debug > 0."

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6593 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-20 07:17:37 +00:00
phpnut
f6652d1b73 "Removing checks in Component::init(); to check for Security component.
Changed AuthComponent::startup() so that the password key $this->data is set to null when login fails instead of being unset."

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6589 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-17 02:31:55 +00:00
phpnut
ecfd70052d "Fixes #4353, SecurityComponent's requireLogin not working if URL spelled different than defined action name
Was not able to reproduce this on local system running php 5, more then likely this is a php 4 issue and not php 5 like ticket suggests.
"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6588 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-17 02:28:04 +00:00
nate
38c7dab9f5 Fixing RequestHandlerComponent::prefers() when using extensions, fixes #4056
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6575 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-15 05:48:56 +00:00
nate
a9378fb681 Adding performance optimizations to dispatch cycle
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6570 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-15 05:04:36 +00:00
phpnut
57918f4199 "Fixing Controller::output; to allow access to the content in Contorller::afterFilter();"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6554 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-10 13:24:36 +00:00
phpnut
5374807164 "Fixes #3846, Security blackhole when no radio selected
Fixes #3920, Multiple select w/ checkboxes issues warning when all are unselected
Fixes #3962, validation POST never pass when select multiple is submit
"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6546 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-10 00:25:59 +00:00
phpnut
63144591c6 "Fixes #3820, Email Component only sends message if using template and layout.
Fixes #4019, email component: attaching file is broke, fixes undefined variable, allows full paths to attachment.
Fixes #4171, Email Component: Lost a head line 'period' via SMTP method.
"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6522 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-08 20:26:16 +00:00
the_undefined
885b41808f Fixed return value for Controller::setAction
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6508 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-04 23:44:50 +00:00
nate
ab50975306 Correcting UPDATE query generation to support SQL standards and MySQL-specific features in parallel, fixes #4080
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6491 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-01 03:12:12 +00:00
gwoo
d3e2d51cbc updating error handling, error.test, view.test, theme.test, change socket.test to use App::import()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6479 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-27 21:22:40 +00:00
nate
bd2ac9a1c1 Fixing Auth component so login still works when you allow('*'), fixes #4159
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6473 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-24 03:20:43 +00:00
nate
d301d7a566 Adding Flash client detection to RequestHandler
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6460 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-14 05:32:46 +00:00
nate
f3355bd74b Removing all references to deprecated 'webservices' and 'bare' routes and route parameters, removing deprecated constants, updating core tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6453 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-11 06:18:41 +00:00
nate
3e36695b1f Adding RequestHandlerComponent::beforeRedirect() callback to handle Ajax redirects, delaying initialization of content-types, fixes #2680
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6445 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-07 00:03:59 +00:00
gwoo
0a52e958b9 adding patch for component initialize, fixes #4000
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6440 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-06 07:47:42 +00:00
nate
71bd08b950 Refactoring Auth / Security::hash()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6426 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-02 04:51:49 +00:00
nate
377643cf2b Adding deprecation warning to Controller::cleanUpFields()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6413 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-28 01:14:05 +00:00
nate
d9691a19c8 Refactoring Router::mapResources(), adding tests for REST routing and HTTP method overrides
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6409 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-26 08:50:06 +00:00
phpnut
7098c5558c "Fixes #3887, Controller::modelClass incorrect when using AppController::uses"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6384 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-16 18:09:25 +00:00
phpnut
654669d48f "Refactoring Component tests.
Removed Component::!__construct();"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6374 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-13 04:06:01 +00:00
phpnut
11afd24c19 "Adding fix when a component loads a component that is also in the components array list.
{{{
	var $components = array('Auth', 'RequestHandler');
}}}
Controller::RequestHandler; would not be available.
Added additional tests

Fixed loading of libs/xml.php "

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6372 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-13 03:53:01 +00:00
gwoo
d564eda38d updating component and tests for Session
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6371 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-13 00:53:45 +00:00
gwoo
e989625316 update loading of components, fixes #3899, tests added
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6368 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-12 17:35:12 +00:00
gwoo
edcdcf3235 updating form helper labels for multiple records, fixes #3880, updating custom acl component loading, #3875
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6358 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-10 23:13:53 +00:00
phpnut
e7c4233963 "Fixing bug with scaffold and valid Session id check"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6346 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-09 04:51:12 +00:00
phpnut
c8172ed96a "Fixes #3851, Acl component fails to check() if a permission is denied in action (*)"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6342 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-09 00:39:00 +00:00
phpnut
43eab108c7 "Fixes #3811, $_SESSION not found
Fixes #3823, Session not restarted after instantiating new SessionComponent
Fixes #3850, Configuration Session.start and SessionComponent::!__active aren't handle correctly"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6341 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-08 15:46:02 +00:00
gwoo
2c4a8f4131 updating component, removing use of Router not needed anymore, fixes #3858
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6335 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-08 03:59:01 +00:00
phpnut
348df0fca2 "Fixes #3849, Deprecated loadView() call in email component when using theme"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6333 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-08 02:48:07 +00:00
phpnut
c47700d8c4 "Removing call to Controller::_initComponents(); and Controller::__mergeVars(); out of Dispatcher"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6322 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-05 01:31:15 +00:00
phpnut
aa32649c02 "Closes #2608, CSRF usability problems
Closes #3436, Security Component and multiple instances of the webapp"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6301 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-02 00:38:35 +00:00
phpnut
cb53dc61b0 "Closes #2897, Built-in file validation.
Implemented Validation::extension(); and Vaidation::range();
Updated copyright notices in all files"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6296 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-01 22:18:17 +00:00
nate
5abe66289d Implemented 'counterCache' and 'counterScope' for belongsTo associations
Exempted 'created', 'updated' and 'modified' fields from whitelist when saving, closes #3720
Updated Model::bind(), closes #2355
Adding Model::saveAll() to save multiple records and associated records, closes #3615
Replacing Model::generateList() with Model::find('list'), deprecates Model::generateList()



git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6295 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-01 19:34:40 +00:00
phpnut
1aa2324e8e "Fixes #3786, Missing keys when Model merges actsAs.
Added additional test for Set::merge();
Refactored Controller::_mergeVars."

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6292 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-01 01:07:24 +00:00
phpnut
013133457c "Fixes #3768, Controller loads wrong model when plugins controller has the controller name of a main model.
moved merging of components, helpers, and uses vars to Controller::_mergeVars(); fixes bug with PluginAppController vars not being merged before components are loaded.
  Added call to Controller::_mergeVars(); in Dispatcher::dispatch();"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6291 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-31 23:27:14 +00:00
phpnut
0644112ca9 "Closes #3560, edit form use PUT so SecurityComponent::validatePost() don't call on submit"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6259 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-25 10:49:29 +00:00
phpnut
6fe54aa1d0 "Reverting 5254, this change is only for 1.2 branch"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6255 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-25 09:55:59 +00:00
phpnut
f9c1058a20 "Closes #3295, Centralize encoding / charset setting in one Configure setting"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6253 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-25 09:08:36 +00:00
phpnut
69b2ad7556 "Closes #3338, Allow AuthComponent::allow to take an array as an argument"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6251 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-25 08:11:26 +00:00
phpnut
b96a3a2e6f "Closes #3216, Allow condition overrides in AuthComponent::identify()"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6248 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-25 07:33:29 +00:00