Commit graph

454 commits

Author SHA1 Message Date
Mark Story
527eec1a54 Fixing doc tags to make merge easier. 2010-01-26 16:51:53 -05:00
Mark Story
fc304056a3 Removing Session deletion of nonce token on blackhole. Fixes possible CSRF risk from multiple submissions of the same invalid data. Refs #214 2010-01-26 13:59:26 -05:00
Robust Solution
16eaa990df optimization in AuthComponent class startup method
Signed-off-by: Mark Story <mark@mark-story.com>
2010-01-26 10:13:09 -05:00
Joël Perras
15b8a3ec71 Updating copyright date on all files. 2010-01-13 23:47:14 -05:00
Mark Story
6356c6ed87 Fixing issue where forms generated with requestAction would be missing the _Token fields that Security component creates. Test cases added to ensure that token key does not change when requestAction is used.
Fixes #68
2009-12-18 19:05:33 -05:00
mark_story
a96c157d94 Applying optimizations to use of count() from 'jrbasso' 2009-11-21 15:14:21 -05:00
Juan Basso
df9e1e0bd1 Replace function join (alias) by implode.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-21 13:43:11 -05:00
Juan Basso
9b6b258fed Replace function is_integer (alias) by is_int.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-21 13:36:10 -05:00
mark_story
a7a6dc8c43 Fixing issue where SecurityComponent::_validatePost could generate notices if elements were removed from _Token array.
Tests Added
Fixed #228
2009-11-08 14:12:18 -05:00
renan.saddam
a15289fba8 Saving few Router::normalize() calls, will may increase performance. Fixes #179. 2009-10-20 16:16:31 -02:00
mark_story
e5a99b2685 Updating RequestHandler::renderAs() to respect DS constant, fixing issues on PHP4 + Windows. Fixes #97 2009-10-12 23:55:40 -04:00
jperras
cd64043702 Adding the 'client' option to the doc block for the email component smtp options. Fixes #111. 2009-09-22 23:10:35 -04:00
jperras
4dc656fd91 Updating EmailComponent smtp HELO handling to account for non-existence of HTTP_HOST environment variable when PHP SAPI is CLI. Fixes #41. 2009-09-07 11:18:11 -04:00
jperras
d41a28c975 Fixing PHP4 compatibility issues for SecurityComponent.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8282 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-08-03 19:40:02 +00:00
DarkAngelBGE
f88cc56cfe Coding standards fixes
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8260 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-28 20:01:42 +00:00
DarkAngelBGE
3e14d281df fixes #6397, removing unneeded line feed in email component headers, adding tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8248 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-22 16:04:53 +00:00
DarkAngelBGE
caeac73562 Applying patch from ' matsinet', fixes #6475, EmailComponent ignoring sendAs when attachments present, adding tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8242 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-21 21:54:05 +00:00
mark_story
02ed77ab20 Adding tests for calling RequestHandlerComponent::renderAs() twice.
Fixing issue where viewPath was not updated.
Fixes #6466

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8230 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-14 03:52:06 +00:00
jperras
4f44a15470 EmailComponent::reset now empties out attachments array. Fixes #6498.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8226 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-10 00:07:51 +00:00
mark_story
f79a68b2a6 Minor refactor of variable names.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8215 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-03 00:20:54 +00:00
jperras
a6d3193a6d Updated EmailComponent::__strip regex for mailto: links. Fixes #6464.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8211 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-02 02:58:43 +00:00
mark_story
ff5d9ed6e0 Fixing issues created in [8205] where allowedActions check was done incorrectly. Fixes #6482
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8208 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-01 03:56:16 +00:00
mark_story
8c7883fe3e Fixing camel cased methods in checks for allowedActions in AuthComponent under PHP5. Normalizes to lowercase method name. Fixes #6142
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8205 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-06-30 00:25:09 +00:00
jperras
d335fefbee Adding a 'client' option to EmailComponent:: for specifying the host to be used in the SMTP HELO request; defaults to env('HTTP_HOST'). Fixes #6264.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8194 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-06-11 03:07:38 +00:00
mark_story
9aa64ef564 Ensuring that 'ext' param added by RequestHandler does not end up as a queryString parameter in Auth.redirect.
Adding test case.
Fixes #6211

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8182 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-06-01 00:01:58 +00:00
mark_story
b68c78fc0f Fixing lost querystring params when user request without a session is performed. Test case updated. Fixes #6211
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8156 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-25 02:16:05 +00:00
jperras
97abf84770 EmailComponent:: now is set to null after calling EmailComponent::reset(). Test cases added; fixes #6314.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8153 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-25 00:01:57 +00:00
jperras
650d1e7c78 Removing hard coded HELO hostname of 'cake' in EmailComponent; better compliance with RFC-821 3.5. Test cases added. Fixes #6264.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8152 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-24 18:20:51 +00:00
mark_story
97652231a0 Fixing RequestHandlerComponent::prefers() with array input. Test case updated. Fixes #6290
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8141 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-14 13:16:25 +00:00
mark_story
811eb90d87 Updating doc blocks on RequestHandler to improve parsing in API.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8064 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-27 01:33:38 +00:00
gwoo
f7dd0800d1 fixes #6062, AuthComponent and Controller::scaffold
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8018 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-06 23:23:12 +00:00
the_undefined
27065d7aab Fixed bug in AuthComponent that allowed uppercase actions to pass checks
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8011 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-26 18:50:09 +00:00
mark_story
ba42eb05c1 Fixing broken tests refs #5687
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7986 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 20:37:31 +00:00
gwoo
e496fc9434 updating auth component and test with additional checks for missing data
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7979 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 05:21:26 +00:00
mark_story
6c258c0f93 Fixing Auth's handling of params when loginAction is an array. Tests updated. Fixes #5961
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7972 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-06 03:20:11 +00:00
gwoo
0751251181 updating email tests to match previous change.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7970 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-02 22:50:28 +00:00
gwoo
4f0256f9cd fixes #5904, changing email component to use initialize instead of startup, so it can be used in other components more easily
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7969 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-02 22:47:38 +00:00
nate
b2b46c3fa4 Implementing $safe mode for RequestHandlerComponent::getClientIP(), which ignores HTTP_X_FORWARDED_FOR, fixes #5842
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7957 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:02:36 +00:00
nate
d5b157ed94 Fixing undefined variable in first if block branch, fixes #5921
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7954 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-24 05:40:05 +00:00
mark_story
ac87db981a Fixing typos in doc blocks. Fixes #5898
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7941 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 14:31:53 +00:00
nate
3129d5411f Correcting return value for Auth::redirect(), fixes #5893
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7930 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 07:30:55 +00:00
nate
2c64c449bc Correcting Flash detection in RequestHandler, adding tests. Fixes #5838.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7914 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-10 13:55:58 +00:00
AD7six
b43128c809 Ensuring that the auth component never redirects to an external link.
Tests updated to match code changes and tests added for external referer examples


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7874 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-14 09:07:22 +00:00
TommyO
11f0817341 Improved strip method for performance and clarity.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7866 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-11 19:54:15 +00:00
gwoo
a99ca57762 fixes #5687, adding Controller::methods to hold available methods for called controller, refactored auth and dispatcher to use this property
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7864 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-11 16:34:05 +00:00
mariano.iglesias
dde4906195 Adding patch by dardosordi. Making all calls to header in SecurityComponent go through Controller. Fixing issue where invalid basic auth credentials would not trigger another login request. Added tests, fixes #5732
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7858 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-10 17:18:00 +00:00
AD7six
3f2fa6929b changing tabs for spaces in comment block indentation
Removing address and replacing with cakefoundation url


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7805 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 17:30:26 +00:00
nate
318c2b4952 Correcting SecurityComponent form hash generation when handling arrays, fixes #5588. Fixing code formatting in FormHelper test.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7794 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-29 06:55:42 +00:00
nate
16e2579f01 Correcting Security component to treat POST data arrays as a single field for validation purposes, fixes #5588
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7774 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 03:18:08 +00:00
mark_story
1b456f2cf1 Applying patch from 'davidpersson' fixing code spacing. Closes #5643
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7772 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 00:10:44 +00:00