Commit graph

320 commits

Author SHA1 Message Date
mark_story
4cb88ab1bb Expanding tests for RouterRoute route compilation. 2009-11-04 23:03:08 -05:00
mark_story
8ebd3ed410 Removing params that are not part of $url. 2009-11-04 23:03:08 -05:00
mark_story
aeb61f3750 Continuing to refactor Router methods into RouterRoute.
Fixed issues with some routes having trailing / and others not.
All existing router tests are passing.
2009-11-04 23:03:08 -05:00
mark_story
cc5c5a5ac9 RouterRoute now being used instead or route arrays.
Still some failing tests, mostly due to trailing /
2009-11-04 23:03:08 -05:00
mark_story
6da1ab9c30 Moving matching and parsing methods into RouterRoute. 2009-11-04 23:03:08 -05:00
mark_story
fec83abd90 Starting refactoring of Route methods into a separate class. Tests added. 2009-11-04 23:03:08 -05:00
mark_story
ed2e20ed23 Merge branch '1.3-misc' into 1.3 2009-10-02 13:18:12 -04:00
mark_story
cba8871f16 Adding tests so that adding one prefix removes other prefixes. Making it so you can only have one prefix at a time in a route. Also simplifies prefix switching. 2009-09-30 10:19:43 -04:00
mark_story
d2b4e33e1b Adding break; to escape out of prefix checking, optimizes operations with many prefixes. 2009-09-30 10:01:08 -04:00
mark_story
893e177909 Fixing isset() checks in Router to test for empty values instead.
Updating prefix use in paginator helper test.
2009-09-30 00:50:15 -04:00
mark_story
17782f71b3 Removing internal magic 'id' param. It behaved inconsistently in that it defaulted into the passed parameters, even though it was input as a named/routed parameter. This change makes 'id' a regular routed/named parameter. 2009-09-29 22:53:17 -04:00
mark_story
c69410d809 Removing static call, and replacing with instance method call. 2009-09-27 16:31:56 -04:00
mark_story
76c1c1cb8e Implementing Routing.prefixes.
Replaces Routing.admin and streamlines the use of Routing prefixes so they behave more consistently with admin routing.
2009-09-27 00:12:03 -04:00
mark_story
3e394f1fa8 Adding test cases for Routing.prefixes. 2009-09-26 22:48:57 -04:00
mark_story
3904c6f7b5 Adding constructor to Router.
Adding __setPrefixes to initialize prefixes and merge Routing.admin with new Routing.prefixes.
2009-09-26 22:37:19 -04:00
mark_story
2f46f39225 Removing subclassing of Object. 2009-09-26 22:24:24 -04:00
mark_story
cf849e3cf8 Removing svn tags. 2009-09-26 22:22:43 -04:00
mark_story
5717e3b59c Merge branch '1.2' into 1.2-merger
Conflicts:
	app/webroot/test.php
	cake/VERSION.txt
	cake/bootstrap.php
	cake/config/config.php
	cake/console/cake.php
	cake/console/libs/schema.php
	cake/console/templates/skel/webroot/test.php
	cake/libs/configure.php
	cake/tests/cases/console/libs/schema.test.php
	cake/tests/cases/libs/debugger.test.php
	cake/tests/cases/libs/model/model_write.test.php
	cake/tests/fixtures/aco_fixture.php
2009-09-16 01:23:49 -04:00
mark_story
bcbdb1cf1d Fixing issue where admin revere routing was possibly unsuccessful due to differences in action param between route and url arrays. Fixes #44 and #6173 2009-09-05 01:06:18 -04:00
gwoo
1423b0067b Merge branch '1.2' into 1.3 2009-07-30 11:34:33 -07:00
DarkAngelBGE
9da7b6ef55 Bringing Router coverage up to 94.45%, minor router refactorings
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8258 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-28 09:49:27 +00:00
gwoo
062f471b7f updating App::import usage. ran each test and everything seems ok. 2009-07-25 18:27:02 -07:00
AD7six
b2142df2bc adding a newline before all comment blocks 2009-07-24 21:18:37 +02:00
gwoo
a9d98e73c3 Merge branch '1.2' into 1.3 2009-07-22 09:27:31 -07:00
DarkAngelBGE
07096f3bcc fixes #6403, removing unreachable code in router
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8247 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-22 14:37:50 +00:00
DarkAngelBGE
d6a12ce5f1 2nd param init value for Router::stripPlugin(), improving router's coverage by adding tests for stripPlugin()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8245 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-22 13:02:31 +00:00
mark_story
d2245fd514 Fixing Router::normalize() so that a url containing the base param more than once, which is passed into normalize() multiple times does not get url segments removed. Fixes #6338 and #5978
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8236 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-20 13:18:38 +00:00
mark_story
74fd4849ba Fixing issue in Router where generating plugin shortcut controller routes with admin prefixes left a :controller param behind. Fixes #6252
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8235 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-17 21:35:23 +00:00
gwoo
c3643767bf some more updates to path handling 2009-06-10 16:13:39 -07:00
nate
cb95f13608 Correcting issue in String::insert() where 0 offsets were handled incorrectly, affecting issue where values were not properly quoted and inserted into conditions strings. Fixes #6163.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8085 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-09 20:03:02 +00:00
gwoo
9217a85281 adding router test and patch for plugin reverse routing
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8041 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-17 18:26:37 +00:00
mark_story
4b00c29eef Updating doc blocks to improve readability in API.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8015 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-04 05:00:59 +00:00
mark_story
7c87d36d74 Updating Router::queryString() and Router::url() to allow additional parameters to force escaping of & used in query strings. Tests added. Refs #5982
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7987 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 21:38:11 +00:00
gwoo
6026e75009 fixing preg error in Router::normalize cause by last commit
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7984 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 18:27:14 +00:00
gwoo
52318f9d17 fixes #5978, Router::normalize url generation
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7981 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 17:55:48 +00:00
AD7six
3f2fa6929b changing tabs for spaces in comment block indentation
Removing address and replacing with cakefoundation url


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7805 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 17:30:26 +00:00
TommyO
2d5773be6b Fix warning when FULL_BASE_URL is unknown. fixes #5683
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7804 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 15:05:46 +00:00
mark_story
1b456f2cf1 Applying patch from 'davidpersson' fixing code spacing. Closes #5643
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7772 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 00:10:44 +00:00
AD7six
f32e557e9c converting ini_get statements to use strict comparisons where loose comparisons were used
correcting zlib comparison to expect ini_get to return a string, rather than a boolean.


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7768 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-21 12:15:28 +00:00
phpnut
a170464d3c Reverting changing Router::compile(); to private method. Since this method is called using an instance of the Router we can still remove code that called Router::getInstance();
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7738 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-12 14:23:16 +00:00
phpnut
404e4ed2c6 Fixing @access tag
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7737 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-12 04:00:48 +00:00
phpnut
47f78d13a0 Adding more optimizations for the static classes
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7736 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-12 03:52:24 +00:00
mark_story
62168bfe0f Updating doc blocks to include access and return PHPDOC tags.
Removing use of e() in Debugger.
Fixing code formatting in CookieComponent
Closes #5477

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7662 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-25 16:49:56 +00:00
nate
85646b1908 Small refactor of Router
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7616 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-17 15:26:31 +00:00
phpnut
5658e26e07 Changing comparison operators to === (identical) which is faster than == (equal)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7604 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-14 17:17:49 +00:00
phpnut
cb487bd6e6 More optimization refactoring.
Fix cache but causing  object_map to be created and deleted on each request.
Replacing function and method calls with better performing code.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7596 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-12 05:11:34 +00:00
nate
7b8e69f120 Added config value caching and just-in-time compiling to Router
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7536 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-29 18:17:14 +00:00
phpnut
32e5f7c886 Removed unused tests route, this route has been obsolete for some time.
Reducing calls to Router::getInstance(); by almost half, increasing performance on applications larger than a hello world benchmark.

Before changes 5551 requests.
After changes 2873 requests.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7524 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-27 12:36:57 +00:00
nate
dbbbccdf18 Refactoring Router, fixed coding standards. Fixed quoting issue in DboSource::name(), affecting quoting of fields starting and ending with ()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7485 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-22 04:06:29 +00:00
mark_story
4db90553ec Router::parse will now pass ids of '0'. Test Added. Closes #5299
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7484 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-22 03:27:07 +00:00
mark_story
8b28eec1ab Removed almost all am() calls from core.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7389 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-31 00:16:16 +00:00
TommyO
b6e9888753 Replaced all instances of ife() in /cake
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7387 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-30 20:34:01 +00:00
nate
4451c02b1c Corrects handling of fully-qualified URLs in Router::normalize(), fixes #4036
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7363 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-25 11:45:00 +00:00
nate
df75a06756 Fixing coding standards violations in core, and adding misc tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7222 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-20 20:17:23 +00:00
gwoo
82f4a03385 fixes #4923, argSeparator in Router::connectNamed()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7206 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-17 15:46:49 +00:00
gwoo
df2be46b00 fixes #4874, duplicate base when url is empty
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7186 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-14 21:12:56 +00:00
phpnut
8a30290862 Fixes #4883 Duplicated component name
Removed bad test since AppController::beforeFilter() is now run when Controller::constructClasses() is called.
Fixed bug with App::import() not caching properly.
More performance changes

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7169 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-11 08:54:27 +00:00
nate
42da5aba81 Moving Cake folder to correct location
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7063 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 11:40:08 +00:00
DarkAngelBGE
e6e0d852a2 deleting cake folder from svn
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7061 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 10:59:16 +00:00
gwoo
f65f2fd3bc fixes #3415, notices in router
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6988 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-20 15:00:00 +00:00
DarkAngelBGE
45bccc5215 optimization refs #3415
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6970 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 20:36:39 +00:00
the_undefined
521986b27f Fixed problem with boolean values passed into connectNamed
Added documentation


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6934 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-18 23:08:49 +00:00
the_undefined
847811701c Fixed Router::connectNamed, added enhanced named parameter control, closes #4451
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6933 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-18 22:52:28 +00:00
the_undefined
170fe3d9d1 Fixed Router::queryString php.ini setting dependency, closes #4614
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6831 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-13 03:40:24 +00:00
nate
b9cfc9ecf3 Correcting handling of empty URLs with full base, fixes #4470
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6750 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-04 04:34:29 +00:00
nate
9bad5824cb Enabling empty array URLs in Router::url()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6727 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-26 14:41:42 +00:00
joelmoss
f9ea98e746 Changed Router tests to use static method calls to reflect actual usage in applications. Fixed the __resourceMapped call in Router::mapResources and added tests to prove it is assigned correctly. Fixes #4530
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6716 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-24 13:41:11 +00:00
the_undefined
ee94d5662c Added persist feature to routing, allows namedArgs to be auto-populated for reverse routing based on current request
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6704 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-19 20:57:23 +00:00
the_undefined
5c0b72db85 Added support for controlling namedArg behavior on routes level, fixes #4451
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6686 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-17 23:14:49 +00:00
the_undefined
f51f051bc2 Fixed small Router bug in previous commit
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6649 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-09 19:07:02 +00:00
the_undefined
4b19d4c38d Added support for final characters in multi param route elements
Fixed issue with reverse routing and falsely escaped route regex

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6647 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-09 18:26:20 +00:00
mariano.iglesias
0427272236 Fixing failing test case introduced in [6635]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6636 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-05 17:49:10 +00:00
the_undefined
7a769f68ca Restricted named route element to contain no special chars other then '_'
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6559 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-11 15:19:46 +00:00
nate
24ea731e7f Making parsed parameters always show up at the beginning of 'pass', closes #4299
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6517 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-08 16:14:51 +00:00
nate
12466ebe43 Making sure default extension is always set when Router::parseExtensions() is used
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6507 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-03 23:56:18 +00:00
the_undefined
5c6b6b9cf6 Removed illegal function names from Router::__named
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6503 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-03 16:01:46 +00:00
the_undefined
6ca8de212e Optimized Router for speed
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6502 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-02 22:47:59 +00:00
the_undefined
0b4e8e63ac Added support for multiple route parameters per path element
Fixed bug with pass param order
Added / updated router tests

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6498 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-01 15:57:25 +00:00
the_undefined
394322f35d Added pass feature to Router::connect
Implemented it for Router::mapResources

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6489 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-29 20:22:57 +00:00
nate
766703f15f Fixing default route mappings, refactoring route generation, fixes #4109
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6456 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-12 14:11:33 +00:00
nate
e0fb76d757 Fixing undefined index error in Router::getParams() when rendering error pages in the test suite
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6455 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-11 06:53:59 +00:00
nate
f3355bd74b Removing all references to deprecated 'webservices' and 'bare' routes and route parameters, removing deprecated constants, updating core tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6453 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-11 06:18:41 +00:00
nate
ab1a245086 Adding option to remove application base path to Router::url()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6444 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-06 20:47:48 +00:00
nate
89052b0f54 Adding performance enhancement to Set::numeric(), adding $filterKey param to Model::create() to overwrite primary keys, closes #4046
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6438 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-06 02:35:12 +00:00
nate
d9691a19c8 Refactoring Router::mapResources(), adding tests for REST routing and HTTP method overrides
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6409 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-26 08:50:06 +00:00
phpnut
cb53dc61b0 "Closes #2897, Built-in file validation.
Implemented Validation::extension(); and Vaidation::range();
Updated copyright notices in all files"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6296 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-01 22:18:17 +00:00
gwoo
48bf9e420d updating router admin handling, closes #3697 test added
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6281 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-30 19:53:21 +00:00
phpnut
75b5623f33 "Closes #3587, Multiple resource routes"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6257 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-25 10:25:42 +00:00
nate
570e71f62a Adding fix for Router named arguments where arg value contains the separator key (Ticket #3752)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6172 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-19 01:49:25 +00:00
nate
481cbf521e Adding fixes to Router::normalize() when called with empty parameter (Ticket #3734)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6152 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-14 15:09:05 +00:00
nate
9d58121205 Removing trailing slash from normalized URLs in AuthComponent, moving AuthComponent::_normalizeURL() to Router::normalize(), refactoring (Ticket #3042)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6145 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-13 07:03:59 +00:00
nate
4689258464 Adding REST route matching fixes (Ticket #3665)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6135 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-08 16:59:57 +00:00
phpnut
8a2b51c3ec "Removing all shortcut function usage from the core"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6128 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-08 06:08:03 +00:00
gwoo
557a1bf239 Router::__mapRoute, added check for plugin and controller with the same name
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5961 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-07 00:17:38 +00:00
gwoo
53f889f6c6 updating router fixes #3485
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5935 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-02 06:21:41 +00:00
gwoo
b1b8fcddd2 adding named to params so the proper args get passed to the action, updated tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5932 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-31 03:53:41 +00:00
nate
9b578c5bb1 Adding tests for incorrectly matched routes
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5931 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-30 22:41:55 +00:00
nate
458bd08027 Adding regular expression tests for route matching
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5930 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-30 21:25:02 +00:00
nate
d913e88ef5 Adding required route matching for passed params in reverse routing, adding fix for matching on optional route parameters (Ticket #3355)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5923 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-29 21:33:20 +00:00
gwoo
020e817815 updating router, adding test case fixes #3440
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5887 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-24 15:09:40 +00:00
mariano.iglesias
896f62544b Changing @return int to @return integer and @param bool to @param boolean
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5860 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-22 16:54:36 +00:00
phpnut
da97a5c871 Correcting @return bool
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5857 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-22 16:09:35 +00:00
mariano.iglesias
897825d596 Adding documentation to classes belonging to Cake console.
Standarizing on datatypes used in phpdocblocs and removing unneeded @return types

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5851 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-22 05:52:20 +00:00
phpnut
0873217a1f Fixes #3427, MAGIC_QUOTES_GPC settings affecting parameters passed to actions
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5848 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-22 04:31:34 +00:00
gwoo
1987814eff adding patch to router for named args, closes #3391
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5842 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-22 00:07:39 +00:00
gwoo
ad6a0c12c5 refactor args generation
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5694 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-09-26 09:49:01 +00:00
phpnut
643da0ab97 fixes #3260, Router generating wrong url
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5684 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-09-21 02:29:36 +00:00
nate
55e8592e17 Fixing passed args support in Router, refactoring helper tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5653 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-09-16 18:32:02 +00:00
gwoo
7793b4f5c0 fix for router and edit links, added tests, closes #3108
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5592 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-28 21:16:24 +00:00
nate
1326d20792 Router fix for breaking out of plugins (Ticket #3106)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5577 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-24 13:11:31 +00:00
nate
73909d0617 Adding Router fix for breaking out of admin mode (Ticket #3119)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5576 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-24 12:50:21 +00:00
nate
b33ff0330f Additional default named argument for pagination (Ticket #5535)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5569 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-22 17:32:12 +00:00
nate
c4c3bf4ccd Adding fixes for parameter matching in reverse routing (Ticket #3099)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5557 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-20 16:02:11 +00:00
nate
bd194b51e5 Routing fixes for invalid null value matching and named argument handling (Ticket #3083, #3085, #3086, #3093). Thanks biesbjerg for all your help!
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5554 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-20 13:09:11 +00:00
nate
90567a286a Moving named argument handling into Router
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5535 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-16 16:31:50 +00:00
nate
3e7044d4b8 Implementing prefix-based routing, and transitioning configuration away from global constants
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5531 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-16 05:44:06 +00:00
nate
ad75ecea81 Fixing and refactoring reverse routing, and adding URL generation fixes (Ticket #3034)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5523 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-15 14:18:39 +00:00
nate
214ad6346f Refactoring Router and fixing route matching, adding tests (Ticket #3033)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5521 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-14 18:51:34 +00:00
gwoo
85c2a4ef98 updating router for plugins
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5501 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-08-07 23:19:42 +00:00
phpnut
64325bd60d Adding fix for failing routes for plugins
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5475 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-07-31 05:00:24 +00:00
phpnut
504dec6d76 Adding quick fix for undefined index admin
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5474 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-07-31 02:01:29 +00:00
nate
cfd4e0f3d7 Fixing Router issue with named arguments being dropped from matched routes
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5473 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-07-30 13:15:59 +00:00
gwoo
d6c4229d81 updating router test
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5471 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-07-27 17:51:33 +00:00
nate
dee2ea4f68 Updating fix for empty parameter passing in Router; adding test case
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5470 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-07-27 13:32:26 +00:00
gwoo
fc9503e473 fixing bug with url parsing
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5468 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-07-27 02:46:30 +00:00
phpnut
549d86ac23 Refactoring dispatcher.
Added test for changes to Dispatcher.
Updating Model::_ _saveMulti(), moved the insert statement to DboSource::insertMulti() this will allow database that do not support multiple inserts in one statement to save data.


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5460 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-07-25 04:38:28 +00:00
nate
7b4264b68c Adding header detection to Router, and implementing prototype REST routes
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5454 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-07-24 13:50:50 +00:00
nate
5ab89f495f Refactoring Router and improving route generation efficiency
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5450 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-07-22 04:07:06 +00:00
nate
2664ed2ee4 Fixing trailing slash in URL when extension is used (Ticket #2934)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5439 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-07-17 13:45:20 +00:00
phpnut
03ea2b8287 Adding fix for Router::url() when static call is made outside of an object instance
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5329 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-06-22 01:25:35 +00:00
phpnut
85492fba92 Adding fix for Ticket #2750, fixes rendering of links when requestAction() is used.
Router::url() replaced $_this with $this which is an instance of the class from which the method is called, in the case of this ticket it was an instance of the HtmlHelper

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5319 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-06-21 06:47:57 +00:00
phpnut
23dfd90b29 Correcting code structure to standards
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5313 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-06-20 06:15:35 +00:00
phpnut
02508cfb02 Adding fix for #2640, fixes nested array issues with Router::stripEscape()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5257 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-06-07 19:27:42 +00:00
gwoo
3acebbcecb adding pass to the default set of router params
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5227 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-06-01 17:27:10 +00:00
mariano.iglesias
61a3d09dbc Adding comments for Router
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5193 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-26 06:26:06 +00:00
phpnut
641a77563f Adding fix for #2637, fixes issue with Router::stripEscape() corrupting boolean values
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5182 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-25 03:33:12 +00:00
phpnut
646d1ad868 changing param check in Router::stripEscape()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5163 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-24 04:20:53 +00:00
phpnut
f706d050a4 Merging changes from [5157] into DboSource.
Adding better check in Router::stripEscape()

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5160 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-23 20:00:16 +00:00
phpnut
056c4cc054 Adding fix for #2613, fixes afterFind callback not called on models in depth search > 1 (recursive).
Changed the regex pattern matching in Router::stripEscape()

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5140 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-21 03:54:42 +00:00
phpnut
df5c02aa8f Adding fix for #2612, Fixes AuthComponent::identify SQL injection, and also removes ability to pass the -! in the posted data
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5139 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-21 03:29:49 +00:00
nate
540b1052d8 Fixing string-based URL generation inside plugins (Ticket #2588)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5123 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-20 01:40:34 +00:00
nate
8fb9acc981 Adding admin route matching fix (Ticket #2541)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5069 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-13 02:00:24 +00:00
phpnut
137fea94c6 Cleaning up line endings
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4994 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-03 04:35:25 +00:00
phpnut
6a5f623240 Adding fix for failing ajax tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4946 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-04-30 11:12:11 +00:00
phpnut
d861587960 Adding fix for #2452 (patch from #2476).
Added tests for ticket #2452

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4927 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-04-29 11:10:11 +00:00
phpnut
0ddac86f58 Adding fix for #2466 fixes missed Router::__mapped reinit in Router::url()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4909 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-04-29 03:46:58 +00:00
nate
3ba273b16d Adding URL fragment (hash) support in Router::url() (Ticket #2432)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4869 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-04-17 07:51:01 +00:00
nate
e5b0f2e3fa Moving Router::__filter() to Set::filter()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4867 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-04-17 07:00:26 +00:00
phpnut
a2ba6d7715 Adding fix for Ticket #2392
Added tests for this fix.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4848 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-04-12 07:17:39 +00:00
gwoo
923303b462 fixing router when affected by requestAction #2319, adding check in magic methods for a value otherwise it will return false
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4740 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-04-02 19:20:50 +00:00