Commit graph

367 commits

Author SHA1 Message Date
phpnut
4c2a3ee02f Closes #5591.
Modified models in models.php setting the with key since these models are not used unless the with key is defined in the association.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7740 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-13 01:17:34 +00:00
phpnut
f139b0312f Fixes #5591 Dynamic With Models broken after changeset [7732]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7739 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-12 22:21:55 +00:00
phpnut
93a54735d6 Fix loading of dynamic 'with' model, each dynamic 'with' would attempt to find and load the file 5 times, fixed so no it longer attempts loading a file if the 'with' key is not defined in the association.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7732 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-12 02:16:43 +00:00
mark_story
b5473a5f9b Refactoring variable names, more readable variable names.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7705 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-06 02:44:05 +00:00
mark_story
b2bda3d1bd Changing spelling of neighbours to neighbors. Closes #4948.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7696 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-03 21:23:13 +00:00
mark_story
2a115d0fa3 Updating doc block for Model::find() adding references for missing find types. Closes #4948
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7695 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-03 18:06:15 +00:00
gwoo
443491e7fa reverting changes from 7668
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7689 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-02 02:16:09 +00:00
nate
2bfd5a4b3e Refactoring schema test and fixing formatting, refactoring Model::_findCount() to use DboSource::calculate() in all cases, closes #4501
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7684 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-01 15:27:29 +00:00
mark_story
1ae8cda6c2 Adding documentation to beforeValidate(). Closes #5498
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7681 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-30 00:13:15 +00:00
gwoo
f8f4bcc16c fixes #5482, playing with model that uses alias
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7668 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-26 15:27:36 +00:00
mark_story
1a0d87ba83 Correcting type and expanding documentation for Model::invalidate(). Closes #5481
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7667 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-26 15:14:31 +00:00
gwoo
e6b994bcb1 updating handling of required classes, fixes #5480
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7666 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-26 14:03:16 +00:00
mark_story
370b20dce6 Minor optimizations
Closes #5249 and #5282

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7664 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-26 00:46:53 +00:00
mark_story
62168bfe0f Updating doc blocks to include access and return PHPDOC tags.
Removing use of e() in Debugger.
Fixing code formatting in CookieComponent
Closes #5477

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7662 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-25 16:49:56 +00:00
DarkAngelBGE
4ce3f21608 adding missing options array in Model::beforeValidate(0 and Model::beforeSave() as they are called with them out of the model and it is good practice, although they are meant to be overriden; closes #5470
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7650 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-23 18:50:27 +00:00
nate
24b444ca55 Fixing behavior initialization in model construction, adding Set::flatten() utility method for future refactoring, updating Set test
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7644 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-22 16:32:41 +00:00
nate
d9b357d05c Making Model::$_findMethods protected, and fixing fatal error when table calls are attempted on a model with a missing table
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7640 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-21 04:09:16 +00:00
gwoo
931d996d90 fixes #5438, multiple binding with alias
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7632 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 15:27:43 +00:00
nate
57c633a64f Adding proper callback disabling for multiple finder types, fixes #5343
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7549 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-04 01:00:08 +00:00
mark_story
a8bb2eb826 Fixing saveAll() using validate => only, applied patch from 'ADmad'. saveAll() now returns value of all validations, not just the last row to be validated. Closes #5376. Tests added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7547 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-03 16:44:48 +00:00
phpnut
6bdc60731f Adding more changes to improve performance. Fixes loading of Models when instance has already been created in the registry
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7527 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-27 16:43:15 +00:00
DarkAngelBGE
7863669dab prevent model->save() validating all fields when a fieldList option is supplied, closes #5320
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7519 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-27 08:01:00 +00:00
nate
1940d8877c Fixing Model/db $cacheSources conflicts, model can now disable only. Fixes #5177
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7518 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-27 04:55:15 +00:00
gwoo
7fe1a03fda fixes #5331, model alias no longer overwritten
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7515 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-27 01:30:09 +00:00
DarkAngelBGE
285d075475 Fxiing validation error when trying to update records using saveAll for hasMany fixes #4981
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7506 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-26 13:31:07 +00:00
gwoo
e35a215883 fixes #5307, model name being overridden by class registry for no reason, thanks to vizjerai for the helpful ticket.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7501 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-25 22:33:36 +00:00
mark_story
ce8dccc1fc Expanding docblock on model::save()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7491 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-23 21:31:38 +00:00
mark_story
b3b9827862 Changed check for tablePrefix. Closes #5266
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7476 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-19 01:18:33 +00:00
nate
dfc115d5da Updating findCount() calls to find('count') in Model test, fixing custom field counting support, regex typo in DataSource
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7466 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-14 16:52:29 +00:00
gwoo
995040a98a fixes #5239, primary key for HABTM, reverts last change for #5233 which broke the tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7454 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-11 16:18:19 +00:00
gwoo
76f7d6dc43 making changes to all the model group to run. Currently I get 8/8 test cases complete: 1486 passes, 22 fails and 3 exceptions.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7439 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-07 15:36:26 +00:00
AD7six
739c5169e4 fixes #5064 Preventing 'floating' results from being returned by find('threaded')
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7414 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-01 16:49:56 +00:00
nate
793295036f Re-fixing Model::set() to allow for fields that don't exist, fixing model validation with messages, adding tests to prove parameter order for custom validation errors, refs #50005
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7408 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-01 06:28:59 +00:00
gwoo
f6d269a9e0 closes #5142 primary key on custom join models
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7393 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-31 15:38:23 +00:00
mark_story
8b28eec1ab Removed almost all am() calls from core.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7389 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-31 00:16:16 +00:00
TommyO
7c7410bda2 Replaced instances of ife() with more sutiable alternatives in model.php
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7384 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-30 16:26:48 +00:00
mark_story
3c1ebafa0a Modified dbo_mysql update() fixes issue with updateCounterCache on self join tables. updateCounterCache query optimized. Closes #4652, #5152
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7376 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-30 02:22:15 +00:00
mark_story
96b5a6fa87 Added test to prove #5125. Added documentation to updateAll.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7373 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-29 01:18:57 +00:00
mark_story
ac45340a71 Optimization when checking for setTable prefix.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7370 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-27 15:55:49 +00:00
mark_story
9b857e9f36 Added camelCase check for setTablePrefix. setTablePrefix now fires on PHP5. Closes #5147
Updated test in model.test to reflect changes in empty string handling for float and integer types.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7368 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-27 04:19:54 +00:00
phpnut
bdc3685e62 Fixes #5024, find('threaded') returns empty array if root node is not included in the results.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7321 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-05 14:10:42 +00:00
phpnut
84069e372f Fixes #5021, findAllThreaded does not work with tables that have set primaryKey to something other than 'id'
Removed am() from Model::_findThreaded();
Cleaned up error.php and dispatcher.test.php

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7318 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-05 12:37:18 +00:00
phpnut
5131e1c3b3 Fixing undefined variable usage in Model::saveField();
Fixes #5053 Model:saveField $options bug;

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7316 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-05 11:02:09 +00:00
gwoo
7ad1790ea2 removing and moving deprecated code
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7285 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 06:19:04 +00:00
nate
14e8c5fe7b Correcting inconsistent return values in Model::saveAll(), updating bad tests, fixes #4981
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7283 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 06:07:00 +00:00
AD7six
d000c59ceb Deprecating findNeighbours
adding find('neighbors')


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7272 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-26 19:42:07 +00:00
AD7six
2ce0f1f3cf deprecating findAllThreaded
removing __doThread
adding find('threaded')


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7271 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-26 19:33:44 +00:00
nate
7b6ee7386b Correcting issue where TranslateBehavior hijacks find() calls from Model::exists(), fixes #4765
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7225 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-21 02:33:04 +00:00
nate
df75a06756 Fixing coding standards violations in core, and adding misc tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7222 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-20 20:17:23 +00:00
gwoo
c75cad26d5 updating model test for new find syntax
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7217 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-19 17:06:50 +00:00