Commit graph

3312 commits

Author SHA1 Message Date
nate
ad208ff8c3 Refactoring previous fix to revert markup changes in HtmlHelper, updating FormHelper tests to comply with coding standard, correcting bad assertions, fixing issue with field types being mis-identified if duplicate names are used, fixes #5919
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7959 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:13:06 +00:00
nate
1deae7a586 Updating Validation::url() with $strict parameter to require URL scheme, fixes #5536
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7958 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:11:06 +00:00
nate
b2b46c3fa4 Implementing $safe mode for RequestHandlerComponent::getClientIP(), which ignores HTTP_X_FORWARDED_FOR, fixes #5842
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7957 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:02:36 +00:00
gwoo
4f799a7141 closes #5121, updating home.ctp
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7955 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 18:02:06 +00:00
nate
d5b157ed94 Fixing undefined variable in first if block branch, fixes #5921
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7954 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-24 05:40:05 +00:00
mark_story
b063f22f31 Fixing habtm joins for tables with two uuid fields, no primary key and a defined join model. Adding fixtures.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7953 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-23 23:28:08 +00:00
nate
61850b1be1 Cleaning up test code formatting, adding fix for POST hash validation of checkbox lists, fixes #5903, test cases added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7951 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-23 08:13:00 +00:00
mark_story
943bb53dda Correcting callback firing of helpers in view. Tests added fixes #5906
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7948 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-21 22:14:48 +00:00
gwoo
3eb9f65e99 fixes #5909, return for __() for translate behavior errors
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7947 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-21 17:32:30 +00:00
nate
e2c087f34b Fixing failing tests in JavascriptHelper.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7944 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-19 01:30:02 +00:00
nate
a5b7276696 Correcting DboSource::order() identifier quoting, correcting bad DboSource tests, fixes #5900
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7942 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 20:49:25 +00:00
mark_story
ac87db981a Fixing typos in doc blocks. Fixes #5898
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7941 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 14:31:53 +00:00
phpnut
eb653b8cba Closes #5792, Inflector optimization by returning replaced values instead of assining before returning
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7940 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 01:35:27 +00:00
phpnut
d5b86bc4bf Closes #5733, Avoid delegation overhead in Folder::correctSlashFor();
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7939 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 00:27:10 +00:00
phpnut
7f30d75739 Closes #5735, Replace preg_match in Folder::isSlashTerm
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7938 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 00:22:57 +00:00
phpnut
3daa7c9e1f Closes #5734, Call static methods in Folder statically
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7937 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 00:17:19 +00:00
phpnut
e102144d42 Closes #5820, Duplicate value in result of Configure::corePaths();
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7936 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 00:12:27 +00:00
gwoo
4dbd8e6791 updating to Set::extract() to fix containable test fails, added set cases to match usage in containable.test
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7934 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 21:33:11 +00:00
john
a1046de895 Couple of syntax fixes - missing semicolon and usage of empty() inside a conditional.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7933 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 18:09:32 +00:00
nate
870c4e87ca Fixing code formatting in JavascriptHelper to wrap at 100 characters, small return-home-early refactoring.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7931 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 16:08:31 +00:00
nate
3129d5411f Correcting return value for Auth::redirect(), fixes #5893
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7930 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 07:30:55 +00:00
nate
8eade1adb3 Fixing code formatting to wrap at 100 characters, adding fix for ticket #5596, counterCache now decrements properly when foreign key value changes.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7927 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 04:13:45 +00:00
mark_story
9071d8165f Correcting generation of id attributes for radio buttons. Tests added, fixes #5891
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7924 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 01:49:58 +00:00
mark_story
ea9c080b1c Adding alterSchema() to dbo_postgres. Also handles index alters. Tests added for field and index alter sql.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7923 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-16 04:38:48 +00:00
mark_story
48c65c4092 Adding index() to dbo_postgres. Tests added for index introspection. Also fixes object to string conversions when working with database expressions. Fixes #5867
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7922 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-15 02:25:55 +00:00
TommyO
a601129d46 Brings odbc driver mostly up-to-date. Fixes #5730
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7921 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-14 18:36:40 +00:00
phpnut
0d3ea7a5f2 Adding fix when join table does not have a primary key 'id' defined
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7918 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-12 17:19:27 +00:00
mark_story
43af288eca Adding index(), alterSchema(), dropSchema() support to MySQLi driver. Refactored MySQL & MySQLi drivers. Updated and fixed tests.
Fixes #5824

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7915 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-11 00:13:11 +00:00
nate
2c64c449bc Correcting Flash detection in RequestHandler, adding tests. Fixes #5838.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7914 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-10 13:55:58 +00:00
mark_story
569b9dd48a Adding index() to dbo_sqlite. Tests added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7913 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-10 03:38:10 +00:00
phishy
caa063590d Fixed #5800. Fixed INSERTs broken by refactoring of DboSource::renderStatement()
Also added slightly more support for CakeSchema with DboOracle


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7912 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-10 01:30:36 +00:00
mark_story
d405d1d1c3 Adding indexes to alterSchema() and CakeSchema::compare(). Thanks for the test case and patch 'bamyers99'. Fixes #5862
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7910 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-09 04:54:58 +00:00
mark_story
930a2d954f Fixing infinite loop in AdoDB when trying to get result sets with more than on result. Fixes #5846
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7908 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-08 03:13:45 +00:00
mark_story
cf3a194807 Modifying getInstance() to allow subclasses to work properly. Tests added. Changed __output() to protected.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7906 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-07 20:44:00 +00:00
mark_story
b2b4c4be47 Adding App::import() to app_helper files. Fixes issues with Missing Helper Class, and allows you to use helpers in shell classes. Fixes #5458
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7904 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-05 16:49:43 +00:00
gwoo
4dd105d415 fixes #5829, form helper using proper method reference for parseAttributes. A patch would have been nice, but some ticket submitters prefer not to make much effort.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7902 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-01 19:39:40 +00:00
mark_story
c49f213fcf Adding spaces before self close of meta link elements. W3C recommends a space before />. Fixes #5821
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7899 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-30 05:25:37 +00:00
mark_story
090028403b Fixing FormHelper dateTime creation when using custom empty strings and null values. Tests added. Fixes #5769
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7898 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-29 00:28:31 +00:00
phpnut
4cdbd4edd9 Removing unreachable code
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7896 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-27 04:52:45 +00:00
gwoo
9d2f59529c fixes #5684, Set::extract() without index 0
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7895 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-26 22:33:21 +00:00
phpnut
92e04703b7 Adding ability to turn off Camel Casing of nodes in Xml::toArray();
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7894 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-26 18:21:21 +00:00
mariano.iglesias
da39ce77b9 Fixing order of associated results on test that was making a test to fail. Fixing issue where HABTM conditions were not being taken into account when deleting links. Adding tests, fixes #5798
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7893 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-26 14:15:51 +00:00
renan.saddam
aa1abdda9a Applying previous patch to _checkValid method. Fixes #5450.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7892 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 16:35:20 +00:00
mariano.iglesias
f9557c7611 Fixing issue where radio elements would produce wrong hash when Security component enabled in FormHelper, fixes #5791
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7891 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 16:32:54 +00:00
mariano.iglesias
acaaa7ee64 Resetting error on Validation (patch from francky06l), fixes #5797
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7890 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 13:05:57 +00:00
phpnut
69f883a89f Adding $data['attrib'] back to RssHelper::channel(); after more research use cases for this were found.
Related test case added

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7889 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 05:54:31 +00:00
phpnut
2444b29cd5 Fixes #5778, Order of L10n map array (esp. fre, fra)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7888 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 04:23:53 +00:00
mark_story
cfa2229689 Fixing incorrect implementation of RssHelper::channel(). Test cases added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7887 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-24 23:10:29 +00:00
mark_story
acb9e72355 Minor refactor to helper callback triggering. Moving repeated loops to _triggerHelpers(). Allows View subclasses to add additional callbacks.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7886 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-24 05:36:06 +00:00
mark_story
ace8ef4b5a Applying patch from 'tyler'. Updates Ajax helper to reflect updated scriptaculous API. See http://github.com/madrobby/scriptaculous/wikis/ajax-inplaceeditor. Fixes #5790
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7885 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-24 05:23:31 +00:00