Commit graph

416 commits

Author SHA1 Message Date
mark_story
c47e899ba1 Fixing HtmlHelper::css, and JavascriptHelper::link so that files containing the asset extension always get the extension added. Test cases added. Refs #139 2009-10-02 12:53:20 -04:00
mark_story
f12cbdba38 Fixing CacheHelper and multiple cake:nocache tags in a view file, breaking cake:nocache following $content_for_layout. Fixes #136 2009-10-01 01:03:47 -04:00
mark_story
508d737b6a Updating HtmlHelper::css, JavascriptHelper::link to not replace multiple occurences of CSS_URL or JS_URL when using Asset.filter settings.
Test cases added.
Thanks to 'robustsolution' for the patch.
Fixes #105
2009-09-26 14:22:12 -04:00
mark_story
06cf97459a Fixing XmlHelper::elem() when value is null and cdata = true. Removing empty invalid tag.
Test cases added.
Fixes #127
2009-09-24 22:43:31 -04:00
mark_story
022f8ccaa2 Making conditions easier to read.
Adding additional test for image timestamping.
Refs #108
2009-09-22 19:04:40 -04:00
ADmad
07a89cd953 Updated Html and Javascript helpers to suffix asset urls with timestamp even when the app is run off a subfolder on the domain
Signed-off-by: Mark Story <mark@mark-story.com>
2009-09-22 18:57:30 -04:00
mark_story
e0b6b25365 Fixing inherited public properties not being set in SessionHelper.
Adding tests for SessionHelper construction and the setting of inherited properties.  Fixes #94
2009-09-17 19:57:56 -04:00
mark_story
0065005f95 Fixing custom error class not being used if error for field is a named index. Test case added. Fixes #76 2009-09-10 09:57:23 -04:00
mark_story
cf3521737f Fixing selected with interval not selecting the correct option. Fixes #70. 2009-09-03 22:47:17 -04:00
mark_story
72d90f2ce8 Adding tests for array_diff_key() in php4. Increasing test compatibility with php4
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8281 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-08-03 19:24:38 +00:00
gwoo
9e1dec3ff3 fixes #6538, xml serialization on multi dimensional
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8264 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-31 01:50:14 +00:00
mark_story
47cd941b53 Applying optimization patch to PaginatorHelper and test refactorings to PaginatorHelper test case. Thanks Phally. Fixes #6526
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8259 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-28 12:40:31 +00:00
mark_story
f9ff43b352 Refactoring paginator.test.php to use assertTags() where it makes sense.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8240 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-21 02:59:30 +00:00
gwoo
56bee6e1fc fixes #6507 paginator sort directions
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8239 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-21 01:53:14 +00:00
gwoo
4cfdd311a9 fixes #6476, crash on missing layout in session flash
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8238 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-21 01:33:12 +00:00
mark_story
76d5855d72 Applying patch from 'Phally' Fixes multiple issues in PaginatorHelper related to first and last option in numbers(). Fixes #6516
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8234 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-17 19:46:33 +00:00
mark_story
baea319122 Applying patch from 'Dremora' fixes JavascriptHelper::codeBlock() and blockEnd() bugs where content vanished due to incorrectly structured buffers. Minor behavior change in that codeBlock(null) no longer returns an opening script tag. The entire script tag is returned when blockEnd() is called.
Test cases updated and refactored.
Fixes #6504


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8231 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-14 17:11:46 +00:00
DarkAngelBGE
44fa8d5fd0 Getting the time helper code coverage up to 99%
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8228 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-11 16:45:29 +00:00
DarkAngelBGE
11c664177f git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8227 3807eeeb-6ff5-0310-8944-8be069107fe0 2009-07-11 15:36:45 +00:00
davidpersson
68d333d088 Applying patches by ADMad updating HtmlHelper and adding test. Adding missing properties in test case. Preventing bleed through in test case. Fixes #6490
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8220 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-04 22:04:40 +00:00
gwoo
9e143bc335 fixes #6473, dot notation for sort in next/prev
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8213 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-07-02 23:48:10 +00:00
mark_story
1ea5f94c29 Updating JavascriptHelper::escapeString to properly encode utf8 characters as per the JSON spec.
Test cases added, with comparisons to json_encode()
Fixes #6400

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8198 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-06-17 01:59:41 +00:00
mark_story
50f4d91873 Adding test case to disprove #6411
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8181 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-05-30 19:12:15 +00:00
jperras
4f2d65943f Fixing form helper checkbox hidden input generation for disabled fields. Thanks to 'trevorsg' for the patch & test case.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8173 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-05-14 03:26:53 +00:00
renan.saddam
bd7bd5d891 Fixing issue when generating textarea with null value.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8146 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-16 18:12:01 +00:00
mark_story
8db4fe682b Allowing name attribute to pass on to hidden field in FormHelper::radio().
Fixes inconsistency with checkbox().  Test case added.
Fixes #6260

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8145 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-15 17:18:01 +00:00
mark_story
377108f930 Adding tests to show correct usage of form::create() with querystring params. Closes #6278
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8144 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-15 02:29:50 +00:00
mark_story
32107f5fba Fixing test broken in [8136]. Adding Configure::write() to prevent fails when running helpers as a group.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8143 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-15 02:14:04 +00:00
mark_story
5f4cdf91ac Fixing AjaxHelper::dragOptions to match scriptaculous docs.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8136 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-06 00:57:46 +00:00
mark_story
5c4f838f5a Adding buffer flush to ajax helper test. Test suite menus now properly display.
Fixing Drag options.  Adding test coverage. Fixes #6266

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8135 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-06 00:45:53 +00:00
mark_story
d74e2d1a73 Fixing newline escaping for single quote strings, output now matches json_encode().
Test added, and old test fixed.
Fixing buffering issues, causing test suite menu to disappear when running JavascriptHelper Test case.
Fixes #6167

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8134 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-04 02:42:46 +00:00
mark_story
6551e2a45d Adding test for file input creation on hasOne relationship. Refs #6223
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8132 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-28 02:46:23 +00:00
mark_story
0516fb2090 Enabling disabled attribute to be passed to hidden input when making checkboxes.
Test case added. 
Fixes #6226

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8128 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-25 16:58:29 +00:00
jperras
4439bc4f70 Fixing regression in PaginatorHelper. Adding tests for PaginatorHelper::sortDir, as well as fixing incorrect test for sorting with Model.field dot notation. Fixes #6218.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8125 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-22 18:59:53 +00:00
davidpersson
fd7d6718a1 Updating tests to not affect other ones when run from a group
Adding NoCrossContamination group
Shortening group class names
Renaming lib_controller group
Updating test imports to include the core AppController by default
Some cosmetics




git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8123 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-21 23:55:39 +00:00
davidpersson
3c3b852099 Changing package of tests from "cake.tests" to "cake".
Moving tearDown et al. to the top of each test class.
Adding short descriptions to docblocks.
Adding missing docblocks.
Removing unnecessary blank lines and whitespaces.
Updating labels of test groups.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8116 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-18 17:55:58 +00:00
nate
36d3540c19 Adding native-type-generation fixes for JavascriptHelper::object()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8095 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-13 14:49:00 +00:00
gwoo
de6541f658 fixes #6189, paginator sort direction for associated fields of the same name
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8092 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-12 17:11:08 +00:00
mariano.iglesias
fdbf102228 Fixing issue where disallowing plugin was not possible in PaginatorHelper, fixes #6159
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8090 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-11 19:24:06 +00:00
mark_story
c164be8c03 Enabling Asset.timestamp for HtmlHelper::image() making it consistent with Javascript::link().
Tests added.
Fixes #6170

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8078 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-06 04:40:50 +00:00
mark_story
18a7115385 Adding test to show proper escaping of escaped strings in Javscript::object() closes #6167.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8076 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-06 03:53:31 +00:00
jperras
79cba70758 Updating number helper to allow output of main currency symbol in the 'after' slot. Also added some basic i18n for NumberHelper::toReadableSize Fixes #6150.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8069 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-03 15:32:12 +00:00
the_undefined
74bf622866 Fixes #6071
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8053 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-23 15:19:33 +00:00
renan.saddam
b5d7f182a0 Disproving FormHelper::textarea always escapes value. Closes #6016.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8006 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-21 01:15:29 +00:00
mark_story
b94a85e938 Altering Helper::url() to enforce escaped query strings for generated urls.
Tests added to Html::link().  Fixes #5982

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7991 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 22:41:47 +00:00
TommyO
de1d1ae3bd Fixed asset.timestamp inconsistency for css files.
Added tests to confirm css linking.
Closes #5990. Fixes #5991

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7990 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 22:19:11 +00:00
mark_story
287968934f Fixing next()/prev() when paginating multiple models. Added tests from 'hummer'. Fixes #5970
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7989 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 22:08:11 +00:00
mark_story
7b12272253 Fixing issues with am times and form test.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7975 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-13 18:42:08 +00:00
mark_story
79c791548f Fixing formHelper::hour when specifying a strtotime compatible string for the selected value. Tests added Fixes #5941
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7967 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-30 16:20:38 +00:00
nate
ad208ff8c3 Refactoring previous fix to revert markup changes in HtmlHelper, updating FormHelper tests to comply with coding standard, correcting bad assertions, fixing issue with field types being mis-identified if duplicate names are used, fixes #5919
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7959 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:13:06 +00:00