Commit graph

4982 commits

Author SHA1 Message Date
Mark Story
c8297ff283 Minor optimization on Inflector::variable 2009-12-16 19:23:29 -05:00
Mark Story
aa3a197b26 Reformatting test case. Fixes #104 2009-12-16 18:40:45 -05:00
real34
bdfb50e6bb Fixed a bug in Set::extract. Wrong key returned when two arrays are at the extraction level.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-12-16 18:33:23 -05:00
Mark Story
4ac29963a8 Refactoring Model::__validateWithModels. Should be slightly faster as loops are smaller. 2009-12-15 22:55:34 -05:00
Mark Story
a490e249fa Adding test for validation of with models canceling a save.
Adding initial implementation of Model::__validateWithModel().

Correcting error in previous commit.  Adding tests for saveAll and validating habtm with models.
2009-12-15 22:55:22 -05:00
ADmad
33038c75ac Removing redundant 'isset' check from DboMysql::connect 2009-12-15 20:41:44 +05:30
Mark Story
02330b2d9c Making DboSource::fields() accept an expression object. Fixes issues with sql parsing over quoting special SQL syntax.
Tests added
Fixes #66
2009-12-13 15:52:07 -05:00
Mark Story
47a9401d43 Adding test case for cached view files, and fatal errors caused by the view instance not being registered. View instances are now registered when rendering view caches, and unregistered if the cached view fails. This fixes issues rendering flash messages with custom layouts and fixes FormHelper methods inside nocache blocks.
Fixes #60
2009-12-13 12:39:39 -05:00
renan.saddam
c3bf6bc0e8 Checking for french error on dbo_mssql. Fixes #77. 2009-12-09 21:20:55 -02:00
Mark Story
7c2cdb1fb4 Adding tests to Xml::toString to disprove #395 2009-12-08 22:00:55 -05:00
mark_story
cc750d15f1 Adding test to disprove #385. Proves saveAll with validate => first behaves correctly. 2009-12-04 14:39:12 -05:00
mark_story
be64f26f9f Updating doc blocks for model::validates. 2009-12-03 00:53:31 -05:00
mark_story
6046528744 Moving XmlNode::__killParent() to a protected method so Xml can access it. Adding _killParent(true) call to Xml::__destruct. Forces destruction of circular references held in child objects when an xml object is garbage collected. Fixes #369 2009-12-01 10:01:36 -05:00
mark_story
cd46f4db2e Fixing function signature of ThemeView constructor. Fixes issues where ThemeView would always be registered causing issues with EmailComponent and themed views. Fixes #370 2009-11-30 09:19:25 -05:00
mark_story
fccfe14e8d Expanding doc block for ClassRegistry. 2009-11-30 09:18:24 -05:00
mark_story
26aa3731e0 Fixing _name_ elements being inserted into serialized xml from Xml lib. Test case added. Fixes #367 2009-11-27 14:27:32 -05:00
ADmad
ad20e43730 Removing unneeded code for minor optimization
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-26 09:54:25 -05:00
mark_story
64dffb7663 Moving shared method from DboMysqli and DboMysql up to DboMysqlBase. Fixes #358 2009-11-24 22:49:40 -05:00
dogmatic
51d0805ce0 fixes Text::toList to allow passing array( 1=>"abc", 2=>"abc" ) and the updated test case
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-24 20:23:23 -05:00
mark_story
d758dbc343 Updating cake.generic.css to let .altrow class to apply to dd and dt elements. Fixes #361 2009-11-24 19:57:20 -05:00
mark_story
58446e0785 Adding documentation note about $options['q'] Refs #357 2009-11-24 11:57:56 -05:00
mark_story
72c0e2ca5a Applying minor optimization from 'robustsolution' to Router::connectNamed().
Fixes #312
2009-11-24 09:27:13 -05:00
mark_story
5aba143620 Applying optimization to Controller::postConditions from 'robustsolution' Fixes #287 2009-11-23 12:52:38 -05:00
mark_story
2e0acbf505 Making habtm join conditions used by __saveMulti when finding link records to remove. It should be noted that having conditions on non-joinTable tables, and not having a model on the joinTable can cause SQL issues. Fixes #304 2009-11-22 17:56:46 -05:00
mark_story
6c3bcdd7e6 Removing commented code. 2009-11-22 17:34:11 -05:00
robustsolution
b0aec35422 Dispatch::baseUrl() needs optimization a little bit
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-22 12:30:54 -05:00
Juan Basso
c6c7474502 Fix test of the size of lines in MagicDb (included test for it).
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-22 12:27:57 -05:00
mark_story
7e889d8495 Changing require_once to require for custom session handlers. If you are using a class to do your custom session handling you must include checks to prevent duplicate class errors. Fixes #324 2009-11-22 12:25:53 -05:00
mark_story
a30aec99fd Applying patch from 'robustsolution' for optimization in Dispatcher::dispatch. Fixes #317 2009-11-21 21:00:15 -05:00
mark_story
a96c157d94 Applying optimizations to use of count() from 'jrbasso' 2009-11-21 15:14:21 -05:00
Juan Basso
71df8dbbba Replace function sizeof (alias) by count.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-21 13:50:57 -05:00
Juan Basso
52fcabc96a Little optimization in redirect of controller.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-21 13:47:42 -05:00
Juan Basso
1cef0ac981 Little optimization in postConditions of controller.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-21 13:46:49 -05:00
Juan Basso
1c0c1bc9c7 Replace function split by explode when possible.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-21 13:45:04 -05:00
Juan Basso
911a99bf23 Replace function preg_split by explode when possible.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-21 13:43:52 -05:00
Juan Basso
df9e1e0bd1 Replace function join (alias) by implode.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-21 13:43:11 -05:00
Juan Basso
1acc60b04c Replace function die (alias) by exit.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-21 13:38:11 -05:00
Juan Basso
9b6b258fed Replace function is_integer (alias) by is_int.
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-21 13:36:10 -05:00
renan.saddam
4a8808eb21 Removing the argument passed to mssql_get_last_message(), it does not accept any argument. 2009-11-19 16:35:29 -02:00
mark_story
9eb1950646 Removing duplicate condition check. Fixes #314 2009-11-16 20:10:08 -05:00
mark_story
63ab96d751 Setting $primary = false inside DboSource::queryAssociation. Fixed #208 2009-11-15 17:48:41 -05:00
mark_story
ea6e3dd076 Fixing issue with bake model <name> 2009-11-15 16:47:58 -05:00
mark_story
6039d6ebe4 Applying optimization in Dispatcher::parseParams() from 'robustsolution'. Fixes #309 2009-11-15 15:32:58 -05:00
mark_story
17e377de7e Updating doc block for MemcacheEngine 2009-11-14 19:40:30 -05:00
ADmad
862ff82ad4 Updating Configure::store to fix escaping issues
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-14 19:38:53 -05:00
mark_story
06d4e5e553 Reformatting code in memcache.
Adding unset() to test case to remove unnecessary keys that can cause test failure.
2009-11-14 18:50:23 -05:00
mark_story
8b1a2b1f72 Applying optimization in Router::__parseExtension from 'robustsolution'. Fixes #301 2009-11-14 16:29:33 -05:00
mark_story
9376826aa4 Fixing HttpSocket::buildUri when host key is empty.
Tests added
Fixes #271
2009-11-13 14:42:40 -05:00
mark_story
8d407ac915 Adding test to form helper to increase code coverage. 2009-11-13 09:45:25 -05:00
mark_story
d302ed1bfa Fixing comment block formatting. 2009-11-13 09:44:51 -05:00
ceeram
a67a97722a refs #291
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-13 09:25:47 -05:00
ceeram
ea482442ff test to prove ticket #291
Signed-off-by: Mark Story <mark@mark-story.com>
2009-11-13 09:22:05 -05:00
nate
1c8a2f232b Changes Model::find() to allow modification of DataSource connection during callbacks. 2009-11-12 14:48:03 -05:00
mark_story
38f578199d Changing new Model() for ClassRegistry::init(). Fixes issues when baking admin and non-admin methods for a controller that uses bound translations + TranslateBehavior. Fixes #245 2009-11-12 09:32:45 -05:00
mark_story
a7a6dc8c43 Fixing issue where SecurityComponent::_validatePost could generate notices if elements were removed from _Token array.
Tests Added
Fixed #228
2009-11-08 14:12:18 -05:00
mark_story
82a2b1a019 Changing import of Dispatcher to direct require.
Modifying order of operations in Configure::__loadBootstrap()
moving inclusion of app/config/bootstrap.php after the creation of core cache configs.  This allows App::import() to be used in the bootstrap file with cached paths.
2009-11-07 17:53:14 -05:00
mark_story
6db91b0f49 Fixing issues in ContainableBehavior that could leave models unbound when 'fields' was used as part of containment conditions. Fixes #253 2009-11-07 17:43:18 -05:00
ceeram
dd0c4a64c5 Test to prove ticket #253 2009-11-07 11:02:43 -05:00
mark_story
30dc0cfe56 Removing unused $view property from CacheHelper.
Fixes #272
2009-11-07 10:44:14 -05:00
mark_story
4bbfcbff7e Fixing limit:0 and controller::paginate. Removes possibilty to generate sql errors by inputting invalid limit options. Tests updated. Refs #264 2009-11-06 00:44:21 -05:00
Ernst Mayerhofer
0327f15395 paginator works with limit 0 now too 2009-11-05 23:44:02 -05:00
mark_story
b4f6dd9c6e Adding tests and support for binary columns in model task. Fixes #241 2009-11-04 22:57:43 -05:00
mark_story
e609875754 Updating Model::invalidFields, so returning false from beforeValidate() will abort both the validation and saving() of the record.
Tests added to check beforeSave, beforeValidate, and beforeDelete return values.
Fixes #257
2009-11-04 12:36:17 -05:00
mark_story
8c46cc49fb Fixing issue in Dispatcher::cached() where plugins ending in asset extensions would be incorrectly handled.
Test added
Fixes #237
2009-11-03 13:14:38 -05:00
mark_story
74edb052f3 Merge branch '1.2' of dev@code.cakephp.org:cakephp into 1.2 2009-11-03 09:58:58 -05:00
mark_story
d63218c0a0 Fixing error in previous commit. 2009-11-03 09:52:59 -05:00
mark_story
133299c653 Removing duplicate constructor from ShellDispatcher.
Fixes warnings under PHP5.3.
Fixes #132
2009-11-03 09:02:17 -05:00
mark_story
6b043c6c57 Updating doc blocks for paginator helper. 2009-11-02 21:37:20 -05:00
mark_story
9d2628f699 Removing tab 2009-11-02 00:07:16 -05:00
mark_story
a87d31cc7f Fixing $cacheAction requiring the inclusion of the controller name for view cache files to be generated. This behavior makes the cache helper behave as documented.
Test cases added.  Fixes #232
2009-11-02 00:07:02 -05:00
mark_story
873760aae4 Merge branch '1.2' of dev@code.cakephp.org:cakephp into 1.2 2009-10-31 15:05:51 -04:00
mark_story
51244907d1 Updating merge vars test to skip itself if run in a group context.
Updating controller group.
2009-10-31 14:55:04 -04:00
mark_story
6b616b7171 Adding skip for validation test, for DNS servers that reply for non-existant domains. 2009-10-31 14:48:37 -04:00
mark_story
76019513e1 Updating lib group to run non-mvc libs.
Removing no_database group.  It was redundant.
2009-10-31 14:33:53 -04:00
mark_story
24a75a27bf Updating Javacsript helper to use a real skipIf 2009-10-31 14:25:52 -04:00
mark_story
0637272bd2 Updating doc block on Controller to include more information about $uses. 2009-10-31 14:25:33 -04:00
mark_story
59566d4587 Updating component test case to no fail in group test.
Updating controller group to only run controller classes.
2009-10-31 14:08:56 -04:00
mark_story
a91970b7b2 Fixing security component test failures when run as part of a group. 2009-10-31 13:41:16 -04:00
renan.saddam
84a10904fb Fixing typo on variable name. 2009-10-30 18:42:04 -02:00
Gordon Pettey
2e3bbe363d Array coding convention and extraneous punctuation
Signed-off-by: Mark Story <mark@mark-story.com>
2009-10-30 16:38:27 -04:00
mark_story
17edec8460 Changin how HttpSocket parses query string parameters. Makes HttpSocket querystring parameter parsing more congruent with how PHP handles query string parameters in that it doesn't require urlencoded characters.
Tests added.
Fixes #156
2009-10-29 20:14:36 -04:00
mark_story
a31a2d264c Fixing Debugger::log() . The method used protected properties only available in test cases. No stack trace was being logged when called either. Method has been updated to match its doc block better.
Fixes #222
2009-10-29 19:47:29 -04:00
mark_story
ad305a890a Applying optimization from 'ermayer' Reduces functions called from Folder::addPathElement() Fixes #178 2009-10-27 21:06:58 -04:00
mark_story
23ab84596a Adding discrete tests to Folder::addPathElement 2009-10-27 21:04:14 -04:00
mark_story
00d7c655ce Improving documentation for PaginatorHelper::sort() Fixes #210 2009-10-27 13:28:43 -04:00
mark_story
5a093e5627 Fixing issues in postgres with time columns and '' values.
Tests added.
Fixes #213
2009-10-27 13:22:34 -04:00
mark_story
79fdd8b341 Adding test to ensure blob integrity. Disproves #199 2009-10-24 12:53:22 -04:00
mark_story
72830cb125 Adding test case for model task
Fixing missing case for float datatypes when generating fixtures.
Fixes #204
2009-10-24 11:26:06 -04:00
mark_story
14bd47842c Removing length() from DboMysqli, fixes incorrect float length parsing.
Test case added.
2009-10-24 11:06:27 -04:00
mark_story
c6999aea7f Moving DboMysqli::describe() and DboMysql::describe() into DboMysqlBase. Removes duplicated method code. 2009-10-24 10:46:28 -04:00
mark_story
d25497c527 Adding Skip to mb_strrpos test case. Skips the test if mbstring is installed and php version is 5.1.x. mb_strrpos had an incompatible function signature in these versions. 2009-10-22 13:51:55 -04:00
mark_story
61c1c47c93 Merge branch '1.2' of dev@code.cakephp.org:cakephp into 1.2 2009-10-22 09:34:45 -04:00
ceeram
3dbae37aad fixing failing i18n testcase, caused by setting $category parameter for __c(), __dc() and __dcn() as LC_MONETARY instead of numeric value 2009-10-22 09:33:48 -04:00
renan.saddam
4e8c268536 Making the test more clear by avoind +-2 days thing. Fixes #186. 2009-10-21 19:19:21 -02:00
mark_story
1ee9771efb Removing ife() from AclShell. Refs #6562 2009-10-21 13:12:03 -04:00
mark_story
0657afcf30 Removing use of low() from core classes. Refs #6525 2009-10-21 13:03:24 -04:00
mark_story
8b419d2dd8 Removing use of ife() from core classes. 2009-10-21 12:57:15 -04:00
mark_story
0cc1d84737 Removing use of e() from core and test suite. 2009-10-21 12:57:03 -04:00
mark_story
0e23fdfbb3 Fixing infinitely nesting stack frames when TreeBehavior::reorder() is called and the models $cacheQueries = true and there are a sizable number of records being manipulated.
Test cases added.
Fixes #188
2009-10-21 00:22:36 -04:00
mark_story
c6f783ebfe Fixing issues with CakeTestCase test case and debug = 3. Fixes #189 2009-10-20 22:19:32 -04:00