Commit graph

223 commits

Author SHA1 Message Date
gwoo
643651fe56 Merge master in 1.3 2009-03-19 14:10:13 -07:00
gwoo
6cb8b3d286 Merge branch 'master' into 1.3.x.x 2009-03-14 13:57:18 -07:00
mark_story
d9cbb85488 Adding test case for RequestHandler::beforeRedirect() when request is an ajax request. Ensures that requestAction() is properly triggered.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8068 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-01 06:11:03 +00:00
gwoo
b8d21c6c2c closes #6142, shows Auth works as expected with camelCased actions
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8065 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-27 16:17:58 +00:00
mark_story
af021cb4b2 Adding Html entity conversion to all urls generated by helpers, fixing potential for merged passedArgs to create xss vectors.
Adding integer cast in paginate() to page param. 
Tests added/updated.
Fixes #6134

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8061 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-25 19:51:41 +00:00
mark_story
b1d05222b8 Adding tests to show filtering of page param when using Controller::paginate(). Refs #6134
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8054 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-24 01:59:58 +00:00
gwoo
43ad3d76e5 updating code from [8024] [8025]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8031 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-15 20:13:14 +00:00
gwoo
712fea65ab updating code from [8024]
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8025 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-13 01:11:00 +00:00
mark_story
e045e6826a Fixing Session from being added to components array twice.
Fixing greedy mergeVars with AppController.
Tests Added
Fixes #6091

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8024 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-12 13:36:20 +00:00
gwoo
f0d03a91cf Merge branch 'master' into 1.3.x.x 2009-02-09 12:01:06 -08:00
gwoo
f7dd0800d1 fixes #6062, AuthComponent and Controller::scaffold
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8018 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-06 23:23:12 +00:00
mark_story
ddc047751c Adding submitted test cases from harking Closes #6047
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8013 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-02-02 02:58:15 +00:00
the_undefined
27065d7aab Fixed bug in AuthComponent that allowed uppercase actions to pass checks
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8011 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-26 18:50:09 +00:00
mark_story
af49aec444 Adding session->delete() to remove bleed through in tests.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8009 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-21 22:52:44 +00:00
mark_story
65a047542e Adding test case to disprove regression in Auth component. Closes #5961
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8008 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-21 22:34:46 +00:00
nate
c7d133fc0f Removing variable name inflection from Controller::set() 2009-01-20 14:36:39 -05:00
mark_story
ba42eb05c1 Fixing broken tests refs #5687
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7986 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 20:37:31 +00:00
gwoo
e496fc9434 updating auth component and test with additional checks for missing data
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7979 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 05:21:26 +00:00
mark_story
6c258c0f93 Fixing Auth's handling of params when loginAction is an array. Tests updated. Fixes #5961
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7972 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-06 03:20:11 +00:00
gwoo
0751251181 updating email tests to match previous change.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7970 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-02 22:50:28 +00:00
gwoo
4f0256f9cd fixes #5904, changing email component to use initialize instead of startup, so it can be used in other components more easily
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7969 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-02 22:47:38 +00:00
nate
b2b46c3fa4 Implementing $safe mode for RequestHandlerComponent::getClientIP(), which ignores HTTP_X_FORWARDED_FOR, fixes #5842
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7957 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:02:36 +00:00
nate
61850b1be1 Cleaning up test code formatting, adding fix for POST hash validation of checkbox lists, fixes #5903, test cases added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7951 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-23 08:13:00 +00:00
mark_story
a12fd86c54 Applied patch from 'jperras' fixes error in Auth.test.php. Fixes #5899
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7943 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-18 21:04:05 +00:00
nate
2c64c449bc Correcting Flash detection in RequestHandler, adding tests. Fixes #5838.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7914 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-10 13:55:58 +00:00
mariano.iglesias
f9557c7611 Fixing issue where radio elements would produce wrong hash when Security component enabled in FormHelper, fixes #5791
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7891 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 16:32:54 +00:00
AD7six
b43128c809 Ensuring that the auth component never redirects to an external link.
Tests updated to match code changes and tests added for external referer examples


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7874 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-14 09:07:22 +00:00
TommyO
5f0858e1ad Fixed errors in usage of SimpleTest for EmailComponent tests.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7865 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-11 19:52:41 +00:00
mariano.iglesias
dde4906195 Adding patch by dardosordi. Making all calls to header in SecurityComponent go through Controller. Fixing issue where invalid basic auth credentials would not trigger another login request. Added tests, fixes #5732
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7858 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-10 17:18:00 +00:00
renan.saddam
111b886570 Removed trailing whitespaces from tests.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7848 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 02:58:37 +00:00
AD7six
3f2fa6929b changing tabs for spaces in comment block indentation
Removing address and replacing with cakefoundation url


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7805 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 17:30:26 +00:00
nate
318c2b4952 Correcting SecurityComponent form hash generation when handling arrays, fixes #5588. Fixing code formatting in FormHelper test.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7794 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-29 06:55:42 +00:00
AD7six
ce0a71aef7 fixes #5603 Duplicate first parameter from the paginator with existing url args
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7777 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 22:20:03 +00:00
nate
16e2579f01 Correcting Security component to treat POST data arrays as a single field for validation purposes, fixes #5588
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7774 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 03:18:08 +00:00
renan.saddam
24949e30e0 Added tests to PagesController and removed twice call to count().
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7756 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-16 23:52:54 +00:00
phpnut
4311ba8000 Close #5534, Rename pages_controller.php to pages_controller.test.php
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7755 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-16 06:51:10 +00:00
nate
19975a2cf6 Fixing issue where startup() / shutdown() etc. were being called on components not directly attached to the controller. Only initialize() should be called on sub-components.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7745 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-15 13:07:46 +00:00
nate
1b9357f5e8 Correcting behavior of layering allow/deny calls in AuthComponent, fixes #5595, formatting fixes for RequestHandler
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7743 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-15 02:52:19 +00:00
gwoo
62d1f367db adding test cases to show #5553 is invalid, $uses is not merged when == null.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7718 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-09 17:03:44 +00:00
mark_story
136f9c4b6d Removing getAco(), getAro(), setAco(), and getAco() from AclComponent. These methods were deprecated and not removed. Refs #5561
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7716 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-09 03:35:17 +00:00
mark_story
17e2b4c054 Applying patch from 'Pixelation' fixes cross platform issues in cookie test. Closes #5559
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7715 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-09 02:35:33 +00:00
nate
300dbc5e91 Correcting how parameters and default values are merged in Controller::paginate(), fixes #5503
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7688 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-02 00:46:26 +00:00
mark_story
915a1e119d Adding test to Auth.test to cover logged in user being denied on an action when there is no HTTP_REFERER set. Refs #5507.
Fixed tests that break when Routing.admin is not set.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7687 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-02 00:18:47 +00:00
TommyO
3da0451907 Added basic mb_encode_mimeheader() to Multibyte class.
Modified EmailComponent to take advantage of multibyte support. fixes #5448
Modified EmailComponent to fix newline issues in long subject lines when using mail send method. fixes #5049

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7685 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-01 18:36:38 +00:00
nate
4b8acf4647 Adding 'type' key to both sets of query calls in Controller::paginate(), fixes #5441
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7680 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-29 21:19:37 +00:00
mark_story
b6f9e1e537 Correcting scaffold view file implementation. Was incorrectly using separate add and edit templates. Changes bring scaffold templates more inline with bake templates.
Tests added to cover use with both primary app and plugins. Refs #4862 and closes #5484 

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7671 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-27 03:48:23 +00:00
renan.saddam
a628dfa028 Added test to prove #5482 (Trying to get property of non-object).
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7665 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-26 01:37:17 +00:00
nate
eb7fb6d7e3 Re-implementing form hashing security to using string-based keying. Fixes #5262, fixes #5300
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7658 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-24 23:02:14 +00:00
mark_story
fafb01b09d Fixing modelClass when using plugin models.
Added TestPluginPost to test_app/test_plugin
Test case added.
Closes #5459

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7641 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-22 04:10:49 +00:00
nate
fc5b128d68 Refactoring Auth test, adding coverage, and enabling custom Ajax layouts (as specified by RequestHandler), fixes #5446
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7637 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-20 20:18:16 +00:00