mark_story
5ce66d3031
Changing how PaginatorComponent::paginate()'s $whitelist param works. It now serves as the whitelist for fields ordering can be done on. It previously allowed you to whitelist things you passed into paginate(), which was kind of useless.
...
Updated tests.
Fixes #430
2010-12-26 21:30:43 -05:00
mark_story
6f1eca79ac
Fixing calltime pass by reference deprecation warnings.
2010-12-26 20:11:17 -05:00
mark_story
f62a067d7c
Making it possible for behaviors to define paginate and paginateCount. Updated test to ensure the component calls the correct methods.
...
Fixes #1373
2010-12-26 17:40:34 -05:00
mark_story
fd3b4b2cd5
Adding Model::hasMethod() and tests.
2010-12-26 17:35:22 -05:00
mark_story
3022e2d785
Adding documentation.
2010-12-26 17:21:49 -05:00
mark_story
ad5a1ca6b7
Making __methods and __mappedMethods protected instead of private.
2010-12-26 17:10:16 -05:00
mark_story
0c4b665ad0
Adding ability for BehaviorCollection::hasMethod() to return the callback.
...
Re-factored BehaviorCollection::dispatchMethod to be simpler and faster.
Changing now BehaviorCollection stores callbacks so they look like normal php callback arrays.
2010-12-26 17:09:20 -05:00
mark_story
769da1a7c8
Adding basic BehaviorCollection::hasMethod implementation. Tests added.
2010-12-26 16:44:50 -05:00
mark_story
edf567b9f9
Adding convertKeys to PaginatorHelper::options().
...
Added a test case.
Fixes #1390
2010-12-26 13:24:05 -05:00
mark_story
56415f20cb
Fixing issue where CakeLog would log suppressed errors even when error reporting was disabled. Fixes #1403
2010-12-26 13:02:43 -05:00
mark_story
83d12ce690
Removing deprecated $this->params in Helpers, it got missed somehow.
...
Removing PaginatorHelper::$convertKeys. Its just a regular option now.
Added some documentation.
2010-12-26 13:01:20 -05:00
mark_story
ee3017599d
Merge branch '2.0' into 2.0-pagination
...
Conflicts:
cake/libs/controller/components/paginator.php
cake/libs/router.php
2010-12-24 14:43:11 -05:00
mark_story
4009b6b2c7
Fixing more @package tags, and removing duplicate tags in classes.
2010-12-24 14:33:41 -05:00
mark_story
d8589323a9
Missed a package tag.
2010-12-24 14:22:40 -05:00
mark_story
ef77e60cb0
Removing @subpackage tags, moving contents of @subpackage into @package.
...
Removing duplicate cake.cake in @package tags.
Renaming cake.app -> app
2010-12-24 14:09:57 -05:00
Juan Basso
ff18fe4e3e
Optimization in postLink and create methods from FormHelper.
2010-12-24 16:52:15 -02:00
mark_story
3fc8a1f8c1
Removing whitespace.
2010-12-24 12:54:18 -05:00
mark_story
e20ea8ad72
Renaming Dispatcher::__loadRoutes -> Dispatcher::_loadRoutes to match naming conventions.
...
Updating method name usage, as assertType is deprecated as of PHPUnit 3.5.6
2010-12-24 12:54:04 -05:00
mark_story
8eaba29c3f
Fixing an entirely wrong condition that prevented routes from being loaded.
2010-12-22 23:19:04 -05:00
mark_story
a37b3a1598
Adding more documentation to DboSource.
2010-12-22 22:33:17 -05:00
mark_story
98c356a9c5
Adding some more documentation to ModelBehavior as well as basic usage.
2010-12-22 22:27:47 -05:00
mark_story
aff5cd7e15
Adding a doc block and code sample for MediaView.
2010-12-22 22:04:02 -05:00
mark_story
3c6fc55eed
Removing strlower() calls as they are not needed in php5 land.
2010-12-21 23:45:47 -05:00
mark_story
af2a5123b5
Fixing issue where prefixes would not be correctly loaded for a request.
2010-12-21 23:14:17 -05:00
mark_story
afbc73a3b5
More documentation.
2010-12-21 22:36:37 -05:00
mark_story
d5589d26bd
more doc blocks.
2010-12-21 22:27:17 -05:00
mark_story
4312a26b2f
Removing View::$autoRender it wasn't used.
...
Removing @access tags, which just restated the visibility keywords.
Adding documentation to a number of parameters and methods.
2010-12-21 21:59:25 -05:00
mark_story
f85567a566
Removing @author tags that snuck in.
2010-12-21 21:58:20 -05:00
mark_story
04929ae1df
Applying patch from 'Thorsten Buss'.
...
Fixes issues in DboSource, where mismatching types on join columns could result in incorrect query generation.
Fixes #708
2010-12-21 20:40:19 -05:00
mark_story
6f62c22cbc
Fixing fencepost errors.
...
Splitting tests up into smaller groups.
2010-12-20 20:27:27 -05:00
mark_story
0b90195a52
Adding tests for creating next/prev links with querystrings.
...
Removing code that doesn't seem to do anything, no tests fail when its removed.
2010-12-20 13:59:09 -05:00
mark_story
e5588f746c
Reversing changes that required a : sigil for named parameters. Also removing ?foo style parameters for querystring args. Having two ways to create querystring args was not sitting well with me.
...
Tests updated.
2010-12-19 23:11:02 -05:00
mark_story
b49b49a5ef
Removing named parameter sigils.
2010-12-19 22:17:57 -05:00
mark_story
d3fc29c8e8
Adding more documentation to connectNamed().
...
Changing argSeparator -> separator, as it is less typing and easier to remember.
2010-12-19 21:49:17 -05:00
mark_story
025ba23886
Removing whitespace and adding some more documentation.
2010-12-19 20:05:57 -05:00
mark_story
4c3736a68a
Making more tests pass with the named parameter changes.
2010-12-19 17:38:21 -05:00
mark_story
5df2678ba9
Fixing named params that were missing the : and fixing Router::reverse() so it adds in the :
2010-12-19 17:09:34 -05:00
mark_story
c83a4703a3
Implementing ability to change pagination params to use querystring variables.
...
Tests added.
2010-12-19 16:47:22 -05:00
mark_story
cc2d8e2fec
Moving limit from the options to the normal paging params. This fixes a few notice errors.
2010-12-19 13:15:04 -05:00
mark_story
8c3ceff50d
Making paging.options only contain options that are not in the defaults. This replaces the many diffs that were calculated on each url generation between paging.options and paging.defaults.
2010-12-19 12:58:07 -05:00
mark_story
833bdbcc0b
Reformatting paging params.
...
Removing defaults from the paging params as they are no longer being used.
2010-12-19 12:43:29 -05:00
mark_story
ef84d86cf5
Reformatting code, and removing merging of defaults key in the helper. It no longer exists.
2010-12-19 12:26:28 -05:00
mark_story
f54479e566
Adding some docblock info about pagination.
2010-12-19 12:20:12 -05:00
mark_story
e9d3fcf5cf
Moving limit checking into a separate method, and adding tests.
...
Removing $scope from being passed down to the options, it previously only allowed additional conditions to be set.
Updated tests.
2010-12-19 11:58:35 -05:00
mark_story
1e741de84b
Removing show alias, it was undocumented and untested.
2010-12-19 02:14:37 -05:00
mark_story
108a6611a8
Moving validation of sorting to a separate method. This makes it easier to test, extends and read.
...
Tests added.
2010-12-19 02:12:39 -05:00
mark_story
7b11eeb6e0
Updating tests to not use the deprecated Controller::$passedArgs.
...
Removing messy and hard to understand defaults + whitelisting from paginate() now that it has a separate method.
2010-12-19 01:57:51 -05:00
mark_story
6b3db0a3eb
Pulling out parameter merging logic into a method, this allows specific typing of parameter merging (named, querystring, route). Also simplifies whitelisting of request parameters.
...
Tests added for merging and whitelisting.
2010-12-19 01:42:23 -05:00
mark_story
7585b2941e
Adding paramType to the test cases.
2010-12-19 00:38:20 -05:00
mark_story
54c52d85fb
Fixing failing tests in PaginatorComponent.
2010-12-18 17:29:47 -05:00
