Commit graph

8583 commits

Author SHA1 Message Date
mark_story
3216c902cd Removing the enable parameter on HelperCollection, BehaviorCollection, and ComponentCollection. They all now support the enabled option that Behaviors have historically supported. This provides a simpler API with fewer arguments, and allows callbacks to be disabled on objects in their declared arrays.
Test cases updated.
2010-11-07 13:23:45 -05:00
mark_story
22497eb41c Fixing failing tests in controller test. 2010-11-07 13:23:45 -05:00
mark_story
88c717dbd8 Removing the 3rd param from ObjectCollection::load() and adding a uniform setting of 'callbacks'. This setting is used to disable callbacks on objects by convention. Test cases updated. 2010-11-07 13:23:45 -05:00
mark_story
1ba28c246b Adding settings['callbacks'] as a way to define enabled/disabled state of helpers in settings arrays. This should replace the separate parameter.
Tests updated.
2010-11-07 13:23:45 -05:00
mark_story
92fec4588a Making private things protected. 2010-11-07 13:23:45 -05:00
mark_story
4c0fd76a2e Changing <cake:nocache></cake:nocache> into <!--nocache--><!--/nocache--> This makes no cache tags valid html/xml at all times, and will not interfere with validation. 2010-11-07 13:23:45 -05:00
mark_story
4739d7f955 Adding tests for CacheHelper callback methods. 2010-11-07 13:23:45 -05:00
mark_story
f7f9c3f6a2 Removing a test case that doesn't need to exist anymore as the conditions for cache generation are now in CacheHelper. 2010-11-07 13:23:44 -05:00
mark_story
c92ecdcd1b Initial pass at decoupling CacheHelper from View.
CacheHelper does all caching using helper callbacks now.
2010-11-07 13:23:43 -05:00
mark_story
1bc6433ecd Removing duplicate import() and fixing missing dependency. 2010-11-07 13:23:43 -05:00
mark_story
23c69b2bfb Adding an import, as I hit an error when trying to bake tests for models. 2010-11-07 13:23:43 -05:00
mark_story
aaff059132 Moving output into a property, and removing extra arguments from helpers. Having a view property reduces the number of strings that are copied around. 2010-11-07 13:23:43 -05:00
mark_story
2dff74d037 Removing local and using output property. 2010-11-07 13:23:43 -05:00
mark_story
2e140a9fd3 Adding tests for element callbacks. 2010-11-07 13:23:43 -05:00
mark_story
32587c154c Adding callback support to elements. You can use the 3rd parameter to control whether or not before/afterRender callbacks should be fired for a particular element. 2010-11-07 13:23:43 -05:00
mark_story
1b19ad48b4 Adding parameters to helper callbacks, these allow helpers to introspect more on the view/layout being rendered.
Updating tests.
2010-11-07 13:23:42 -05:00
mark_story
882efa883e Removing the trigger_error and view re-renders and replacing them with exceptions. 2010-11-07 13:23:42 -05:00
mark_story
76919902b9 Removing direct tests of protected method.
Refactoring View with the intention of eventually removing coupling with CacheHelper.
Making Helpers load after the first rendering method is called.
Moving callbacks out of _render() to make logic simpler, and with the idea that elements will get a callback too.
2010-11-07 13:23:42 -05:00
mark_story
540f1426be Removing View::error(). Instead you should be handling error states in your controller, or throwing exceptions and letting the application error handling deal with the error. 2010-11-07 13:23:42 -05:00
mark_story
3f61fa004e Removing dead import. 2010-11-07 13:23:42 -05:00
Mark Story
8f31ef7149 Making $scripts_for_layout and $content_for_layout regular viewVars. This will allow helpers to manipulate them in callbacks.
Made $___dataForView an optional parameter, it defaults to $this->viewVars if left undefined. Refs #624
2010-11-07 13:23:42 -05:00
Mark Story
157bdfafc6 Moving beforeLayout, before additional viewVars are processed. Refs #624 2010-11-07 13:23:42 -05:00
mark_story
09d3a0626a Updating l10n to use the new CakeRequest method. 2010-11-07 01:38:25 -04:00
mark_story
22bb07abb0 Adding visibility to a few methods. 2010-11-07 01:36:37 -04:00
mark_story
1424e02488 Adding a method to CakeRequest to parse out the accept-language header. This will help remove features from l10n. 2010-11-07 01:35:36 -04:00
mark_story
af303f01c7 Fixing baked actions to use request object.
Fixes #1091
2010-11-07 01:08:58 -04:00
José Lorenzo Rodríguez
1c37751038 Adding missign option to testsuite shell 2010-11-03 19:41:17 -04:30
José Lorenzo Rodríguez
224f65af05 Preventing bug in testsuite shell 2010-11-03 18:56:06 -04:30
José Lorenzo Rodríguez
557c5274e8 Making file argument optional in console testsuite in order to show complete list of test cases for a category 2010-11-03 01:27:37 -04:30
José Lorenzo Rodríguez
9afd4d7875 Fixing option parsing and help for testsuite after new console libraries merge 2010-11-03 01:25:27 -04:30
mark_story
bff711e2dc Merge branch '2.0-console' into 2.0
Conflicts:
	cake/console/shells/acl.php
	cake/tests/cases/console/libs/tasks/plugin.test.php
2010-11-02 23:49:19 -04:00
Juan Basso
b0a600f925 Merge branch '2.0-post-method' into 2.0 2010-11-03 01:42:06 -02:00
Juan Basso
adb2d90b9a Changed the regex to follow the RFC 3986, working to protocols like "svn+ssh://" and "ed2k://" 2010-11-03 01:26:41 -02:00
mark_story
c9ca3c3785 Fixing path constants in DbConfig and FixtureTask to be more consistent between web and cli. 2010-11-02 23:25:36 -04:00
Juan Basso
b752766d6c Using full base when $url is empty. 2010-11-03 01:16:38 -02:00
mark_story
6d54202c4c Adding another group test case file for all the console tests at once. 2010-11-02 23:15:33 -04:00
Mark Story
94f9f7afeb Fixing failing tests from merge with 1.3. Most tests were failing due to internal changes and PHPUnit being more specific than SimpleTest. 2010-10-31 22:42:16 -04:00
Mark Story
a3da915abd Fixing issue where value in difference array was always the string value instead of the original value. 2010-10-31 22:41:33 -04:00
Mark Story
c2063f1229 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-10-31 21:58:38 -04:00
Mark Story
b67d3fac44 Updating FormHelper to fix failing test from merge. 2010-10-31 21:57:51 -04:00
Mark Story
08e7bcb7ab Merge branch '1.3' into integration
Conflicts:
	app/config/core.php
	cake/console/libs/acl.php
	cake/console/templates/skel/config/core.php
	cake/console/templates/skel/webroot/test.php
	cake/dispatcher.php
	cake/libs/view/errors/missing_action.ctp
	cake/libs/view/helpers/form.php
	cake/tests/cases/libs/cache/memcache.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/log/file_log.test.php
	cake/tests/cases/libs/model/cake_schema.test.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helpers/ajax.test.php
	cake/tests/groups/bake.group.php
	cake/tests/groups/behaviors.group.php
	cake/tests/groups/i18n.group.php
	cake/tests/groups/javascript.group.php
	cake/tests/lib/reporter/cake_cli_reporter.php
2010-10-31 21:56:59 -04:00
Juan Basso
7f448a1d35 Allowed the use of empty() and isset() in Controllers aliases properties. 2010-10-31 22:02:26 -02:00
Mark Story
b86bec14b5 Removing dead code in EmailComponent.
Fixes #1248
2010-10-31 00:00:54 -04:00
Juan Basso
e380b76e16 Created an exception to error 405 (Method Not Allowed) and changed the delete action in bake to use it. 2010-10-30 23:13:54 -02:00
Juan Basso
4eed660a62 Changed the form style to not affect layout. 2010-10-30 22:39:31 -02:00
Juan Basso
a040c9a218 Changed the cake bake to use postLink for delete actions. 2010-10-30 21:58:42 -02:00
Mark Story
d5f582beee Merge branch 'master' of http://github.com/kwiky/cakephp into kwicky 2010-10-30 00:29:21 -04:00
Mark Story
e9851a644b Merge branch 'form-selected' into 2.0 2010-10-30 00:08:21 -04:00
Mark Story
3b5dafadc5 Adding value option documentation. 2010-10-29 23:56:22 -04:00
Robert Sworder
593c45b6e7 Whitespace changes 2010-10-29 23:43:50 -04:00