Commit graph

151 commits

Author SHA1 Message Date
mark_story
b2d74c8be1 Added tests to cover model validation setting errors, controller render passing error and form helper field error display. Closes #5077.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7338 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-15 02:13:14 +00:00
mark_story
3da913f392 Updated String::insert() so that when using ? as parameter it offsets the length of the parameter. Added tests to model, and string. Closes #5035
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7307 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-03 02:19:19 +00:00
mark_story
c25ed9016a Fixed attributes being set for select elements in formHelper::dateTime() when $options[id] is specified. Closes #5013.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7306 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-03 00:46:42 +00:00
gwoo
c004dd68a5 removing empty lines from the end of test cases
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7295 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 08:17:02 +00:00
gwoo
67f55ba53e fixes #3869, required css for validation fields
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7242 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-23 00:07:33 +00:00
gwoo
4759a4506b better fix for #3869
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7240 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-22 19:31:44 +00:00
gwoo
d29883993e fixes #3869, form 'required' CSS when not actually required
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7239 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-22 19:16:34 +00:00
nate
df75a06756 Fixing coding standards violations in core, and adding misc tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7222 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-20 20:17:23 +00:00
gwoo
9d950c7698 closes #4726, test cases added to show special characters in select options
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7189 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-14 21:48:57 +00:00
gwoo
8707c6861a fixes #4912, correct label "for" in time input
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7188 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-14 21:40:01 +00:00
mark_story
8c32547351 Adding test to formHelper. Testing checkbox in response to #4869
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7146 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-09 12:34:30 +00:00
AD7six
a978fb2661 adding Doc blocks to everything in tests folder missed in the first pass.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7126 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-05 15:20:45 +00:00
gwoo
298ede514c removing debug statement from form.test
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7115 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-04 17:07:40 +00:00
gwoo
071af32eb2 adding test cases showing usage of showParents in form helper, closes #4831
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7113 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-04 15:57:45 +00:00
AD7six
f44c755475 Adding doc blocks to everything in the tests dir
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7094 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-02 19:22:55 +00:00
joelmoss
d294e91d42 Fixing PHP error with $divOptions in FormHelper::input() when passing $option['div'] = false
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7066 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 16:05:53 +00:00
joelmoss
03322a31d7 FormHelper::submit() now accepts alternative wrapping tags, instead of a div.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7065 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 15:44:39 +00:00
joelmoss
4dfe7333b7 FormHelper::error() can now be passed the tag to wrap the error message in.
FormHelper::input() can now be passed the tag to wrap the input element in; same applies to the tag that wraps the error message.
Corrected date format in Form test testMonth().


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7064 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 15:07:32 +00:00
nate
42da5aba81 Moving Cake folder to correct location
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7063 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 11:40:08 +00:00
DarkAngelBGE
e6e0d852a2 deleting cake folder from svn
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7061 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 10:59:16 +00:00
mark_story
78e534b73b Refactored month() to take monthNames in the options array. Added options descriptions to several doc blocks. Tests updated.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7047 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-27 00:07:00 +00:00
mark_story
9da3e638df Applied Enhancement submitted by 'chjunior', month display can be set to numbers or translated text. Closes #4327. Tests also updated.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7039 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-24 04:00:26 +00:00
the_undefined
52bae8a7bf Made form helper pick up field definitions outside the current context
Made form helper handle maxlength for float fields properly, fixes #4724


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7021 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-23 05:14:57 +00:00
mark_story
f7438da72e Implemented patch from 'johnathansnook' closes #4496 Form::inputs now allows for fieldset classname to be set. Updated tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6991 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-21 03:57:35 +00:00
mark_story
f2eab6ef59 Implemented enhancements, closes #4059 and #4584
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6972 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 21:01:02 +00:00
mariano.iglesias
5459b92f02 Ensuring that a valid maxlength value is used for inputs, fixes #4691
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6965 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 12:17:37 +00:00
mariano.iglesias
697261e3da Finished refactoring of FormHelperTest so tag matching is done through assertTags
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6784 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-10 03:20:06 +00:00
the_undefined
de5f744a9c Changed close tag prefix from ! to / to be more HTMLish
Added support for simple open tags using <tag
Refactored FormHelper to use new syntax / features

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6771 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-08 13:14:47 +00:00
the_undefined
075afb244a Restored last missing FormHelper test
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6770 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-08 11:57:58 +00:00
the_undefined
0a715f2afe Refactored CakeTestCase::assertTags to tokenize the validation process and give useful debug information on demand
Refactored all FormHelper test cases to work for the new approach and make use of new features
Fixed a FormHelper::hour dateTime bug causing the hour 0 to be selected at 12pm

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6769 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-08 11:32:31 +00:00
mariano.iglesias
ce31e77574 Continuing refactor of FormHelperTest to use assertTags for tag testing
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6747 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-01 22:09:16 +00:00
mariano.iglesias
f7384bca87 Removing extra check for closing tag in assertTags().
Continuing with FormHelperTest refactoring.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6730 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-26 18:44:01 +00:00
mariano.iglesias
3180aecb95 Initial refactor of FormHelperTest to use assertTags for tag testing
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6729 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-26 15:09:41 +00:00
joelmoss
7f6e54ea3a Validation now supports error messages on multi record forms. Added tests to support this. Closes #4499. Thanks jose_zap
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6713 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-23 14:14:58 +00:00
the_undefined
aee33deb3a Implemented CakeTestCase::assertTags
Replaced some regex in Form helper test with it

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6710 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-22 19:53:00 +00:00
mariano.iglesias
953c778f5f Adding tests to FormHelper including generating custom names for checkbox elements, closes #4479
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6688 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-18 00:58:47 +00:00
tclineks
2262e5803c fixed removal of test model instance from registry
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6681 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-17 20:33:54 +00:00
tclineks
f99c8996e3 added test for FormHelper::create with non-standard primaryKey. disproves and closes #3942
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6680 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-17 20:31:49 +00:00
phpnut
1250c6e0cc "Adding patches and test from #4447.
Closes #4447, Multiselects' hidden input should not have an id attribute.
Thanks sarimarton"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6640 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-09 01:39:10 +00:00
phpnut
a138ae3d63 "Fixing use of array('minuteInterval' => #);
Proper usage is array('interval' => #); but for backwards compatibility this fix has been added"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6633 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-04 12:48:13 +00:00
phpnut
d14b50fc92 "References #4394, additional fixes to multi record forms.
Added additional test cases"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6629 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-03 06:48:56 +00:00
phpnut
f2941a660e "References #4239 Added test from ticket to showing ticket is invalid.
Fixes #4394, fails when the hasMany multi-record form contains hidden fields.
"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6627 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-03 02:29:17 +00:00
nate
bd929c45df Adding test case for validation error display with FormHelper::input(type => password), disproves #4242
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6548 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-10 03:54:15 +00:00
phpnut
5374807164 "Fixes #3846, Security blackhole when no radio selected
Fixes #3920, Multiple select w/ checkboxes issues warning when all are unselected
Fixes #3962, validation POST never pass when select multiple is submit
"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6546 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-10 00:25:59 +00:00
nate
98831d27fe Enabling mutli-record validation errors in FormHelper, fixes #4076
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6540 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-09 18:28:38 +00:00
nate
9a6029f03e Fixing fully-qualified form field references, fixes #4068
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6535 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-09 07:36:34 +00:00
the_undefined
8b8b268c08 Added test demonstrating useless error messages being thrown for table-less models
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6480 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-28 00:23:28 +00:00
gwoo
fb4244bb89 updating Helper::setEntity() and form.test
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6464 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-18 21:58:32 +00:00
nate
7f673226d7 Enabling suffixes for virtual fields, fixes #3724
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6449 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-11 02:20:43 +00:00
nate
271777b9f5 Adding FormHelper tests for ID generation, closes #4005
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6432 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-03 06:54:05 +00:00