Commit graph

264 commits

Author SHA1 Message Date
AD7six
ce0a71aef7 fixes #5603 Duplicate first parameter from the paginator with existing url args
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7777 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 22:20:03 +00:00
gwoo
443491e7fa reverting changes from 7668
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7689 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-02 02:16:09 +00:00
nate
300dbc5e91 Correcting how parameters and default values are merged in Controller::paginate(), fixes #5503
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7688 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-02 00:46:26 +00:00
nate
4b8acf4647 Adding 'type' key to both sets of query calls in Controller::paginate(), fixes #5441
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7680 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-29 21:19:37 +00:00
gwoo
f8f4bcc16c fixes #5482, playing with model that uses alias
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7668 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-26 15:27:36 +00:00
mark_story
62168bfe0f Updating doc blocks to include access and return PHPDOC tags.
Removing use of e() in Debugger.
Fixing code formatting in CookieComponent
Closes #5477

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7662 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-25 16:49:56 +00:00
DarkAngelBGE
e245d18ed8 fixes #5469
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7648 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-23 12:04:02 +00:00
mark_story
fafb01b09d Fixing modelClass when using plugin models.
Added TestPluginPost to test_app/test_plugin
Test case added.
Closes #5459

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7641 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-22 04:10:49 +00:00
mark_story
768e25c4fd Updating Controller::paginate(). Custom paginate() and paginateCount() methods now receive $extra params similar to find('all') and find('count') do. Allows the use of things like 'contain' with custom paginate() methods.
Test case added. Closes #5433 refs #5123.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7627 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-19 00:46:20 +00:00
nate
66240f0c5d Refactoring DboPostgres and adding '.' to sequence name detection, fixes #5424, fixing code formatting
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7620 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 00:23:17 +00:00
phpnut
5658e26e07 Changing comparison operators to === (identical) which is faster than == (equal)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7604 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-14 17:17:49 +00:00
DarkAngelBGE
19d4f3d596 adding a couple 'return home early' refactorings
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7572 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-08 20:33:48 +00:00
mark_story
8a76b86c85 Updating doc block for Controller::flash(). Closes #5333
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7511 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-26 18:35:44 +00:00
TommyO
570145d568 Added test to show (deprecated?) support of string status codes in redirect().
Fixed fail on string status codes in redirect().

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7410 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-01 11:27:53 +00:00
gwoo
4a94397b43 removing deprecated code
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7401 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-01 01:04:03 +00:00
TommyO
b6e9888753 Replaced all instances of ife() in /cake
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7387 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-30 20:34:01 +00:00
gwoo
460b219810 small refactor to Controller::paginate handling of sort direction
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7369 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-27 15:55:19 +00:00
gwoo
e26b7e7a63 refactor dispatcher, fixes #5033
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7365 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-26 20:09:20 +00:00
mark_story
cc098629a6 Added direction check to Controller::paginate(). paginate() now forces 'asc' when wrong. Added tests. Closes #5120
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7357 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-24 02:46:39 +00:00
phpnut
022ffa3f4f Adding fixes for pagination on associated models.
Corrected dot notation use in Controller::paginate();

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7286 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 06:25:08 +00:00
gwoo
b8714ede74 fix to paginate sort order for self associated models
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7278 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 03:12:45 +00:00
gwoo
1576a83505 fixing issue with sort in pagination and adding tests, removes previously deprecated controller methods and adds trigger_error to recent ones
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7276 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-27 00:43:31 +00:00
nate
df75a06756 Fixing coding standards violations in core, and adding misc tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7222 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-20 20:17:23 +00:00
gwoo
97a57a0f05 fixing bug in error handler when callbacks were moved to construct classes, moved callbacks back to dispatcher for now until we find a better place in the controller, fixed caching for the "home" page by adding check for "/', original test case was incorrect.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7177 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-12 18:36:08 +00:00
phpnut
6807d4c333 Starting initial refactoring of current code base.
Made changes to test suite to allow running test without headers already sent errors.
Moved Component::initialize(), Controller::beforeFilter(); and Component::startup(); from Dipatcher::start() to Controller::constructClasses();
Removed Dispatcher::start();
Fixing model instances not being created
Adding additional test to CookieComponent to increase coverage to 95%
Optimizing Set::diff();
Fixing SessionComponent test and RequestHandlerComponent test
Fixing CakeSession tests, removed deprecated code from CakeSession

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7162 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-10 22:38:05 +00:00
the_undefined
2d8e63ae7b Refactored and updated postConditions to new operator syntax, fixes #4860
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7145 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-09 08:29:56 +00:00
gwoo
b3f605c1d8 fixes #4836 components initialize for error pages, also changing Object::stop() to Object::_stop()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7116 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-04 19:04:58 +00:00
mark_story
55bcf1e25e Components can have settings assigned in the components declaration, tests added. Closes #4055
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7112 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-04 02:39:05 +00:00
gwoo
cf896eaa9b refactoring component handling, closes #4795, tests added. deprecated Controller::_initComponents();
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7070 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-31 03:54:22 +00:00
nate
42da5aba81 Moving Cake folder to correct location
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7063 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 11:40:08 +00:00
DarkAngelBGE
e6e0d852a2 deleting cake folder from svn
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7061 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 10:59:16 +00:00
mariano.iglesias
9c722b6999 Improving field detection in Containable. paginate() now avoids sending recursive to find calls when it is not explicitly set. Adding more tests to Containable to show how to paginate, fixes #4746
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7030 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-23 16:12:14 +00:00
mariano.iglesias
62bf371aec Allowing paginate to override the default find type for fetching records.
Set the find type as the first string parameter in your paginate settings:
var $paginate = array('popular', ...);
Check the test case for an example.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7013 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-22 17:07:42 +00:00
mariano.iglesias
8f92952d46 Allowing paginate() to send any extra parameters to the find call, and updating it to use new find notation.
Updating test in Containable to reflect how to properly use pagination: just set your 'contain' setting as you do with other pagination parameters, for example:
var $paginate = array('Article' => array('conditions' => ..., 'contain' => array( ... ));
and then do your normal paginate(), without having to set reset to false nor call resetBindings(). Check the test case for an actual example.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7010 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-22 16:25:10 +00:00
DarkAngelBGE
45bccc5215 optimization refs #3415
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6970 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 20:36:39 +00:00
the_undefined
8f4eda68fc Fixed issues with Controller::persistModel and behaviors, closes #4647
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6959 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 08:03:00 +00:00
the_undefined
065b8f4281 Made Controller::redirect use Object::stop, fixes #4154
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6947 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-19 05:21:43 +00:00
DarkAngelBGE
d04101a95a refactoring Controller::referer
adding Controller::header() for testability
bring Controller up in code coverage

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6844 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-13 14:22:57 +00:00
phpnut
06d06c85d9 "Fixes #4339, Providing null for variable with underscores leads to camelcased variable in view"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6626 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-04-02 20:14:06 +00:00
phpnut
57918f4199 "Fixing Controller::output; to allow access to the content in Contorller::afterFilter();"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6554 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-10 13:24:36 +00:00
the_undefined
885b41808f Fixed return value for Controller::setAction
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6508 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-04 23:44:50 +00:00
nate
f3355bd74b Removing all references to deprecated 'webservices' and 'bare' routes and route parameters, removing deprecated constants, updating core tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6453 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-02-11 06:18:41 +00:00
nate
377643cf2b Adding deprecation warning to Controller::cleanUpFields()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6413 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-28 01:14:05 +00:00
nate
d9691a19c8 Refactoring Router::mapResources(), adding tests for REST routing and HTTP method overrides
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6409 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-26 08:50:06 +00:00
phpnut
7098c5558c "Fixes #3887, Controller::modelClass incorrect when using AppController::uses"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6384 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-16 18:09:25 +00:00
phpnut
c47700d8c4 "Removing call to Controller::_initComponents(); and Controller::__mergeVars(); out of Dispatcher"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6322 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-05 01:31:15 +00:00
phpnut
cb53dc61b0 "Closes #2897, Built-in file validation.
Implemented Validation::extension(); and Vaidation::range();
Updated copyright notices in all files"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6296 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-01 22:18:17 +00:00
phpnut
1aa2324e8e "Fixes #3786, Missing keys when Model merges actsAs.
Added additional test for Set::merge();
Refactored Controller::_mergeVars."

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6292 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-01 01:07:24 +00:00
phpnut
013133457c "Fixes #3768, Controller loads wrong model when plugins controller has the controller name of a main model.
moved merging of components, helpers, and uses vars to Controller::_mergeVars(); fixes bug with PluginAppController vars not being merged before components are loaded.
  Added call to Controller::_mergeVars(); in Dispatcher::dispatch();"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6291 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-31 23:27:14 +00:00
phpnut
6fe54aa1d0 "Reverting 5254, this change is only for 1.2 branch"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6255 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-12-25 09:55:59 +00:00