Commit graph

1783 commits

Author SHA1 Message Date
mark_story
d14d148948 Making scaffold form view names consistent with those used in bake.
Renaming test_app files.
Fixes #501
2010-12-12 13:18:28 -05:00
mark_story
11df32148f Updating scaffold templates to use post forms for delete buttons. Updating test case. 2010-12-12 13:13:00 -05:00
mark_story
44c080d5ad Making all core classes throw CakeException subclasses, this allows developers to catch framework exceptions with one catch.
Adding package specific exceptions.
Replacing generic exceptions in the codebase with CakeException + package exceptions.
2010-12-11 19:26:10 -05:00
mark_story
b9f0fc0724 Merge branch '1.3' into merger
Conflicts:
	cake/dispatcher.php
	cake/libs/cake_session.php
	cake/libs/controller/components/cookie.php
	cake/libs/controller/components/email.php
	cake/libs/controller/controller.php
	cake/libs/controller/scaffold.php
	cake/libs/set.php
	cake/libs/validation.php
	cake/libs/view/view.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/validation.test.php
	cake/tests/cases/libs/view/view.test.php
2010-12-10 22:24:31 -05:00
Juan Basso
d97103d739 Making the format attribute customizable in helpers. 2010-12-10 02:42:38 -02:00
mark_story
a830632071 Changing View::element() to not overwrite viewVars with helpers that
have the same name.
Test added.
Fixes #1354
2010-12-09 22:06:23 -05:00
jblotus
48f32a11e0 Fixed incorrect docblock. Fixes #1350
Signed-off-by: mark_story <mark@mark-story.com>
2010-12-08 22:08:43 -05:00
mark_story
55e06ec244 Merge branch '2.0-config' into 2.0
Conflicts:
	cake/libs/configure.php
2010-12-05 23:00:05 -05:00
Juan Basso
c52d5320c8 Replaced the *printf with i18n aliases by i18n aliases with params. 2010-12-04 23:37:13 -02:00
mark_story
539f2cd785 Removing a cakeError that slipped through the cracks. 2010-12-04 16:34:20 -05:00
mark_story
e40ee2576b Minor optimization in h()
Minor optimizations in FormHelper, as calls to ArrayAccess methods are avoided now.
2010-11-28 00:33:01 -05:00
mark_story
79aafda698 Removing use of serialize() for locked fields. This removes any
possible exploit related to serialize()/unserialize().  Instead values
are passed as | delimited.
2010-11-21 00:09:45 -05:00
mark_story
47f6a29998 Small optimizations in env() and Helper::_parseAttributes(). 2010-11-16 22:24:54 -05:00
mark_story
d12c232d8a Merge branch '1.3' into merger
Conflicts:
	app/config/core.php
	cake/console/templates/skel/config/core.php
	cake/dispatcher.php
	cake/libs/controller/components/auth.php
	cake/libs/view/helpers/form.php
	cake/tests/cases/libs/cake_test_case.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/model/models.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helpers/paginator.test.php
	cake/tests/lib/cake_test_case.php
2010-11-16 21:48:13 -05:00
mark_story
c7fed2ecba Removing duplicate calls to Inflector. 2010-11-13 21:08:26 -05:00
mark_story
4c3337598e Updating version numbers for 1.3.6 2010-11-13 20:01:20 -05:00
mark_story
47fa4713b1 Pulling ScaffoldView into a separate file. 2010-11-12 22:54:28 -05:00
mark_story
85e072a64b Removing reference operators in view class constructors. 2010-11-12 22:51:53 -05:00
mark_story
6c2b088706 Merge branch '2.0' into 2.0-view 2010-11-10 23:41:44 -05:00
mark_story
76c3e1a112 Adding cache comment stripping to the CacheHelper, it was recently removed from View, and needed to be added here to fix failing tests. 2010-11-09 23:55:30 -05:00
mark_story
ee0dc785b2 Removing cache comment stripping, they are harmless in html/xml. 2010-11-09 22:37:02 -05:00
mark_story
7ad4068085 Refactoring to remove some duplication. 2010-11-09 22:27:36 -05:00
mark_story
1cf5e72054 Removing duplicated calls to slug()
Extracting getElementFilename() into a method, this should allow developers to more easily replace how elements are found.
Refs #1268
2010-11-09 22:16:45 -05:00
mark_story
dfefc2d97b Very initial pass at getting elements cached with Cache. Refs #1268 2010-11-08 00:06:10 -05:00
Jeremy Harris
060f149a84 Added configurable ellipsis on Paginator::numbers(), Paginator::first(), Paginator::last(). Fixes #1086 2010-11-07 17:08:01 -08:00
mark_story
3216c902cd Removing the enable parameter on HelperCollection, BehaviorCollection, and ComponentCollection. They all now support the enabled option that Behaviors have historically supported. This provides a simpler API with fewer arguments, and allows callbacks to be disabled on objects in their declared arrays.
Test cases updated.
2010-11-07 13:23:45 -05:00
mark_story
88c717dbd8 Removing the 3rd param from ObjectCollection::load() and adding a uniform setting of 'callbacks'. This setting is used to disable callbacks on objects by convention. Test cases updated. 2010-11-07 13:23:45 -05:00
mark_story
1ba28c246b Adding settings['callbacks'] as a way to define enabled/disabled state of helpers in settings arrays. This should replace the separate parameter.
Tests updated.
2010-11-07 13:23:45 -05:00
mark_story
92fec4588a Making private things protected. 2010-11-07 13:23:45 -05:00
mark_story
4c0fd76a2e Changing <cake:nocache></cake:nocache> into <!--nocache--><!--/nocache--> This makes no cache tags valid html/xml at all times, and will not interfere with validation. 2010-11-07 13:23:45 -05:00
mark_story
c92ecdcd1b Initial pass at decoupling CacheHelper from View.
CacheHelper does all caching using helper callbacks now.
2010-11-07 13:23:43 -05:00
mark_story
aaff059132 Moving output into a property, and removing extra arguments from helpers. Having a view property reduces the number of strings that are copied around. 2010-11-07 13:23:43 -05:00
mark_story
2dff74d037 Removing local and using output property. 2010-11-07 13:23:43 -05:00
mark_story
2e140a9fd3 Adding tests for element callbacks. 2010-11-07 13:23:43 -05:00
mark_story
32587c154c Adding callback support to elements. You can use the 3rd parameter to control whether or not before/afterRender callbacks should be fired for a particular element. 2010-11-07 13:23:43 -05:00
mark_story
1b19ad48b4 Adding parameters to helper callbacks, these allow helpers to introspect more on the view/layout being rendered.
Updating tests.
2010-11-07 13:23:42 -05:00
mark_story
882efa883e Removing the trigger_error and view re-renders and replacing them with exceptions. 2010-11-07 13:23:42 -05:00
mark_story
76919902b9 Removing direct tests of protected method.
Refactoring View with the intention of eventually removing coupling with CacheHelper.
Making Helpers load after the first rendering method is called.
Moving callbacks out of _render() to make logic simpler, and with the idea that elements will get a callback too.
2010-11-07 13:23:42 -05:00
mark_story
540f1426be Removing View::error(). Instead you should be handling error states in your controller, or throwing exceptions and letting the application error handling deal with the error. 2010-11-07 13:23:42 -05:00
mark_story
3f61fa004e Removing dead import. 2010-11-07 13:23:42 -05:00
Mark Story
8f31ef7149 Making $scripts_for_layout and $content_for_layout regular viewVars. This will allow helpers to manipulate them in callbacks.
Made $___dataForView an optional parameter, it defaults to $this->viewVars if left undefined. Refs #624
2010-11-07 13:23:42 -05:00
Mark Story
157bdfafc6 Moving beforeLayout, before additional viewVars are processed. Refs #624 2010-11-07 13:23:42 -05:00
mark_story
d56b812181 Fixing issue where an array to string conversion error could occur if you had multiple values for a model's primary key and you created a matching form. Tests added.
Fixes #1257
2010-11-04 21:08:40 -04:00
Juan Basso
b0a600f925 Merge branch '2.0-post-method' into 2.0 2010-11-03 01:42:06 -02:00
mark_story
d1403b0da8 Changing NumberHelper::currency() to format < 1euro based on the suggestions from 'Joel Haasnoot'. Instead of 99c you will get €0,99.
Test cases updated.  Fixes #1253
2010-11-02 21:56:24 -04:00
Mark Story
b67d3fac44 Updating FormHelper to fix failing test from merge. 2010-10-31 21:57:51 -04:00
Mark Story
08e7bcb7ab Merge branch '1.3' into integration
Conflicts:
	app/config/core.php
	cake/console/libs/acl.php
	cake/console/templates/skel/config/core.php
	cake/console/templates/skel/webroot/test.php
	cake/dispatcher.php
	cake/libs/view/errors/missing_action.ctp
	cake/libs/view/helpers/form.php
	cake/tests/cases/libs/cache/memcache.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/log/file_log.test.php
	cake/tests/cases/libs/model/cake_schema.test.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helpers/ajax.test.php
	cake/tests/groups/bake.group.php
	cake/tests/groups/behaviors.group.php
	cake/tests/groups/i18n.group.php
	cake/tests/groups/javascript.group.php
	cake/tests/lib/reporter/cake_cli_reporter.php
2010-10-31 21:56:59 -04:00
Juan Basso
4eed660a62 Changed the form style to not affect layout. 2010-10-30 22:39:31 -02:00
Mark Story
d5f582beee Merge branch 'master' of http://github.com/kwiky/cakephp into kwicky 2010-10-30 00:29:21 -04:00
Mark Story
3b5dafadc5 Adding value option documentation. 2010-10-29 23:56:22 -04:00
Robert Sworder
593c45b6e7 Whitespace changes 2010-10-29 23:43:50 -04:00
Robert Sworder
9eb533b9f6 dateTime functions + tests 2010-10-29 23:43:50 -04:00
Robert Sworder
a876c77987 meridian function 2010-10-29 23:43:50 -04:00
Robert Sworder
6d97aedd47 __selectOptions function 2010-10-29 23:43:50 -04:00
Robert Sworder
d3c1e8c974 minute function + tests 2010-10-29 23:43:49 -04:00
Robert Sworder
5f0700342b hour function + tests 2010-10-29 23:43:49 -04:00
Robert Sworder
6620b3b8fc month function + tests 2010-10-29 23:43:49 -04:00
Robert Sworder
529791842c year function + tests 2010-10-29 23:43:49 -04:00
Robert Sworder
a1b1a07af2 __dateTimeSelected and day functions done, with tests 2010-10-29 23:43:48 -04:00
Robert Sworder
30f3494c98 Select function signature changed. Corresponding tests changed. 2010-10-29 23:43:48 -04:00
Robert Sworder
115c6102b9 Changes to make tests pass... 2010-10-29 23:43:48 -04:00
Juan Basso
daa8d1fac2 Added a message to avoid the use of postLink and postButton in forms. 2010-10-30 00:32:14 -02:00
mark_story
1166806218 Removing shutup operator from View::_render()
Errors in your views will not be suppressed when debug = 0 anymore.
Fixes #943
2010-10-26 23:12:24 -04:00
Steve Grosbois
bc3a9e8a3a Removing a dot at the end of a message in mission_action.ctp because there is no dot in the same message in all other errors view, this can help for traductors 2010-10-25 11:43:03 +02:00
mark_story
eb3cc3db3a Making default scaffold views html escape contents. Refs #1186 2010-10-24 19:30:22 -04:00
Graham Weldon
d3e0ddbb0e Update copyright years. 2010-10-25 07:58:22 +11:00
mark_story
a16f4c5248 Updating version numbers for 1.3.5 2010-10-24 13:56:45 -04:00
mark_story
bf7b8b0e93 Fixing issues with RssHelper and updating tests to reflect changes in how Xml::build() differs from previous versions' Xml. 2010-10-23 13:11:50 -04:00
mark_story
077d1c5ad5 Applying patch from 'hashmich' to fix issues with slideUp and slideDown effects in prototype engine.
Tests updated.
Fixes #1213
2010-10-20 22:07:53 -04:00
Juan Basso
373fa780f7 Created the method FormHelper::postLink() to create a link with form to send data via POST. This feature require javascript. 2010-10-18 21:51:17 -02:00
Juan Basso
4c106490ef Created the method FormHelper::postButton() to create a button with form to send data via POST. 2010-10-18 17:53:27 -02:00
mark_story
61864a3b76 Adding some missing documentation and cleaning up code inside FormHelper::select(). 2010-10-16 13:40:27 -04:00
mark_story
c35ef7dbab Making class attribute bubble down into FormHelper::__selectOption().
Fixes issue where you couldn't change the classname of checkbox options.
Fixes #1202
2010-10-16 13:32:04 -04:00
mark_story
f19e3d501c Merge branch '1.3' into integration
Conflicts:
	cake/libs/model/cake_schema.php
	cake/libs/model/datasources/dbo_source.php
	cake/libs/model/model.php
	cake/libs/view/helpers/form.php
	cake/libs/view/view.php
	cake/libs/xml.php
	cake/tests/cases/libs/model/model_delete.test.php
	cake/tests/cases/libs/view/view.test.php
	cake/tests/cases/libs/xml.test.php
2010-10-13 22:30:40 -04:00
mark_story
6529e0e2b4 Making optiongroup elements follow the escape parameter.
Tests added.
Fixes #1191
2010-10-13 21:59:53 -04:00
mark_story
3f2109f3c3 Applying patch from 'dragonfly' to fix issue where FormHelper would always append an argument even if one was supplied.
Test Added
Fixes #1155
2010-10-13 21:36:05 -04:00
Juan Basso
c95c808f88 Merge with 2.0-xml 2010-10-10 23:21:56 -03:00
ADmad
62161203f2 Fixed issue where FormHelper::radio() and FormHelper::select() with option "multiple"=>"checkbox" would generate tag with invalid "id" attribute if a value was non alphanumeric 2010-10-10 23:16:48 +05:30
José Lorenzo Rodríguez
018def81f4 Cleaning up the MediaView class 2010-10-03 23:27:22 -04:30
José Lorenzo Rodríguez
a611fd0e6c Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-10-03 19:36:24 -04:30
José Lorenzo Rodríguez
bdade0fe08 Adding the ability to compress the response sent from the MeviaView class 2010-10-03 19:35:48 -04:30
José Lorenzo Rodríguez
cf48ee7ed5 Refactoring MediaView to fully use the response object
Improved the way cache headers are sent for delivered files, now it is possible to set cache for files marked for download
2010-10-03 19:34:37 -04:30
José Lorenzo Rodríguez
d117300518 Improving feedback for developer in case media view does not find the specified file 2010-10-03 19:05:23 -04:30
José Lorenzo Rodríguez
0ba5023f3a Updating testcase and fixing small bug in last commit 2010-10-03 16:48:07 -04:30
José Lorenzo Rodríguez
6f5ce8a81d Refactoring media view to start using the response object, improving CakeResponse::cache() 2010-10-03 16:40:54 -04:30
mark_story
f847080cbf Changing more php version strings. 2010-10-03 12:46:03 -04:00
mark_story
5c27abd35f Applying patch from 'hashmich' to make jQueryEngine not override the success callback. This allows you to provide a success callback and still get the html insertion when used with the update key.
Tests updated.
Fixes #1158
2010-10-01 22:43:46 -04:00
mark_story
0761edecfb Making the cake:nocache stripping more relaxed so that if either condition to enable caching is on, tags will be stripped. Tests added. Fixes #1148 2010-09-28 23:03:56 -04:00
mark_story
6d7f2d37ab Fixing issue where fields with the exact same name as the model would result in incorrect name attributes. Tests added. Fixes #1123 2010-09-26 00:46:51 -04:00
mark_story
f21161ef46 Merge branch '1.3' into 2.0. Had to fix a number of 1.3 -> 2.0
differences upon merging.

Conflicts:
	app/config/core.php
	cake/console/templates/skel/config/core.php
	cake/libs/cache/file.php
	cake/libs/cake_session.php
	cake/libs/controller/components/email.php
	cake/libs/i18n.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/cache/memcache.test.php
	cake/tests/cases/libs/model/model_write.test.php
2010-09-24 23:27:22 -04:00
Joe Beeson
b9163b95fe Added a warning that will appear on the homepage to alert users that
their PCRE installation doesn't have Unicode support which can cause a
whole mess of trouble if gone unnoticed. The warning will only display
if their system doesn't have support, not if it does. Fixes #1113

Signed-off-by: mark_story <mark@mark-story.com>
2010-09-18 00:17:51 -04:00
mark_story
e91fa68f8e Making the set() functions use + instead of array_merge() so that numeric indices are properly preserved across multiple method calls. Fixes #1105 2010-09-18 00:13:03 -04:00
mark_story
c255539980 Removing assignment of reference to theme view.
Removing cruft in ThemeView test.
2010-09-14 23:13:00 -04:00
mark_story
2906927a16 Adding BC wrappers for helpers.
Updating paginator test case to use non deprecated properties.
2010-09-13 23:12:00 -04:00
mark_story
e4b2fb173b Removing the deprecated properties.
Removing property copying to helpers.
Making the view test cases pass again.
2010-09-13 23:11:59 -04:00
mark_story
634cea24eb Adding 'action' into View::__get() to make an integration test pass. 2010-09-13 23:11:59 -04:00
mark_story
730e373afe Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/cake_session.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/cache/memcache.test.php
	cake/tests/cases/libs/cake_session.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
	cake/tests/fixtures/data_test_fixture.php
2010-09-12 13:35:46 -04:00
predominant
703344cbae Updated version number to 1.3.4 2010-09-12 17:57:55 +10:00
mark_story
e4d34b640b Merge branch '2.0-exceptions' into 2.0
Conflicts:
	cake/libs/error.php
	cake/tests/cases/libs/controller/scaffold.test.php
	cake/tests/cases/libs/error.test.php
2010-09-10 20:31:16 -04:00
Scott Reeves
9ac8d1af1b Cleaning up link to 1.3 docs, fixing link to blog tutorial. Fixes #1097
Signed-off-by: mark_story <mark@mark-story.com>
2010-09-10 19:42:06 -04:00