Commit graph

1038 commits

Author SHA1 Message Date
Jose Lorenzo Rodriguez
222df2c315 Removing unneeded assert that fails when run in the all test suite 2011-07-17 23:12:51 -04:30
Jose Lorenzo Rodriguez
3594f7aa88 Adding condition inside Controller::render() to avoid storing in the request an empty model definition 2011-07-17 22:54:11 -04:30
Jose Lorenzo Rodriguez
4c8f5ce5be Bringing up to date the ModelTask test case after adding the new validation method 2011-07-17 22:46:56 -04:30
Jose Lorenzo Rodriguez
03dac31930 Using the static property instead 2011-07-17 22:41:12 -04:30
Jose Lorenzo Rodriguez
a786f4b1c6 Making DboSource::$methodCache a static variable to be able to share the cache between multiple instances of the same class 2011-07-17 22:26:21 -04:30
Jose Lorenzo Rodriguez
58282c3934 Micro optimization on Mysql source 2011-07-17 19:23:15 -04:30
Jose Lorenzo Rodriguez
762ebd4b93 Implementing a persitent method cache for DboSource, using a stronger hashing algorithm to ensure unique keys 2011-07-17 19:08:23 -04:30
Jose Lorenzo Rodriguez
ca0a7e4271 Removing method cache from DboSource::conditions() this was consuming too much memory and bringing little to no performance increase 2011-07-17 17:44:12 -04:30
Jose Lorenzo Rodriguez
b603232aee Removing redundant call to DboSource::fields(), the fields come already quoted from DboSource::read() 2011-07-17 17:42:47 -04:30
Jose Lorenzo Rodriguez
ad28228495 Removing unused parameters of tagIsInvalid() 2011-07-16 17:36:47 -04:30
Jose Lorenzo Rodriguez
108505a6a0 Merge branch '2.0-form-helper' into 2.0 2011-07-16 17:32:07 -04:30
Jose Lorenzo Rodriguez
c6c1bf110d Fixing caching of class loading in App class, this was broken after a recent refactoring
Additionally a new property $bootstrapping is added to App, this is set during the bootstrap process to indicate that classes loaded before the caching is initialized should not trigger the cache write routine.
Performance++
2011-07-15 20:44:39 -04:30
Jose Lorenzo Rodriguez
ca0dccb1e7 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2011-07-15 18:30:55 -04:30
Jose Lorenzo Rodriguez
a02db65fd1 Removing persist object feature, it was problematic an incomplete 2011-07-15 18:30:03 -04:30
Jose Lorenzo Rodriguez
d5ce09cd96 Restoring the validationErrors property in FormHelper, it will be checked first before the validation errors in the model 2011-07-15 18:24:27 -04:30
José Lorenzo Rodríguez
11f4d1c0e9 Fixing whitespace in CakeSchema 2011-07-15 14:49:33 -07:00
José Lorenzo Rodríguez
7596fcf45a Merge pull request #153 from ajibarra/e4c1f28d849c6a60c369265a502315260babe80b
Preventing AppModel to be inspected inside CakeSchema
2011-07-15 14:48:01 -07:00
José Lorenzo Rodríguez
57a8c108a6 Merge pull request #147 from burzum/feature/2.0-return-query
Feature/2.0 return query
2011-07-15 14:10:08 -07:00
Alejandro Ibarra
e4c1f28d84 Included validation to skip AppModel on CakeSchema->readSchema because it tries to find 'app_models' table. Added testSchemaReadWithAppModel test 2011-07-15 15:18:38 -04:30
Jose Lorenzo Rodriguez
fb264d9671 Adding a datetime validation method to the Validation class, closes #1021 2011-07-15 01:20:37 -04:30
Jose Lorenzo Rodriguez
8a6d97dfa7 Fixing loading of default options in CakePlugin::loadAll(), fixes #1737 2011-07-15 01:05:53 -04:30
Jose Lorenzo Rodriguez
84aba009e7 Documentation and code cleaning, this commit means that the FormHelper is now fully able to locate models even though lazy loading is used in the controller, closes #1690 2011-07-14 20:35:44 -04:30
Jose Lorenzo Rodriguez
b16a5f24db Making sure the default model for controller is added to the request models parameter in render() 2011-07-14 18:06:16 -04:30
Jose Lorenzo Rodriguez
37231b4ce6 Updating Controller test case 2011-07-14 17:38:02 -04:30
Jose Lorenzo Rodriguez
ac2538b108 REmoving call to deprecated method in PHPUnit 2011-07-14 17:28:53 -04:30
Jose Lorenzo Rodriguez
0c79ad88a3 Cleaning up the code and adding tests for new features 2011-07-14 17:26:55 -04:30
Jose Lorenzo Rodriguez
dcd8811771 Fixing typo 2011-07-14 16:05:23 -04:30
Jose Lorenzo Rodriguez
0228611969 Fixing remaining failing tests on FormHelperTest case 2011-07-14 13:56:31 -04:30
Jose Lorenzo Rodriguez
a5851e9597 Updating test to reflect that models passed as a request parameter are now in an associative array 2011-07-14 13:53:27 -04:30
Jose Lorenzo Rodriguez
4ed46cf330 Updating more tests on FormHelperTest case 2011-07-14 13:53:10 -04:30
Jose Lorenzo Rodriguez
ba012ed950 Adding a special case for not trying to instantiate a Model called Model in FormHelper 2011-07-14 11:13:51 -04:30
Jose Lorenzo Rodriguez
9304f3420b Currently the FormHelper fails if the Model supplied is 'Model', perhaps we need to add a special case for this 2011-07-14 11:05:41 -04:30
Jose Lorenzo Rodriguez
ef5650c034 Fixing ClassRegistry that was incorrectly checking class inheritance
Fixing Model class that was incorrectly sending model names to be instantiated
Fixing more FormHelper tests
2011-07-14 01:30:52 -04:30
Jose Lorenzo Rodriguez
1941be6a76 Updating FormHelper tests 2011-07-14 01:03:29 -04:30
Jose Lorenzo Rodriguez
e8efc67d3d Ensuring that classes returned by ClassRegistry::init() are model instances 2011-07-14 01:02:50 -04:30
Jose Lorenzo Rodriguez
60b44e074a Cleaning up the ClassRegistry::init() method, removing the use of the second parameter as it always accepted but one value
The second parameter is now $strict, meaning that if the model class is not found it will not try to create an AppModel instance
2011-07-14 00:06:01 -04:30
Jose Lorenzo Rodriguez
d54e8cd82f Starting to update tests after removing the validationErrors property in Helper 2011-07-13 23:51:23 -04:30
Jose Lorenzo Rodriguez
39dadf58db Refactoring how model information is extracted in the FormHelper, it is done now in a lazy manner and hopefully using less memory 2011-07-13 23:49:50 -04:30
Jose Lorenzo Rodriguez
22f02373c9 Moving tagIsInvalid from Helper back to FormHelper, as it is a better home for it 2011-07-13 23:49:01 -04:30
Jose Lorenzo Rodriguez
567ac0209c Refactoring how models are passed as a request parameter to the view, now the full plugin and model name will be passed on 2011-07-13 23:47:45 -04:30
Ceeram
a025cb2e01 Adding option to ProjectTask, for setting CAKE_CORE_INCLUDE_PATH. Tests added. 2011-07-13 23:54:24 +02:00
Ceeram
e3dfec98c7 fixing regex for setting constant in test.php 2011-07-13 18:23:07 +02:00
Florian Krmer
adb943b7fd Refactoring the code to build the query array as suggested here https://github.com/cakephp/cakephp/pull/147#issuecomment-1553663 2011-07-12 23:31:07 +02:00
Ceeram
6047024546 removing unneeded parameter 2011-07-12 17:00:25 +02:00
Jose Lorenzo Rodriguez
e45b35cffe Removing the Controller::modelNames property and loading it's contents in the uses variable.
Simplifying code in Controller::render()
Setting all models loaded into the request parameters so it can be used later on the Form helper
2011-07-12 01:19:14 -04:30
Jose Lorenzo Rodriguez
f8ab1d3c73 Adding App::location() method to be able to obtain the defined path for a class 2011-07-12 00:38:50 -04:30
José Lorenzo Rodríguez
273125d2f5 Merge pull request #146 from majna/2.0-database-session
Refactored DatabaseSession to use only 'Session.handler.model' config
2011-07-11 16:28:25 -07:00
Florian Krmer
9d7c97c296 Adding the "returnQuery" key to the 2nd argument of the find() method to be able to get the query array back from the before state of findMethod() calls. This was required in the past for some more complex queries and is in 2.0 no longer possible because the find methods became protected. 2011-07-12 01:04:22 +02:00
Ceeram
4d702ee97f removing unused parameter for value() 2011-07-11 22:13:03 +02:00
Ceeram
00dd1ccc96 removing unneeded parameter, describe() only takes one parameter 2011-07-11 21:07:44 +02:00
Majna
cde13daed4 Refactored DatabaseSession to use only 'Session.handler.model' config. Fixed static call on non-static method DatabaseSession::gc(). Fix for SessionFixture -primary key too long (MySQL Error: 1071) 2011-07-11 00:16:41 +02:00
hiromi2424
9e79756b1f fixed unassigned "show passes" parameter for test 2011-07-09 18:40:22 +09:00
José Lorenzo Rodríguez
a69fccabf6 Merge pull request #144 from majna/2.0
Fix for exception messages and typos
2011-07-07 11:26:32 -07:00
ADmad
1bccc7713d Fixing singularization of "curves" 2011-07-07 23:08:03 +05:30
Majna
742130b540 Fix for wrong Exception messages and typos. Added missing ExceptionRenderer tests for Datasource 2011-07-07 19:36:21 +02:00
José Lorenzo Rodríguez
af12a17b81 Fixing copy paste typos from previous commit 2011-07-07 09:59:02 -07:00
Leonid Mamchenkov
b6ff3a6fdf Fixed typo in the comment 2011-07-07 15:14:06 +03:00
Jose Lorenzo Rodriguez
feb567d4ee Adding better help and documentation for loading plugins. The exception renderer will serve a helpful page if a plugin is missing 2011-07-07 02:34:22 -04:30
Jose Lorenzo Rodriguez
eaa80bbced Completing support for extracting model validation messages from application plugins 2011-07-07 02:11:48 -04:30
Jose Lorenzo Rodriguez
d2519ae0ae Adding support to the extract task to operate on a single plugin, thus removing the hassle of declaring the plugin path in command line 2011-07-07 01:57:55 -04:30
Jose Lorenzo Rodriguez
765164f33b Merge branch '2.0-extract-model-validation' into 2.0 2011-07-07 01:05:39 -04:30
mark_story
1d0d3f80fb Fixing Helper::value() when models exist in ClassRegistry
and field values are empty.
Fixes #1817
2011-07-06 21:26:07 -04:00
mark_story
81a2563a05 Merge branch 'auth-logout' into 2.0 2011-07-03 12:53:57 -04:00
mark_story
71933f5cf5 Adding a logout callback to authenticate objects.
Adding tests for the callback.
Adding doc blocks for the new callback.
Fixes #1758
2011-07-03 12:53:21 -04:00
José Lorenzo Rodríguez
9ea1a049fe Fixing typo in UpgradeShell 2011-07-02 14:21:27 -07:00
José Lorenzo Rodríguez
f671be60d1 Merge pull request #141 from luisarmando/componentsUpgrade
Update component task, make components extend Component instead of Object
2011-07-02 13:05:43 -07:00
mark_story
be09c67fa6 Fixing failing test that happened between 12:00 & 12:59 2011-07-02 13:01:08 -04:00
mark_story
c2a96267b2 Merge branch 'form-helper' into 2.0 2011-07-02 12:13:41 -04:00
Luís Armando
ae9a3ef479 Update component task, make components extend Component instead of Object. 2011-07-02 17:49:29 +02:00
Mark Story
0366d8f18a Changing title CSS for web test runner.
Fixes #1752
2011-07-01 23:23:22 -04:00
Mark Story
2f24be77e9 Merge pull request #140 from majna/2.0
Fix for render element - allow under_scored plugin name.
Fixes #1814
2011-07-01 18:11:57 -07:00
Mark Story
2725718231 Merge pull request #132 from thatcode/2.0
Minor comment and path changes.
2011-07-01 18:06:24 -07:00
Majna
71ed244f14 Fix for render element - allow under_scored plugin name. Fixes #1814 2011-07-02 02:17:44 +02:00
mark_story
bef2e75bdf Fixing failing debugger test.
Adding doc blocks for helper properties.
2011-07-01 07:56:48 -04:00
mark_story
c9acb6b587 Moving FormHelper specifics into that class. 2011-07-01 07:39:03 -04:00
Jose Lorenzo Rodriguez
ee2930d3d0 Removing magic variable in DboSource to bypass the adding of fields to association queries, instead adding the ability to declare 'fields' => false in the association array. This opens the possibility of having joins for filtering purposes. 2011-06-28 11:45:37 -04:30
ADmad
b22e30c5a3 Removing unneeded magic methods. Closes #1802 2011-06-28 17:28:36 +05:30
Mark Story
89258327c6 Moving entity() and its related attributes to Helper
Removing entity() and its attributes from View.
Having that information on View allowed for unwanted side effects,
and seemed like a break of encapsulation.
2011-06-25 20:02:34 -04:00
Mark Story
e4d701021e Fixing failing tests caused by merge with 1.3 2011-06-25 20:00:39 -04:00
Mark Story
1ffa7366a5 Removing now dead code. 2011-06-25 19:31:20 -04:00
Mark Story
4073584eef Fixing more failing tests.
Fixing use of properties that are going away.
2011-06-25 19:31:20 -04:00
Mark Story
87fe66353f Removing pointless test that was in the middle of an unrelated test. 2011-06-25 19:31:20 -04:00
Mark Story
f5b3549018 Fixing issue where _method would be remembered as a field. 2011-06-25 19:31:20 -04:00
Mark Story
25870441bc Fixing '2.name' style fields when creating multiple record forms. 2011-06-25 19:31:20 -04:00
Mark Story
96cc1b98b4 Making a test more specific. 2011-06-25 19:31:19 -04:00
Mark Story
b7e554fcd7 Starting to update FormHelper's internals to work with changes in
Helper.
2011-06-25 19:31:19 -04:00
Mark Story
3a847ae28f Updating more tests for change in Helper setEntity(). 2011-06-25 19:31:19 -04:00
Mark Story
8a8336c1b0 Starting to convert Helper::setEntity() and View::entity()
to not be nearly as complex and magic.  This also
helps reduce coupling between the helpers and Models.
2011-06-25 19:31:19 -04:00
Mark Story
ffe575bb7d Removing expectation that was not being fulfilled. 2011-06-25 19:30:56 -04:00
Robert Sworder
fb3a1928d3 Minor comment and path changes. 2011-06-25 15:08:41 +01:00
AD7six
fcd0505d42 Hide db credentials
To protect users who have publically accessible installs with debug
turned on - *** out db login credentials
2011-06-24 10:25:20 +02:00
Mark Story
08f1afe328 Updating varchar, text columns to use nvarchar.
This storage type stores unicode properly, and is the
saner default datatype for most applications.
Fixes #1321
2011-06-23 23:01:17 -07:00
Mark Story
6bcfd19ea7 Fixing tests that shouldn't have been changed. 2011-06-23 16:27:59 -07:00
Mark Story
3169c5a1e7 Fixing issues with unicode quoting. 2011-06-23 16:13:35 -07:00
Mark Story
9ab2ec7d49 Adding support for Unicode characters. Refs #1321 2011-06-23 15:46:03 -07:00
Mark Story
623466dcf8 Removing duplicated code. 2011-06-23 14:34:45 -07:00
Mark Story
d6e262da2d Fixing form action attributes being double encoded with
querystring attributes.
Fixes #1748
2011-06-23 14:32:53 -07:00
Mark Story
68378f2d06 Adding a test for double escaped form urls.
Refs #1748
2011-06-23 14:32:53 -07:00
Jose Lorenzo Rodriguez
55387ef77f Removing a apparently bad hack in the FolderTest case 2011-06-23 13:53:19 -07:00
Jose Lorenzo Rodriguez
d86dcd6d3b Fixing test broken in Mysql driver 2011-06-23 13:47:11 -07:00