Markus Podar
459ee900fe
php-7.4-compact: replace deprecated curly brace offset access
...
Per https://wiki.php.net/rfc/deprecate_curly_braces_array_access and https://www.php.net/manual/en/migration74.deprecated.php
> The array and string offset access syntax using curly braces is deprecated. Use $var[$idx] instead of $var{$idx}.
2020-03-20 21:10:58 +01:00
mark_story
1ea6732e40
Update version number to 2.10.20
2020-01-16 20:56:03 -05:00
Mark Story
13fba738f7
Merge pull request #13984 from othercorey/2.x-phpunit-warnings
...
2.x - Updated CakeTestSuiteCommand::run() exit logic to match phpunit's
2019-12-06 10:14:14 -05:00
Val Bancer
c59f021c4e
Improve doc block
2019-12-06 10:41:45 +01:00
Corey Taylor
eda72a6f3b
Updated CakeTestSuiteCommand::run() exit logic to match phpunit's behavior now that doRun() is called with =false.
2019-12-06 01:15:11 -06:00
Edgaras Janušauskas
49bbc21e1d
Fix failures on PHP 7.4. Run phpcs on PHP 7.0
2019-12-05 15:11:35 +02:00
Pascal Woerde
2affcdfb00
Fix duplicate session_set_save_handler call from handler instantiation.
2019-11-26 13:39:22 +01:00
Gerson Felipe Schwinn
cf49efdf0e
Solving headers already sent bug on sessions whit phpunit.phar
2019-09-26 09:00:11 -03:00
Milan van As
64700e9a08
Fix loading ShellHelpers from plugins
...
Previously the Shell::helper() function would call a `class_exists` on a variable that contained the `Plugin.ClassName` notation which will always result be false, e.g. `class_exists('YourPlugin.TestShellHelper')` will always be false. Loading ShellHelpers from a plugin will never work because of this. (This notation is described in the ShellHelper 2.x documentation).
After the pluginSplit and the loading of the actual ShellHelper class file (through `App::uses`), the `class_exists` should be called on the real class name, not on `Plugin.ClassName`.
Through this fix, plugins with an ExampleShellHelper in placed in MyPlugin/Console/Helper/ExampleShellHelper.php can be called in Shells by `$this->helper('MyPlugin.ExampleShellHelper')` and plugins within your app can still be loaded through the regular `$this->helper('MyShellHelper')`.
2019-09-04 14:56:12 +02:00
Mark van Driel
142c19c557
Fix for: Empty post body for json will put null value in request->data
2019-08-19 15:00:19 +02:00
Mark van Driel
d4c351563e
Test to prove issue with empty body for json
2019-08-19 14:52:46 +02:00
Gareth Ellis
dba84d65d7
Corrects style error from PHPCS by prefixing method name with an underscore
2019-07-29 15:27:45 +01:00
Gareth Ellis
f198ffdb9c
Moves creation of ControllerTestDispatcher to its own protected method
2019-07-29 10:35:43 +01:00
mark_story
8f08a83474
Update version number to 2.10.19
2019-07-24 21:32:25 -04:00
mark_story
85eb25e8b5
Add missing App::uses()
...
Fixes #13083
2019-06-19 21:52:57 -04:00
Koji Tanaka
d09e827f6c
Pass $exit arguments to the parent doRun() method and $exit is false
2019-06-01 22:59:30 +09:00
mark_story
00aec4b4f5
Update version number to 2.10.18
2019-05-13 22:28:47 -04:00
Mark Story
3522378925
Merge pull request #13198 from bancer/2.x-docs
...
Improve doc block
2019-05-06 11:12:38 -04:00
bancer
7e1fef4066
Improve doc block
2019-05-06 14:21:24 +02:00
Mark Sch
9270d4759b
Merge pull request #13171 from bancer/2.x-docs
...
Improved doc block
2019-04-29 14:30:49 +02:00
bancer
928f586599
Improved doc block
2019-04-29 10:40:10 +02:00
Koji Tanaka
cf39119151
In PHP 7.3+, call the built-in function mb_strtoupper() to skip failed tests
2019-04-28 21:00:45 +09:00
mark_story
4d0a209033
Fix shutdown warnings in PHP7.2+
...
Check if the current file is valid before re-using it. This fixes
warnings emitted during process shutdown when DboSource is persisting
the method cache.
Fixes #13085
2019-04-16 21:23:58 -04:00
mark_story
d954e96671
Update version number to 2.10.17
2019-04-13 22:17:43 -04:00
Mark Story
3d216935c9
Merge pull request #13054 from savedario/2.x
...
FormHelper does not respect passed 'escape' option for errors
2019-03-30 21:38:41 -04:00
Mark Story
8ff719de66
Merge pull request #13058 from bancer/2.x-use-trans-session-id
...
Add extra unit tests
2019-03-30 21:36:13 -04:00
Mark Sch
b8cefad8c5
Merge pull request #13060 from hgsgtk/2.x-fix-phpdoc
...
fix phpdoc at HtmlHelper::link
2019-03-19 08:47:55 +01:00
Kazuki Higashiguchi
e472a85ab2
fix phpdoc at HtmlHelper::link
2019-03-19 12:03:33 +09:00
bancer
4db38f26ca
Improve unit test
2019-03-18 12:43:26 +01:00
bancer
ec3abd9089
Add extra test to AllControllerTest
2019-03-18 11:58:42 +01:00
bancer
2fe0af9fa9
Improve docs
2019-03-18 11:52:35 +01:00
bancer
534d9362e4
Add extra unit tests
2019-03-18 11:50:13 +01:00
Dario Savella
cf5577234f
PHPCS typos fixed
2019-03-15 18:50:26 +01:00
Dario Savella
08d11154a7
Changes reverted. Added 2 tests of error-related options
2019-03-15 17:41:29 +01:00
Dario Savella
5ba9e41df8
Form helper did not respect passed FormHelper::inputDefaults()
2019-03-15 10:39:52 +01:00
Gareth Ellis
c14782305b
Separates derivation of conditions for cascaded deletion of HABTM records to a protected method #13046
2019-03-14 10:28:59 +00:00
mark_story
c4a51509c5
Update version number to 2.10.16
2019-02-28 21:45:41 -05:00
Mark Story
d054d536ab
Merge pull request #13010 from bancer/2.x-config
...
Use CONFIG constant
2019-02-23 16:50:54 -09:00
Benjamin Stout
71f5133a86
Use strict comparison instead of function call - #13001
2019-02-21 11:44:38 -08:00
bancer
3f909e9a00
Define CONFIG constant
2019-02-21 17:18:15 +01:00
bancer
8a724bb698
Use CONFIG constant
2019-02-21 16:54:07 +01:00
Benjamin Stout
0cc3509b74
Prevent attempting to close an uninitialized Redis instance (issue #13001 )
2019-02-19 18:21:44 -08:00
Benjamin Stout
d486e1ca9e
Wrap index reference in empty() check - closes cakephp#13001
2019-02-19 16:32:25 -08:00
bancer
63bbd4cd7b
Fix queryString documentation
2019-02-07 14:23:56 +01:00
Mark Story
c5229c2037
Merge pull request #12913 from bancer/2.x
...
Add unit test for timezone conversion
2019-01-31 22:20:11 -05:00
bancer
bb20b4f419
Change private method to protected
2019-01-31 09:49:41 +01:00
bancer
e94183c6d8
Give a better name to a new function
2019-01-29 09:16:48 +01:00
mark_story
7da7a9fab4
Update version number to 2.10.15
2019-01-25 21:41:55 -05:00
bancer
ec5bac5e52
Fix timezone adjustment in CakeTime::nice and CakeTime::niceShort
2019-01-25 13:56:50 +01:00
bancer
e845e8876d
Add unit test
2019-01-25 13:04:41 +01:00
bancer
c855ef874b
Simplify i18nFormat
2019-01-25 12:25:26 +01:00
bancer
009d69b3f7
Fix code style errors
2019-01-25 12:21:34 +01:00
bancer
044e8f24af
Fix timezone conversion
2019-01-25 12:05:44 +01:00
bancer
7911bb9052
Remove unnecessary timezone offset manipulation
2019-01-24 15:43:11 +01:00
Val Bancer
c269ae29e6
Add timezone conversion unit test
2019-01-20 21:54:41 +01:00
bancer
4eb42e0b05
Add unit test for timezone conversion
2019-01-18 17:07:05 +01:00
Mark Story
73de35c119
Merge pull request #12906 from akeiper/2.x
...
resolving ini_set error in php 7.2
Fixes #12678
2019-01-16 21:57:13 -05:00
mark_story
a13abcf97b
Fix tests.
2019-01-16 21:53:42 -05:00
andrew.keiper
38074f72e9
adding support for PHP 5.3 by adding function_exists for session_status
2019-01-16 15:28:35 -05:00
andrew.keiper
06269b3fba
resolving session issues for php 7.2
2019-01-16 10:43:04 -05:00
kicaj
bcbe5fdcf0
Fix #12885
2019-01-11 13:20:09 +01:00
bancer
71ea302336
Improve documentation
2018-12-28 14:19:26 +01:00
Joseph Zidell
6ed88922a5
Fixes docblock for View::set() ( #12837 )
...
* Fixes docblock for View::set()
2018-12-23 00:09:44 +04:00
mark_story
1dc3219f22
Update version number to 2.10.14
2018-12-19 20:45:32 -05:00
Mark Story
0471d7a9ca
Merge pull request #12808 from bancer/2.x-issue-12804-generate-shell-enum
...
Improve support of enum data type
2018-12-16 19:30:21 -08:00
Joseph Zidell
44f4fe27bf
Fixes docblock for Folder constructor
2018-12-12 22:45:41 -05:00
bancer
7788c60f58
Adjust enum related unit tests
2018-12-12 14:31:55 +01:00
bancer
cf6c8d511f
Improve support of enum data type
2018-12-12 12:40:20 +01:00
Mark Story
acb0436cb6
Merge pull request #12736 from bancer/2.x-documentation
...
Improve documentation and code style
2018-12-11 12:59:19 -08:00
Val Bancer
0f2bbf505d
Adjust the check according to review comments
2018-12-11 16:36:32 +01:00
Yaser Naderi
3d224639d9
Add the functionality to accept enum MySQL datatype storing the Integer values as String ( #12715 )
...
Fix a bug in enum MySQL datatype storing Integers when enum contains
integer string values. Now strings will always be used for enum values.
2018-11-30 21:27:58 -05:00
Martin Stücklschwaiger
a9e20c39be
Fix @return value
2018-11-29 20:37:03 +01:00
Val Bancer
addd538526
Fix invalid condition
2018-11-18 22:48:34 +01:00
Val Bancer
c00579153b
Cast var to int for comparison
2018-11-18 18:22:19 +01:00
Val Bancer
cb1d80fda1
Improve documentation
2018-11-18 17:13:11 +01:00
Val Bancer
92e9277d20
Improve code style
2018-11-18 16:24:25 +01:00
Val Bancer
509accc421
Improve code style
2018-11-17 20:55:42 +01:00
Val Bancer
261a99c0e3
Improve documentation and code style
2018-11-17 20:27:05 +01:00
Val Bancer
320cdf98ee
Add undocumented properties ( #12717 )
...
See https://book.cakephp.org/2.0/en/controllers/request-response.html#accessing-request-parameters and https://api.cakephp.org/2.10/source-class-UpgradeShell.html#345-403
* Initialize $params to null
* Document more magic properties, trigger deprecated notices
* Use $controller->request->params instead $controller->params
* Remove unused variable
* Improve documentation, add type checks.
* It seems like $this->uses can also be of type false; however, parameter
$array of array_unshift() does only seem to accept array.
* Declare undeclared property
* Add extra type checks
* Adjust type check
* Improve documentation, initiate uninitialized variables.
* Improve documentation, reset variable
2018-11-15 20:41:57 -05:00
Val Bancer
22b0386fd5
Move failing assertion to a new test method
2018-11-11 17:53:28 +01:00
Val Bancer
2f5467e8e8
Move failing assertion to a new test method
2018-11-11 17:36:10 +01:00
Val Bancer
0f0cedec14
Move failing assertion to a new test method
2018-11-11 17:18:18 +01:00
Val Bancer
d5ac7aa0b2
Simplify assertions in tests
2018-11-11 17:00:55 +01:00
Val Bancer
90ddb43632
Fix some PHP 7.3 errors
2018-11-11 16:15:55 +01:00
Mark Story
b1a93df604
Merge pull request #12692 from bancer/model-exists-without-id
...
Add model id to all `exists()` method calls
2018-11-01 21:21:27 -04:00
bancer
58ebf6a303
Remove id property from bake template
2018-10-31 09:46:01 +01:00
Mark Story
89005c4440
Merge pull request #12680 from bancer/issue-12636-tests-constants
...
Replace hard coded test directory paths with constants, fixes #12636
2018-10-30 14:28:49 -04:00
bancer
d8d65027ac
Adjust unit tests with id parameter for exists() method
2018-10-30 11:02:42 +01:00
bancer
3ea39d96b4
Add model id to all exists() method calls,
...
Related issue - https://github.com/dereuromark/cakephp-shim/issues/25
2018-10-30 10:39:16 +01:00
mark_story
33ac2b2537
Update version number to 2.10.13
2018-10-27 22:01:42 -04:00
bancer
ee1b1a10df
Defines TESTS also after app bootstrap.php is loaded, #12636
2018-10-26 15:52:39 +02:00
bancer
85cc215293
Improve documentation
2018-10-26 14:23:30 +02:00
bancer
53e3df20d0
Replace hard coded test directory paths with constants, fixes #12636
...
The `TESTS` constant definition is moved from bootstrap.php in order
to make it possible to set the constant in test.php or in the project's
bootstrap file so that CakePHP would detect tests in a different folder.
2018-10-26 13:49:53 +02:00
Val Bancer
3c9d46864e
Improve documentation
...
The parameter description is copied from `CakeLog::write` method.
2018-10-26 09:54:23 +02:00
Val Bancer
527b9fe640
Improve documentation
2018-10-22 10:11:01 +02:00
Val Bancer
e825823e9a
Improve documentation
2018-10-22 10:02:51 +02:00
Mark Story
2bdc04e53c
Merge pull request #12653 from begnini/fix_describe_pgsql_function
...
limiting the regex to consume only words in default value in pgsql
2018-10-21 02:30:44 +00:00
mark_story
ffde7ee32a
Don't break UNC file paths
...
Blindly replacing // causes network paths and paths with protocols to
break. Relying on correct input allows the user to get what they want
without the framework interfering.
Refs #12657
2018-10-19 22:08:39 -04:00
Val Bancer
b97530977d
Improve documentation
2018-10-19 16:54:05 +02:00
Val Bancer
8e8fbae78c
Improve documentation
2018-10-19 16:45:21 +02:00
Humberto Pereira
23e38aeaf0
limiting the regex to consume only words in default value in PostgreSQL after ::
...
added tests showing the old behavior was broken.
2018-10-18 17:16:29 -04:00
Joseph Zidell
59fe9f55c2
Augment docblock for Hash::combine()
...
Adds array as possible types for `Hash::combine()` for `$keyPath` and `$valuePath` params.
2018-09-20 22:00:03 -04:00
Val Bancer
d7b5cda0ea
Fix PHP 5.3 syntax
2018-09-12 18:14:24 +02:00
Val Bancer
a7a49c5f8e
Fix syntax
2018-09-12 17:32:00 +02:00
Val Bancer
1a62c147fe
Improve handling of CURRENT_TIMESTAMP default value
...
Resolves https://github.com/cakephp/cakephp/issues/12553 .
2018-09-12 16:45:01 +02:00
mark_story
4aa0df8370
Fix tests to run when database name is not cakephp_test
2018-09-09 13:03:36 -04:00
Mark Story
2bea29d07c
Merge pull request #12487 from josephzidell/php_7.3_issues
...
Fixes: a few issues found when running PHP 7.3
2018-09-09 12:50:23 -04:00
mark_story
29f89c5aa7
Update version number to 2.10.12
2018-09-03 12:37:15 -04:00
Joe
34bfeba15d
Fixes failing tests
2018-09-03 00:45:34 -04:00
Mark Story
c2df84c701
Merge pull request #12503 from bancer/code-style
...
Improve documentation
2018-08-29 13:49:00 -07:00
Val Bancer
e13d44be87
Initialize $map to empty array
2018-08-26 14:20:38 +02:00
Val Bancer
df1c25f4cf
Fix documentation of resultSet method
2018-08-26 02:23:29 +02:00
Val Bancer
2aa8fac574
Fix resultSet() method signature
2018-08-26 01:58:56 +02:00
Val Bancer
c5d78b6302
Remove duplicate connect method from the unit test stub
2018-08-26 01:24:18 +02:00
Val Bancer
290bccedb4
Add missing method definitions
2018-08-25 23:19:26 +02:00
Val Bancer
957b4e566a
Move declaration of $map to DboSource
2018-08-25 22:39:26 +02:00
Val Bancer
f768689bd0
Improve documentation
2018-08-25 19:34:29 +02:00
Val Bancer
5105c49668
Improve documentation
2018-08-25 19:15:30 +02:00
Joe
013ecc3f9f
Rebuilds the solution
2018-08-22 11:40:41 -04:00
Joe
1fca92fb4e
Fixes issue raised by @garas
2018-08-22 00:40:28 -04:00
Joe
af516eebb0
Cleanup fix
2018-08-21 15:29:48 -04:00
Joe
8e7bc7701c
Combine variable defaults
2018-08-21 15:29:04 -04:00
Joe
a4e71b3b40
Fixes:
...
* Issue with preg_match()
* Undefined variables
2018-08-21 14:46:58 -04:00
Val Bancer
a05c09c1f4
Improve code style
2018-08-14 12:33:49 +02:00
Val Bancer
e56452b2c5
Improve code style
2018-08-14 12:31:58 +02:00
Val Bancer
f5bf22e1e3
Do not unset $this->fixtures
2018-08-13 17:13:47 +02:00
Val Bancer
0e02af091a
Move unset to the proper place
2018-08-13 15:28:10 +02:00
Val Bancer
727aac1713
Move unset to the proper place
2018-08-13 15:06:19 +02:00
Val Bancer
cb23bf9223
Remove whitespace
2018-08-13 14:38:54 +02:00
Val Bancer
b45fe026f5
Unset more properties to free more memory
2018-08-13 14:20:29 +02:00
Val Bancer
dbbc8400b6
Free some memory in unit tests
2018-08-13 13:09:22 +02:00
Val Bancer
8bfdcdb637
Free some memory in unit tests
2018-08-13 12:26:26 +02:00
Jan Ptacek
d292a83407
Avoid undefined index: null (update action)
...
Avoid Notice (8): Undefined index: null [APP/Vendor/cakephp/cakephp/lib/Cake/Model/Datasource/DboSource.php, line 2180]
also discussed here: 22b0275#diff-b8a4043bec5d20830b77d240ae8fdef5R2087
fix for previous instance if same bug already merged here: cakephp#12411
(sorry for overlooking this second use-case :( )
2018-08-06 12:15:41 +02:00
Mark Story
1f1cd775c1
Merge pull request #12430 from bancer/2.x-documentation
...
Fix param documentation in App::import
2018-08-05 21:41:10 -04:00
Val Bancer
494913648d
Restore property deleted by accident
2018-08-05 15:34:12 +02:00
Val Bancer
377cd09062
Fix param documentation in App::import
2018-08-05 15:32:12 +02:00
Mark Story
252f3a0e44
Merge pull request #12420 from mma/tests
...
2.x Enchament to CakeEmail error message
2018-08-01 16:08:24 -04:00
AlexAlexandru
c44113af66
code style
2018-08-01 21:50:38 +03:00
AlexAlexandru
44c0d73391
code style
2018-08-01 21:04:50 +03:00
AlexAlexandru
8c3982b192
fixes #11424 Enchament to email class error message
2018-08-01 20:54:53 +03:00
Mark Story
9f16d2e515
Merge pull request #12378 from mma/tests
...
Fixes #12376 bindTranslation restore fields
2018-07-30 15:05:32 -04:00
Jan Ptacek
ca59191d5c
Avoid undefined index: null
...
Avoid Notice (8): Undefined index: null [APP/Vendor/cakephp/cakephp/lib/Cake/Model/Datasource/DboSource.php, line 1013]
also discussed here: 22b0275a58 (diff-b8a4043bec5d20830b77d240ae8fdef5R2087)
2018-07-30 11:17:24 +02:00
AlexAlexandru
a58eb706dc
added tests
2018-07-19 21:14:18 +03:00
AlexAlexandru
1aa0108354
Issue #12376
2018-07-19 20:28:53 +03:00
Mark Story
ee02d4274f
Merge pull request #11750 from bancer/11528-code-coverage
...
fixes Error: Class 'PHP_CodeCoverage' not found error
2018-07-13 13:24:19 -04:00
mark_story
98c7fa1c97
Update version number to 2.10.11
2018-07-01 15:05:15 -04:00
Mark Story
fd568e7c79
Fix method casing.
...
Closes #12241
2018-06-30 14:55:37 -04:00
Mark Story
a1203409aa
Merge pull request #12218 from WrDX/WrDX-session-write-doc
...
2.x Updated docs for CakeSession
2018-06-12 10:54:22 -04:00
Wouter
6c86981858
Make docs compatible with CakeSession
2018-06-12 10:24:24 +02:00
Wouter
9ef47b49cc
Update CakeSession.php
2018-06-12 10:21:37 +02:00
