Commit graph

5298 commits

Author SHA1 Message Date
mark_story
dc65f2306b Making Cache methods always need a config name. This allows the removal of hidden and often confusing state that gets remembered by Cache each time config() is called. Removing the hidden state makes Cache more predictable. 2010-09-18 00:45:29 -04:00
Joe Beeson
b9163b95fe Added a warning that will appear on the homepage to alert users that
their PCRE installation doesn't have Unicode support which can cause a
whole mess of trouble if gone unnoticed. The warning will only display
if their system doesn't have support, not if it does. Fixes #1113

Signed-off-by: mark_story <mark@mark-story.com>
2010-09-18 00:17:51 -04:00
mark_story
e91fa68f8e Making the set() functions use + instead of array_merge() so that numeric indices are properly preserved across multiple method calls. Fixes #1105 2010-09-18 00:13:03 -04:00
mark_story
d113d7d612 Removing dead code from DboSource::fields()
Updating fields() to use implode, so complex virtual fields are better handled.  Fixes #1079
2010-09-18 00:04:36 -04:00
mark_story
5a8648cca0 Fixing issue in DboSource::_matchRecords() where unqualified conditions would result in 1=1 conditions. Fixing incorrect test case. Fixes #930 2010-09-16 00:17:09 -04:00
mark_story
1707c92aa1 Removing duplicated code. 2010-09-14 23:15:10 -04:00
mark_story
c255539980 Removing assignment of reference to theme view.
Removing cruft in ThemeView test.
2010-09-14 23:13:00 -04:00
mark_story
f34cfd1f1e Updating EmailComponent to use new methods on the ComponentCollection to ensure it always has a controller reference.
Removing triggerDisabled key as its no longer needed or wanted.
2010-09-14 23:02:38 -04:00
mark_story
273a189e98 Adding some documentation about component callbacks. 2010-09-14 23:01:39 -04:00
mark_story
30589e2cdf Removing dead method. 2010-09-14 22:56:33 -04:00
mark_story
0ef76eb69a Adding a reference of the controller to the component collection, so components can easily access the controller in their constructor. 2010-09-14 22:52:51 -04:00
mark_story
7a14d3a8f2 Fixing issue where mockObject expectations were not counted hiding fails. Fixing all objects not actually being iterated. 2010-09-14 22:40:46 -04:00
mark_story
0baaf6801b Removing call to RequestHandler as its just a pass through to the request object which is available in that scope. Updating the test cases to not use deprecated and non-existent things. 2010-09-14 22:12:14 -04:00
mark_story
97dd7c7644 Adding support to ObjectCollection and its subclasses to trigger callbacks on all objects instead of just the enabled ones. Fixes issues where inner components would not get access to the controller as the initialize callback wasn't fired. This fixes some backwards compatibility issues. Tests updated. 2010-09-14 21:57:40 -04:00
mark_story
2906927a16 Adding BC wrappers for helpers.
Updating paginator test case to use non deprecated properties.
2010-09-13 23:12:00 -04:00
mark_story
e4b2fb173b Removing the deprecated properties.
Removing property copying to helpers.
Making the view test cases pass again.
2010-09-13 23:11:59 -04:00
mark_story
634cea24eb Adding 'action' into View::__get() to make an integration test pass. 2010-09-13 23:11:59 -04:00
mark_story
a521291afd Adding a __set() method to make some tests pass.
Updating internal usage to not use deprecated attributes.
Updating test cases to not use deprecated attributes.
2010-09-13 23:11:59 -04:00
mark_story
84565151de Removing all the deprecated properties from Controller.
Adding a __get() method to provide the properties that were moved to CakeRequest.
Tests added.
2010-09-13 23:11:59 -04:00
mark_story
c7fb20d13a Reformatting doc block indentation. 2010-09-13 23:09:00 -04:00
mark_story
834c44b303 Fixing return value tag. 2010-09-13 23:06:15 -04:00
mark_story
d7bb7699e2 Applying patch from '0x20h' to fix issue where domain translation files would be mixed together causing duplicate data in the various cache files. There should now be one cache per domain + language. Fixes #1085 2010-09-13 22:17:05 -04:00
mark_story
6519de3a2e Adding CakeRequest::data() to make reading/writing data similar to CakeSession.
Tests added.
2010-09-12 14:05:57 -04:00
mark_story
730e373afe Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/cake_session.php
	cake/libs/view/pages/home.ctp
	cake/tests/cases/libs/cache/memcache.test.php
	cake/tests/cases/libs/cake_session.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
	cake/tests/fixtures/data_test_fixture.php
2010-09-12 13:35:46 -04:00
mark_story
e9d194822d Adding more tests for SMTP address formatting. Fixes #1100 2010-09-12 11:48:09 -04:00
Juan Basso
46f784f956 Support to DOMDocument/DOMNode in Xml::toArray(). 2010-09-12 11:25:37 -03:00
predominant
703344cbae Updated version number to 1.3.4 2010-09-12 17:57:55 +10:00
Juan Basso
a006ee0019 Updating docs. 2010-09-11 22:20:21 -03:00
Juan Basso
7237713a30 Added test to dont use encoding in XML. 2010-09-11 22:12:54 -03:00
Juan Basso
2e7851c2be Support to namespaces in Xml::fromArray(). 2010-09-11 21:51:49 -03:00
mark_story
e4d34b640b Merge branch '2.0-exceptions' into 2.0
Conflicts:
	cake/libs/error.php
	cake/tests/cases/libs/controller/scaffold.test.php
	cake/tests/cases/libs/error.test.php
2010-09-10 20:31:16 -04:00
Scott Reeves
9ac8d1af1b Cleaning up link to 1.3 docs, fixing link to blog tutorial. Fixes #1097
Signed-off-by: mark_story <mark@mark-story.com>
2010-09-10 19:42:06 -04:00
mark_story
f8dbeb2b70 Adding documentation for a new feature. 2010-09-09 22:02:36 -04:00
mark_story
4a0e34a0d6 Applying patch from 'jeremyharris' to make RequestHandler::renderAs() accept an array of options that can be used to send a file as a download. Fixes #950 2010-09-09 21:31:34 -04:00
mark_story
d5e906f086 Adding deprecation flags. 2010-09-08 22:49:00 -04:00
mark_story
12338a0c16 Updating instance method calls in AclComponent. 2010-09-08 22:48:21 -04:00
mark_story
b60f65f420 Adding a tiny bit of documentation to App::import(). 2010-09-08 22:29:47 -04:00
mark_story
d5bde3fe7a Adding a call to session_destroy() to remove the session data. This fixes the issue where data would not be totally destroyed. Fixes #1089 2010-09-08 22:05:53 -04:00
Juan Basso
c8c20eafdc Xml::build now supports options and can return DOMDocument. 2010-09-08 21:47:55 -03:00
Juan Basso
071ff04556 Xml::fromArray now receives a list of options unless simple format. 2010-09-08 19:40:33 -03:00
Juan Basso
a8b6182d43 Changing Xml::fromArray to use DOMDocument unless SimpleXMLElement. The return continue as SimpleXMLElement. 2010-09-08 19:18:58 -03:00
mark_story
5d703c4f50 Fixing + adding imports for Scaffold. 2010-09-08 00:11:37 -04:00
mark_story
fa9eb94fb0 Adding base class import for view classes. 2010-09-08 00:10:36 -04:00
mark_story
4ff52da57e Making import() ing a component ensure that the Component base class is loaded. 2010-09-07 23:39:31 -04:00
Juan Basso
ca7e327af1 Fixing the documentation. 2010-09-07 18:19:14 -03:00
Mark Story
2b3099fa70 Removing duplicate method call. 2010-09-07 00:42:49 -04:00
Mark Story
e15069769d Adding tests for #1079 and fixing some formatting. 2010-09-07 00:09:06 -04:00
Juan Basso
c1a75cbc47 Support to namespaces in Xml::toArray(). 2010-09-07 00:31:50 -03:00
Juan Basso
5f902d42e0 Changing the default format of fromArray from attributes to tags. 2010-09-06 23:11:45 -03:00
Mark Story
0f23634382 Adding stack traces to error400 and error500 when debug > 0.
Adding the stack trace element.
2010-09-06 18:09:11 -04:00
Mark Story
09fd8ba463 Adding stack trace output to the framework errors. 2010-09-06 17:54:48 -04:00
Mark Story
d88da3d579 Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/configure.php
	cake/libs/model/connection_manager.php
	cake/libs/model/model.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
	cake/tests/cases/libs/view/helpers/text.test.php
2010-09-06 16:53:04 -04:00
Mark Story
c60edfae6d Fixing issue where errors containing code = 500, were not actually converted to error500 when debug = 0. Making missingConnection, and missingTable into error500 errors. 2010-09-06 16:46:41 -04:00
Mark Story
464d2217e6 Renaming model_behavior test to behavior_collection test as that's the class that contains the tested methods. 2010-09-06 13:51:42 -04:00
Mark Story
73057b8853 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-09-06 13:39:37 -04:00
Mark Story
5789aaf24d Applying patch from 'tkykmw'. Behavior mapped methods are no longer run through strtolower(). Mapped methods are now case sensitive. Fixes #318 2010-09-06 13:38:01 -04:00
predominant
a6b08c94d0 Merge remote branch 'origin/2.0' into 2.0
Conflicts:
	cake/libs/session/database_session.php
2010-09-06 23:57:36 +10:00
Mark Story
d54c901f5d Moving _setupDatabase() into the Database session class, as that's the only place its used. 2010-09-06 01:12:23 -04:00
Mark Story
474ace09c1 Adding CakeResponse to the list of included files for Controller. 2010-09-06 01:11:26 -04:00
Mark Story
d62ae2900a Fixing issue where ConnectionManager wasn't triggering session close, causing issues with database sessions. 2010-09-06 01:10:45 -04:00
Mark Story
27ae7f1f44 Making session storage classes not static, there was no real reason they were static before, and removing the static methods allows them to have constructors. This will allow moving database specific features from CakeSession to DatabaseSession. 2010-09-06 00:43:58 -04:00
ADmad
bfaaa6b8ba Fixing unnecessary extra calls to 'afterFind' callback of 'hasMany' associated models. Closes #995 2010-09-05 23:53:24 +05:30
Mark Story
01eb0bf07d Making messages optional for HTTP exceptions. 2010-09-05 11:32:35 -04:00
Mark Story
e5b4dd94d7 Renaming exceptions to not use Error400, Error500. Instead HTTP status words are used.
Adding more common HTTP status errors.
Updating tests for ErrorHandler.
2010-09-05 02:05:31 -04:00
Mark Story
b7791dd94f Removing variable that wasn't provided by the exception. 2010-09-05 02:04:08 -04:00
Mark Story
82fffe6914 Fixing issue where FormHelper::select() with multiple = checkbox and a custom name attribute would not work correctly. Fixes #1078 2010-09-05 01:28:13 -04:00
Mark Story
cc17e1a85a Adding more doc blocks to error classes. 2010-09-04 19:18:14 -04:00
Mark Story
954676c9f6 Adding doc blocks to the new exception classes. 2010-09-04 19:16:06 -04:00
Mark Story
d198230e61 Fixing issue where errors that did not have a 500+ code would use the incorrect status code. 2010-09-04 19:06:10 -04:00
Mark Story
4d863618f5 Refactoring exception handling so codes are much more flexible and easy to change.
Made error404 and error500 more generic.
Removed error() as it didn't really make that much sense.
2010-09-04 15:38:10 -04:00
Mark Story
4980f42dc5 Renaming file. 2010-09-04 15:35:01 -04:00
Mark Story
fa7549dc4c Fixing comments and removing cakeError(). Instead you should be throwing exceptions. 2010-09-04 01:34:45 -04:00
Mark Story
8c428ff8a8 Moving where AppError is used, as infinite recursion is no fun. 2010-09-03 15:03:33 -04:00
Mark Story
f2db19767d Adding in support for AppError. 2010-09-03 10:30:35 -04:00
Mark Story
3940b059a3 Adding a big docblock to explain how to setup application exception handling. 2010-09-02 16:39:09 -04:00
Mark Story
2e8a60f932 Removing some mentions of cakeError as its been removed. Also adding information about exceptions that can be raised. 2010-09-02 16:38:19 -04:00
Mark Story
dbdd17f51a Adding test cases from 'euromark' and updating how email addresses are parsed so they are slightly more conformant to RFC 5322. Fixes #1066 2010-09-02 11:16:10 -04:00
Mark Story
3e5e52d52e Fixing doc block for Form::create(). Fixes #1058 2010-09-02 00:29:04 -04:00
Mark Story
063fcf557d Moving error handler inclusion to before Configure::bootstrap() so app error handlers can be created.
Fixing issue where unknown exception types would not be handled spewing out errors.  Unknown exception types are interpreted as 500 errors.
2010-09-01 20:29:55 -04:00
mark_story
a8d4015f47 Updating bootstrap process in CLI to match the one in web.
Updating all_libs to use new file.
Updating error_handler test to run in cli.
Updating Controller so it imports required classes.
2010-08-30 22:59:10 -04:00
mark_story
1f30c06695 Fixing method coercion in error404 so it only coerces CakeExceptions.
Test Added.
2010-08-29 23:39:28 -04:00
mark_story
534f6006f8 Adding omitted parent call. 2010-08-29 23:38:46 -04:00
mark_story
612c52bb8b Adding a beforeRender() that automatically escapes all the content sent to errors handled by CakeErrorController. 2010-08-29 23:31:20 -04:00
mark_story
f1164c93d6 Updating the various CakeExceptions to take arrays in their constructors. This allows for the existing templates to continue working, as well as generalize the way in which errors are handled. This change also makes the messages coming out of exceptions more readable and removes string hackery. 2010-08-29 21:37:25 -04:00
mark_story
741f2972f9 Removing non required attribute from missing controller error page. 2010-08-29 15:12:50 -04:00
mark_story
99cde14432 No more skipped tests for ErrorHandler.
Removing missing_model as it was never called.
2010-08-29 13:49:10 -04:00
predominant
465b15c64e Removing reference assignments. 2010-08-29 23:09:33 +10:00
mark_story
7fb62e9b7e Updating more error messages to use exceptions. 2010-08-29 01:26:21 -04:00
mark_story
041aeecce4 Renaming test case file to match class file.
Updating tests and methods for missing_action, missing_view, private_action.
2010-08-29 01:01:36 -04:00
mark_story
88c66c057d Renaming error.php to error_handler.php to better match its class name. 2010-08-29 01:00:36 -04:00
mark_story
756baeafdb Making CakeErrorController get the most recent request, this will help when using requestAction.
Updating test cases for error404.
Updating ErrorHandler
2010-08-28 23:32:14 -04:00
mark_story
8712a90c8b Adding some tests for construction. 2010-08-28 22:50:29 -04:00
mark_story
a30721b46b Moving exception classes around and making all the core exceptions extend one class that overrides the code to 500. The code value will be used as the HTTP status code for the error page. 2010-08-28 22:49:52 -04:00
mark_story
5d942ee609 Extracting a few methods to make testing easier, and subclasses easier to create. 2010-08-28 19:53:21 -04:00
mark_story
5257a66fe5 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-08-28 11:26:28 -04:00
mark_story
26f4ad4da1 Modifying bootstrap so it sets a default exception handler.
Making a ghetto implementation of exception handling.
Adding a crude test case, adding incomplete markers to all other tests.
2010-08-28 01:39:02 -04:00
predominant
04d3353ee4 Adding access specifiers to methods 2010-08-28 15:38:48 +10:00
mark_story
9b3e91089a Adding omitted types of exceptions. 2010-08-28 01:38:03 -04:00
mark_story
5de88c0f02 Moving CakeErrorController to its own file. 2010-08-28 01:37:39 -04:00
predominant
f7addabcf2 Whitespace removal 2010-08-28 15:27:12 +10:00
mark_story
a2186c412a Updating doc blocks for CakeRequest and CakeResponse. 2010-08-28 00:59:07 -04:00
mark_story
d8b2bcdf06 Making view + helpers groups pass. 2010-08-28 00:40:12 -04:00
mark_story
9485f0a993 Merge branch 'request-response' into 2.0
Conflicts:
	cake/tests/cases/libs/controller/controller.test.php
2010-08-28 00:24:07 -04:00
mark_story
e4545dbe5e Fixing failing tests in Dispatcher.test. 2010-08-28 00:19:09 -04:00
mark_story
c76f205bcb Adding exceptions file. 2010-08-28 00:18:46 -04:00
mark_story
2cdb10812d Merge branch '2.0-exceptions' into 2.0
Conflicts:
	cake/dispatcher.php
	cake/libs/controller/scaffold.php
	cake/tests/cases/dispatcher.test.php
2010-08-28 00:14:34 -04:00
mark_story
dc67b9cacc Moving all the exceptions into one file for the short term. 2010-08-28 00:08:35 -04:00
José Lorenzo Rodríguez
f63b093d24 Merge branch '2.0-request' into 2.0
Still tons of tests failing
Conflicts:
	cake/dispatcher.php
	cake/libs/controller/components/auth.php
	cake/libs/controller/components/request_handler.php
	cake/libs/controller/components/security.php
	cake/libs/controller/controller.php
	cake/libs/router.php
	cake/libs/view/helper.php
	cake/libs/view/helpers/html.php
	cake/libs/view/view.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/controller/components/auth.test.php
	cake/tests/cases/libs/controller/components/request_handler.test.php
	cake/tests/cases/libs/controller/components/security.test.php
	cake/tests/cases/libs/controller/controller.test.php
	cake/tests/cases/libs/router.test.php
	cake/tests/cases/libs/view/helper.test.php
	cake/tests/cases/libs/view/helpers/cache.test.php
	cake/tests/cases/libs/view/helpers/form.test.php
	cake/tests/cases/libs/view/helpers/html.test.php
	cake/tests/cases/libs/view/helpers/js.test.php
	cake/tests/cases/libs/view/helpers/paginator.test.php
2010-08-27 23:31:41 -04:30
mark_story
0683dc43ff Replacing cakeError calls with exceptions in ConnectionManager and Model. 2010-08-27 23:54:22 -04:00
mark_story
c4cb629d80 Replacing cakeError with exceptions in Scaffold. 2010-08-27 23:54:00 -04:00
mark_story
b301b0d86e Adding MissingModelException. 2010-08-27 23:04:35 -04:00
mark_story
4cc2229641 Updating CacheHelper to use correct View API.
Updating View to make CacheHelper tests pass.
2010-08-26 23:24:09 -04:00
mark_story
b02e213958 Adding test case from '0x20h'. Fixing issue where atomic = false, validate = first and saveAll() saving many rows could return an incorrect value. Fixes #1050 2010-08-26 22:21:39 -04:00
mark_story
ea9e30890f Adding a workaround to DboSource::showLog() to work around fix added in [da9c0da626].
Also adding explanation message when logs are not generated.
2010-08-26 21:24:09 -04:00
dogmatic69
95168cee6e casting the find as an array to avoid errors with array_values() fixes #1041 and 4 failing tests (3 previous)
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-26 20:32:48 -04:00
mark_story
ece055eefe Adding object type check to prevent fatal errors caused by view being used like a model object. Tests added. Fixes #1039 2010-08-23 21:39:23 -04:00
Juan Basso
65726841cd Merge branch 2.0-xml of github.com:cakephp/cakephp into 2.0-xml 2010-08-23 01:49:42 -03:00
Juan Basso
f8b4d92a34 Arrays with @ as key now is the value of tag in Xml. 2010-08-23 01:33:06 -03:00
mark_story
ac36bc5894 Adding some docblocks to Xml. 2010-08-23 00:01:55 -04:00
Juan Basso
f777bd983f Making Xml::fromArray() parse @ in attibutes keys. 2010-08-23 00:48:34 -03:00
Juan Basso
9611ab1027 Changing to Xml::toArray() return @ after attributes to dont conflict with tags with same name. 2010-08-23 00:24:56 -03:00
mark_story
b5b7595bc0 Fixing issue in scaffold where it accessed $output, which no longer exists. 2010-08-22 12:41:04 -04:00
mark_story
7221f9c3b9 Moving response construction into Controller, this will let controller classes more easily modify the response subclass they want to use.
Test case updated.
2010-08-22 12:31:55 -04:00
mark_story
efc1a2033f Adding spaces infront of comment blocks. 2010-08-22 00:48:24 -04:00
mark_story
ec22db597f Adding methods to get host, domain and subdomains for a request.
Tests added.
2010-08-22 00:44:05 -04:00
mark_story
0ec0962932 Adding CakeRequest::method() to find the name of the HTTP method name used for the request. Test case added. 2010-08-22 00:15:13 -04:00
mark_story
5446a062ee Fixing issue where whitelist would not be used for validation. Test case added. Fixes #1037 2010-08-21 22:48:59 -04:00
mark_story
12d4b52f10 Fixing failing tests in DboMysql and DboPostgres related to localized floats. Refs #1029 2010-08-21 00:49:40 -04:00
mark_story
e23fe25787 Fixing code formatting. 2010-08-21 00:17:40 -04:00
zimakm
b22f2f746b Configure fix problem 3-dimensional arrays to be handled as 4+ arrays.
This saves a lot of execution time when configure holds many values.
Fixes #1028

Signed-off-by: mark_story <mark@mark-story.com>
2010-08-18 22:29:23 -04:00
mark_story
6d8c761f2f Adding a missing s. 2010-08-17 22:25:45 -04:00
mark_story
750fe3aa05 Removing text() and password() as the new __call method handles them.
Updating test cases and adding a test for allowing a magic method to override the type.
2010-08-17 00:13:22 -04:00
mark_story
4efc170ce4 Adding some documentation. 2010-08-17 00:08:41 -04:00
mark_story
e79df23491 Adding a magic __call method to handle html5 inputs and simplify input generation logic. 2010-08-17 00:06:23 -04:00
mark_story
f46241a6e7 Merge branch '2.0' into 2.0-helpers 2010-08-16 23:02:44 -04:00
mark_story
fc9340213e Applying patch from 'thatcode', makes the 'us' rule case insensitive. Fixes #1020 2010-08-16 22:26:48 -04:00
mark_story
c4a978d386 Adding changes missed in the merge. 2010-08-15 23:10:29 -04:00
mark_story
705e90bef7 Merge branch '1.3' into 2.0-merge
Conflicts:
	cake/libs/cache/memcache.php
	cake/libs/cake_session.php
	cake/libs/model/behaviors/acl.php
	cake/tests/cases/dispatcher.test.php
	cake/tests/cases/libs/cake_test_fixture.test.php
	cake/tests/cases/libs/model/behaviors/acl.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
2010-08-15 23:09:02 -04:00
mark_story
2a50c3a1fb Removing time manipulation so its possible to create memcache entries that do not expire. Updating documentation about the peculiarities of memcache. Refs #871 2010-08-15 22:40:55 -04:00
mark_story
0865679684 Removing _expires keys made with Memcache cache engine. These did not add any value as Memcache already handles expiration of keys. Fixes #871 2010-08-15 22:32:52 -04:00
mark_story
686b9c2c8b Fixing issues in alterSchema in DboMysql and DboPostgres, where fields would be appended to each table being altered.
Also fixed an issue in DboPostgres where the generated alter statements would contain too many ;.
Test cases added.  Fixes #1023
2010-08-15 22:17:02 -04:00
mark_story
1b41a987fa Adding test cases and fixing inflection issues with bases. Tests added. Fixes #1012 2010-08-12 20:26:11 -04:00
mark_story
45064315d4 Fixing a comment. 2010-08-11 22:47:20 -04:00
mark_story
bd89ef533b Updating session helper constructor to fix failing tests in Controller::render() integration tests. 2010-08-11 00:01:24 -04:00
mark_story
74a12940cb Removing incorrect method implementation.
Adding documentation to Component::beforeRedirect()
Adding documentation to ObjectCollection::trigger().
2010-08-10 23:45:28 -04:00
mark_story
2494156e9a Removing reference operators that caused tests to fail.
Adding an alias as several tests relied on a User object being in the registry to autodetect fields.
2010-08-10 23:18:43 -04:00
mark_story
f5bebc9306 Adding an Acl property to AuthComponent and updating tests to use new API's 2010-08-10 23:18:42 -04:00
mark_story
c6a63bae82 Fixing incorrect method call from merge with 1.3 2010-08-10 23:18:42 -04:00
mark_story
db1acb461a Making SessionComponent extend Component. Updating test case. 2010-08-10 23:18:42 -04:00
mark_story
6dbe5b09f8 Fixing failing test caused by undefined variable. 2010-08-10 23:18:42 -04:00
mark_story
5068d62473 Fixing issue that came up in rebasing. 2010-08-10 23:18:42 -04:00
mark_story
d01708b1ef Adding temporary $View property to controller until I figure out a better way to provide access for it. Test case updated to reflect View not being in the registry anymore. 2010-08-10 23:18:42 -04:00
mark_story
07a7e18dc7 Removing ClassRegistry access in RssHelper. 2010-08-10 23:18:41 -04:00
mark_story
65c235023d Removing ability to register View and ThemeView into ClassRegistry. 2010-08-10 23:18:41 -04:00
mark_story
dfa5273b22 Making SessionHelper not use ClassRegistry to access View. SessionHelper still needs to not inherit from CakeSession. 2010-08-10 23:18:41 -04:00
mark_story
576eba3ef9 Removing ClassRegistry use from FormHelper and its test case. 2010-08-10 23:18:41 -04:00
mark_story
90b0ac7258 Removing remaining ClassRegistry::getObject() in HtmlHelper. 2010-08-10 23:18:41 -04:00
mark_story
7b3f2f7e6e Updating methods in Helper to use $this->_View. 2010-08-10 23:18:41 -04:00
mark_story
7efe1636aa Making HtmlHelper not use ClassRegistry to access the View instance. Updating test cases. 2010-08-10 23:18:41 -04:00
mark_story
19f008b1a4 Fixing broken tests in HelperCollectionTest
Moving unload into ObjectCollection as its common between 2 child classes, and possibly a 3rd.
2010-08-10 23:18:40 -04:00
mark_story
426d35d66e Fixing string that got changed in a rebase. 2010-08-10 23:18:40 -04:00
mark_story
0f5e881f26 Fixing typo. 2010-08-10 23:18:40 -04:00
mark_story
7b4916e16a Updating AclComponent to new Component API. 2010-08-10 23:18:40 -04:00
mark_story
a4e2f7c55f Updating intialiize() callbacks. Moving $this->_set() int Component::__construct as all the core components did it. Updating constructors and including parent calls. 2010-08-10 23:18:40 -04:00
mark_story
052c81774c Removing some code duplication. 2010-08-10 23:18:40 -04:00
mark_story
22fbc24560 Adding 'collectReturn' option to ObjectCollection::trigger. lets a callback collect the return of each object and return that.
Adding tests.
2010-08-10 23:18:40 -04:00
mark_story
fac97738ce Making Controller use ComponentCollection. 2010-08-10 23:18:39 -04:00
mark_story
256532b8e4 Updating Components to use Component as the parent class. 2010-08-10 23:18:39 -04:00
mark_story
bf75ab5737 Starting to update Component into a base class instead of a loader class. 2010-08-10 23:18:39 -04:00
mark_story
3666643b84 Adding ComponentCollection and a test case. 2010-08-10 23:18:39 -04:00
mark_story
337ab19145 Updating ObjectCollection::trigger() so it doesn't call __get().
Updating HelperCollection test which was passing by coincidence.
2010-08-10 23:18:39 -04:00
mark_story
62019888ba Changing file headers to reflect accurate licences and versions created. 2010-08-10 23:18:39 -04:00
mark_story
c44c276fa3 Removing ModelBehavior::dispatchMethod(), replacing with call_user_func_array() as its faster and the php4 workaround is no longer needed. 2010-08-10 23:18:39 -04:00
mark_story
409b12954b Simplifying logic and data structures used to store enabled-ness of objects in an object collection. 2010-08-10 23:18:39 -04:00
mark_story
b2250852e4 Moving BehaviorCollection into its own file.
Changing how behaviors are stored in the collection object.  Makes it work the same as HelperCollection.
2010-08-10 23:18:39 -04:00
mark_story
fcbfb556c5 Moving loaded helpers into a protected array.
Adding magic methods to access the object array.
2010-08-10 23:18:39 -04:00
mark_story
c78e869be6 Removing PHP4 workarounds in BehaviorCollection.
Making BehaviorCollection throw exceptions instead of use cakeError.
2010-08-10 23:18:39 -04:00
mark_story
d048813af8 Adding in property copying until this branch gets merged with 2.0-request. 2010-08-10 23:18:39 -04:00
mark_story
6a88452072 Updating TextHelper to not use create_function(). The create_function calls leaked memory and didn't work with the new helper constructors. 2010-08-10 23:18:38 -04:00
mark_story
4672cee5d3 Removing dispatchMethod from JsHelper, its not really that useful, and is good at hiding bugs in mock tests.
Updating test cases.
2010-08-10 23:18:38 -04:00
mark_story
0e933e8893 Updating most helper test cases to use View in their constructors. 2010-08-10 23:18:38 -04:00
mark_story
68ff2e5ce5 Adding additional tests for Helper lazy loading. 2010-08-10 23:18:38 -04:00
mark_story
fc3379767d Moving methods around. ObjectCollection now normalizes helpers arrays. Plugin helpers now lazy load.
Tests updated.
2010-08-10 23:18:38 -04:00
mark_story
98982a6f7a First attempt at lazy loading helpers done. Plugin support not complete. 2010-08-10 23:18:38 -04:00
mark_story
ab815a53ba Helper test case is passing again. 2010-08-10 23:18:37 -04:00
mark_story
087ccabffe Starting to modify Helper constructors. 2010-08-10 23:18:37 -04:00
mark_story
1d983e1cd4 Making MissingView and MissingLayout cake errors into exceptions. 2010-08-10 23:18:37 -04:00
mark_story
a23207791a Modifying View to accept HelperCollection. Removing methods that are no longer needed. 2010-08-10 23:18:37 -04:00
mark_story
f8ecb10407 Adding stub callbacks so errors aren't generated. 2010-08-10 23:18:37 -04:00
mark_story
c15d228515 Initial integration of HelperCollection into View. 2010-08-10 23:18:37 -04:00
mark_story
16d5b2655c Adding a way to load helpers in a disabled state. Updating tests and subclasses. 2010-08-10 23:18:37 -04:00
mark_story
d0de468ce0 Removing options that were not used in the generic application. 2010-08-10 23:18:37 -04:00
mark_story
aa61a251dc Deprecating BehaviorCollection::attach() and BehaviorCollection::detach(). load() and unload() are more generic and make sense in other contexts.
Adding base trigger implementation.
Adding tests for helper triggering.
2010-08-10 23:18:37 -04:00
mark_story
9fd881cb00 Moving methods down and adding some tests. 2010-08-10 23:18:36 -04:00
mark_story
6db3dbc680 Starting to create HelperCollection which will be responsible for loading and constructing helpers.
Making an abstract class that will be the base of all object collections.
Adding test cases.
2010-08-10 23:18:36 -04:00
mark_story
da9c0da626 Changing sql_dump element so it only shows if there is no $logs variable set in the view. Overwriting it could adversely effect helper references. Fixes #998 2010-08-10 23:09:27 -04:00
mark_story
1371cefc3d Applying patch from 'thatcode' to fix an issue where FormHelper::datetime() would not use 'default' or 'value' keys like other inputs would. This corrects an unintentional inconsistency in the methods. Test cases added. Fixes #988 2010-08-09 23:49:18 -04:00
mark_story
29ddffa2d3 Fixing regression in DboMysqlBase where describe() was no longer pulling out fieldParameters. A test case has been added to catch any future regressions. Fixes #991 2010-08-09 23:25:32 -04:00
mark_story
ccfb1d179a Expanding test and fixing issue where the return of Folder::create() would be incorrect even though the directory was properly created. Fixes #996 2010-08-09 22:56:41 -04:00
mark_story
d6e3c318cd Merge branch '1.3' of github.com:cakephp/cakephp into 1.3 2010-08-04 23:59:17 -04:00