Commit graph

1133 commits

Author SHA1 Message Date
nate
ad208ff8c3 Refactoring previous fix to revert markup changes in HtmlHelper, updating FormHelper tests to comply with coding standard, correcting bad assertions, fixing issue with field types being mis-identified if duplicate names are used, fixes #5919
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7959 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-25 22:13:06 +00:00
nate
61850b1be1 Cleaning up test code formatting, adding fix for POST hash validation of checkbox lists, fixes #5903, test cases added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7951 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-23 08:13:00 +00:00
nate
e2c087f34b Fixing failing tests in JavascriptHelper.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7944 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-19 01:30:02 +00:00
john
a1046de895 Couple of syntax fixes - missing semicolon and usage of empty() inside a conditional.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7933 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 18:09:32 +00:00
nate
870c4e87ca Fixing code formatting in JavascriptHelper to wrap at 100 characters, small return-home-early refactoring.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7931 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 16:08:31 +00:00
mark_story
9071d8165f Correcting generation of id attributes for radio buttons. Tests added, fixes #5891
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7924 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-17 01:49:58 +00:00
mark_story
b2b4c4be47 Adding App::import() to app_helper files. Fixes issues with Missing Helper Class, and allows you to use helpers in shell classes. Fixes #5458
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7904 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-05 16:49:43 +00:00
gwoo
4dd105d415 fixes #5829, form helper using proper method reference for parseAttributes. A patch would have been nice, but some ticket submitters prefer not to make much effort.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7902 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-12-01 19:39:40 +00:00
mark_story
c49f213fcf Adding spaces before self close of meta link elements. W3C recommends a space before />. Fixes #5821
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7899 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-30 05:25:37 +00:00
mark_story
090028403b Fixing FormHelper dateTime creation when using custom empty strings and null values. Tests added. Fixes #5769
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7898 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-29 00:28:31 +00:00
mariano.iglesias
f9557c7611 Fixing issue where radio elements would produce wrong hash when Security component enabled in FormHelper, fixes #5791
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7891 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 16:32:54 +00:00
phpnut
69f883a89f Adding $data['attrib'] back to RssHelper::channel(); after more research use cases for this were found.
Related test case added

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7889 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 05:54:31 +00:00
mark_story
cfa2229689 Fixing incorrect implementation of RssHelper::channel(). Test cases added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7887 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-24 23:10:29 +00:00
mark_story
ace8ef4b5a Applying patch from 'tyler'. Updates Ajax helper to reflect updated scriptaculous API. See http://github.com/madrobby/scriptaculous/wikis/ajax-inplaceeditor. Fixes #5790
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7885 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-24 05:23:31 +00:00
nate
ab152bd291 Updating AjaxHelper docblocks and fixing code formatting -- lines wrap at 100 characters. Fixes #5701.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7852 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 22:15:43 +00:00
mariano.iglesias
e9953e3f93 Fixing issue where JavascriptHelper::link was generating wrong URLs when webroot is defined and appending timestapping. Fixing issue in previous commit. Fixes #5723, fixes #5045
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7851 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 12:45:00 +00:00
mariano.iglesias
81e2f4a044 Fixing commit in r7843 so real files are accounted for
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7850 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 12:34:51 +00:00
renan.saddam
6319f8ea69 Removed trailing whitespaces from core.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7847 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 02:54:07 +00:00
mariano.iglesias
8777b8ef96 Fixing issue where double call to webroot on HtmlHelper::css was generating wrong URLs when forcing asset timestamp, fixes #5723
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7843 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 00:24:51 +00:00
mariano.iglesias
8da2a5208f Adding multibyte support to TextHelper::truncate, fixes #5610
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7842 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-08 00:07:17 +00:00
AD7six
3f2fa6929b changing tabs for spaces in comment block indentation
Removing address and replacing with cakefoundation url


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7805 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 17:30:26 +00:00
nate
40bf675589 Refactoring DboSource to remove use of str_split, adding $read (false to calls to) DboSource::value() inside DboSource::create(), cleaning up code formatting, fixes #5598, fixes #5682
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7802 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 05:03:01 +00:00
renan.saddam
41d82920f5 Fixing issue with rounded values in NumberHelper::toReadableSize. Fixes #5676.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7790 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-29 01:15:59 +00:00
mark_story
97cd2c5aef Committing patch from 'fernyb' to add support for with key in AjaxHelper::autoComplete()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7785 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-26 23:47:00 +00:00
mark_story
5a2db7a5b4 Fixing interaction between Model::_clearCache() and CacheHelper. Cached view files for camelCased controller or underscored URL's were not being cleared. Fixes #5611
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7783 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-26 18:51:38 +00:00
mark_story
2d1483e1e5 Updating formHelper::dateTime() to work correctly with string timestamp values. Closes #5621
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7781 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-26 14:53:06 +00:00
nate
16e2579f01 Correcting Security component to treat POST data arrays as a single field for validation purposes, fixes #5588
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7774 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 03:18:08 +00:00
mark_story
1b456f2cf1 Applying patch from 'davidpersson' fixing code spacing. Closes #5643
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7772 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 00:10:44 +00:00
mark_story
5c962accc1 Fixing timehelper::fromString when input time is invalid.
Tests added and renamed for better consistentancy with other tests.
Closes #5556

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7713 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-08 17:19:07 +00:00
mark_story
acce4fa54e Adding interval to minute() attributes when timeformat = 24.
Tests added.
Closes #5428, refs #4641

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7711 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-07 16:57:22 +00:00
nate
b29f805632 Allowing $attributes param of FormHelper::select() to be null, fixes #5518
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7697 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-03 21:55:41 +00:00
nate
badfb42c6a Fixing issue with file upload inputs not being factored into form security hash, closes #5489
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7678 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-29 16:23:39 +00:00
mark_story
bf3e254987 Removing secure() from FormHelper::submit(). Removes creation of multiple _Token inputs when multiple submit buttons are created. Fixes #5490.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7677 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-29 01:58:27 +00:00
nate
eb7fb6d7e3 Re-implementing form hashing security to using string-based keying. Fixes #5262, fixes #5300
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7658 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-24 23:02:14 +00:00
DarkAngelBGE
cc425a5e0a adding a couple whitespace corrections (trailing tabs, newlines, ..)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7654 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-24 11:52:29 +00:00
nate
80c1950530 Refactoring FormHelper security token generation, fixing code formatting
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7639 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-21 04:06:37 +00:00
phpnut
8ae5866a1c Additional optimization refactoring
Removed ability to use deprecated / with plugin, helper, etc combinations. The dot notation is only allowed from this point forward.
Corrected tests for the above changes.
Corrected formating in basics.php

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7623 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-18 03:09:19 +00:00
mark_story
44cf61b240 Updating doc blocks for ajax helper. Closes #5426
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7606 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-15 04:03:15 +00:00
nate
dba8d8740d Adding object hook calls for JsHelper
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7562 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-07 03:26:58 +00:00
mark_story
e5cfd69636 Adding test layout with cake:nocache tags.
Adding tests to CacheHelper
Fixing CacheHelper not parsing cake:nocache after $content_for_layout when view file has cake:nocache tags as well.
Closes #5275

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7560 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-05 21:41:07 +00:00
nate
ccc602c82a Updating PaginatorHelper::options() docblock and adding test cases to demonstrate correct usage, closes #5380
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7556 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-04 19:10:15 +00:00
mariano.iglesias
46620f8ee2 Fixing issue where reference fatal is thrown with PHP 5.0.5
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7552 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-04 13:35:04 +00:00
mark_story
c58e58a491 Adding tests for secured forms. Fixes the issues related to checkboxes in multi row forms.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7533 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-29 03:11:35 +00:00
mark_story
c4b4c25402 Removed BOM from form.php. Closes #5317
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7497 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-25 14:57:37 +00:00
mark_story
9ae4975bff Applied patch from 'biscazziere' updated TimeHelper::timeAgoInWords() to be i18n friendly. Closes #5082.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7496 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-25 03:15:10 +00:00
mark_story
792863a3b4 Adding test to illustrate #5302. Corrected Error in doc block. Closes #5302
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7487 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-22 17:50:32 +00:00
nate
6f660812ca Adding FormHelper security token patch from renan.saddam, fixes #5061, adding test to disprove #2729 (FormHelper::input() and float fields)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7486 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-22 16:05:34 +00:00
mark_story
3fb44e4485 Adding 'submitOnBlur' to $editorOptions. Closes #5263
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7467 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-14 21:03:15 +00:00
mark_story
a180071f6c FormHelper::checkbox() now sets name of hidden field when name option is set. Closes #5224
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7449 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-09 22:08:17 +00:00
mark_story
9e51a64f87 Adding additional doc block explanations for method options.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7446 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-08 12:29:49 +00:00