Commit graph

9428 commits

Author SHA1 Message Date
mark_story
22497eb41c Fixing failing tests in controller test. 2010-11-07 13:23:45 -05:00
mark_story
88c717dbd8 Removing the 3rd param from ObjectCollection::load() and adding a uniform setting of 'callbacks'. This setting is used to disable callbacks on objects by convention. Test cases updated. 2010-11-07 13:23:45 -05:00
mark_story
1ba28c246b Adding settings['callbacks'] as a way to define enabled/disabled state of helpers in settings arrays. This should replace the separate parameter.
Tests updated.
2010-11-07 13:23:45 -05:00
mark_story
92fec4588a Making private things protected. 2010-11-07 13:23:45 -05:00
mark_story
4c0fd76a2e Changing <cake:nocache></cake:nocache> into <!--nocache--><!--/nocache--> This makes no cache tags valid html/xml at all times, and will not interfere with validation. 2010-11-07 13:23:45 -05:00
mark_story
4739d7f955 Adding tests for CacheHelper callback methods. 2010-11-07 13:23:45 -05:00
mark_story
f7f9c3f6a2 Removing a test case that doesn't need to exist anymore as the conditions for cache generation are now in CacheHelper. 2010-11-07 13:23:44 -05:00
mark_story
c92ecdcd1b Initial pass at decoupling CacheHelper from View.
CacheHelper does all caching using helper callbacks now.
2010-11-07 13:23:43 -05:00
mark_story
1bc6433ecd Removing duplicate import() and fixing missing dependency. 2010-11-07 13:23:43 -05:00
mark_story
23c69b2bfb Adding an import, as I hit an error when trying to bake tests for models. 2010-11-07 13:23:43 -05:00
mark_story
aaff059132 Moving output into a property, and removing extra arguments from helpers. Having a view property reduces the number of strings that are copied around. 2010-11-07 13:23:43 -05:00
mark_story
2dff74d037 Removing local and using output property. 2010-11-07 13:23:43 -05:00
mark_story
2e140a9fd3 Adding tests for element callbacks. 2010-11-07 13:23:43 -05:00
mark_story
32587c154c Adding callback support to elements. You can use the 3rd parameter to control whether or not before/afterRender callbacks should be fired for a particular element. 2010-11-07 13:23:43 -05:00
mark_story
1b19ad48b4 Adding parameters to helper callbacks, these allow helpers to introspect more on the view/layout being rendered.
Updating tests.
2010-11-07 13:23:42 -05:00
mark_story
882efa883e Removing the trigger_error and view re-renders and replacing them with exceptions. 2010-11-07 13:23:42 -05:00
mark_story
76919902b9 Removing direct tests of protected method.
Refactoring View with the intention of eventually removing coupling with CacheHelper.
Making Helpers load after the first rendering method is called.
Moving callbacks out of _render() to make logic simpler, and with the idea that elements will get a callback too.
2010-11-07 13:23:42 -05:00
mark_story
540f1426be Removing View::error(). Instead you should be handling error states in your controller, or throwing exceptions and letting the application error handling deal with the error. 2010-11-07 13:23:42 -05:00
mark_story
3f61fa004e Removing dead import. 2010-11-07 13:23:42 -05:00
Mark Story
8f31ef7149 Making $scripts_for_layout and $content_for_layout regular viewVars. This will allow helpers to manipulate them in callbacks.
Made $___dataForView an optional parameter, it defaults to $this->viewVars if left undefined. Refs #624
2010-11-07 13:23:42 -05:00
Mark Story
157bdfafc6 Moving beforeLayout, before additional viewVars are processed. Refs #624 2010-11-07 13:23:42 -05:00
mark_story
09d3a0626a Updating l10n to use the new CakeRequest method. 2010-11-07 01:38:25 -04:00
mark_story
22bb07abb0 Adding visibility to a few methods. 2010-11-07 01:36:37 -04:00
mark_story
1424e02488 Adding a method to CakeRequest to parse out the accept-language header. This will help remove features from l10n. 2010-11-07 01:35:36 -04:00
mark_story
af303f01c7 Fixing baked actions to use request object.
Fixes #1091
2010-11-07 01:08:58 -04:00
ADmad
eb76ab95f2 Fixed issue where Model::saveAll() would incorrectly commit a transaction which was not started in that function call itself. 2010-11-06 09:33:50 +05:30
mark_story
268dae722e Reverting change from [16387f1961]. Using
the constant caused a number of issues for several other people. Refs #1231
2010-11-05 22:31:41 -04:00
mark_story
d56b812181 Fixing issue where an array to string conversion error could occur if you had multiple values for a model's primary key and you created a matching form. Tests added.
Fixes #1257
2010-11-04 21:08:40 -04:00
ADmad
81ce6f40b9 Added test cases showing usage of 'full_base' key for url generation. Refs #1256 2010-11-04 17:59:23 +05:30
José Lorenzo Rodríguez
3a8016b875 Even more methods containing quoting specific to mysql out of DboSource 2010-11-03 19:59:15 -04:30
José Lorenzo Rodríguez
6028705c72 Moving more methods out from DboSourceTest 2010-11-03 19:52:49 -04:30
José Lorenzo Rodríguez
1c37751038 Adding missign option to testsuite shell 2010-11-03 19:41:17 -04:30
José Lorenzo Rodríguez
a39adf213e Adding missign option to testsuite shell 2010-11-03 19:40:48 -04:30
José Lorenzo Rodríguez
86f1309a54 iMoving a couple of methods out from DboSourceTest 2010-11-03 19:40:09 -04:30
José Lorenzo Rodríguez
f2f378ca73 Moving testGenerateInnerJoinAssociationQuery out from DboSourceTest 2010-11-03 19:35:15 -04:30
José Lorenzo Rodríguez
605a6b17a5 Moving another method out of DboSourceTest 2010-11-03 19:18:51 -04:30
José Lorenzo Rodríguez
146af7faa5 Stating to move quoting test out from dbosource into mysql test 2010-11-03 19:14:22 -04:30
José Lorenzo Rodríguez
3b133a4142 Merge remote branch 'origin/2.0' into feature/2.0/pdo 2010-11-03 19:02:28 -04:30
José Lorenzo Rodríguez
224f65af05 Preventing bug in testsuite shell 2010-11-03 18:56:06 -04:30
José Lorenzo Rodríguez
557c5274e8 Making file argument optional in console testsuite in order to show complete list of test cases for a category 2010-11-03 01:27:37 -04:30
José Lorenzo Rodríguez
9afd4d7875 Fixing option parsing and help for testsuite after new console libraries merge 2010-11-03 01:25:27 -04:30
José Lorenzo Rodríguez
eedd823fd8 Merge remote branch 'origin/2.0' into feature/2.0/pdo 2010-11-03 00:23:18 -04:30
mark_story
bff711e2dc Merge branch '2.0-console' into 2.0
Conflicts:
	cake/console/shells/acl.php
	cake/tests/cases/console/libs/tasks/plugin.test.php
2010-11-02 23:49:19 -04:00
Juan Basso
b0a600f925 Merge branch '2.0-post-method' into 2.0 2010-11-03 01:42:06 -02:00
Juan Basso
adb2d90b9a Changed the regex to follow the RFC 3986, working to protocols like "svn+ssh://" and "ed2k://" 2010-11-03 01:26:41 -02:00
mark_story
c9ca3c3785 Fixing path constants in DbConfig and FixtureTask to be more consistent between web and cli. 2010-11-02 23:25:36 -04:00
Juan Basso
b752766d6c Using full base when $url is empty. 2010-11-03 01:16:38 -02:00
mark_story
6d54202c4c Adding another group test case file for all the console tests at once. 2010-11-02 23:15:33 -04:00
mark_story
d1403b0da8 Changing NumberHelper::currency() to format < 1euro based on the suggestions from 'Joel Haasnoot'. Instead of 99c you will get €0,99.
Test cases updated.  Fixes #1253
2010-11-02 21:56:24 -04:00
mark_story
2403d7fedc Applying updates to skel/core.php. Fixes #1255 2010-11-02 21:43:33 -04:00