Commit graph

1444 commits

Author SHA1 Message Date
mark_story
3a7f44e04c Updating the doc blocks for TreeBehavior::moveup/movedown to indicate that
number can be either an integer or a boolean.
Fixes 
2011-04-19 21:02:33 -04:00
mark_story
6cc1688d4e Fixing issue where DboMysql would perform joins on delete queries even if the conditions did not require joins. Added a more intelligent join detector, that removes joins if all the conditions are simple. This will only be able to optimize array conditions.
Test cases added.  Fixes 
2011-03-24 23:25:56 -04:00
mark_story
532555b94b Fixing order condition quoting to allow fields with - in them. Fixes 2011-03-24 22:28:11 -04:00
Ceeram
e9011badb5 Ensure both node() and afterSave() use ->name
Fixes 
2011-02-28 21:43:33 -05:00
mark_story
8d5e68d582 Fixing issue where habtm tables would not have the connection prefix removed when generating schema. Fixes 2011-02-05 11:19:05 -05:00
mark_story
71d8e744f1 Fixing case-sensitivity of AS in fields. Tests added. Fixes 2011-01-26 20:58:16 -05:00
mark_story
d192ed32f0 Adding a socket key to DboMysqli::$baseConfig. Fixes notice errors when socket is undefined. Fixes 2011-01-26 20:54:14 -05:00
mark_story
32f0b20a33 Removing wonky and most likely incorrect manipulation of socket and port
setting mangling in DboMysqli.  Fixes 
2011-01-24 22:05:16 -05:00
mark_story
ed7f8d1906 Fixing issue where DboPostgres used the wrong type for boolean columns with a default of false or true.
Added a test case.
Changing Model::create() so it doesn't wipe out default values === false.
Fixes 
2011-01-21 13:31:33 -05:00
mark_story
f893e3b63b Applying patch from 'ryandesign' fixing incorrect datetime formats. Fixes 2011-01-11 20:16:42 -05:00
mark_story
04929ae1df Applying patch from 'Thorsten Buss'.
Fixes issues in DboSource, where mismatching types on join columns could result in incorrect query generation.
Fixes 
2010-12-21 20:40:19 -05:00
mark_story
15ca2400bc Fixing issue in DboSource::name() where special characters in column names would not be correctly quoted.
Tests added.
Fixes 
2010-11-25 06:52:23 -05:00
mark_story
bf10723f89 Applying patch from 'michealc' to fix duplicated comments. Fixes 2010-11-22 21:21:55 -05:00
mark_story
e8678b38ac Adding specific conditions to model->delete's call to dbo->delete. This
helps fix a race condition where dbo->defaultConditions could cause
additional data loss.  Fixes 
2010-11-08 21:50:45 -05:00
ADmad
eb76ab95f2 Fixed issue where Model::saveAll() would incorrectly commit a transaction which was not started in that function call itself. 2010-11-06 09:33:50 +05:30
Mark Story
e6aeae8935 Fixing issue where value in difference array was always the string value instead of the original value. 2010-10-31 22:44:45 -04:00
mark_story
f5fd069583 Applying patch from 'Justas Butkus' to fix CakeSchema::compare()
Fixes issues with comparing null == '' and adds a new protected method to handle null aware array difference generation.
Tests added.
Fixes 
2010-10-27 23:03:31 -04:00
mark_story
7c296211ef Making generating schema for connections with prefixes work correctly. The prefix needs to be removed so that when tables are created or updated they do not get the prefix added twice.
Moving tests around. Fixes 
2010-10-20 23:17:04 -04:00
mark_story
498417203b Making DboSource::fields() use cacheMethod() so it respects $cacheMethods.
Test added.
Fixes 
2010-10-20 22:28:31 -04:00
mark_story
d56416456c Applying patch from 'Justas Butkus' to DboSource
Fixes issues where reconnect could issue warnings related to
array_merge.  Fixes 
2010-10-11 21:52:10 -04:00
mark_story
5e26d282a1 Fixing connection specific schema generation
Fixing missing table errors when reading schema for specific connections.
Tests updated to check that tables not on a connection are never touched.  Fixes 
2010-09-30 23:22:57 -04:00
mark_story
c573fd0432 Fixing issue where a beforeDelete() could trigger a table truncation.
Moving the exists check below beforeDelete() and behavior->beforeDelete() so any records deleted in the callbacks will not exist when db->delete() is called.  Test updated. Fixes 
2010-09-29 23:31:41 -04:00
mark_story
b08aba8e86 Adding a missing rollback when validation on an associated record fails, and validate = first. Fixes 2010-09-28 23:37:28 -04:00
mark_story
a4746c7227 Applying patch from 'kworr' to reorder the switch in DboPostgres::value() to fix issues with pgsql 9.0. Fixes 2010-09-24 22:47:18 -04:00
mark_story
8cd266c77f Correcting example in doc block. Fixes 2010-09-24 22:23:24 -04:00
mark_story
729a45703b Fixing issue where table names with spaces would not be quoted by name(). Fixes 2010-09-21 20:34:27 -04:00
mark_story
d113d7d612 Removing dead code from DboSource::fields()
Updating fields() to use implode, so complex virtual fields are better handled.  Fixes 
2010-09-18 00:04:36 -04:00
mark_story
5a8648cca0 Fixing issue in DboSource::_matchRecords() where unqualified conditions would result in 1=1 conditions. Fixing incorrect test case. Fixes 2010-09-16 00:17:09 -04:00
Mark Story
e15069769d Adding tests for and fixing some formatting. 2010-09-07 00:09:06 -04:00
Mark Story
c60edfae6d Fixing issue where errors containing code = 500, were not actually converted to error500 when debug = 0. Making missingConnection, and missingTable into error500 errors. 2010-09-06 16:46:41 -04:00
ADmad
bfaaa6b8ba Fixing unnecessary extra calls to 'afterFind' callback of 'hasMany' associated models. Closes 2010-09-05 23:53:24 +05:30
mark_story
b02e213958 Adding test case from '0x20h'. Fixing issue where atomic = false, validate = first and saveAll() saving many rows could return an incorrect value. Fixes 2010-08-26 22:21:39 -04:00
mark_story
ea9e30890f Adding a workaround to DboSource::showLog() to work around fix added in [da9c0da626].
Also adding explanation message when logs are not generated.
2010-08-26 21:24:09 -04:00
dogmatic69
95168cee6e casting the find as an array to avoid errors with array_values() fixes and 4 failing tests (3 previous)
Signed-off-by: mark_story <mark@mark-story.com>
2010-08-26 20:32:48 -04:00
mark_story
5446a062ee Fixing issue where whitelist would not be used for validation. Test case added. Fixes 2010-08-21 22:48:59 -04:00
mark_story
12d4b52f10 Fixing failing tests in DboMysql and DboPostgres related to localized floats. Refs 2010-08-21 00:49:40 -04:00
mark_story
686b9c2c8b Fixing issues in alterSchema in DboMysql and DboPostgres, where fields would be appended to each table being altered.
Also fixed an issue in DboPostgres where the generated alter statements would contain too many ;.
Test cases added.  Fixes 
2010-08-15 22:17:02 -04:00
mark_story
29ddffa2d3 Fixing regression in DboMysqlBase where describe() was no longer pulling out fieldParameters. A test case has been added to catch any future regressions. Fixes 2010-08-09 23:25:32 -04:00
mark_story
509a9e14e2 Fixing condition missing a model name in the TreeBehavior. Fixes 2010-07-31 14:29:00 -04:00
mark_story
2b1efafe65 Applying optimization from 'michaelc' to reduce number of strtolower() calls in AclBehavior. Fixes 2010-07-29 22:04:22 -04:00
mark_story
d81d33ffe6 Adding some additional documentation for Model::find(). Fixes 2010-07-27 21:25:31 -04:00
Scott Reeves
b717abe1aa Fixing typo in Constructor description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:15:00 -04:00
mark_story
4c27c24a72 Fixing issue in DboSource where COUNT() was hardcoded, omitting any other aggregate functions. Replaced with a regexp that accepts only letters. Test case added. Fixes 2010-07-15 23:17:38 -04:00
mark_story
65efd675c1 Fixing fatal error caused by associated models using a datasource that is not a subclass of dbo_source. Test added. Fixes 2010-07-11 13:06:33 -04:00
mark_story
4cd43553b4 Fixing issues where multiple reset bindModel() calls would cause incorrect associations to be restored.
Also fixing issues where multiple calls to unbindModel() would cause incorrect associations to be restored.
Tests added.
Fixes 
2010-07-03 18:05:14 -04:00
mark_story
17a7a96ba2 Fixing issue where non-reset associations would get reset by resetAssociations if __backAssociations existed. Test cases from 'real34' added. Fixes 2010-07-01 12:39:50 -04:00
mark_story
e023350af5 Updating API docs related to DboSource::$cacheMethods. Fixes 2010-06-30 08:52:39 -04:00
Juan Basso
2a4489cdf2 Naming conventions to datasources with plugins. Fixes 2010-06-20 23:53:54 -03:00
mark_story
df3432aa86 Updating doc blocks in ModelBehavior. Refs 2010-06-11 09:55:39 -04:00
mark_story
e5df32e9d9 Adding omitted documentation information. 2010-06-10 14:23:49 -04:00