Commit graph

7682 commits

Author SHA1 Message Date
mark_story
b3febb483e Fixing incorrect use of Cache::gc(). It has no parameters for now. 2010-07-27 22:27:43 -04:00
mark_story
2f1aa0a97f Making CakeHtmlReporter dump a stack trace when an exception is caught. 2010-07-27 22:27:43 -04:00
mark_story
81f6f43193 Moving a few things around to better replicate how CakeSession behaved in 1.3. Also fixes the countdown & session id regeneration feature. Still need to write a test case for it though. 2010-07-27 22:27:43 -04:00
mark_story
d2097c514f Fixing issue where infinite loops would occur when a session was first created. 2010-07-27 22:27:43 -04:00
mark_story
977ffa96be Removing dead properties and methods from SessionComponent.
Sessions should be started as soon as the component is constructed. So there is no reason to have an active()/activate() method.
2010-07-27 22:27:43 -04:00
mark_story
574bfe6b67 Changing clear of $_SESSION to null instead of array(), makes checks later easier. Removing _checkValid call from destroy and making it run in start(), as destroy() calls start(). 2010-07-27 22:27:43 -04:00
mark_story
a857e4505c Adding files from previous commit. 2010-07-27 22:27:43 -04:00
mark_story
db5c44e386 Adding support + test cases for plugin and app/libs session handlers. 2010-07-27 22:27:42 -04:00
mark_story
5673ceb816 Updating core.php files with new session configuration. 2010-07-27 22:27:42 -04:00
mark_story
18b6668a34 Moving tests from SessionComponent to CakeSession, as that is where the features actually are. Removing Security.level/Security::inactiveMins() calculations. 2010-07-27 22:27:42 -04:00
mark_story
eb30c12560 Adding a test case for DatabaseSession::gc(); 2010-07-27 22:27:13 -04:00
mark_story
28b9ed7264 Adding test cases for DatabaseSession and fixing a test case in CacheSession. 2010-07-27 22:27:13 -04:00
mark_story
7d2d2aaa4d Adding test case stub for DatabaseSession and test case for CacheSession. 2010-07-27 22:27:13 -04:00
mark_story
951eeae817 Extracting handler location into a method.
Moving DatabaseSession and CacheSession into separate files.  Tests to come soon.
2010-07-27 22:27:13 -04:00
mark_story
736d33647e Adding tests for using a custom session config with CacheSession. 2010-07-27 22:27:13 -04:00
mark_story
49397c74af Making cache config used for cache session storage configurable. 2010-07-27 22:27:13 -04:00
mark_story
f5d81e53fc Refactoring Cache and Database session handlers into a separate class, and adding an interface for custom session handlers. Tests updated. 2010-07-27 22:27:13 -04:00
mark_story
a8b05c2fbc Adding a check for '' and failure. When trying to Cache '', FileEngine will return false. This shouldn't trigger an error inside Cache. 2010-07-27 22:27:12 -04:00
mark_story
339fa29502 Updating CakeSession test case and fixing a few issues in the default settings. 2010-07-27 22:27:12 -04:00
mark_story
b247559e9e Starting to implement new session configuration setup. Test case updated. 2010-07-27 22:27:12 -04:00
predominant
f05a13a451 Added test for empty key write on CakeSession 2010-07-27 22:27:12 -04:00
predominant
7501fcf46d Add test for empty read() calls on CakeSession 2010-07-27 22:27:12 -04:00
predominant
623998f550 Added test for empty session check. 2010-07-27 22:27:12 -04:00
predominant
ca65689dd9 Change _setHost() on CakeSession to accept parameter to ease testing, add test cases for host setting, and port stripping. 2010-07-27 22:27:12 -04:00
predominant
a63474a54d Add test for path containing question, and fix assignment of CakeSession::path 2010-07-27 22:27:12 -04:00
predominant
f5565895e9 Removing __regenerateId method, and moving code to renew(). 2010-07-27 22:27:11 -04:00
predominant
afede663c0 Reducing redundant code for CakeSession. 2010-07-27 22:27:11 -04:00
predominant
725bfc3e12 Create _setPath() and _setHost to simplify startup. 2010-07-27 22:27:11 -04:00
mark_story
4b65ebd64f Making SessionComponent mostly a wrapper for CakeSession.
Adding CakeSession::begin() to replace SessionComponent::__start().
Tests updated.  Tests related to autoStart were removed/skipped as that feature isn't really around right now.
2010-07-27 22:27:11 -04:00
mark_story
e660416545 Making CakeSession::write() able to write hashes of data. 2010-07-27 22:26:03 -04:00
mark_story
59ea917c23 Fixing a few failing tests, and splitting a big test into two smaller ones. 2010-07-27 22:26:03 -04:00
predominant
4e9d76e806 Fixing session write use issue. 2010-07-27 22:26:03 -04:00
predominant
dd3e0facd2 Trim down CakeSession::started() 2010-07-27 22:26:03 -04:00
predominant
db97df31cd Adding static to regen 2010-07-27 22:26:03 -04:00
predominant
1dd02b77b2 Adding static to destroy() 2010-07-27 22:26:03 -04:00
mark_story
f47ee0d29a Making CakeSession destory() make started() not return true. Fixing tests that tried to modify session config while a session was active. 2010-07-27 22:26:03 -04:00
mark_story
daab018777 Removing code for PHP < 5.1 which is not supported by 2.0 2010-07-27 22:26:03 -04:00
mark_story
1938e57cbc Making userAgent check test pass.
Reformatting code inside valid().
2010-07-27 22:26:02 -04:00
predominant
b60b077056 Fix __startSession being called after method rename to _startSession. 2010-07-27 22:26:02 -04:00
predominant
34a6808d5d Move CakeSession database configuration to separate method, cutting down init(). 2010-07-27 22:26:02 -04:00
predominant
632d1f13ae Minor refactor for CakeSession. 2010-07-27 22:26:02 -04:00
predominant
9bddd9a861 Minor refactor of if()'s 2010-07-27 22:26:02 -04:00
predominant
e5b8454736 Update test Start with fresh watchKeys. 2010-07-27 22:26:02 -04:00
predominant
06f9d748e2 Fix session path/base for init() 2010-07-27 22:25:37 -04:00
predominant
16f4899821 Fix destroy() calling old constructor on CakeSession 2010-07-27 22:25:37 -04:00
predominant
ea7d45cb11 Remove unset() 2010-07-27 22:25:37 -04:00
predominant
b0e4a09d38 Rename constructor to init() and add init() call at bottom of CakeSession. 2010-07-27 22:25:37 -04:00
predominant
3430930fde Remove Session helepr disabling tests. 2010-07-27 22:25:37 -04:00
predominant
86a7263ab5 Fix cookielifetime variable declaration for CakeSession. 2010-07-27 22:25:37 -04:00
predominant
b054e122f1 Comment out testValid() for SessionHelper 2010-07-27 22:25:37 -04:00
predominant
6f2cee65b6 Fix removed valid() test. 2010-07-27 22:25:37 -04:00
predominant
913d54caa0 Remove __start from SessionHelper 2010-07-27 22:25:37 -04:00
predominant
04b67e59fc Fix tests to remove checking of session ID directly on Session Helper. 2010-07-27 22:25:37 -04:00
predominant
17688a6002 Chaned CakeSessn o use static approache. 2010-07-27 22:25:37 -04:00
predominant
0a72de6438 Removing @access doc block lines from CakeSession. 2010-07-27 22:25:05 -04:00
predominant
58c94b8578 Add access to started() on CakeSession. 2010-07-27 22:25:05 -04:00
predominant
c8c677ae9e Change SessionHelper to extend AppHelper instead of CakeSession. 2010-07-27 22:25:05 -04:00
predominant
390274f807 Remove function exists check on session_write_close() 2010-07-27 22:25:05 -04:00
mark_story
d38857095a Merge branch '1.3' into 2.0
Conflicts:
	cake/libs/model/model.php
	cake/libs/validation.php
	cake/libs/view/helpers/ajax.php
	cake/tests/cases/libs/controller/components/session.test.php
2010-07-24 22:34:42 -04:00
José Lorenzo Rodríguez Urdaneta
e47a464d63 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-07-24 15:22:12 -04:30
José Lorenzo Rodríguez Urdaneta
1cfcec9a1a Removin use of File class in favor of SplFileObject 2010-07-24 15:21:14 -04:30
ADmad
91b0a4ba4f Changing Tree behavior's function names to be camel cased as per convention 2010-07-24 23:32:49 +05:30
mark_story
b5d7f6447f Applying patch from 'asavoy'. Changing schema shell so that schema files generated for plugins have the classname of PluginSchema instead of AppSchema. Tests updated. Fixes #922 2010-07-23 21:46:06 -04:00
mark_story
43127caad2 Making Cache::write() trigger warnings when a cache engine returns false from a write. Tests added. Fixes #877 2010-07-23 21:40:57 -04:00
mark_story
a965056af7 Merge remote branch 'origin/1.3' into 1.3 2010-07-23 21:12:44 -04:00
José Lorenzo Rodríguez Urdaneta
88ea68af96 Using keyword self instead of Configure, removing use of File class in favor of SplFileObject 2010-07-23 18:42:30 -04:30
Juan Basso
5b7b2d074e Putting the port in header Host, following RFC 2616 item 14.23. Fixes #947. 2010-07-23 00:13:19 -03:00
mark_story
fbb54e6a45 Adding a test case for nested array data and clean(). 2010-07-21 23:37:14 -04:00
mark_story
766d7d50c6 Updating HtmlReporter so it doesn't make notice errors when printing stack traces. 2010-07-20 23:49:38 -04:00
mark_story
572f79be67 Fixing failing tests caused by strtolower() in AuthComponent. 2010-07-20 23:44:25 -04:00
mark_story
f6c7be9d22 Adding omitted import for Multibyte to i18n. Fixes #929 2010-07-19 23:18:42 -04:00
Scott Reeves
88e32b3cee Fixing typo
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:15:28 -04:00
Scott Reeves
f44911f6dc Fixing typo in parameter description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:15:20 -04:00
Scott Reeves
ba9fc94977 Fix typo in variable description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:15:12 -04:00
Scott Reeves
b717abe1aa Fixing typo in Constructor description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:15:00 -04:00
Scott Reeves
ba59c93187 Fixing typo in method description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:14:51 -04:00
Scott Reeves
037a7628c4 Fixing typo in parameter description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:14:43 -04:00
Scott Reeves
1774530222 Fixing typo in method description.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:14:28 -04:00
Scott Reeves
742bb29118 Fixing typo in variable description for logoutRedirect.
Signed-off-by: mark_story <mark@mark-story.com>
2010-07-19 23:14:06 -04:00
mark_story
f01b4ae13b Updating version numbers to 1.3.3 2010-07-18 23:00:24 -04:00
mark_story
0c312e3d77 Adding some destroy() calls to cause the timestamps to refresh. 2010-07-18 22:56:57 -04:00
predominant
ca1c8f1f80 Remvoed session destruction from tests. 2010-07-19 12:14:44 +10:00
mark_story
a78bb20bda Fixing failing test in ControllerTest caused by ThemeView not being correctly found if it was not in the mapped files. 2010-07-18 21:28:52 -04:00
mark_story
41997b06e1 Fixing issues where mb_internal_encoding() might not be correctly set, causing email subjects to be incorrectly encoded. Tests added. Fixes #904 2010-07-18 20:48:15 -04:00
José Lorenzo Rodríguez Urdaneta
bc27d1eae4 Returning only booleans in Model::__isset() and removing return by reference in Model::getDataSource() 2010-07-15 23:17:13 -04:30
José Lorenzo Rodríguez Urdaneta
c7f1650510 Fixing test case 2010-07-15 23:16:47 -04:30
José Lorenzo Rodríguez Urdaneta
b8b4647355 Removing use of cakeError in Model and replacing it with an Exception 2010-07-15 23:11:30 -04:30
mark_story
4c27c24a72 Fixing issue in DboSource where COUNT() was hardcoded, omitting any other aggregate functions. Replaced with a regexp that accepts only letters. Test case added. Fixes #878 2010-07-15 23:17:38 -04:00
José Lorenzo Rodríguez Urdaneta
6fb930c73b Removing assignments by reference in model class 2010-07-15 22:16:19 -04:30
José Lorenzo Rodríguez Urdaneta
14d3d009c0 Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 2010-07-15 22:10:03 -04:30
José Lorenzo Rodríguez Urdaneta
e30904f8b4 Removing some of the loaded fixtures to show that tables are not needed in the process of model construction 2010-07-15 21:45:50 -04:30
Ceeram
32ea6d24cf Moving Component::beforeRender triggering to allow components to modify
the view class to use for the render() call.  Fixes #917

Signed-off-by: mark_story <mark@mark-story.com>
2010-07-15 21:54:18 -04:00
mark_story
0e184c66f4 Adding failing test for #917 2010-07-15 21:52:24 -04:00
José Lorenzo Rodríguez Urdaneta
a57e5e8c68 Replacing direct reads to schema cache and routing them to the correct method 2010-07-15 21:19:23 -04:30
José Lorenzo Rodríguez Urdaneta
5d1e6f9e4f Fixing errors with displayField 2010-07-15 21:18:16 -04:30
José Lorenzo Rodríguez Urdaneta
a13be623b5 Making the model require database connection only wen needed or requested 2010-07-15 21:16:52 -04:30
José Lorenzo Rodríguez Urdaneta
67612872da Removing non used fixtures 2010-07-14 23:31:54 -04:30
José Lorenzo Rodríguez Urdaneta
e165f7d559 Changing how dynamic "with" models are loaded
Changing all calls to get model's datasourse to use Model::getDatasource()
2010-07-14 23:19:38 -04:30
mark_story
71af126171 Changing HtmlReporter to print out testname and stack trace instead of trying to guess where things went wrong. 2010-07-14 23:00:09 -04:00
José Lorenzo Rodríguez Urdaneta
0ec30be076 Improving tests for model associations lazy loading 2010-07-14 22:10:56 -04:30