Commit graph

819 commits

Author SHA1 Message Date
Jan Pešek
9140745ef1
fix: get rid of (some) PHP deprecation warnings (#66)
- CakeResponse.php strlen() no longer accepts null as a parameter

Co-authored-by: Jan Pešek <jan@sinch.cz>
2024-02-03 10:26:26 +01:00
Jan Pešek
a83e9c77bb fix: get rid of (some) PHP deprecation warnings
- CakeResponse.php strotime() and preg_split() warnings
2024-01-19 22:35:39 +01:00
Juan Cruz Vincenti
84cfdfb0c3 Fix some PHP 8.1 deprecation warnings
* Fix passing null to str_replace and preg_replace in HttpSocket
* Fix dynamic props usage in ModelValidator
* Fix passing null to rawurlencode in CakeRoute
2024-01-11 23:02:17 +01:00
Koji Tanaka
aac44b074b build: Added GitHub Actions workflow to run phpcs. 2023-01-11 22:45:29 +01:00
chrip
dbb77bf125 Fix wrong line ending in email header when using MailTransport. 2022-10-20 22:35:02 +02:00
Kamil Wylegala
7302598222 Fixed deprecation notice: numeric prefix cannot be null in http_build_query. 2022-01-04 23:08:45 +01:00
Kamil Wylegala
61e4ef05c8 Fixed implementations of ArrayAccess to reduce deprecation notices in PHP 8.1 #1 2021-12-20 23:09:51 +01:00
Mark Story
63d708118a Fix incorrect URL generation
When a fullBaseURL is being used we should check for the exact base
string being a prefix and not just the string length as it could be full
of garbage.

Fixes #15163
2020-11-19 22:47:52 -05:00
andrii-pukhalevych
8addcf1fa3
Microoptimization for ServerRequest::is() and ServerRequest::isAll() (#14654) 2020-05-31 22:43:58 +05:30
Mark Story
50e0ca7f9d Add TLS 1.3 support to CakeSocket
Fixes #14422
2020-04-05 00:25:09 -04:00
Markus Podar
459ee900fe
php-7.4-compact: replace deprecated curly brace offset access
Per https://wiki.php.net/rfc/deprecate_curly_braces_array_access and https://www.php.net/manual/en/migration74.deprecated.php
>  The array and string offset access syntax using curly braces is deprecated. Use $var[$idx] instead of $var{$idx}.
2020-03-20 21:10:58 +01:00
kicaj
bcbe5fdcf0
Fix #12885 2019-01-11 13:20:09 +01:00
bancer
71ea302336 Improve documentation 2018-12-28 14:19:26 +01:00
Val Bancer
0f2bbf505d
Adjust the check according to review comments 2018-12-11 16:36:32 +01:00
Val Bancer
addd538526 Fix invalid condition 2018-11-18 22:48:34 +01:00
Val Bancer
c00579153b Cast var to int for comparison 2018-11-18 18:22:19 +01:00
Val Bancer
cb1d80fda1 Improve documentation 2018-11-18 17:13:11 +01:00
Val Bancer
92e9277d20 Improve code style 2018-11-18 16:24:25 +01:00
Val Bancer
509accc421 Improve code style 2018-11-17 20:55:42 +01:00
Val Bancer
261a99c0e3 Improve documentation and code style 2018-11-17 20:27:05 +01:00
Val Bancer
320cdf98ee Add undocumented properties (#12717)
See https://book.cakephp.org/2.0/en/controllers/request-response.html#accessing-request-parameters and https://api.cakephp.org/2.10/source-class-UpgradeShell.html#345-403

* Initialize $params to null
* Document more magic properties, trigger deprecated notices
* Use $controller->request->params instead $controller->params
* Remove unused variable
* Improve documentation, add type checks.
* It seems like $this->uses can also be of type false; however, parameter
$array of array_unshift() does only seem to accept array.
* Declare undeclared property
* Add extra type checks
* Adjust type check
* Improve documentation, initiate uninitialized variables.
* Improve documentation, reset variable
2018-11-15 20:41:57 -05:00
Joe
34bfeba15d Fixes failing tests 2018-09-03 00:45:34 -04:00
Joe
013ecc3f9f Rebuilds the solution 2018-08-22 11:40:41 -04:00
Joe
1fca92fb4e Fixes issue raised by @garas 2018-08-22 00:40:28 -04:00
Joe
af516eebb0 Cleanup fix 2018-08-21 15:29:48 -04:00
Joe
8e7bc7701c Combine variable defaults 2018-08-21 15:29:04 -04:00
Joe
a4e71b3b40 Fixes:
* Issue with preg_match()
* Undefined variables
2018-08-21 14:46:58 -04:00
AlexAlexandru
c44113af66 code style 2018-08-01 21:50:38 +03:00
AlexAlexandru
44c0d73391 code style 2018-08-01 21:04:50 +03:00
AlexAlexandru
8c3982b192 fixes #11424 Enchament to email class error message 2018-08-01 20:54:53 +03:00
Mark Story
fd568e7c79 Fix method casing.
Closes #12241
2018-06-30 14:55:37 -04:00
chinpei215
9f65402d2c Fix CakeRequest::referer(true) returning scheme-relative URLs
Backport of #11503 (and #8795)
2017-12-04 21:18:27 +09:00
LustyRain
31b13edf8a Fix: phpdoc miss
## did
- void unReturn
- miss return void
- add return type
- type miss typing
- add param type and return type
  - string → string|array
- change ClassName
2017-10-04 00:22:42 +09:00
Ionut-Mihai Burlacu
3bc55f6341 Fixes #11221 2017-09-21 14:33:10 +03:00
bclay
38161917eb Address CakeEmail regression when data is defined with no mimetype 2017-08-03 17:00:58 -04:00
mark_story
2032fef772 Merge branch '2.x' into 2.next 2017-06-26 21:51:41 -04:00
Mark Story
2b8447dc5b Merge pull request #10766 from cakephp/issue-10763
Fix encoding of addreses contain comma & unicode
2017-06-16 21:37:54 -04:00
mark_story
738b20a19b Fix encoding of addreses containin comma & unicode
Email addresses that contain both unicode and commas will not be
correctly encoded by mime_encode_header if the comma precedes the
unicode. In this scenario we have to quote the encoded address.

Refs #10763
2017-06-12 10:58:44 -04:00
Marc Würth
88aadf3804 Use HTTPS for the www.cakephp.org URL
Do not change those in tests.
2017-06-11 00:43:06 +02:00
Marc Würth
da8414e13b Use HTTPS for the opensource.org MIT license URL 2017-06-11 00:23:22 +02:00
Marc Würth
10b89b51a9 Use HTTPS for the cakefoundation.org URL 2017-06-11 00:10:59 +02:00
Marc Würth
17314baa15 Use HTTPS for the cakephp.org URL 2017-06-10 23:40:28 +02:00
mark_story
cf679a3233 Merge branch '2.x' into 2.next 2017-05-27 21:47:22 -04:00
Joe
70ead28a1d Redo commits on 2.next branch 2017-05-12 02:02:36 -04:00
Mark Story
0a378021a0 Merge pull request #10482 from cakephp/issue-10232
Fix CakeSocket not being able to connect to TLS1.2 only servers
2017-04-06 15:35:45 -04:00
mark_story
c74d2e0860 Split conditional TLS versions into a separate method
Having a separate method gives a nicer home to the inline comments. I've
had to disable coding standards checks as the constants provided by PHP
do not follow the UPPER_CASE conventions.
2017-04-06 10:00:47 -04:00
mark_story
4475cc06fd Update tls_client and tls_server to include newer TLS versions.
Refs #10445
2017-04-04 23:17:30 -04:00
mark_story
7dbc71df8c Conditionally define TLS constants & add test for new types.
Only map the new TLS constants if they exist.
2017-04-04 22:59:05 -04:00
chinpei215
31a1837c1d Merge branch '2.x' into 2.next
Conflicts:
	lib/Cake/Test/Case/View/Helper/FlashHelperTest.php
	lib/Cake/VERSION.txt
	lib/Cake/View/Helper/FlashHelper.php
2017-03-25 17:12:28 +09:00
Mischa ter Smitten
2304ca379a PHPDoc fixes
Found with Phan
2017-02-17 16:59:35 +01:00