Commit graph

4612 commits

Author SHA1 Message Date
davidpersson
06d3aee348 Fixing help not getting called
Adding tests
2009-05-02 23:51:57 +02:00
davidpersson
1d8f57d37a Second pass at dispatch refactor
Updating command dispatching
Fixing incorrect arg handling
Moving assignments out of conditionals
Updating tests to reset args
Adding dispatch task test
2009-05-01 18:46:23 +02:00
davidpersson
ebe1cd258a Updating shiftArgs to return shifted arg
If no args were available the method was returning false and now
returns null. If args were available the method was returning true it
now returns the shifted argument instead.
2009-05-01 03:47:33 +02:00
davidpersson
4b89dd2209 Refactoring ShellDispatcher::dispatch
Updating dispatch method to use is_a fixes #5318
Adding _getShell method to ease testing
Updating status code handling in the constructor
Adding and updating tests
2009-04-30 19:25:58 +02:00
davidpersson
0ee8889e6d Adding Shell::nl method
Updating out to not use newline feature of SD::stdout
Updating out, err and hr methods to utilize the new method
Rewording parameters of out, err and hr
Changing handling of multiple messages
Adding tests for nl, hr and error
Updating tests for out and err
Updating docblocks
2009-04-24 21:04:07 +02:00
davidpersson
82641e535f Updating formatting of output in Shell:error
Renaming $msg param to $message
The $message param is now optional
The method now exits the app with status code 1
2009-04-16 11:05:30 +02:00
davidpersson
4faa9d3b21 Adding newline param to Shell::err
The signature of ::err is now identical to ::out
Adding tests for ::err
2009-04-16 10:59:53 +02:00
davidpersson
73cbdf011b Removing prepending of "Error: " in ShellDispatcher::stderr 2009-04-16 10:30:36 +02:00
gwoo
ec18aac4ab Merge branch 1.2 into 1.3 2009-04-15 15:16:01 -07:00
mark_story
8db4fe682b Allowing name attribute to pass on to hidden field in FormHelper::radio().
Fixes inconsistency with checkbox().  Test case added.
Fixes #6260

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8145 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-15 17:18:01 +00:00
mark_story
377108f930 Adding tests to show correct usage of form::create() with querystring params. Closes #6278
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8144 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-15 02:29:50 +00:00
mark_story
32107f5fba Fixing test broken in [8136]. Adding Configure::write() to prevent fails when running helpers as a group.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8143 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-15 02:14:04 +00:00
mark_story
fcb8ef25d6 Renaming setUp() to startTest() in Controller task. Fixes issues with fixtures and baked controller tests.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8142 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-14 23:13:43 +00:00
mark_story
97652231a0 Fixing RequestHandlerComponent::prefers() with array input. Test case updated. Fixes #6290
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8141 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-14 13:16:25 +00:00
jperras
225e5e6aa8 Adding missing fixtures from last commit.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8140 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-13 14:25:01 +00:00
jperras
066629d566 Removing hard-coded 'id' field from Model::_prepareUpdateFields. Fixes #6274.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8139 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-13 14:15:58 +00:00
the_undefined
bf2829a896 Fixed bug related to the order in which some replacement take place
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8138 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-09 13:15:43 +00:00
mark_story
9491e4632d Applying patch from 'SkieDr' to fix custom find type pagination. Removes parameters from exiting paginate(). Test case added.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8137 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-07 14:56:30 +00:00
mark_story
5f4cdf91ac Fixing AjaxHelper::dragOptions to match scriptaculous docs.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8136 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-06 00:57:46 +00:00
mark_story
5c4f838f5a Adding buffer flush to ajax helper test. Test suite menus now properly display.
Fixing Drag options.  Adding test coverage. Fixes #6266

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8135 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-06 00:45:53 +00:00
mark_story
d74e2d1a73 Fixing newline escaping for single quote strings, output now matches json_encode().
Test added, and old test fixed.
Fixing buffering issues, causing test suite menu to disappear when running JavascriptHelper Test case.
Fixes #6167

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8134 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-04 02:42:46 +00:00
davidpersson
392a6b195d Adding tests for Folder::copy and ::move showing that
skipping existing subdirectories is the intended behavior.
Disproves #6529.  Refs #6529.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8133 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-04-01 17:54:25 +00:00
mark_story
6551e2a45d Adding test for file input creation on hasOne relationship. Refs #6223
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8132 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-28 02:46:23 +00:00
davidpersson
5d23f46118 Adding tests to disprove #6236. Closes #6236.
Removing return from testWriteEmptyValues method to enable the test.
Updating CacheTest to revert settings changed in the tests.



git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8131 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-26 20:40:45 +00:00
renan.saddam
9f0cbb00ce Adding tests to Session Save Handler callbacks. Refs #6229.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8130 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-26 14:25:47 +00:00
renan.saddam
2082239969 Calling the right Garbage Colector callback when using Cache as Session Save Handler. Fixes #6229.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8129 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-26 13:50:25 +00:00
mark_story
0516fb2090 Enabling disabled attribute to be passed to hidden input when making checkboxes.
Test case added. 
Fixes #6226

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8128 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-25 16:58:29 +00:00
davidpersson
0a610d2c30 Updating Debugger::log to get the source from the end of the stack
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8127 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-23 18:59:37 +00:00
jperras
14aaa1682f Updating doc block for Valdation::url optional parameter. Fixes #6220.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8126 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-23 13:48:37 +00:00
jperras
4439bc4f70 Fixing regression in PaginatorHelper. Adding tests for PaginatorHelper::sortDir, as well as fixing incorrect test for sorting with Model.field dot notation. Fixes #6218.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8125 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-22 18:59:53 +00:00
mariano.iglesias
364fe18208 Adding test to disprove issue. Closes #4693
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8124 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-22 13:09:50 +00:00
davidpersson
fd7d6718a1 Updating tests to not affect other ones when run from a group
Adding NoCrossContamination group
Shortening group class names
Renaming lib_controller group
Updating test imports to include the core AppController by default
Some cosmetics




git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8123 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-21 23:55:39 +00:00
gwoo
643651fe56 Merge master in 1.3 2009-03-19 14:10:13 -07:00
gwoo
fc7773fe2d merging fixes to trunk. set version to 1.2.2.8120
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8120 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-19 20:25:10 +00:00
gwoo
3d4c5b424d adding models/behaviors for object persist tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8119 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-19 20:10:10 +00:00
jperras
641a48342b Adding test for Auth login redirect to url with query string parameters. Disproves #6211.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8118 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-19 18:37:54 +00:00
gwoo
5c53fcfcb9 fixes #6209, persistModel and undefined $Behaviors
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8117 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-19 18:27:49 +00:00
davidpersson
3c3b852099 Changing package of tests from "cake.tests" to "cake".
Moving tearDown et al. to the top of each test class.
Adding short descriptions to docblocks.
Adding missing docblocks.
Removing unnecessary blank lines and whitespaces.
Updating labels of test groups.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8116 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-18 17:55:58 +00:00
renan.saddam
78daa13900 Defining the default answer as the current path. Fixes #6204
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8115 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-18 00:43:21 +00:00
renan.saddam
76e0f17dbc Updating documentation to improve code completion
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8114 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-17 21:10:28 +00:00
gwoo
de5907326e fixes #6203, Model::invalidFields respecting Model::whitelist
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8113 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-17 18:19:12 +00:00
gwoo
7f853532d9 updating ShellDispatcher to pass tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8112 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-16 23:08:39 +00:00
davidpersson
1c76e2e18e Fixing ShellDispatcher tests.
Order of paths should not be taken into account.
CONSOLE_LIBS constant is not guaranteed to hold a relative path only.
Matching expectations for the output of help command to show correct shortened paths.


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8111 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-16 22:54:22 +00:00
davidpersson
0ead89639a Adding tests for Controller::redirect.
Proves #6200 is invalid. 
Making original tests more strict.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8110 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-16 14:07:26 +00:00
mariano.iglesias
a9062e2e02 Adding new email validation
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8109 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-16 12:54:25 +00:00
mark_story
eba2e78d06 Fixing typo in last commit.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8108 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-16 03:06:28 +00:00
mark_story
4dceb5be31 Adding doc blocks for properties that previously had no documentation. Closes #6199
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8107 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-16 03:01:51 +00:00
jperras
beb6aeec0c Fixing incorrect doc blocks for connection_manager.php. Thanks to ADmad for noticing the inconsistency.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8106 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-15 23:01:21 +00:00
gwoo
056402efa7 moving checks for Set::extract() so that null will be returned when empty data is passed and classicExtract is expected.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8105 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-15 19:39:35 +00:00
davidpersson
93bf4fd0dc Fixing debug() test making it match truncated paths too.
Adding skip to uses() test to make running all tests in sequence more smooth.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@8104 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-03-15 19:31:59 +00:00