Commit graph

104 commits

Author SHA1 Message Date
gwoo
643651fe56 Merge master in 1.3 2009-03-19 14:10:13 -07:00
phpnut
a6250ad648 Adding fix when a invalid session is destroyed in CakeSession::_checkValid(); and session data wrote after the session is destroyed no longer being available because the session data was wrote using the old session id
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7976 3807eeeb-6ff5-0310-8944-8be069107fe0
2009-01-14 03:52:37 +00:00
renan.saddam
aa1abdda9a Applying previous patch to _checkValid method. Fixes #5450.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7892 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-11-25 16:35:20 +00:00
AD7six
3f2fa6929b changing tabs for spaces in comment block indentation
Removing address and replacing with cakefoundation url


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7805 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-30 17:30:26 +00:00
mark_story
1b456f2cf1 Applying patch from 'davidpersson' fixing code spacing. Closes #5643
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7772 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-23 00:10:44 +00:00
phpnut
3c50e54213 Closes #5542 Duplicate cookies
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7735 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-10-12 03:29:10 +00:00
gwoo
e6b994bcb1 updating handling of required classes, fixes #5480
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7666 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-26 14:03:16 +00:00
mark_story
62168bfe0f Updating doc blocks to include access and return PHPDOC tags.
Removing use of e() in Debugger.
Fixing code formatting in CookieComponent
Closes #5477

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7662 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-25 16:49:56 +00:00
mark_story
9482105abe Applying patch from renan_saddam. Fixes session checkAgent logic. Closes #5450
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7636 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-20 13:51:49 +00:00
phpnut
2b95df3abf Additional optimization refactoring
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7597 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-09-13 18:59:30 +00:00
gwoo
6fb27553f1 fixes #5254, setting secure session cookie when https is used
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7458 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-08-12 23:47:00 +00:00
phpnut
9bc1acb2ec Closes #5051, AjaxHelper form function should use mt_rand() instead of rand().
Replaced all rand() with mt_rand() in the core.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7322 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-07-05 14:31:22 +00:00
nate
df75a06756 Fixing coding standards violations in core, and adding misc tests
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7222 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-20 20:17:23 +00:00
gwoo
1e231e9511 some cleanup, wrapping uses() in class exists
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7172 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-11 15:46:31 +00:00
phpnut
6807d4c333 Starting initial refactoring of current code base.
Made changes to test suite to allow running test without headers already sent errors.
Moved Component::initialize(), Controller::beforeFilter(); and Component::startup(); from Dipatcher::start() to Controller::constructClasses();
Removed Dispatcher::start();
Fixing model instances not being created
Adding additional test to CookieComponent to increase coverage to 95%
Optimizing Set::diff();
Fixing SessionComponent test and RequestHandlerComponent test
Fixing CakeSession tests, removed deprecated code from CakeSession

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7162 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-10 22:38:05 +00:00
mark_story
7820d639b8 changed column datatyping in __destroy() closes #4782. Updated session test to use session fixture.
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7084 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-06-01 22:03:29 +00:00
nate
42da5aba81 Moving Cake folder to correct location
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7063 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 11:40:08 +00:00
DarkAngelBGE
e6e0d852a2 deleting cake folder from svn
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7061 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-05-30 10:59:16 +00:00
phpnut
d801e5c897 "Fixing typo in [6514]"
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6515 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-08 05:58:14 +00:00
phpnut
0740ac519b "Fixes #3234, Session.cookie_path in php ini gets a buggy value when not using mod_rewrite."
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6514 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-03-08 05:44:04 +00:00
phpnut
43eab108c7 "Fixes #3811, $_SESSION not found
Fixes #3823, Session not restarted after instantiating new SessionComponent
Fixes #3850, Configuration Session.start and SessionComponent::!__active aren't handle correctly"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6341 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-08 15:46:02 +00:00
phpnut
cb53dc61b0 "Closes #2897, Built-in file validation.
Implemented Validation::extension(); and Vaidation::range();
Updated copyright notices in all files"

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@6296 3807eeeb-6ff5-0310-8944-8be069107fe0
2008-01-01 22:18:17 +00:00
phpnut
18c7a00a47 Correcting issues with Sessions and Controller::redirect()
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5999 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-16 03:52:14 +00:00
phpnut
eb6c94a01e Closes #2781, $form->input on date fields renders maxYear and minYear in $options as HTML attributes.
Closes #3181, Year list ordering in FormHelper order is now formated descending.
Fixes #3524, FormHelper->month, day, year, hour, and minute should use $selected if it is supplied.
Fixes #3558, post validation don't pass if form use only hidden fields.
Fixes #3568, Saving datetime fields is broken in scaffolding.
Fixes #3574, Typo in Session class.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5987 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-12 11:31:43 +00:00
phpnut
11d295eb0c Fixes #3507 Session Security.level "high", session destroyed on media 404.
Added ability to turn off HTTP_USER_AGENT check in a Controller::beforeFilter(),
Added id() to Session helper and component to return current Session id, the component accepts a $id parameter to force setting the Session id which must be called in a Controller::beforeFilter().
Sessions id are not longer renewed if a request is from Ajax, or from requestAction();
When Security.level (1.2) or CAKE_SECURITY (1.1) is set the 'high' renewing of Session id only happens if request is 2 seconds after the last request.
Added $_Session[Config][timeout] which forces renewing Session if request are within the 2 second limit and over 10 request.
If an application is expected to make multiple request (more than 10) to the server in a single proccess, Configure::write('Security.level', 'medium'); (1.2) or $this->Session->security = 'medium'; (1.1) should be used in a beforeFilter for the specific methods.
1.2 Sessions allow using CacheEngines to store Sessions, be aware that using memory caching as the only storage of Sessions is not reliable. Further work will be done to allow using the CacheEngines with database Sessions, etc.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5982 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-11-12 01:36:20 +00:00
phpnut
d5ca583326 If Configure::read('Session.checkAgent') has not explicitly set false, 'HTTP_USER_AGENT' will be checked
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5907 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-27 19:06:19 +00:00
mariano.iglesias
896f62544b Changing @return int to @return integer and @param bool to @param boolean
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5860 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-22 16:54:36 +00:00
phpnut
160cd28440 Correcting @return int
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5858 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-22 16:11:12 +00:00
phpnut
da97a5c871 Correcting @return bool
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5857 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-22 16:09:35 +00:00
mariano.iglesias
897825d596 Adding documentation to classes belonging to Cake console.
Standarizing on datatypes used in phpdocblocs and removing unneeded @return types

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5851 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-22 05:52:20 +00:00
phpnut
e750c9d38f Closes #3318, When model calls invalidate, it would be usefull to use the __(messageID, true)
Fixes #2603, Scaffold edit() should redirect to index() when no record is found.
Closes #2990 cake_sessions Needs A Database Name Setting, Configure::write('Session.database', 'default')
Closes #3120, database - $config['encoding']; added new settings to database.php.default
Corrected errors when setting database configurations from console, would not allow changing setting on old configuration.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5815 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-20 10:14:30 +00:00
phpnut
03b94b2601 Fixes #3313, Session ID doesn't regen between requests when CAKE_SECURITY is set to 'high'
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5771 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-17 01:30:06 +00:00
phpnut
bf273081f0 Closes #3238, added ability to turn of check for HTTP_USER_AGENT by using Configure::write('Session.checkAgent', false); in a beforeFilter().
Added test for changes.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5770 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-17 00:40:47 +00:00
phpnut
1aa1164b1d Closes #3394, applied test patch
Deprecated define('MAX_MD5SIZE', (5 * 1024) * 1024); in core.php
Removing additional defines in core.php, replaced with Configure::write();
Added CakeSession::__startSession() to check for sent headers before attempting to start the session.
Added notices to Configure::__loadBootstrap() that will be removed before stable release.
Refactored Folder::tree().
Added additional FolderTest cases

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5768 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-10-16 09:05:25 +00:00
gwoo
4f8f7a7045 refactoring cache engines, adding tests, update configure fixes #3082
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5700 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-09-30 07:45:34 +00:00
phpnut
6c650e2371 Fixes #3234, Session.cookie_path in php ini gets a buggy value when not using mod_rewrite
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5655 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-09-16 18:43:41 +00:00
phpnut
23dfd90b29 Correcting code structure to standards
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5313 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-06-20 06:15:35 +00:00
phpnut
1454a05ee3 Adding fix for Ticket #2738, fixes Nesting level too deep error when writing object in CakeSession in php 5.2+
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5286 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-06-16 23:51:12 +00:00
nate
07006c9e4a Allowing spaces in session keys (Ticket #2639)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5208 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-27 04:10:29 +00:00
mariano.iglesias
8392d8d3cf Fixing docs for Session
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5199 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-26 18:41:03 +00:00
phpnut
e2617621fd Adding fix for #2607, fixes Fatal error: Call to a member function on a non-object when using php 4
Adding fix for #2590, fixes ps_files_cleanup_dir: failed: Permission denied

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5124 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-05-20 04:44:18 +00:00
phpnut
4f78065c14 Adding fix for Ticket #2387
Fixed issue in view with $session->valid() always returning false.


git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4839 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-04-11 20:47:17 +00:00
phpnut
dcac88825a Adding fix for Ticket #2339
Adding fix for Ticket #2335
Adding fix for Ticket #2344

Merged changes in dbo from 1.2 to 1.1
Merged changes to session handling in 1.2 to 1.1
Merged changes to Model::_ _saveMulti() in 1.2 to 1.1
Added Set::pushDiff() to append differences in array 2 to array 1
Added SessionComponent::activate() and SessionHelper::activate() to turn sessions usage on if AUTO_SESSION is set to false
Added test for Ticket #2343
Added change to AclNode to use correct table naming
Added garbage clean up to CakeSession::_ _close(); some installs, like Debian, have removed garbage clean
up and use a cron job instead. Currently this change is only supported for database session.

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4752 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-04-04 07:25:48 +00:00
phpnut
70e11838a7 Adding fix for Ticket #2295
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4690 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-03-27 03:47:19 +00:00
phpnut
12f99cd1e9 Adding fix for Ticket #2287
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4670 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-03-25 00:33:57 +00:00
dho
a0897be3fb Fixing small bug in Session::check() (ticket #2257)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4618 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-03-16 12:47:49 +00:00
nate
2650c3a582 Finished retro-fitting CakeSession::del() (Ticket #2163)
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4552 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-02-22 19:53:25 +00:00
nate
cb511b95ed Removing eval() calls from Session and replacing with Set methods
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4545 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-02-20 19:51:58 +00:00
phpnut
b6bc6d6033 Refactoring SessionHelper and SessionComponent
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4514 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-02-12 22:29:49 +00:00
phpnut
53254d9a0f Refactoring SessionHelper and SessionComponent
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4512 3807eeeb-6ff5-0310-8944-8be069107fe0
2007-02-12 21:46:17 +00:00