From faafe5a0dce20fc2a2391b058536632789855c30 Mon Sep 17 00:00:00 2001 From: Mark Story Date: Tue, 5 Jan 2010 20:52:22 -0500 Subject: [PATCH] Removing use of Set::filter(). Coupling the test suite to Set is not a good idea. --- cake/tests/lib/reporter/cake_html_reporter.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cake/tests/lib/reporter/cake_html_reporter.php b/cake/tests/lib/reporter/cake_html_reporter.php index 0c8005136..97d0c15a9 100644 --- a/cake/tests/lib/reporter/cake_html_reporter.php +++ b/cake/tests/lib/reporter/cake_html_reporter.php @@ -32,6 +32,7 @@ class CakeHtmlReporter extends SimpleReporter { * Character set for the output of test reporting. * * @var string + * @access protected */ var $_character_set; /** @@ -153,7 +154,7 @@ class CakeHtmlReporter extends SimpleReporter { echo "
  • \n"; echo "Failed"; echo "
    " . $this->_htmlEntities($message) . "
    \n"; - $breadcrumb = Set::filter($this->getTestList()); + $breadcrumb = $this->getTestList(); array_shift($breadcrumb); echo "
    " . implode(" -> ", $breadcrumb) . "
    \n"; echo "
  • \n"; @@ -173,7 +174,7 @@ class CakeHtmlReporter extends SimpleReporter { if ($this->_show_passes) { echo "
  • \n"; echo "Passed "; - $breadcrumb = Set::filter($this->getTestList()); + $breadcrumb = $this->getTestList(); array_shift($breadcrumb); echo implode(" -> ", $breadcrumb); echo "
    " . $this->_htmlEntities($message) . "\n"; @@ -192,7 +193,7 @@ class CakeHtmlReporter extends SimpleReporter { echo "
  • \n"; echo "Error"; echo "
    " . $this->_htmlEntities($message) . "
    \n"; - $breadcrumb = Set::filter($this->getTestList()); + $breadcrumb = $this->getTestList(); array_shift($breadcrumb); echo "
    " . implode(" -> ", $breadcrumb) . "
    \n"; echo "
  • \n"; @@ -213,7 +214,7 @@ class CakeHtmlReporter extends SimpleReporter { '] in ['. $exception->getFile() . ' line ' . $exception->getLine() . ']'; echo "
    " . $this->_htmlEntities($message) . "
    \n"; - $breadcrumb = Set::filter($this->getTestList()); + $breadcrumb = $this->getTestList(); array_shift($breadcrumb); echo "
    " . implode(" -> ", $breadcrumb) . "
    \n"; echo "\n";