diff --git a/lib/Cake/Console/Command/SchemaShell.php b/lib/Cake/Console/Command/SchemaShell.php index c45988b67..314502af4 100644 --- a/lib/Cake/Console/Command/SchemaShell.php +++ b/lib/Cake/Console/Command/SchemaShell.php @@ -327,7 +327,7 @@ class SchemaShell extends AppShell { $this->out("\n" . __d('cake_console', 'The following table(s) will be dropped.')); $this->out(array_keys($drop)); - if ('y' == $this->in(__d('cake_console', 'Are you sure you want to drop the table(s)?'), array('y', 'n'), 'n')) { + if ($this->in(__d('cake_console', 'Are you sure you want to drop the table(s)?'), array('y', 'n'), 'n') === 'y') { $this->out(__d('cake_console', 'Dropping table(s).')); $this->_run($drop, 'drop', $Schema); } @@ -335,7 +335,7 @@ class SchemaShell extends AppShell { $this->out("\n" . __d('cake_console', 'The following table(s) will be created.')); $this->out(array_keys($create)); - if ('y' == $this->in(__d('cake_console', 'Are you sure you want to create the table(s)?'), array('y', 'n'), 'y')) { + if ($this->in(__d('cake_console', 'Are you sure you want to create the table(s)?'), array('y', 'n'), 'y') === 'y') { $this->out(__d('cake_console', 'Creating table(s).')); $this->_run($create, 'create', $Schema); } @@ -378,7 +378,7 @@ class SchemaShell extends AppShell { $this->out("\n" . __d('cake_console', 'The following statements will run.')); $this->out(array_map('trim', $contents)); - if ('y' == $this->in(__d('cake_console', 'Are you sure you want to alter the tables?'), array('y', 'n'), 'n')) { + if ($this->in(__d('cake_console', 'Are you sure you want to alter the tables?'), array('y', 'n'), 'n') === 'y') { $this->out(); $this->out(__d('cake_console', 'Updating Database...')); $this->_run($contents, 'update', $Schema); diff --git a/lib/Cake/Console/Command/Task/ModelTask.php b/lib/Cake/Console/Command/Task/ModelTask.php index 0ff102454..525149398 100644 --- a/lib/Cake/Console/Command/Task/ModelTask.php +++ b/lib/Cake/Console/Command/Task/ModelTask.php @@ -657,7 +657,7 @@ class ModelTask extends BakeTask { $prompt = "{$model->name} {$type} {$assoc['alias']}?"; $response = $this->in($prompt, array('y', 'n'), 'y'); - if ('n' == strtolower($response)) { + if (strtolower($response) === 'n') { unset($associations[$type][$i]); } elseif ($type === 'hasMany') { unset($associations['hasOne'][$i]); diff --git a/lib/Cake/Console/Command/Task/ViewTask.php b/lib/Cake/Console/Command/Task/ViewTask.php index 38ceb5c5c..e38fd2ab0 100644 --- a/lib/Cake/Console/Command/Task/ViewTask.php +++ b/lib/Cake/Console/Command/Task/ViewTask.php @@ -335,9 +335,8 @@ class ViewTask extends BakeTask { if (strtolower($looksGood) === 'y') { $this->bake($action, ' '); return $this->_stop(); - } else { - $this->out(__d('cake_console', 'Bake Aborted.')); } + $this->out(__d('cake_console', 'Bake Aborted.')); } /** diff --git a/lib/Cake/Controller/Scaffold.php b/lib/Cake/Controller/Scaffold.php index 477b8c9d5..c63ab7b32 100644 --- a/lib/Cake/Controller/Scaffold.php +++ b/lib/Cake/Controller/Scaffold.php @@ -252,10 +252,9 @@ class Scaffold { return $this->_sendMessage($message); } return $this->controller->afterScaffoldSaveError($action); - } else { - if ($this->_validSession) { - $this->controller->Session->setFlash(__d('cake', 'Please correct errors below.')); - } + } + if ($this->_validSession) { + $this->controller->Session->setFlash(__d('cake', 'Please correct errors below.')); } } diff --git a/lib/Cake/Model/Model.php b/lib/Cake/Model/Model.php index 09418910b..d90f9e52a 100644 --- a/lib/Cake/Model/Model.php +++ b/lib/Cake/Model/Model.php @@ -1255,11 +1255,11 @@ class Model extends Object implements CakeEventListener { isset($data['meridian']) && !empty($data['hour']) && $data['hour'] != 12 && - 'pm' == $data['meridian'] + $data['meridian'] === 'pm' ) { $data['hour'] = $data['hour'] + 12; } - if (isset($data['hour']) && isset($data['meridian']) && $data['hour'] == 12 && 'am' == $data['meridian']) { + if (isset($data['hour']) && isset($data['meridian']) && $data['hour'] == 12 && $data['meridian'] === 'am') { $data['hour'] = '00'; } if ($type === 'time') { diff --git a/lib/Cake/Utility/Hash.php b/lib/Cake/Utility/Hash.php index 607158b94..a0f64ebee 100644 --- a/lib/Cake/Utility/Hash.php +++ b/lib/Cake/Utility/Hash.php @@ -54,7 +54,6 @@ class Hash { } else { return null; } - } return $data; } diff --git a/lib/Cake/View/Helper/FormHelper.php b/lib/Cake/View/Helper/FormHelper.php index cea2ea1f1..1f6773bd3 100644 --- a/lib/Cake/View/Helper/FormHelper.php +++ b/lib/Cake/View/Helper/FormHelper.php @@ -731,9 +731,8 @@ class FormHelper extends AppHelper { $tag = is_string($options['wrap']) ? $options['wrap'] : 'div'; unset($options['wrap']); return $this->Html->tag($tag, $error, $options); - } else { - return $error; } + return $error; } /** diff --git a/lib/Cake/View/Helper/HtmlHelper.php b/lib/Cake/View/Helper/HtmlHelper.php index 9ad868eac..5dd729f4f 100644 --- a/lib/Cake/View/Helper/HtmlHelper.php +++ b/lib/Cake/View/Helper/HtmlHelper.php @@ -289,9 +289,8 @@ class HtmlHelper extends AppHelper { if (empty($options['block'])) { return $out; - } else { - $this->_View->append($options['block'], $out); } + $this->_View->append($options['block'], $out); } /** @@ -451,9 +450,8 @@ class HtmlHelper extends AppHelper { if (empty($options['block'])) { return $out; - } else { - $this->_View->append($options['block'], $out); } + $this->_View->append($options['block'], $out); } /** @@ -674,9 +672,8 @@ class HtmlHelper extends AppHelper { } } return implode($separator, $out); - } else { - return null; } + return null; } /** diff --git a/lib/Cake/basics.php b/lib/Cake/basics.php index 538de3f00..14b31cb14 100644 --- a/lib/Cake/basics.php +++ b/lib/Cake/basics.php @@ -470,29 +470,6 @@ if (!function_exists('clearCache')) { return false; } - foreach ($files as $file) { - if (is_file($file) && strrpos($file, DS . 'empty') !== strlen($file) - 6) { - //@codingStandardsIgnoreStart - @unlink($file); - //@codingStandardsIgnoreEnd - } - } - return true; - } else { - $cache = array( - CACHE . $type . DS . '*' . $params . $ext, - CACHE . $type . DS . '*' . $params . '_*' . $ext - ); - $files = array(); - while ($search = array_shift($cache)) { - $results = glob($search); - if ($results !== false) { - $files = array_merge($files, $results); - } - } - if (empty($files)) { - return false; - } foreach ($files as $file) { if (is_file($file) && strrpos($file, DS . 'empty') !== strlen($file) - 6) { //@codingStandardsIgnoreStart @@ -502,6 +479,29 @@ if (!function_exists('clearCache')) { } return true; } + $cache = array( + CACHE . $type . DS . '*' . $params . $ext, + CACHE . $type . DS . '*' . $params . '_*' . $ext + ); + $files = array(); + while ($search = array_shift($cache)) { + $results = glob($search); + if ($results !== false) { + $files = array_merge($files, $results); + } + } + if (empty($files)) { + return false; + } + foreach ($files as $file) { + if (is_file($file) && strrpos($file, DS . 'empty') !== strlen($file) - 6) { + //@codingStandardsIgnoreStart + @unlink($file); + //@codingStandardsIgnoreEnd + } + } + return true; + } elseif (is_array($params)) { foreach ($params as $file) { clearCache($file, $type, $ext);