From e6a87bac40074ac30960cf6a7773b93a740c7555 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Lorenzo=20Rodr=C3=ADguez?= <jose.zap@gmail.com>
Date: Wed, 28 Mar 2012 23:18:32 -0530
Subject: [PATCH 1/2] Removing extra spaces
---
lib/Cake/Cache/Engine/RedisEngine.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Cake/Cache/Engine/RedisEngine.php b/lib/Cake/Cache/Engine/RedisEngine.php
index 14cc24e15..c281bd3c4 100644
--- a/lib/Cake/Cache/Engine/RedisEngine.php
+++ b/lib/Cake/Cache/Engine/RedisEngine.php
@@ -77,9 +77,9 @@ class RedisEngine extends CacheEngine {
try {
$this->_Redis = new Redis();
if (empty($this->settings['persistent'])) {
- $return = $this->_Redis->connect($this->settings['server']);
+ $return = $this->_Redis->connect($this->settings['server']);
} else {
- $return = $this->_Redis->pconnect($this->settings['server']);
+ $return = $this->_Redis->pconnect($this->settings['server']);
}
} catch (RedisException $e) {
return false;
From 4958f0ee5dbabcf85c0e1fb96e9af4b2292ed649 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Lorenzo=20Rodr=C3=ADguez?= <jose.zap@gmail.com>
Date: Wed, 28 Mar 2012 23:22:30 -0530
Subject: [PATCH 2/2] Using a more specific function to check for numbers on
redis engine read
---
lib/Cake/Cache/Engine/RedisEngine.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Cake/Cache/Engine/RedisEngine.php b/lib/Cake/Cache/Engine/RedisEngine.php
index c281bd3c4..db8325c1c 100644
--- a/lib/Cake/Cache/Engine/RedisEngine.php
+++ b/lib/Cake/Cache/Engine/RedisEngine.php
@@ -114,7 +114,7 @@ class RedisEngine extends CacheEngine {
*/
public function read($key) {
$value = $this->_Redis->get($key);
- if (is_numeric($value)) {
+ if (ctype_digit($value)) {
$value = (int) $value;
}
if ($value !== false && is_string($value)) {