From da19e31188a701461606c99b1f0c20cc297b0179 Mon Sep 17 00:00:00 2001 From: Mark Story Date: Sun, 3 Jan 2010 22:27:52 -0500 Subject: [PATCH] Refactoring duplicate switch logic to a single method. --- cake/tests/lib/cake_test_menu.php | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/cake/tests/lib/cake_test_menu.php b/cake/tests/lib/cake_test_menu.php index 8fc50298e..e27ffe401 100644 --- a/cake/tests/lib/cake_test_menu.php +++ b/cake/tests/lib/cake_test_menu.php @@ -103,16 +103,8 @@ class CakeTestMenu { * @access public */ function testCaseList() { - switch (CAKE_TEST_OUTPUT) { - case CAKE_TEST_OUTPUT_HTML: - ob_start(); - echo HtmlTestManager::getTestCaseList(); - break; - case CAKE_TEST_OUTPUT_TEXT: - default: - echo TextTestManager::getTestCaseList(); - break; - } + $class = CakeTestMenu::getTestManager(); + echo call_user_func(array($class, 'getTestCaseList')); } /** @@ -122,14 +114,22 @@ class CakeTestMenu { * @access public */ function groupTestList() { + $class = CakeTestMenu::getTestManager(); + echo call_user_func(array($class, 'getGroupTestList')); + } + +/** + * Gets the correct test manager for the chosen output. + * + * @return void + */ + function getTestManager() { switch (CAKE_TEST_OUTPUT) { case CAKE_TEST_OUTPUT_HTML: - echo HtmlTestManager::getGroupTestList(); - break; + return 'HtmlTestManager'; case CAKE_TEST_OUTPUT_TEXT: default: - echo TextTestManager::getGroupTestList(); - break; + return 'TextTestManager'; } }